frankvicky closed pull request #17874: MINOR: Cleanup e2e unused import
URL: https://github.com/apache/kafka/pull/17874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
sjhajharia opened a new pull request, #18500:
URL: https://github.com/apache/kafka/pull/18500
Adding the code for `DescribeShareGroupOffsetsResponse` and
`DescribeShareGroupOffsetsRequest`
Implementation shall follow.
--
This is an automated message from the Apache Git Service.
To resp
squah-confluent opened a new pull request, #18499:
URL: https://github.com/apache/kafka/pull/18499
* Ensure that coordinator contexts are removed even if they throw an
exception during unload, otherwise the next load will fail.
* Ensure that the active partition count metric is decrem
Sean Quah created KAFKA-18484:
-
Summary: More robust exception handling for new group coordinator
unload
Key: KAFKA-18484
URL: https://issues.apache.org/jira/browse/KAFKA-18484
Project: Kafka
Is
snehashisp commented on code in PR #18403:
URL: https://github.com/apache/kafka/pull/18403#discussion_r1909683257
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/ReflectionScanner.java:
##
@@ -77,7 +79,8 @@ private static String versionFor(Class
plu
gnarula commented on PR #17901:
URL: https://github.com/apache/kafka/pull/17901#issuecomment-2586383607
CC: @soarez can you PTAL?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
stoty commented on PR #17901:
URL: https://github.com/apache/kafka/pull/17901#issuecomment-2586375435
Could you please review and merge this ?
Is there anything I need to do ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/KAFKA-18346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
TaiJuWu reassigned KAFKA-18346:
---
Assignee: TaiJuWu
> Fix e2e TestKRaftUpgrade from v3.3.2
>
>
>
lucasbru commented on code in PR #18278:
URL: https://github.com/apache/kafka/pull/18278#discussion_r1912755471
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/OptimizedKTableIntegrationTest.java:
##
@@ -78,24 +80,28 @@ public class OptimizedKTabl
lucasbru commented on code in PR #18231:
URL: https://github.com/apache/kafka/pull/18231#discussion_r1912750089
##
tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommand.java:
##
@@ -205,23 +206,23 @@ private void printMembers(StreamsGroupDescription
description
lucasbru commented on code in PR #18231:
URL: https://github.com/apache/kafka/pull/18231#discussion_r1912749627
##
tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommand.java:
##
@@ -205,23 +206,23 @@ private void printMembers(StreamsGroupDescription
description
chia7712 commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2586347959
@trnguyencflt we have resolved the issue in #18472. If you have some free
time, could you please test it on your project?
Please don't hesitate to provide any feedback if you think som
aliehsaeedii commented on code in PR #18231:
URL: https://github.com/apache/kafka/pull/18231#discussion_r1912747227
##
tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommand.java:
##
@@ -205,23 +206,23 @@ private void printMembers(StreamsGroupDescription
descrip
chia7712 commented on PR #18461:
URL: https://github.com/apache/kafka/pull/18461#issuecomment-2586248506
> Any reason why you did not?
I have verified that all your comments have been addressed. Merging this PR
can facilitate the progress of other ZK-related code cleanups. We can addr
aliehsaeedii commented on code in PR #18231:
URL: https://github.com/apache/kafka/pull/18231#discussion_r1912697855
##
tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommand.java:
##
@@ -205,23 +206,23 @@ private void printMembers(StreamsGroupDescription
descrip
[
https://issues.apache.org/jira/browse/KAFKA-17745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PoAn Yang reassigned KAFKA-17745:
-
Assignee: PoAn Yang
> Move static request validation from GroupMetadataManager to
> GroupCoord
[
https://issues.apache.org/jira/browse/KAFKA-17745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912339#comment-17912339
]
PoAn Yang commented on KAFKA-17745:
---
Hi [~jimmywang611], I will handle this. Thanks fo
m1a2st commented on PR #18477:
URL: https://github.com/apache/kafka/pull/18477#issuecomment-2586220217
It seens lot of tests using `ListenerType.ZK_BROKER`, I will take a look
this night and fix these tests.
--
This is an automated message from the Apache Git Service.
To respond to the me
ijuma commented on PR #18477:
URL: https://github.com/apache/kafka/pull/18477#issuecomment-2586174363
Looks like this caused a lot of test failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
ijuma commented on code in PR #18477:
URL: https://github.com/apache/kafka/pull/18477#discussion_r1912662716
##
clients/src/main/resources/common/message/LeaderAndIsrRequest.json:
##
@@ -16,7 +16,8 @@
{
"apiKey": 4,
"type": "request",
- "listeners": [],
+ // TODO: The g
frankvicky commented on PR #18498:
URL: https://github.com/apache/kafka/pull/18498#issuecomment-2586165018
Preview after this patch:
--
This is an automated message from the Apache Git Service
frankvicky opened a new pull request, #18498:
URL: https://github.com/apache/kafka/pull/18498
There is a unnecessary `<` in Errant Record Reporter section:
:
return consumer
@cluster(num_nodes=7)
-def t
dajac commented on PR #18461:
URL: https://github.com/apache/kafka/pull/18461#issuecomment-2586143058
@chia7712 You could have mentioned me as a reviewer on this one. Any reason
why you did not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
github-actions[bot] commented on PR #17494:
URL: https://github.com/apache/kafka/pull/17494#issuecomment-2586118225
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
github-actions[bot] commented on PR #18389:
URL: https://github.com/apache/kafka/pull/18389#issuecomment-2586099249
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #18390:
URL: https://github.com/apache/kafka/pull/18390#issuecomment-2586099232
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
pramithas commented on PR #18482:
URL: https://github.com/apache/kafka/pull/18482#issuecomment-2586053230
@ijuma The tests are passing in my local env when I run them independently
with the specific java version. Moreover, they don't look like to be failing
due to my changes. Should we re-i
m1a2st commented on PR #18477:
URL: https://github.com/apache/kafka/pull/18477#issuecomment-2586003080
Thanks for @ijuma reminder, the error is `Caused by:
java.lang.IllegalArgumentException: Collection is empty`, I will add TODO tag
to these empty collectioin.
--
This is an automated me
ijuma merged PR #18495:
URL: https://github.com/apache/kafka/pull/18495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
apoorvmittal10 commented on code in PR #17870:
URL: https://github.com/apache/kafka/pull/17870#discussion_r1912538632
##
core/src/test/java/kafka/server/share/DelayedShareFetchTest.java:
##
@@ -559,13 +561,18 @@ public void testCombineLogReadResponse() {
.withShareP
ijuma commented on code in PR #18477:
URL: https://github.com/apache/kafka/pull/18477#discussion_r1912538347
##
clients/src/main/resources/common/message/UpdateMetadataRequest.json:
##
@@ -16,7 +16,7 @@
{
"apiKey": 6,
"type": "request",
- "listeners": ["zkBroker"],
+ "l
ijuma opened a new pull request, #18497:
URL: https://github.com/apache/kafka/pull/18497
This is not complete yet, I want to see the results of a full test run.
Aside from that,
I also need to add new generator tests.
### Committer Checklist (excluded from commit message)
- [ ]
[
https://issues.apache.org/jira/browse/KAFKA-14552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-14552:
Description:
Kafka 4.0 will remove support for zk mode and will require conversion to kraft
befor
[
https://issues.apache.org/jira/browse/KAFKA-14552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-14552:
Summary: Assume a baseline of 3.0 for server protocol versions (was:
Remove no longer required se
fonsdant commented on PR #18314:
URL: https://github.com/apache/kafka/pull/18314#issuecomment-2585901473
@mjsax, how about using the `PopularPageEmailAlert` of the _Applying
processors and transformers (Processor API integration)_ section?
```java
package org.apache.kafka.streams.k
ppkarwasz commented on PR #18472:
URL: https://github.com/apache/kafka/pull/18472#issuecomment-2585899468
@chia7712,
I have created #18496 to protect the two classes that use Log4j Core
(`k.util.Log4jController` and `o.a.k.connect.runtime.Loggers`) from throwing a
linkage error if Lo
ppkarwasz opened a new pull request, #18496:
URL: https://github.com/apache/kafka/pull/18496
If Log4j Core is absent, most calls to `Log4jController` and `Loggers` will
end up with a `NoClassDefFoundError`.
This changeset:
- Profits from the major version bump to rename `k.util
Piotr Karwasz created KAFKA-18483:
-
Summary: Protect `Loggers` and `Log4jController` against
`LinkageError`s
Key: KAFKA-18483
URL: https://issues.apache.org/jira/browse/KAFKA-18483
Project: Kafka
nvartolomei commented on code in PR #6731:
URL: https://github.com/apache/kafka/pull/6731#discussion_r1912507814
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java:
##
@@ -1136,24 +1163,42 @@ private PartitionRecords
parseCompletedFetch(CompletedF
mimaison commented on PR #18039:
URL: https://github.com/apache/kafka/pull/18039#issuecomment-2585859774
Just re-rebased to re-resolve the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
chia7712 commented on code in PR #18480:
URL: https://github.com/apache/kafka/pull/18480#discussion_r1912502970
##
core/src/main/scala/kafka/tools/DumpLogSegments.scala:
##
@@ -691,34 +625,17 @@ object DumpLogSegments {
class ShareGroupStateMessageParser extends MessageParser
ijuma commented on code in PR #18414:
URL: https://github.com/apache/kafka/pull/18414#discussion_r1912503825
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -637,21 +637,12 @@ class KafkaConfig private(doLog: Boolean, val props:
util.Map[_, _])
if (nodeId != b
pramithas commented on PR #18482:
URL: https://github.com/apache/kafka/pull/18482#issuecomment-2585853316
> Since we do all the checks when things are good, is this intended to fail
faster?
Yes, specifically in the scenarios when the less expensive checks fail.
--
This is an automa
ijuma commented on PR #18460:
URL: https://github.com/apache/kafka/pull/18460#issuecomment-2585852485
Not related to this PR, but follow-ups: we are deleting a bunch of code due
to zk removal - it probably makes sense to merge those PRs first before
continuing with the Java rewrites.
--
ijuma commented on PR #18482:
URL: https://github.com/apache/kafka/pull/18482#issuecomment-2585852018
Since we do all the checks when things are good, is this intended to fail
faster?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ijuma commented on PR #18477:
URL: https://github.com/apache/kafka/pull/18477#issuecomment-2585851376
This seems to be failing - I haven't looked at the details, but if it's
related to some of the json files having no listeners, you could leave those in
and only remove it from the protocol
chia7712 commented on PR #18465:
URL: https://github.com/apache/kafka/pull/18465#issuecomment-2585847752
@mingdaoy please fix the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
chia7712 merged PR #18447:
URL: https://github.com/apache/kafka/pull/18447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
TaiJuWu opened a new pull request, #18495:
URL: https://github.com/apache/kafka/pull/18495
Convert Some to Optional
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify docume
chia7712 merged PR #18464:
URL: https://github.com/apache/kafka/pull/18464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
frankvicky commented on PR #18494:
URL: https://github.com/apache/kafka/pull/18494#issuecomment-2585817758
I have run the test on several machines.
local:
jenk
frankvicky opened a new pull request, #18494:
URL: https://github.com/apache/kafka/pull/18494
JIRA: KAFKA-18482
This test fails due to `node_version` is null. We should get the node
version by `get_version` method which has null guard.
### Committer Checklist (excluded from com
TengYao Chi created KAFKA-18482:
---
Summary: Fix fail e2e `test_streams`
Key: KAFKA-18482
URL: https://issues.apache.org/jira/browse/KAFKA-18482
Project: Kafka
Issue Type: Bug
Reporte
brandboat commented on code in PR #18448:
URL: https://github.com/apache/kafka/pull/18448#discussion_r1912486167
##
core/src/test/scala/integration/kafka/coordinator/transaction/ProducerIntegrationTest.scala:
##
@@ -0,0 +1,185 @@
+/**
+ * Licensed to the Apache Software Foundati
divijvaidya commented on PR #18380:
URL: https://github.com/apache/kafka/pull/18380#issuecomment-2585793520
> All this code, automation to update year in one file?
Haha. I had some extra time to kill.
In seriousness, I plan to extend this to automate a bunch of regular tasks
su
frankvicky opened a new pull request, #18493:
URL: https://github.com/apache/kafka/pull/18493
The parameter `upperIndex` never exists. We should remove its javadoc.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test co
[
https://issues.apache.org/jira/browse/KAFKA-17834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
黃竣陽 updated KAFKA-17834:
Summary: Improvement the Dockerfile (was: Improvement the e2e Dockerfile)
> Improvement the Dockerfile
>
m1a2st commented on code in PR #18378:
URL: https://github.com/apache/kafka/pull/18378#discussion_r1912475984
##
docker/jvm/Dockerfile:
##
@@ -56,8 +56,9 @@ ARG build_date
LABEL org.label-schema.name="kafka" \
org.label-schema.description="Apache Kafka" \
org.labe
[
https://issues.apache.org/jira/browse/KAFKA-18481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
TengYao Chi updated KAFKA-18481:
Summary: Remove ZookeeperClient, KeeperException, Code (was: Remove
ZookeeperClient)
> Remove Zo
TengYao Chi created KAFKA-18481:
---
Summary: Remove ZookeeperClient
Key: KAFKA-18481
URL: https://issues.apache.org/jira/browse/KAFKA-18481
Project: Kafka
Issue Type: Improvement
Repo
[
https://issues.apache.org/jira/browse/KAFKA-18481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912282#comment-17912282
]
TengYao Chi commented on KAFKA-18481:
-
Thanks for pointing out
> Remove ZookeeperC
[
https://issues.apache.org/jira/browse/KAFKA-18481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
TengYao Chi resolved KAFKA-18481.
-
Resolution: Duplicate
> Remove ZookeeperClient, KeeperException, Code
>
[
https://issues.apache.org/jira/browse/KAFKA-18481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912280#comment-17912280
]
黃竣陽 commented on KAFKA-18481:
-
It's dulpicate with https://issues.apache.org/jira/browse/KAF
ppkarwasz commented on PR #18472:
URL: https://github.com/apache/kafka/pull/18472#issuecomment-2585756769
> @ppkarwasz we don't use the Gradle’s feature variants in this PR due to
following reasons.
>
> 1. We do not expect users to include the optional dependencies.
Instead, user
frankvicky commented on code in PR #18492:
URL: https://github.com/apache/kafka/pull/18492#discussion_r1912463400
##
tests/kafkatest/tests/client/truncation_test.py:
##
@@ -51,7 +51,8 @@ def print_record(event, node):
return consumer
@cluster(num_nodes=7)
-de
chia7712 commented on PR #16990:
URL: https://github.com/apache/kafka/pull/16990#issuecomment-2585736628
@bachmanity1
this PR is merged to trunk (see
https://github.com/apache/kafka/commit/dd7d7c3145d41103525cd212e718a8bdf5dd484b),
and you PR #15475 is
https://github.com/apache/kaf
TaiJuWu commented on code in PR #18492:
URL: https://github.com/apache/kafka/pull/18492#discussion_r1912458228
##
tests/kafkatest/tests/client/truncation_test.py:
##
@@ -51,7 +51,8 @@ def print_record(event, node):
return consumer
@cluster(num_nodes=7)
-def t
wernerdv commented on PR #18491:
URL: https://github.com/apache/kafka/pull/18491#issuecomment-2585748900
@ijuma @junrao Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
TaiJuWu commented on code in PR #18492:
URL: https://github.com/apache/kafka/pull/18492#discussion_r1912458228
##
tests/kafkatest/tests/client/truncation_test.py:
##
@@ -51,7 +51,8 @@ def print_record(event, node):
return consumer
@cluster(num_nodes=7)
-def t
bachmanity1 commented on PR #16990:
URL: https://github.com/apache/kafka/pull/16990#issuecomment-2585738545
This is really weird. I guess I was looking at the wrong file. Thanks for
your help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
frankvicky commented on PR #18492:
URL: https://github.com/apache/kafka/pull/18492#issuecomment-2585739845
I have run the test on several machines with this patch.
local:
- [ ] Verify design and implementation
- [ ] Verif
abhijeetk88 commented on PR #16884:
URL: https://github.com/apache/kafka/pull/16884#issuecomment-2585725869
I would like to revive this PR. @kamalcph @showuon @satishd will you be able
to help with reviews. I can rebase the PR with trunk.
--
This is an automated message from the Apache Gi
abhijeetk88 commented on PR #16834:
URL: https://github.com/apache/kafka/pull/16834#issuecomment-2585725730
I would like to revive this PR. @kamalcph will you be able to help with
reviews. I can rebase the PR with trunk.
--
This is an automated message from the Apache Git Service.
To resp
abhijeetk88 commented on PR #16584:
URL: https://github.com/apache/kafka/pull/16584#issuecomment-2585725553
I would like to revive this PR. @kamalcph @showuon will you be able to help
with reviews. I can rebase the PR with trunk.
--
This is an automated message from the Apache Git Service
chia7712 commented on PR #18464:
URL: https://github.com/apache/kafka/pull/18464#issuecomment-2585724663
@m1a2st please rebase code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
[
https://issues.apache.org/jira/browse/KAFKA-18474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-18474:
--
Assignee: 黃竣陽 (was: Chia-Ping Tsai)
> Remove zkBroker tag
> ---
>
>
chia7712 merged PR #18461:
URL: https://github.com/apache/kafka/pull/18461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on code in PR #18454:
URL: https://github.com/apache/kafka/pull/18454#discussion_r1912443707
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -2620,13 +2620,11 @@ class KafkaApis(val requestChannel: RequestChannel,
}
def handleCreateAcls(requ
chia7712 merged PR #18456:
URL: https://github.com/apache/kafka/pull/18456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-18467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-18467.
Fix Version/s: 4.1.0
Resolution: Fixed
> Add create topic doc
> --
chia7712 merged PR #18470:
URL: https://github.com/apache/kafka/pull/18470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-18466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-18466.
Resolution: Fixed
trunk:
https://github.com/apache/kafka/commit/b0b54f6db1ab775291c3bb4fb
chia7712 merged PR #18472:
URL: https://github.com/apache/kafka/pull/18472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #18472:
URL: https://github.com/apache/kafka/pull/18472#issuecomment-2585709664
@ppkarwasz we don't use the Gradle’s feature variants in this PR due to
following reasons.
1. We do not expect users to include the optional dependencies. Instead,
users should ex
mimaison commented on PR #18480:
URL: https://github.com/apache/kafka/pull/18480#issuecomment-2585678376
Yeah I did not mean to do it in this PR. Just as a follow up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
[
https://issues.apache.org/jira/browse/KAFKA-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912252#comment-17912252
]
Yu-Lin Chen edited comment on KAFKA-18298 at 1/12/25 9:58 AM:
[
https://issues.apache.org/jira/browse/KAFKA-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yu-Lin Chen resolved KAFKA-18298.
-
Resolution: Fixed
Locally validated that the issue was fixed after this PR. (No error in 200
lo
89 matches
Mail list logo
