aliehsaeedii commented on code in PR #18231:
URL: https://github.com/apache/kafka/pull/18231#discussion_r1912747227


##########
tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommand.java:
##########
@@ -205,23 +206,23 @@ private void printMembers(StreamsGroupDescription 
description, boolean verbose)
                     System.out.printf(fmt, "GROUP", "MEMBER", "PROCESS", 
"CLIENT-ID", "ACTIVE-TASKS", "STANDBY-TASKS", "WARMUP-TASKS");
                     for (StreamsGroupMemberDescription member : members) {
                         System.out.printf(fmt, description.groupId(), 
member.memberId(), member.processId(), member.clientId(),
-                            
getTopicPartitions(member.assignment().activeTasks()).stream().map(tp -> 
tp.topic() + ":" + tp.partition()).collect(Collectors.joining(",")),
-                            
getTopicPartitions(member.assignment().standbyTasks()).stream().map(tp -> 
tp.topic() + ":" + tp.partition()).collect(Collectors.joining(",")),
-                            
getTopicPartitions(member.assignment().warmupTasks()).stream().map(tp -> 
tp.topic() + ":" + tp.partition()).collect(Collectors.joining(",")));
+                            
member.assignment().activeTasks().stream().map(taskId -> taskId.subtopologyId() 
+ ":" + taskId.partitions()).collect(Collectors.joining(",")),

Review Comment:
   > How are you testing these changes?
   
   Do you mean testing the output of `print` methods? The counterpart classes 
(`ShareGroup` etc) dont test it. Do you think is it needed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to