Re: [PR] KAFKA-16181: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh [kafka]

2024-11-27 Thread via GitHub
dengziming commented on code in PR #15304: URL: https://github.com/apache/kafka/pull/15304#discussion_r1861624180 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -333,6 +333,9 @@ object TestUtils extends Logging { if (!props.containsKey(GroupCoordinatorConfi

Re: [PR] KAFKA-10361: Windows batch files that use /bin/windows/kafka-run-class.bat fail with a class path error on fresh installation [kafka]

2024-11-27 Thread via GitHub
BackTrak commented on PR #9125: URL: https://github.com/apache/kafka/pull/9125#issuecomment-2505356756 Bump! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Updated] (KAFKA-18026) Allow custom processor wrapping

2024-11-27 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-18026: --- Description: See KIP-1112: [https://cwiki.apache.org/confluence/display/KAF

[jira] [Updated] (KAFKA-18026) Allow custom processor wrapping

2024-11-27 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-18026: --- Description: See KIP-1112: [https://cwiki.apache.org/confluence/display/KAF

[jira] [Updated] (KAFKA-18026) Allow custom processor wrapping

2024-11-27 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-18026: --- Description: See KIP-1112: [https://cwiki.apache.org/confluence/display/KAF

[jira] [Updated] (KAFKA-18026) Allow custom processor wrapping

2024-11-27 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-18026: --- Description: See KIP-1112: [https://cwiki.apache.org/confluence/display/KAF

[jira] [Updated] (KAFKA-18026) Allow custom processor wrapping

2024-11-27 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-18026: --- Description: See KIP-1112: [https://cwiki.apache.org/confluence/display/KAF

Re: [PR] KAFKA-18026: KIP-1112, document new config and update the Streams upgrade guide [kafka]

2024-11-27 Thread via GitHub
ableegoldman commented on PR #17906: URL: https://github.com/apache/kafka/pull/17906#issuecomment-2505269545 > @ableegoldman Could you please take a look at the screenshot above? It seems we are missing some cells in the table. @chia7712 do you mean that some cells are literally non-e

Re: [PR] KAFKA-18026: KIP-1112, document new config and update the Streams upgrade guide [kafka]

2024-11-27 Thread via GitHub
ableegoldman commented on PR #17906: URL: https://github.com/apache/kafka/pull/17906#issuecomment-2505261229 dammit Bruno 😠 (@cadonna just kidding, no worries) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[jira] [Updated] (KAFKA-18026) Allow custom processor wrapping

2024-11-27 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-18026: --- Description: See KIP-1112: [https://cwiki.apache.org/confluence/display/KAF

[jira] [Created] (KAFKA-18114) Add Use Case Descriptions to README

2024-11-27 Thread Swikar Patel (Jira)
Swikar Patel created KAFKA-18114: Summary: Add Use Case Descriptions to README Key: KAFKA-18114 URL: https://issues.apache.org/jira/browse/KAFKA-18114 Project: Kafka Issue Type: Sub-task

Re: [PR] KAFKA-9941;WorkerSinkTask:When a record triggers a RetriableException and the retry is processed successfully, its offset does not commit. [kafka]

2024-11-27 Thread via GitHub
github-actions[bot] commented on PR #9167: URL: https://github.com/apache/kafka/pull/9167#issuecomment-2505205585 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR

[jira] [Created] (KAFKA-18113) Create Component Table in README

2024-11-27 Thread Swikar Patel (Jira)
Swikar Patel created KAFKA-18113: Summary: Create Component Table in README Key: KAFKA-18113 URL: https://issues.apache.org/jira/browse/KAFKA-18113 Project: Kafka Issue Type: Sub-task

[jira] [Updated] (KAFKA-18112) Add Kafka Logo to README

2024-11-27 Thread Swikar Patel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swikar Patel updated KAFKA-18112: - Description: * Download the official Apache Kafka logo in SVG format from the Apache Kafka webs

[jira] [Created] (KAFKA-18112) Add Kafka Logo to README

2024-11-27 Thread Swikar Patel (Jira)
Swikar Patel created KAFKA-18112: Summary: Add Kafka Logo to README Key: KAFKA-18112 URL: https://issues.apache.org/jira/browse/KAFKA-18112 Project: Kafka Issue Type: Sub-task Compo

Re: [PR] KAFKA-10385 - Remove no print stat when on detailed stat mode on Consumer Perf [kafka]

2024-11-27 Thread via GitHub
github-actions[bot] commented on PR #9161: URL: https://github.com/apache/kafka/pull/9161#issuecomment-2505205571 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR

[jira] [Updated] (KAFKA-18111) Improve README: Add logo, component table, and use case descriptions

2024-11-27 Thread Swikar Patel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swikar Patel updated KAFKA-18111: - Description: h2. Proposed README Improvements This issue proposes several enhancements to the K

[jira] [Updated] (KAFKA-18111) Improve README: Add logo, component table, and use case descriptions

2024-11-27 Thread Swikar Patel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swikar Patel updated KAFKA-18111: - Description: h2. Proposed README Improvements This issue proposes several enhancements to the K

[jira] [Created] (KAFKA-18111) Improve README: Add logo, component table, and use case descriptions

2024-11-27 Thread Swikar Patel (Jira)
Swikar Patel created KAFKA-18111: Summary: Improve README: Add logo, component table, and use case descriptions Key: KAFKA-18111 URL: https://issues.apache.org/jira/browse/KAFKA-18111 Project: Kafka

[jira] [Resolved] (KAFKA-18109) Fix failed SaslClientsWithInvalidCredentialsTest in tools module

2024-11-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18109. Fix Version/s: 4.0.0 Assignee: TaiJuWu (was: Chia-Ping Tsai) Resolution: F

Re: [PR] KAFKA-18109: Fix failed SaslClientsWithInvalidCredentialsTest in tools module [kafka]

2024-11-27 Thread via GitHub
chia7712 merged PR #17971: URL: https://github.com/apache/kafka/pull/17971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-9366: Upgrade log4j to log4j2 [kafka]

2024-11-27 Thread via GitHub
frankvicky commented on PR #17373: URL: https://github.com/apache/kafka/pull/17373#issuecomment-2505169162 Hi @mimaison, Unfortunately, I don't have the resources to perform the full test suite as it would take a very long time 😬. Instead, I selected a test related to this PR. The

Re: [PR] KAFKA-18061 AddRaftVoter responds with error message "NONE" instead of null [kafka]

2024-11-27 Thread via GitHub
Linsiyuan9 commented on PR #17930: URL: https://github.com/apache/kafka/pull/17930#issuecomment-2505160080 @aiven-anton ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[jira] [Created] (KAFKA-18110) Fail Test: PlaintextAdminIntegrationTest#testDeleteConsumerGroupOffsets

2024-11-27 Thread Jira
黃竣陽 created KAFKA-18110: --- Summary: Fail Test: PlaintextAdminIntegrationTest#testDeleteConsumerGroupOffsets Key: KAFKA-18110 URL: https://issues.apache.org/jira/browse/KAFKA-18110 Project: Kafka Issue

Re: [PR] MINOR: remove zk from several tests [kafka]

2024-11-27 Thread via GitHub
chia7712 commented on code in PR #17949: URL: https://github.com/apache/kafka/pull/17949#discussion_r1861411178 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/SaslClientsWithInvalidCredentialsTest.java: ## @@ -106,13 +115,13 @@ public void setUp(TestInfo testInfo)

[PR] KAFKA-18109: Fix failed SaslClientsWithInvalidCredentialsTest in tools module [kafka]

2024-11-27 Thread via GitHub
TaiJuWu opened a new pull request, #17971: URL: https://github.com/apache/kafka/pull/17971 Jira: https://issues.apache.org/jira/browse/KAFKA-18109 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI buil

[jira] [Created] (KAFKA-18109) Fix failed SaslClientsWithInvalidCredentialsTest in tools module

2024-11-27 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18109: -- Summary: Fix failed SaslClientsWithInvalidCredentialsTest in tools module Key: KAFKA-18109 URL: https://issues.apache.org/jira/browse/KAFKA-18109 Project: Kafka

Re: [PR] KAFKA-17338 ConsumerConfig should prevent using partition assignors with CONSUMER group protocol [kafka]

2024-11-27 Thread via GitHub
m1a2st commented on PR #16899: URL: https://github.com/apache/kafka/pull/16899#issuecomment-2505100487 Hello @lianetm, I think this fail test is not related with this PR, I will file a Jira to trace this Issue. ``` Expected an exception of type org.apache.kafka.common.errors.UnknownTo

[jira] [Assigned] (KAFKA-18108) De-flake DynamicBrokerReconfigurationTest.testUncleanLeaderElectionEnable

2024-11-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-18108: -- Assignee: Chia-Ping Tsai > De-flake DynamicBrokerReconfigurationTest.testUncleanLeade

Re: [PR] KAFKA-18100: `Using` block suppresses all errors [kafka]

2024-11-27 Thread via GitHub
TaiJuWu commented on PR #17954: URL: https://github.com/apache/kafka/pull/17954#issuecomment-2505078614 Back port to 3.9 branch https://github.com/apache/kafka/pull/17970 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] KAFKA-18100 `Using` block suppresses all errors (#17954) [kafka]

2024-11-27 Thread via GitHub
TaiJuWu opened a new pull request, #17970: URL: https://github.com/apache/kafka/pull/17970 https://github.com/apache/kafka/pull/15881 changed our tests to utilize `using` blocks. But these blocks don't throw any errors, so if there is a failed assertion within the block, the test will still

[jira] [Created] (KAFKA-18108) De-flake DynamicBrokerReconfigurationTest.testUncleanLeaderElectionEnable

2024-11-27 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-18108: Summary: De-flake DynamicBrokerReconfigurationTest.testUncleanLeaderElectionEnable Key: KAFKA-18108 URL: https://issues.apache.org/jira/browse/KAFKA-18108 Project: Ka

[PR] KAFKA-7516: Attempt to dynamically load ManagementFactory class [kafka]

2024-11-27 Thread via GitHub
gtbX opened a new pull request, #17969: URL: https://github.com/apache/kafka/pull/17969 Fail gracefully if not found. This can be the case on Android. With this change, it's no longer necessary for me to stub out JMX classes on Android. I do still need to supply a custom `metric.repor

Re: [PR] KAFKA-10132: Return correct value types for MBean attributes [kafka]

2024-11-27 Thread via GitHub
rgroothuijsen closed pull request #9078: KAFKA-10132: Return correct value types for MBean attributes URL: https://github.com/apache/kafka/pull/9078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Created] (KAFKA-18107) Sensor Access Concurrency Enhancements

2024-11-27 Thread Lingnan Liu (Jira)
Lingnan Liu created KAFKA-18107: --- Summary: Sensor Access Concurrency Enhancements Key: KAFKA-18107 URL: https://issues.apache.org/jira/browse/KAFKA-18107 Project: Kafka Issue Type: Improvement

[jira] [Resolved] (KAFKA-17113) Flaky Test in GlobalStreamThreadTest#shouldThrowStreamsExceptionOnStartupIfExceptionOccurred

2024-11-27 Thread Ao Li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ao Li resolved KAFKA-17113. --- Resolution: Fixed The CDL has fixed this concurrency issue. > Flaky Test in > GlobalStreamThreadTest#shou

[PR] Kip1071 trunk rebase 11 25 add bruno pr [kafka]

2024-11-27 Thread via GitHub
bbejeck opened a new pull request, #17968: URL: https://github.com/apache/kafka/pull/17968 PR to help resolve some errors from cherry-picking new PR into trunk rebased kip1071 branch ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation

Re: [PR] KAFKA-18026: migrate KStream and KTable aggregates to use ProcesserSupplier#stores [kafka]

2024-11-27 Thread via GitHub
ableegoldman commented on code in PR #17929: URL: https://github.com/apache/kafka/pull/17929#discussion_r1861300121 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreFactory.java: ## @@ -75,4 +76,79 @@ default void configure(final StreamsConfig config) {

Re: [PR] KAFKA-15561 [5/N]: Integration tests for new subscribe API with Re2J pattern [kafka]

2024-11-27 Thread via GitHub
chia7712 commented on code in PR #17964: URL: https://github.com/apache/kafka/pull/17964#discussion_r1861262476 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerSubscriptionTest.scala: ## @@ -178,6 +178,49 @@ class PlaintextConsumerSubscriptionTest extends Abstract

Re: [PR] KAFKA-18026: migrate KTableSource to use ProcesserSupplier#stores [kafka]

2024-11-27 Thread via GitHub
ableegoldman merged PR #17903: URL: https://github.com/apache/kafka/pull/17903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

Re: [PR] MINOR: Add protocol documentation about ApiVersions Fallback behaviour [kafka]

2024-11-27 Thread via GitHub
robobario commented on code in PR #17967: URL: https://github.com/apache/kafka/pull/17967#discussion_r1861278947 ## docs/protocol.html: ## @@ -143,7 +138,13 @@ ApiVersionRequest is not available. Also, note that broker versions older -than 0.10.0.0 do not support this A

[PR] MINOR: Add protocol documentation about ApiVersions Fallback behaviour [kafka]

2024-11-27 Thread via GitHub
robobario opened a new pull request, #17967: URL: https://github.com/apache/kafka/pull/17967 Documents current ApiVersions fallback mechanism The broker behaviour when it receives an ApiVersionsRequest ahead of it's supported versions is useful to know as an implementor/manipulator of

Re: [PR] KAFKA-17338 ConsumerConfig should prevent using partition assignors with CONSUMER group protocol [kafka]

2024-11-27 Thread via GitHub
lianetm commented on PR #16899: URL: https://github.com/apache/kafka/pull/16899#issuecomment-2504803872 Hi @m1a2st , could you please check the test failure on testDeleteConsumerGroupOffsets? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, p

[jira] [Resolved] (KAFKA-18097) Upgrade readme to include min JDK changes

2024-11-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18097. Fix Version/s: 4.0.0 Resolution: Fixed > Upgrade readme to include min JDK changes

[jira] [Commented] (KAFKA-16096) Drop broker and tools support for Java 11 in Kafka 4.0 (deprecate in 3.7) (KIP-1013)

2024-11-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17901584#comment-17901584 ] Chia-Ping Tsai commented on KAFKA-16096: All sub-tasks are completed, but there

Re: [PR] KAFKA-18097: Upgrade readme to include min JDK changes [kafka]

2024-11-27 Thread via GitHub
chia7712 merged PR #17948: URL: https://github.com/apache/kafka/pull/17948 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18098: add kraft support to testReplicaPlacementAllServers and testReplicaPlacementPartialServers [kafka]

2024-11-27 Thread via GitHub
chia7712 merged PR #17955: URL: https://github.com/apache/kafka/pull/17955 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-18098) add kraft support to testReplicaPlacementAllServers and testReplicaPlacementPartialServers

2024-11-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18098. Fix Version/s: 4.0.0 Resolution: Fixed > add kraft support to testReplicaPlacementA

Re: [PR] KAFKA-18068: Fixing typo in ProducerConfig [kafka]

2024-11-27 Thread via GitHub
chia7712 commented on PR #17908: URL: https://github.com/apache/kafka/pull/17908#issuecomment-2504785460 > I meant that we could temporarily have both spellings starting in AK 4.0. Something like: sorry that I didn't get your point :( > That wouldn't break the user's code at al

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

2024-11-27 Thread via GitHub
artemlivshits commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1861250626 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -525,6 +558,7 @@ class TransactionCoordinator(txnConfig: TransactionConfi

Re: [PR] MINOR: KStreamRepartitionIntegrationTest bug [kafka]

2024-11-27 Thread via GitHub
bbejeck commented on PR #17963: URL: https://github.com/apache/kafka/pull/17963#issuecomment-2504772293 Merged #17963 into trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] MINOR: KStreamRepartitionIntegrationTest bug [kafka]

2024-11-27 Thread via GitHub
bbejeck merged PR #17963: URL: https://github.com/apache/kafka/pull/17963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-18068: Fixing typo in ProducerConfig [kafka]

2024-11-27 Thread via GitHub
AndrewJSchofield commented on PR #17908: URL: https://github.com/apache/kafka/pull/17908#issuecomment-2504764436 @chia7712 I meant that we could temporarily have both spellings starting in AK 4.0. Something like: ``` public static final String PARTITIONER_ADAPTIVE_PARTITIONING_ENAB

Re: [PR] MINOR: remove zk from several tests [kafka]

2024-11-27 Thread via GitHub
chia7712 merged PR #17949: URL: https://github.com/apache/kafka/pull/17949 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-17010) Remove DescribeLogDirsResponse#ReplicaInfo

2024-11-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17010. Resolution: Fixed > Remove DescribeLogDirsResponse#ReplicaInfo > -

Re: [PR] KAFKA-17010: Remove `DescribeLogDirsResponse#ReplicaInfo` [kafka]

2024-11-27 Thread via GitHub
chia7712 merged PR #17953: URL: https://github.com/apache/kafka/pull/17953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Update Streams compatibility table in upgrade guide for 3.8 [kafka]

2024-11-27 Thread via GitHub
mjsax commented on PR #17851: URL: https://github.com/apache/kafka/pull/17851#issuecomment-2504726977 @JimGalasyn -- I think Bruno did a PR in the meantime for this already. Can you double check? I do see merge conflicts on this PR. (Seems there was some race condition.) -- This is an au

Re: [PR] MINOR: Use JDK 17 in Vagrant after dropping JDK 8 [kafka]

2024-11-27 Thread via GitHub
chia7712 commented on PR #17861: URL: https://github.com/apache/kafka/pull/17861#issuecomment-2504723014 Maybe we could add a CI job to run clients:check and streams:check using JDK 11? This would not only help us avoid concerns about Java 11 byte-code, but also be a straightforward task to

[jira] [Comment Edited] (KAFKA-18084) Null and leaked AcquisitionLockTimerTask causes hanging AcknowledgeRequest and corrupted state of batch

2024-11-27 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17901471#comment-17901471 ] Abhinav Dixit edited comment on KAFKA-18084 at 11/27/24 8:10 PM: -

[jira] [Commented] (KAFKA-18084) Null and leaked AcquisitionLockTimerTask causes hanging AcknowledgeRequest and corrupted state of batch

2024-11-27 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17901576#comment-17901576 ] Abhinav Dixit commented on KAFKA-18084: --- [~chia7712] , I've opened a PR for issue

[PR] [WIP DON'T MERGE] Kip1071 trunk rebase 11 25 [kafka]

2024-11-27 Thread via GitHub
bbejeck opened a new pull request, #17966: URL: https://github.com/apache/kafka/pull/17966 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

Re: [PR] KAFKA-15561 [4/N]: MockConsumer support for SubscriptionPattern [kafka]

2024-11-27 Thread via GitHub
lianetm merged PR #17962: URL: https://github.com/apache/kafka/pull/17962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-17696 New consumer background operations unaware of metadata errors [kafka]

2024-11-27 Thread via GitHub
lianetm commented on code in PR #17440: URL: https://github.com/apache/kafka/pull/17440#discussion_r1861159924 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -168,6 +171,8 @@ private void processApplicationEvents() {

[jira] [Assigned] (KAFKA-18100) `Using` block suppresses all errors

2024-11-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-18100: -- Assignee: TaiJuWu (was: Chia-Ping Tsai) > `Using` block suppresses all errors >

[jira] [Resolved] (KAFKA-18100) `Using` block suppresses all errors

2024-11-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18100. Fix Version/s: 4.0.0 Resolution: Fixed > `Using` block suppresses all errors >

Re: [PR] KAFKA-18100: `Using` block suppresses all errors [kafka]

2024-11-27 Thread via GitHub
chia7712 merged PR #17954: URL: https://github.com/apache/kafka/pull/17954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Created] (KAFKA-18106) Brokers should be removed from the ISR if possible on unclean restart

2024-11-27 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-18106: Summary: Brokers should be removed from the ISR if possible on unclean restart Key: KAFKA-18106 URL: https://issues.apache.org/jira/browse/KAFKA-18106 Project: Kafka

[jira] [Created] (KAFKA-18105) Fix flaky PlaintextAdminIntegrationTest#testElectPreferredLeaders

2024-11-27 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18105: -- Summary: Fix flaky PlaintextAdminIntegrationTest#testElectPreferredLeaders Key: KAFKA-18105 URL: https://issues.apache.org/jira/browse/KAFKA-18105 Project: Kafka

Re: [PR] MINOR: Use JDK 17 in Vagrant after dropping JDK 8 [kafka]

2024-11-27 Thread via GitHub
mjsax commented on PR #17861: URL: https://github.com/apache/kafka/pull/17861#issuecomment-2504594900 Yes, it's simpler, but I am still wondering if a "dual setup" would be better? -- I am not sure if we want to trust JDK17 to produce correct Java-11 byte-code, and thus, it might be better

[jira] [Assigned] (KAFKA-10409) Refactor Kafka Streams RocksDb iterators

2024-11-27 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] João Pedro Fonseca reassigned KAFKA-10409: -- Assignee: João Pedro Fonseca > Refactor Kafka Streams RocksDb iterators > --

Re: [PR] KAFKA-17593; [9/N] Mark ConsumerGroupHeartbeat API v1 as stable [kafka]

2024-11-27 Thread via GitHub
lianetm merged PR #17961: URL: https://github.com/apache/kafka/pull/17961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] MINOR: remove zk from several tests [kafka]

2024-11-27 Thread via GitHub
cmccabe commented on PR #17949: URL: https://github.com/apache/kafka/pull/17949#issuecomment-2504509772 - Removed modifications to `core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala` and removed it from the PR description - Added reference to `core/src/test/scala/integration/

Re: [PR] MINOR: remove zk from several tests [kafka]

2024-11-27 Thread via GitHub
cmccabe commented on code in PR #17949: URL: https://github.com/apache/kafka/pull/17949#discussion_r1861069280 ## core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala: ## @@ -191,8 +182,9 @@ class AddPartitionsTest extends BaseRequestTest { assertEquals(Set(0, 1), r

Re: [PR] KAFKA-17338 ConsumerConfig should prevent using partition assignors with CONSUMER group protocol [kafka]

2024-11-27 Thread via GitHub
m1a2st commented on code in PR #16899: URL: https://github.com/apache/kafka/pull/16899#discussion_r1861067203 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java: ## @@ -666,7 +686,8 @@ protected Map postProcessParsedConfig(final Map Map refi

Re: [PR] KAFKA-18098: add kraft support to testReplicaPlacementAllServers and testReplicaPlacementPartialServers [kafka]

2024-11-27 Thread via GitHub
peterxcli commented on code in PR #17955: URL: https://github.com/apache/kafka/pull/17955#discussion_r1861038757 ## core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala: ## @@ -17,14 +17,13 @@ package kafka.admin -import java.util.{Collections, Optional} +import jav

Re: [PR] MINOR: KStreamRepartitionIntegrationTest bug [kafka]

2024-11-27 Thread via GitHub
bbejeck commented on PR #17963: URL: https://github.com/apache/kafka/pull/17963#issuecomment-2504427813 Test time without the fix ![repartition_integration_test_without_fix](https://github.com/user-attachments/assets/49a072b0-2cb7-4366-b1be-6da7628715c4) Test time with the fix

[jira] [Reopened] (KAFKA-18104) Add test for in Loggers#currentLoggers

2024-11-27 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reopened KAFKA-18104: > Add test for in Loggers#currentLoggers > -- > >

[jira] [Assigned] (KAFKA-8458) Flaky Test AdminClientIntegrationTest#testElectPreferredLeaders

2024-11-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-8458: - Assignee: Chia-Ping Tsai > Flaky Test AdminClientIntegrationTest#testElectPreferredLeade

Re: [PR] MINOR: KStreamRepartitionIntegrationTest bug [kafka]

2024-11-27 Thread via GitHub
bbejeck commented on code in PR #17963: URL: https://github.com/apache/kafka/pull/17963#discussion_r1861005332 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KStreamRepartitionIntegrationTest.java: ## @@ -723,7 +724,7 @@ public void shouldGoThrou

[PR] MINOR: KStreamRepartitionIntegrationTest bug [kafka]

2024-11-27 Thread via GitHub
bbejeck opened a new pull request, #17963: URL: https://github.com/apache/kafka/pull/17963 The `KStreamRepartitionIntegrationTest.shouldThrowAnExceptionWhenNumberOfPartitionsOfRepartitionOperationDoNotMatchSourceTopicWhenJoining` test was taking two minutes due not reaching an expected cond

Re: [PR] KAFKA-15561 [3/N]: Client support for SubscriptionPattern in HB [kafka]

2024-11-27 Thread via GitHub
lianetm merged PR #17951: URL: https://github.com/apache/kafka/pull/17951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-9366: Upgrade log4j to log4j2 [kafka]

2024-11-27 Thread via GitHub
mimaison commented on PR #17373: URL: https://github.com/apache/kafka/pull/17373#issuecomment-2504369138 I just tested the Connect REST API with https://github.com/apache/kafka/pull/17373/commits/6d41bcd92758c7bc02c173b98dc4c53f88633ba0 and it worked fine. You mentioned issues with t

Re: [PR] Kafka-16505: Adding dead letter queue in Kafka Streams [kafka]

2024-11-27 Thread via GitHub
Dabz commented on code in PR #17942: URL: https://github.com/apache/kafka/pull/17942#discussion_r1860997384 ## streams/src/main/java/org/apache/kafka/streams/errors/DeserializationExceptionHandler.java: ## @@ -89,10 +95,35 @@ enum DeserializationHandlerResponse { */

Re: [PR] Kafka-16505: Adding dead letter queue in Kafka Streams [kafka]

2024-11-27 Thread via GitHub
Dabz commented on code in PR #17942: URL: https://github.com/apache/kafka/pull/17942#discussion_r1860996923 ## streams/src/main/java/org/apache/kafka/streams/errors/CommonExceptionHandler.java: ## Review Comment: I renamed this class to ExceptionHandlerUtils, make it packag

Re: [PR] KAFKA-18098: add kraft support to testReplicaPlacementAllServers and testReplicaPlacementPartialServers [kafka]

2024-11-27 Thread via GitHub
Yunyung commented on code in PR #17955: URL: https://github.com/apache/kafka/pull/17955#discussion_r1860984674 ## core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala: ## @@ -17,14 +17,13 @@ package kafka.admin -import java.util.{Collections, Optional} +import java.

Re: [PR] Kafka-16505: Adding dead letter queue in Kafka Streams [kafka]

2024-11-27 Thread via GitHub
Dabz commented on code in PR #17942: URL: https://github.com/apache/kafka/pull/17942#discussion_r1860995169 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -588,6 +588,10 @@ public class StreamsConfig extends AbstractConfig { public static final

Re: [PR] MINOR: Using rocksdb's prefixScan in fk joins for better performances [kafka]

2024-11-27 Thread via GitHub
Chuckame commented on code in PR #16218: URL: https://github.com/apache/kafka/pull/16218#discussion_r1860964070 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/ForeignTableJoinProcessorSupplier.java: ## @@ -111,34 +110,26 @@ public void process

Re: [PR] KAFKA-17750: Extend kafka-consumer-groups command line tool to support new consumer group (part 1) [kafka]

2024-11-27 Thread via GitHub
dajac commented on code in PR #17958: URL: https://github.com/apache/kafka/pull/17958#discussion_r1860958252 ## clients/src/main/resources/common/message/ConsumerGroupDescribeRequest.json: ## @@ -18,7 +18,7 @@ "type": "request", "listeners": ["broker"], "name": "Consume

Re: [PR] KAFKA-17696 New consumer background operations unaware of metadata errors [kafka]

2024-11-27 Thread via GitHub
chia7712 commented on code in PR #17440: URL: https://github.com/apache/kafka/pull/17440#discussion_r1860952945 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -153,7 +154,16 @@ void runOnce() { .map(rm -> r

Re: [PR] KAFKA-17696 New consumer background operations unaware of metadata errors [kafka]

2024-11-27 Thread via GitHub
chia7712 commented on code in PR #17440: URL: https://github.com/apache/kafka/pull/17440#discussion_r1860948200 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java: ## @@ -150,6 +152,7 @@ private void maybePropagateMetadataError() {

Re: [PR] KAFKA-18061 AddRaftVoter responds with error message "NONE" instead of null [kafka]

2024-11-27 Thread via GitHub
aiven-anton commented on PR #17930: URL: https://github.com/apache/kafka/pull/17930#issuecomment-2504287219 Is it possible to add some test for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (KAFKA-17789) State updater stuck when starting with empty state folder

2024-11-27 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17901529#comment-17901529 ] Lucas Brutschy commented on KAFKA-17789: [~chuckame] did you have time to provid

[jira] [Updated] (KAFKA-18104) Add test for in Loggers#currentLoggers

2024-11-27 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi updated KAFKA-18104: Description: Since we are upgrading to Log4j2, we also identified some test coverage issues. Curr

[jira] [Updated] (KAFKA-18104) Add test for in Loggers#currentLoggers

2024-11-27 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi updated KAFKA-18104: Issue Type: Test (was: Bug) > Add test for in Loggers#currentLoggers > --

[jira] [Updated] (KAFKA-18104) Add test for in Loggers#currentLoggers

2024-11-27 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi updated KAFKA-18104: Summary: Add test for in Loggers#currentLoggers (was: Fix bug in Loggers#currentLoggers) > Add t

[jira] [Commented] (KAFKA-18054) Automatically detect missed configs needed by a topology

2024-11-27 Thread Peter Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17901527#comment-17901527 ] Peter Lee commented on KAFKA-18054: --- Hi [~ableegoldman] , if you are not working on th

Re: [PR] KAFKA-9366: Upgrade log4j to log4j2 [kafka]

2024-11-27 Thread via GitHub
mimaison commented on PR #17373: URL: https://github.com/apache/kafka/pull/17373#issuecomment-2504207669 Apart if the changes to fix the system tests are very large, I'd rather do them in this PR as well. We typically don't merge PRs that we know will break tests. -- This is an automated

Re: [PR] KAFKA-9366: Upgrade log4j to log4j2 [kafka]

2024-11-27 Thread via GitHub
frankvicky commented on PR #17373: URL: https://github.com/apache/kafka/pull/17373#issuecomment-2504196849 Hi @mimaison, I have filed a JIRA for the issue with the Connect API: https://issues.apache.org/jira/browse/KAFKA-18104 BTW, I’m aware that this PR is expected to break

[jira] [Commented] (KAFKA-18104) Fix bug in Loggers#currentLoggers

2024-11-27 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17901524#comment-17901524 ] Mickael Maison commented on KAFKA-18104: This bug should be fixed in https://git

[jira] [Resolved] (KAFKA-18104) Fix bug in Loggers#currentLoggers

2024-11-27 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-18104. Resolution: Invalid > Fix bug in Loggers#currentLoggers >

  1   2   >