robobario commented on code in PR #17967: URL: https://github.com/apache/kafka/pull/17967#discussion_r1861278947
########## docs/protocol.html: ########## @@ -143,7 +138,13 @@ <h5 class="anchor-heading"><a id="api_versions" class="anchor-link"></a><a href= Kafka protocol requests may take place on an SSL listener before the SSL handshake is finished). If this is considered to leak information about the broker version a workaround is to use SSL with client authentication which is performed at an earlier stage of the connection where the <code>ApiVersionRequest</code> is not available. Also, note that broker versions older - than 0.10.0.0 do not support this API and will either ignore the request or close connection in response to the request.</li> + than 0.10.0.0 do not support this API and will either ignore the request or close connection in response to the request. Also Review Comment: maybe better to extract it into it's own paragraph or section about fallback behaviour and link from here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org