Re: [PR] KAFKA-17954: Error getting oldest-iterator-open-since-ms from JMX [kafka]

2024-11-19 Thread via GitHub
ableegoldman commented on code in PR #17713: URL: https://github.com/apache/kafka/pull/17713#discussion_r1849779903 ## streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java: ## @@ -154,7 +155,13 @@ private void registerMetrics() { Stat

Re: [PR] KAFKA-18039: Test all versions of quorum responses in RequestResponseTest [kafka]

2024-11-19 Thread via GitHub
peterxcli commented on PR #17873: URL: https://github.com/apache/kafka/pull/17873#issuecomment-2487755203 @ahuang98 Hi, This PR is ready, could you please take a look, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[PR] KAFKA-18039: Test all versions of quorum responses in RequestResponseTest [kafka]

2024-11-19 Thread via GitHub
peterxcli opened a new pull request, #17873: URL: https://github.com/apache/kafka/pull/17873 - [KAFKA-18039](https://issues.apache.org/jira/browse/KAFKA-18039) ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverag

Re: [PR] MINOR: Fix the leak "unknown" `group.coordinator.rebalance.protocols` on document [kafka]

2024-11-19 Thread via GitHub
chia7712 commented on code in PR #17834: URL: https://github.com/apache/kafka/pull/17834#discussion_r1848203586 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java: ## @@ -76,7 +76,9 @@ public class GroupCoordinatorConfig { pu

[PR] WIP: Remove partitionMaxBytes from share fetch requests [kafka]

2024-11-19 Thread via GitHub
adixitconfluent opened a new pull request, #17870: URL: https://github.com/apache/kafka/pull/17870 ### About Making an attempt to remove partitionMaxBytes from share fetch requests -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] KAFKA-17750: Extend kafka-consumer-groups command line tool to support new consumer group [kafka]

2024-11-19 Thread via GitHub
FrankYang0529 opened a new pull request, #17872: URL: https://github.com/apache/kafka/pull/17872 The new consumer groups have more state available to troubleshoot issues. For instance, each member has an epoch, an assignment, a target assignment, etc. It would be useful to display those too

Re: [PR] KAFKA-16540: use feature version to enable ELR [kafka]

2024-11-19 Thread via GitHub
CalvinConfluent commented on code in PR #17867: URL: https://github.com/apache/kafka/pull/17867#discussion_r1849662649 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -1029,7 +1030,8 @@ TimelineHashSet imbalancedPartitions() { }

[jira] [Resolved] (KAFKA-18043) Fix flaky test - StreamThreadTest: shouldLogAndRecordSkippedRecordsForInvalidTimestamps

2024-11-19 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhinav Dixit resolved KAFKA-18043. --- Resolution: Duplicate Duplicate with Jira https://issues.apache.org/jira/browse/KAFKA-18038

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

2024-11-19 Thread via GitHub
jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1848875185 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -476,7 +476,7 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-6807: Inconsistent method name. [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] closed pull request #4899: KAFKA-6807: Inconsistent method name. URL: https://github.com/apache/kafka/pull/4899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[PR] [WIP] KAFKA-17243 [kafka]

2024-11-19 Thread via GitHub
peterxcli opened a new pull request, #17871: URL: https://github.com/apache/kafka/pull/17871 - [KAFKA-17243](https://issues.apache.org/jira/browse/KAFKA-17243) ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverag

[jira] [Commented] (KAFKA-18043) Fix flaky test - StreamThreadTest: shouldLogAndRecordSkippedRecordsForInvalidTimestamps

2024-11-19 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17899658#comment-17899658 ] Abhinav Dixit commented on KAFKA-18043: --- thanks for the input [~peterxcli], I'll c

Re: [PR] [WIP] KAFKA-6589 Extract Heartbeat thread from AbstractCoordinator [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] commented on PR #4647: URL: https://github.com/apache/kafka/pull/4647#issuecomment-2487284675 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to r

Re: [PR] KAFKA-17928: Make remote log manager thread-pool configs dynamic [kafka]

2024-11-19 Thread via GitHub
peterxcli commented on code in PR #17859: URL: https://github.com/apache/kafka/pull/17859#discussion_r1849596423 ## core/src/main/scala/kafka/server/DynamicBrokerConfig.scala: ## @@ -1167,6 +1167,22 @@ class DynamicRemoteLogConfig(server: KafkaBroker) extends BrokerReconfigurab

Re: [PR] KAFKA-17928: Make remote log manager thread-pool configs dynamic [kafka]

2024-11-19 Thread via GitHub
satishd commented on code in PR #17859: URL: https://github.com/apache/kafka/pull/17859#discussion_r1849549295 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -2151,31 +2167,30 @@ RLMTaskWithFuture followerTask(TopicIdPartition partition) { static class

Re: [PR] KAFKA-18027: MINOR: Correct DelayedOperationPurgatory code around adding of an already completed operation [kafka]

2024-11-19 Thread via GitHub
adixitconfluent commented on PR #17842: URL: https://github.com/apache/kafka/pull/17842#issuecomment-2487544060 > @adixitconfluent : Are the test failures related to the PR? Hi @junrao , I ran the test on my local machine. It ran fine. I think the test is flaky, hence created a JIRA

[jira] [Created] (KAFKA-18043) Fix flaky test - StreamThreadTest: shouldLogAndRecordSkippedRecordsForInvalidTimestamps

2024-11-19 Thread Abhinav Dixit (Jira)
Abhinav Dixit created KAFKA-18043: - Summary: Fix flaky test - StreamThreadTest: shouldLogAndRecordSkippedRecordsForInvalidTimestamps Key: KAFKA-18043 URL: https://issues.apache.org/jira/browse/KAFKA-18043

Re: [PR] MINOR: use bash regex matching instead of egrep inside kafka-run-class.sh [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] commented on PR #4588: URL: https://github.com/apache/kafka/pull/4588#issuecomment-2487284562 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to r

Re: [PR] KAFKA-17928: Make remote log manager thread-pool configs dynamic [kafka]

2024-11-19 Thread via GitHub
kamalcph commented on PR #17793: URL: https://github.com/apache/kafka/pull/17793#issuecomment-2485668397 @peterxcli I've fixed the unit tests and opened #17859 PR. Added you as the co-author. Thought to open a PR against your branch but you've multiple `trunk` merges instead of `reb

Re: [PR] MINOR: Various cleanups in coordinator modules [kafka]

2024-11-19 Thread via GitHub
mimaison merged PR #17828: URL: https://github.com/apache/kafka/pull/17828 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Fixing typos in property definition: Adding an apostrophe and capitalizing ISR. [kafka]

2024-11-19 Thread via GitHub
jolshan merged PR #17848: URL: https://github.com/apache/kafka/pull/17848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-17593; [8/N] Resolve regular expressions [kafka]

2024-11-19 Thread via GitHub
dajac commented on code in PR #17864: URL: https://github.com/apache/kafka/pull/17864#discussion_r1849538916 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2427,25 +2471,259 @@ private boolean hasMemberSubscriptionChanged(

Re: [PR] KAFKA-17593; [8/N] Resolve regular expressions [kafka]

2024-11-19 Thread via GitHub
dajac commented on code in PR #17864: URL: https://github.com/apache/kafka/pull/17864#discussion_r1849535598 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2427,25 +2471,259 @@ private boolean hasMemberSubscriptionChanged(

Re: [PR] KAFKA-4893: Fix conflict between async topic deletion and max topic length [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] commented on PR #4241: URL: https://github.com/apache/kafka/pull/4241#issuecomment-2487284300 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to r

Re: [PR] MINOR: clarify ProducerPerformance throughput units [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] commented on PR #4750: URL: https://github.com/apache/kafka/pull/4750#issuecomment-2487284904 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to r

Re: [PR] KAFKA-6332: Kafka system tests should use nc instead of log grep to d… [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] commented on PR #4589: URL: https://github.com/apache/kafka/pull/4589#issuecomment-2487284602 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to r

Re: [PR] KAFKA-6649: Should catch OutOfRangeException for ReplicaFetcherThread [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] commented on PR #4707: URL: https://github.com/apache/kafka/pull/4707#issuecomment-2487284706 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to r

Re: [PR] [KAFKA-6482] when produce send a invalidity timestamps, broker will be not delete … [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] closed pull request #4473: [KAFKA-6482] when produce send a invalidity timestamps, broker will be not delete … URL: https://github.com/apache/kafka/pull/4473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-17981:add Integration test for ConfigCommand to add config `key=[val1,val2]` [kafka]

2024-11-19 Thread via GitHub
Rancho-7 commented on code in PR #17771: URL: https://github.com/apache/kafka/pull/17771#discussion_r1849499551 ## core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java: ## @@ -138,6 +139,36 @@ public void testNullStatusOnKraftCommandAlterClientMetrics() { a

Re: [PR] KAFKA-5285: Use window and session key schema's comparator for rocksDB / Cache bytes [WIP] [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] commented on PR #4576: URL: https://github.com/apache/kafka/pull/4576#issuecomment-2487284515 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to r

[jira] [Assigned] (KAFKA-18039) Test all versions of quorum responses in RequestResponseTest

2024-11-19 Thread Alyssa Huang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alyssa Huang reassigned KAFKA-18039: Assignee: Peter Lee (was: Alyssa Huang) > Test all versions of quorum responses in Reque

Re: [PR] KAFKA-4893: Fix conflict between async topic deletion and max topic length [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] closed pull request #4241: KAFKA-4893: Fix conflict between async topic deletion and max topic length URL: https://github.com/apache/kafka/pull/4241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-6757 Log runtime exception in case of server startup errors [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] closed pull request #4833: KAFKA-6757 Log runtime exception in case of server startup errors URL: https://github.com/apache/kafka/pull/4833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [WIP] KAFKA-6589 Extract Heartbeat thread from AbstractCoordinator [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] closed pull request #4647: [WIP] KAFKA-6589 Extract Heartbeat thread from AbstractCoordinator URL: https://github.com/apache/kafka/pull/4647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] MINOR: UpdateMetadataRequest should be lazily created [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] closed pull request #4553: MINOR: UpdateMetadataRequest should be lazily created URL: https://github.com/apache/kafka/pull/4553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] KAFKA-6588: Add metric for alive log cleaner thread count [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] closed pull request #4616: KAFKA-6588: Add metric for alive log cleaner thread count URL: https://github.com/apache/kafka/pull/4616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] KAFKA 5609 - Added RollingFileAppender as per review comments [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] closed pull request #4753: KAFKA 5609 - Added RollingFileAppender as per review comments URL: https://github.com/apache/kafka/pull/4753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-6807: Inconsistent method name. [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] commented on PR #4899: URL: https://github.com/apache/kafka/pull/4899#issuecomment-2487285070 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to r

Re: [PR] Remove ignore-case grep option from kafka-server-stop.sh [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] closed pull request #4298: Remove ignore-case grep option from kafka-server-stop.sh URL: https://github.com/apache/kafka/pull/4298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-5285: Use window and session key schema's comparator for rocksDB / Cache bytes [WIP] [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] closed pull request #4576: KAFKA-5285: Use window and session key schema's comparator for rocksDB / Cache bytes [WIP] URL: https://github.com/apache/kafka/pull/4576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] KAFKA-6303: Potential lack of synchronization in NioEchoServer [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] commented on PR #4400: URL: https://github.com/apache/kafka/pull/4400#issuecomment-2487284373 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to r

Re: [PR] KAFKA-6581: Fix the ConsumerGroupCommand indefinite execution if one of the partition is unavailable. [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] closed pull request #4612: KAFKA-6581: Fix the ConsumerGroupCommand indefinite execution if one of the partition is unavailable. URL: https://github.com/apache/kafka/pull/4612 -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] KAFKA-6700; allow producer performance test to run for a fixed duration [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] commented on PR #4748: URL: https://github.com/apache/kafka/pull/4748#issuecomment-2487284784 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to r

Re: [PR] Dynamically reload truststore. [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] commented on PR #4541: URL: https://github.com/apache/kafka/pull/4541#issuecomment-2487284419 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to r

Re: [PR] MINOR: UpdateMetadataRequest should be lazily created [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] commented on PR #4553: URL: https://github.com/apache/kafka/pull/4553#issuecomment-2487284448 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to r

Re: [PR] KAFKA-6559: Iterate record sets before calling Log.append [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] closed pull request #4567: KAFKA-6559: Iterate record sets before calling Log.append URL: https://github.com/apache/kafka/pull/4567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (KAFKA-18041) Update key for global consumer in client instance ids

2024-11-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-18041: Affects Version/s: 3.7.0 > Update key for global consumer in client instance ids > ---

Re: [PR] KAFKA-6700; allow producer performance test to run for a fixed duration [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] closed pull request #4748: KAFKA-6700; allow producer performance test to run for a fixed duration URL: https://github.com/apache/kafka/pull/4748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA 5609 - Added RollingFileAppender as per review comments [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] commented on PR #4753: URL: https://github.com/apache/kafka/pull/4753#issuecomment-2487284982 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to r

Re: [PR] KAFKA-6581: Fix the ConsumerGroupCommand indefinite execution if one of the partition is unavailable. [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] commented on PR #4612: URL: https://github.com/apache/kafka/pull/4612#issuecomment-2487284623 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to r

Re: [PR] KAFKA-6649: Should catch OutOfRangeException for ReplicaFetcherThread [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] closed pull request #4707: KAFKA-6649: Should catch OutOfRangeException for ReplicaFetcherThread URL: https://github.com/apache/kafka/pull/4707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] KAFKA-6332: Kafka system tests should use nc instead of log grep to d… [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] closed pull request #4589: KAFKA-6332: Kafka system tests should use nc instead of log grep to d… URL: https://github.com/apache/kafka/pull/4589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-6588: Add metric for alive log cleaner thread count [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] commented on PR #4616: URL: https://github.com/apache/kafka/pull/4616#issuecomment-2487284646 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to r

Re: [PR] MINOR: use bash regex matching instead of egrep inside kafka-run-class.sh [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] closed pull request #4588: MINOR: use bash regex matching instead of egrep inside kafka-run-class.sh URL: https://github.com/apache/kafka/pull/4588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] KAFKA-6326: when broker is unavailable, fast revover [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] closed pull request #4302: KAFKA-6326: when broker is unavailable, fast revover URL: https://github.com/apache/kafka/pull/4302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-6559: Iterate record sets before calling Log.append [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] commented on PR #4567: URL: https://github.com/apache/kafka/pull/4567#issuecomment-2487284484 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to r

Re: [PR] Dynamically reload truststore. [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] closed pull request #4541: Dynamically reload truststore. URL: https://github.com/apache/kafka/pull/4541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [KAFKA-6482] when produce send a invalidity timestamps, broker will be not delete … [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] commented on PR #4473: URL: https://github.com/apache/kafka/pull/4473#issuecomment-2487284399 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to r

Re: [PR] Remove ignore-case grep option from kafka-server-stop.sh [kafka]

2024-11-19 Thread via GitHub
github-actions[bot] commented on PR #4298: URL: https://github.com/apache/kafka/pull/4298#issuecomment-2487284321 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to r

[jira] [Commented] (KAFKA-18042) Reject the produce request with lower producer epoch early.

2024-11-19 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17899609#comment-17899609 ] TaiJuWu commented on KAFKA-18042: - Hi [~calvinliu] , If you are not working on this, may

Re: [PR] MINOR: Fix the leak "unknown" `group.coordinator.rebalance.protocols` on document [kafka]

2024-11-19 Thread via GitHub
m1a2st commented on PR #17834: URL: https://github.com/apache/kafka/pull/17834#issuecomment-2485544560 test in my local ![CleanShot 2024-11-19 at 20 09 34@2x](https://github.com/user-attachments/assets/03f2fecd-8805-4a5a-aa6a-7a258dadf4cc) -- This is an automated message from the A

[jira] [Updated] (KAFKA-18041) Update key for global consumer in client instance ids

2024-11-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-18041: Component/s: streams > Update key for global consumer in client instance ids > ---

Re: [PR] KAFKA-16339: [3/4 KStream#transformValues] Remove Deprecated "transformer" methods and classes [kafka]

2024-11-19 Thread via GitHub
mjsax commented on code in PR #17266: URL: https://github.com/apache/kafka/pull/17266#discussion_r1849419753 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamTransformValuesTest.java: ## @@ -54,92 +44,6 @@ public class KStreamTransformValuesTest {

Re: [PR] MINOR: Test all comsumer api does not allow multi-threading [kafka]

2024-11-19 Thread via GitHub
TaiJuWu commented on PR #17405: URL: https://github.com/apache/kafka/pull/17405#issuecomment-2487212576 > @TaiJuWu—just checking in on this PR. It seems like we're really close to getting something mergeable. Is there anything you need from @lianetm or myself? Thanks! Hi @kirktrue ,

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

2024-11-19 Thread via GitHub
CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1849411061 ## core/src/test/scala/integration/kafka/api/TransactionsTest.scala: ## @@ -401,6 +401,7 @@ class TransactionsTest extends IntegrationTestHarness { produce

Re: [PR] KAFKA-17981:add Integration test for ConfigCommand to add config `key=[val1,val2]` [kafka]

2024-11-19 Thread via GitHub
TaiJuWu commented on code in PR #17771: URL: https://github.com/apache/kafka/pull/17771#discussion_r1849404649 ## core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java: ## @@ -138,6 +139,36 @@ public void testNullStatusOnKraftCommandAlterClientMetrics() { as

Re: [PR] MINOR Fix test-catalog generation [kafka]

2024-11-19 Thread via GitHub
mumrah commented on PR #17866: URL: https://github.com/apache/kafka/pull/17866#issuecomment-2487175485 Confirmed the test-catalog is fixed now on after the trunk build -> https://github.com/apache/kafka/commit/738ad9c5575ffaef01a6974c25040b048caae573 -- This is an automated message from

[jira] [Updated] (KAFKA-16699) Have Streams treat InvalidPidMappingException like a ProducerFencedException

2024-11-19 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-16699: --- Fix Version/s: 3.8.0 > Have Streams treat InvalidPidMappingException like a ProducerFencedEx

[jira] [Reopened] (KAFKA-10409) Refactor Kafka Streams RocksDb iterators

2024-11-19 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reopened KAFKA-10409: > Refactor Kafka Streams RocksDb iterators >

[jira] [Resolved] (KAFKA-12689) Remove deprecated EOS configs

2024-11-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-12689. - Resolution: Fixed Covered by https://github.com/apache/kafka/pull/17170 > Remove deprec

[jira] [Assigned] (KAFKA-12689) Remove deprecated EOS configs

2024-11-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-12689: --- Assignee: Matthias J. Sax > Remove deprecated EOS configs > ---

Re: [PR] KAFKA-17981:add Integration test for ConfigCommand to add config `key=[val1,val2]` [kafka]

2024-11-19 Thread via GitHub
Rancho-7 commented on code in PR #17771: URL: https://github.com/apache/kafka/pull/17771#discussion_r1849375257 ## core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java: ## @@ -138,6 +139,37 @@ public void testNullStatusOnKraftCommandAlterClientMetrics() { a

[jira] [Commented] (KAFKA-18015) Add duration based offset reset option for Kafka Streams

2024-11-19 Thread Kevin Apolinario (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17899612#comment-17899612 ] Kevin Apolinario commented on KAFKA-18015: -- Added AutoOffsetReset Class and rel

Re: [PR] MINOR: Test all comsumer api does not allow multi-threading [kafka]

2024-11-19 Thread via GitHub
kirktrue commented on PR #17405: URL: https://github.com/apache/kafka/pull/17405#issuecomment-2487107688 @TaiJuWu—just checking in on this PR. It seems like we're really close to getting something mergeable. Is there anything you need from @lianetm or myself? Thanks! -- This is an automa

[jira] [Resolved] (KAFKA-10409) Refactor Kafka Streams RocksDb iterators

2024-11-19 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-10409. Resolution: Incomplete > Refactor Kafka Streams RocksDb iterators > -

Re: [PR] KAFKA-17338 ConsumerConfig should prevent using partition assignors with CONSUMER group protocol [kafka]

2024-11-19 Thread via GitHub
kirktrue commented on PR #16899: URL: https://github.com/apache/kafka/pull/16899#issuecomment-2487106509 @m1a2st—just checking in on this PR. It seems like we're really close. Is there anything you need from @lianetm or myself? Thanks! -- This is an automated message from the Apache Git S

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

2024-11-19 Thread via GitHub
CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1849324300 ## core/src/test/scala/integration/kafka/api/TransactionsTest.scala: ## @@ -401,6 +401,7 @@ class TransactionsTest extends IntegrationTestHarness { produce

Re: [PR] KAFKA-17696 New consumer background operations unaware of metadata errors [kafka]

2024-11-19 Thread via GitHub
kirktrue commented on code in PR #17440: URL: https://github.com/apache/kafka/pull/17440#discussion_r1849333895 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java: ## @@ -230,6 +234,10 @@ private ClientRequest makeClientRequest(

Re: [PR] KAFKA-16540: use feature version to enable ELR [kafka]

2024-11-19 Thread via GitHub
cmccabe commented on code in PR #17867: URL: https://github.com/apache/kafka/pull/17867#discussion_r1849118418 ## metadata/src/test/java/org/apache/kafka/controller/QuorumControllerIntegrationTestUtils.java: ## @@ -75,6 +77,27 @@ static BrokerRegistrationRequestData.FeatureColle

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

2024-11-19 Thread via GitHub
CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1849340745 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -225,7 +245,7 @@ class AddPartitionsToTxnManager( val code =

Re: [PR] KAFKA-16143: New JMX metrics for AsyncKafkaConsumer [kafka]

2024-11-19 Thread via GitHub
kirktrue commented on code in PR #17199: URL: https://github.com/apache/kafka/pull/17199#discussion_r1849317079 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -213,10 +212,11 @@ private void process(final ConsumerRebalanceLis

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

2024-11-19 Thread via GitHub
jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1849325623 ## core/src/test/scala/integration/kafka/api/TransactionsTest.scala: ## @@ -401,6 +401,7 @@ class TransactionsTest extends IntegrationTestHarness { producer1.begin

[jira] [Created] (KAFKA-18042) Reject the produce request with lower producer epoch early.

2024-11-19 Thread Calvin Liu (Jira)
Calvin Liu created KAFKA-18042: -- Summary: Reject the produce request with lower producer epoch early. Key: KAFKA-18042 URL: https://issues.apache.org/jira/browse/KAFKA-18042 Project: Kafka Issu

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

2024-11-19 Thread via GitHub
CalvinConfluent commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1849318159 ## core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala: ## @@ -490,9 +494,10 @@ private[transaction] class TransactionMetadata(val tran

Re: [PR] KAFKA-17898: Refine Epoch Bumping Logic [kafka]

2024-11-19 Thread via GitHub
CalvinConfluent commented on code in PR #17849: URL: https://github.com/apache/kafka/pull/17849#discussion_r1848672480 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1164,23 +1164,42 @@ private TransactionalRequestResult han

Re: [PR] KAFKA-17593; [8/N] Resolve regular expressions [kafka]

2024-11-19 Thread via GitHub
jeffkbkim commented on code in PR #17864: URL: https://github.com/apache/kafka/pull/17864#discussion_r1848659608 ## coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/MockCoordinatorExecutor.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Soft

Re: [PR] KAFKA-17898: Refine Epoch Bumping Logic [kafka]

2024-11-19 Thread via GitHub
rreddy-22 commented on code in PR #17849: URL: https://github.com/apache/kafka/pull/17849#discussion_r1848881323 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -191,7 +191,7 @@ public class TransactionManager { private vo

[PR] KAFKA-18041: Update key for storing global consumer instance id for consistency [kafka]

2024-11-19 Thread via GitHub
bbejeck opened a new pull request, #17869: URL: https://github.com/apache/kafka/pull/17869 This PR updates the key for storing the KIP-714 client instance id for the global consumer to follow a more consistent pattern of the other embedded Kafka Streams consumer clients. *Su

[jira] [Created] (KAFKA-18041) Update key for global consumer in client instance ids

2024-11-19 Thread Bill Bejeck (Jira)
Bill Bejeck created KAFKA-18041: --- Summary: Update key for global consumer in client instance ids Key: KAFKA-18041 URL: https://issues.apache.org/jira/browse/KAFKA-18041 Project: Kafka Issue Typ

[jira] [Commented] (KAFKA-15826) WorkerSinkTask leaks Consumer if plugin start or stop blocks indefinitely

2024-11-19 Thread Will Perlichek (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17899564#comment-17899564 ] Will Perlichek commented on KAFKA-15826: Hi [~gharris1727] do you know if this t

Re: [PR] KAFKA-18027: MINOR: Correct DelayedOperationPurgatory code around adding of an already completed operation [kafka]

2024-11-19 Thread via GitHub
junrao commented on PR #17842: URL: https://github.com/apache/kafka/pull/17842#issuecomment-2486900169 @adixitconfluent : Are the test failures related to the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (KAFKA-17635) Lost events on internal repartition topic when excatly_once_v2 is set and producer is fenced

2024-11-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-17635: Fix Version/s: 3.9.1 (was: 3.9.0) > Lost events on internal reparti

Re: [PR] KAFKA-16540: use feature version to enable ELR [kafka]

2024-11-19 Thread via GitHub
cmccabe commented on code in PR #17867: URL: https://github.com/apache/kafka/pull/17867#discussion_r1849116901 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -1029,7 +1030,8 @@ TimelineHashSet imbalancedPartitions() { } bo

Re: [PR] KAFKA-16143: New JMX metrics for AsyncKafkaConsumer [kafka]

2024-11-19 Thread via GitHub
FrankYang0529 commented on code in PR #17199: URL: https://github.com/apache/kafka/pull/17199#discussion_r1848358392 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java: ## @@ -267,7 +272,9 @@ public void addAll(final List requests) {

Re: [PR] KAFKA-16143: New JMX metrics for AsyncKafkaConsumer [kafka]

2024-11-19 Thread via GitHub
lianetm commented on code in PR #17199: URL: https://github.com/apache/kafka/pull/17199#discussion_r1849018100 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -173,6 +181,7 @@ private void processApplicationEvents() {

[PR] MINOR: Update streams metrics table with alive stream threads entry [kafka]

2024-11-19 Thread via GitHub
bbejeck opened a new pull request, #17868: URL: https://github.com/apache/kafka/pull/17868 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade n

Re: [PR] KAFKA-17593; [8/N] Resolve regular expressions [kafka]

2024-11-19 Thread via GitHub
dajac commented on code in PR #17864: URL: https://github.com/apache/kafka/pull/17864#discussion_r1849089218 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java: ## @@ -240,7 +245,9 @@ public class GroupCoordinatorConfig {

Re: [PR] KAFKA-17593; [8/N] Resolve regular expressions [kafka]

2024-11-19 Thread via GitHub
dajac commented on code in PR #17864: URL: https://github.com/apache/kafka/pull/17864#discussion_r1849088378 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1812,23 +1844,36 @@ private CoordinatorResult .setCl

Re: [PR] KAFKA-17696 New consumer background operations unaware of metadata errors [kafka]

2024-11-19 Thread via GitHub
m1a2st commented on code in PR #17440: URL: https://github.com/apache/kafka/pull/17440#discussion_r1848318657 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorRequestManager.java: ## @@ -188,6 +190,8 @@ private void onFailedResponse(final long curr

Re: [PR] KAFKA-17593; [8/N] Resolve regular expressions [kafka]

2024-11-19 Thread via GitHub
dajac commented on code in PR #17864: URL: https://github.com/apache/kafka/pull/17864#discussion_r1849085536 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2427,25 +2471,259 @@ private boolean hasMemberSubscriptionChanged(

  1   2   3   >