CalvinConfluent commented on code in PR #17867:
URL: https://github.com/apache/kafka/pull/17867#discussion_r1849662649
##########
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##########
@@ -1029,7 +1030,8 @@ TimelineHashSet<TopicIdPartition> imbalancedPartitions() {
}
boolean isElrEnabled() {
- return eligibleLeaderReplicasEnabled &&
featureControl.metadataVersion().isElrSupported();
+ return featureControl.metadataVersion().isElrSupported() &&
featureControl.finalizedFeatures(offsetControl.lastStableOffset()).
Review Comment:
Updated to use the latest finalized version.
##########
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerIntegrationTestUtils.java:
##########
@@ -75,6 +77,27 @@ static BrokerRegistrationRequestData.FeatureCollection
brokerFeatures(
return features;
}
+ /**
+ * Create a broker features collection for use in a registration request.
MV and given features are included.
+ *
+ * @param minVersion The minimum supported MV.
+ * @param maxVersion The maximum supported MV.
+ * @param featureList Other features to add.
+ */
+ static BrokerRegistrationRequestData.FeatureCollection
brokerFeaturesPlusFeatureVersions(
Review Comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
