[jira] [Commented] (KAFKA-7281) Fix documentation and error message regarding cleanup.policy=[compact,delete]

2024-07-08 Thread Ksolves (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864028#comment-17864028 ] Ksolves commented on KAFKA-7281: The behavior of the cleanup.policy parameter is inconsis

[jira] [Assigned] (KAFKA-16355) ConcurrentModificationException in InMemoryTimeOrderedKeyValueBuffer.evictWhile

2024-07-08 Thread Ksolves (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ksolves reassigned KAFKA-16355: --- Assignee: Ksolves > ConcurrentModificationException in > InMemoryTimeOrderedKeyValueBuffer.evictWh

[jira] [Updated] (KAFKA-7281) Fix documentation and error message regarding cleanup.policy=[compact,delete]

2024-07-08 Thread Ksolves (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ksolves updated KAFKA-7281: --- Attachment: topic-cleanup-policy.png > Fix documentation and error message regarding cleanup.policy=[compact,

Re: [PR] KAFKA-16745: Implemented handleShareFetchRequest RPC including unit tests [kafka]

2024-07-08 Thread via GitHub
chirag-wadhwa5 commented on code in PR #16456: URL: https://github.com/apache/kafka/pull/16456#discussion_r1669817534 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -4004,6 +4471,99 @@ class KafkaApis(val requestChannel: RequestChannel, CompletableFuture.complet

Re: [PR] KAFKA-16745: Implemented handleShareFetchRequest RPC including unit tests [kafka]

2024-07-08 Thread via GitHub
chirag-wadhwa5 commented on code in PR #16456: URL: https://github.com/apache/kafka/pull/16456#discussion_r1669815168 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -4390,6 +4401,2215 @@ class KafkaApisTest extends Logging { assertEquals("broker2", node

[jira] [Resolved] (KAFKA-17071) SharePartition - Add more unit tests

2024-07-08 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhinav Dixit resolved KAFKA-17071. --- Fix Version/s: 4.0.0 3.9.0 Resolution: Fixed > SharePartition - Ad

Re: [PR] KAFKA-17071: SharePartition - Add more unit tests and minor enhancement [kafka]

2024-07-08 Thread via GitHub
omkreddy merged PR #16530: URL: https://github.com/apache/kafka/pull/16530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16851: Add remote.log.disable.policy [kafka]

2024-07-08 Thread via GitHub
showuon commented on code in PR #16132: URL: https://github.com/apache/kafka/pull/16132#discussion_r1669550818 ## metadata/src/main/java/org/apache/kafka/metadata/KafkaConfigSchema.java: ## @@ -166,9 +166,11 @@ public Map resolveEffectiveTopicConfigs( ConfigDef configD

Re: [PR] KAFKA-16745: Implemented handleShareFetchRequest RPC including unit tests [kafka]

2024-07-08 Thread via GitHub
chirag-wadhwa5 commented on code in PR #16456: URL: https://github.com/apache/kafka/pull/16456#discussion_r1669768302 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -4390,6 +4401,2215 @@ class KafkaApisTest extends Logging { assertEquals("broker2", node

Re: [PR] KAFKA-16584 Make log processing summary configurable or debug [kafka]

2024-07-08 Thread via GitHub
mjsax commented on PR #16509: URL: https://github.com/apache/kafka/pull/16509#issuecomment-2216578847 @dujian0068 -- you should send a final email to the VOTE thread calling the vote closed and accepted (also summarizing the vote result), and update the KIP wiki pages accordingly. Thanks.

Re: [PR] KAFKA-16584 Make log processing summary configurable or debug [kafka]

2024-07-08 Thread via GitHub
mjsax commented on PR #16509: URL: https://github.com/apache/kafka/pull/16509#issuecomment-2216575106 Please don't forget to update the docs (upgrade guide and configs sections). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Created] (KAFKA-17101) Mirror maker internal topics cleanup policy changes to 'delete' from 'compact'

2024-07-08 Thread kaushik srinivas (Jira)
kaushik srinivas created KAFKA-17101: Summary: Mirror maker internal topics cleanup policy changes to 'delete' from 'compact' Key: KAFKA-17101 URL: https://issues.apache.org/jira/browse/KAFKA-17101

[jira] [Commented] (KAFKA-17098) Error Opening RocksDBStore

2024-07-08 Thread Eduwer Camacaro (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863989#comment-17863989 ] Eduwer Camacaro commented on KAFKA-17098: - [~mjsax] Yes, I just attached a log f

[jira] [Updated] (KAFKA-17098) Error Opening RocksDBStore

2024-07-08 Thread Eduwer Camacaro (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eduwer Camacaro updated KAFKA-17098: Attachment: server.log > Error Opening RocksDBStore > -- > >

Re: [PR] KAFKA-16851: Add remote.log.disable.policy [kafka]

2024-07-08 Thread via GitHub
showuon commented on code in PR #16132: URL: https://github.com/apache/kafka/pull/16132#discussion_r1669549418 ## clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: ## @@ -93,6 +93,17 @@ public class TopicConfig { "deletes the old segments. Defau

Re: [PR] MINOR: Increase some unit tests for utils [kafka]

2024-07-08 Thread via GitHub
xijiu commented on PR #16549: URL: https://github.com/apache/kafka/pull/16549#issuecomment-2216139424 > @xijiu, Thanks for your comments, I leaved some comments @m1a2st Thanks for your code review. They are all very helpful. I have fixed all of them, please review again. -- Th

[jira] [Commented] (KAFKA-17100) GlobalStreamThread#start should not busy-wait

2024-07-08 Thread kangning.li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863980#comment-17863980 ] kangning.li commented on KAFKA-17100: - hi [~gharris1727] , If you are not start work

[jira] [Commented] (KAFKA-17096) Fix kafka_log4j_appender.py

2024-07-08 Thread xuanzhang gong (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863978#comment-17863978 ] xuanzhang gong commented on KAFKA-17096: hello,i will handle this issue.  Please

[jira] [Commented] (KAFKA-17097) Add replace.null.with.default configuration to ValueToKey and ReplaceField (KIP-1040)

2024-07-08 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863977#comment-17863977 ] PoAn Yang commented on KAFKA-17097: --- Hi [~gharris1727], I'm interested in this. If you

[jira] [Commented] (KAFKA-17098) Error Opening RocksDBStore

2024-07-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863975#comment-17863975 ] Matthias J. Sax commented on KAFKA-17098: - [~cadonna] – do you think you recent

Re: [PR] Minor: Consumer group response should set error msg [kafka]

2024-07-08 Thread via GitHub
ulysses-you commented on code in PR #16497: URL: https://github.com/apache/kafka/pull/16497#discussion_r1669509734 ## clients/src/test/java/org/apache/kafka/common/requests/ConsumerGroupHeartbeatRequestTest.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-15999 Migrate HeartbeatRequestManagerTest away from ConsumerTestBuilder [kafka]

2024-07-08 Thread via GitHub
brenden20 commented on PR #16200: URL: https://github.com/apache/kafka/pull/16200#issuecomment-2215943716 @lianetm @philipnee thank you both for the feedback! I have addressed all comments and left some replies as well, let me know what you think, made some pretty major improvements over th

Re: [PR] KAFKA-15999 Migrate HeartbeatRequestManagerTest away from ConsumerTestBuilder [kafka]

2024-07-08 Thread via GitHub
brenden20 commented on code in PR #16200: URL: https://github.com/apache/kafka/pull/16200#discussion_r1669499524 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -251,23 +304,25 @@ public void testSkippingHeartbeat(fina

Re: [PR] KAFKA-15999 Migrate HeartbeatRequestManagerTest away from ConsumerTestBuilder [kafka]

2024-07-08 Thread via GitHub
brenden20 commented on code in PR #16200: URL: https://github.com/apache/kafka/pull/16200#discussion_r1669499273 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -349,6 +408,10 @@ public void testNoCoordinator() {

Re: [PR] KAFKA-15999 Migrate HeartbeatRequestManagerTest away from ConsumerTestBuilder [kafka]

2024-07-08 Thread via GitHub
brenden20 commented on code in PR #16200: URL: https://github.com/apache/kafka/pull/16200#discussion_r1669498721 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -898,6 +967,6 @@ private HeartbeatRequestManager createH

Re: [PR] KAFKA-15999 Migrate HeartbeatRequestManagerTest away from ConsumerTestBuilder [kafka]

2024-07-08 Thread via GitHub
brenden20 commented on code in PR #16200: URL: https://github.com/apache/kafka/pull/16200#discussion_r1669497625 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -756,18 +846,18 @@ public void testFencedMemberStopHeart

Re: [PR] KAFKA-15999 Migrate HeartbeatRequestManagerTest away from ConsumerTestBuilder [kafka]

2024-07-08 Thread via GitHub
brenden20 commented on code in PR #16200: URL: https://github.com/apache/kafka/pull/16200#discussion_r1669495115 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -756,18 +846,18 @@ public void testFencedMemberStopHeart

Re: [PR] MINOR: Increase some unit tests for utils [kafka]

2024-07-08 Thread via GitHub
m1a2st commented on code in PR #16549: URL: https://github.com/apache/kafka/pull/16549#discussion_r1669482604 ## clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java: ## @@ -448,6 +449,87 @@ public void testMin() { assertEquals(1, Utils.min(2, 3, 1));

Re: [PR] KAFKA-16684: Remove cache in responseData [kafka]

2024-07-08 Thread via GitHub
m1a2st commented on code in PR #16532: URL: https://github.com/apache/kafka/pull/16532#discussion_r1669472238 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java: ## @@ -3665,6 +3670,18 @@ public void testWhenFetchResponseReturnsALeaderShipChan

Re: [PR] KAFKA-16684: Remove cache in responseData [kafka]

2024-07-08 Thread via GitHub
m1a2st commented on code in PR #16532: URL: https://github.com/apache/kafka/pull/16532#discussion_r1669472238 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java: ## @@ -3665,6 +3670,18 @@ public void testWhenFetchResponseReturnsALeaderShipChan

Re: [PR] KAFKA-16684: Remove cache in responseData [kafka]

2024-07-08 Thread via GitHub
m1a2st commented on code in PR #16532: URL: https://github.com/apache/kafka/pull/16532#discussion_r1669467090 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java: ## @@ -3665,6 +3670,18 @@ public void testWhenFetchResponseReturnsALeaderShipChan

Re: [PR] KAFKA-16684: Remove cache in responseData [kafka]

2024-07-08 Thread via GitHub
m1a2st commented on code in PR #16532: URL: https://github.com/apache/kafka/pull/16532#discussion_r1669467090 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java: ## @@ -3665,6 +3670,18 @@ public void testWhenFetchResponseReturnsALeaderShipChan

Re: [PR] KAFKA-15999 Migrate HeartbeatRequestManagerTest away from ConsumerTestBuilder [kafka]

2024-07-08 Thread via GitHub
brenden20 commented on code in PR #16200: URL: https://github.com/apache/kafka/pull/16200#discussion_r1669465217 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -312,31 +369,33 @@ public void testHeartbeatOutsideInterv

Re: [PR] KAFKA-15999 Migrate HeartbeatRequestManagerTest away from ConsumerTestBuilder [kafka]

2024-07-08 Thread via GitHub
brenden20 commented on code in PR #16200: URL: https://github.com/apache/kafka/pull/16200#discussion_r1669460104 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -251,23 +304,25 @@ public void testSkippingHeartbeat(fina

Re: [PR] KAFKA-15999 Migrate HeartbeatRequestManagerTest away from ConsumerTestBuilder [kafka]

2024-07-08 Thread via GitHub
brenden20 commented on code in PR #16200: URL: https://github.com/apache/kafka/pull/16200#discussion_r1669445851 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -251,23 +304,25 @@ public void testSkippingHeartbeat(fina

Re: [PR] KAFKA-15999 Migrate HeartbeatRequestManagerTest away from ConsumerTestBuilder [kafka]

2024-07-08 Thread via GitHub
brenden20 commented on code in PR #16200: URL: https://github.com/apache/kafka/pull/16200#discussion_r1669445851 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -251,23 +304,25 @@ public void testSkippingHeartbeat(fina

Re: [PR] KAFKA-15999 Migrate HeartbeatRequestManagerTest away from ConsumerTestBuilder [kafka]

2024-07-08 Thread via GitHub
brenden20 commented on code in PR #16200: URL: https://github.com/apache/kafka/pull/16200#discussion_r1669428550 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -251,23 +304,25 @@ public void testSkippingHeartbeat(fina

Re: [PR] KAFKA-15999 Migrate HeartbeatRequestManagerTest away from ConsumerTestBuilder [kafka]

2024-07-08 Thread via GitHub
brenden20 commented on code in PR #16200: URL: https://github.com/apache/kafka/pull/16200#discussion_r1669428550 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -251,23 +304,25 @@ public void testSkippingHeartbeat(fina

[jira] [Updated] (KAFKA-17100) GlobalStreamThread#start should not busy-wait

2024-07-08 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-17100: Labels: newbie (was: ) > GlobalStreamThread#start should not busy-wait >

[jira] [Created] (KAFKA-17100) GlobalStreamThread#start should not busy-wait

2024-07-08 Thread Greg Harris (Jira)
Greg Harris created KAFKA-17100: --- Summary: GlobalStreamThread#start should not busy-wait Key: KAFKA-17100 URL: https://issues.apache.org/jira/browse/KAFKA-17100 Project: Kafka Issue Type: Task

[jira] [Commented] (KAFKA-17095) Fix the typo: CreateableTopicConfig -> CreatableTopicConfig

2024-07-08 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863953#comment-17863953 ] Greg Harris commented on KAFKA-17095: - > I believe the renaming should not break it.

Re: [PR] KAFKA-17011: Fix a bug preventing features from supporting v0 [kafka]

2024-07-08 Thread via GitHub
junrao commented on code in PR #16421: URL: https://github.com/apache/kafka/pull/16421#discussion_r1669372235 ## clients/src/main/java/org/apache/kafka/common/requests/BrokerRegistrationRequest.java: ## @@ -45,7 +46,21 @@ public short oldestAllowedVersion() { @Overrid

[jira] [Updated] (KAFKA-17099) Improve the process exception logs with the exact processor node name in which processing exceptions occur

2024-07-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Loïc Greffier updated KAFKA-17099: -- Component/s: streams > Improve the process exception logs with the exact processor node name i

[jira] [Updated] (KAFKA-17099) Improve the process exception logs with the exact processor node name in which exceptions occur

2024-07-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Loïc Greffier updated KAFKA-17099: -- Summary: Improve the process exception logs with the exact processor node name in which except

[jira] [Updated] (KAFKA-17099) Improve the process exception logs with the exact processor node name in which processing exceptions occur

2024-07-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Loïc Greffier updated KAFKA-17099: -- Summary: Improve the process exception logs with the exact processor node name in which proces

Re: [PR] KAFKA-16684: Remove cache in responseData [kafka]

2024-07-08 Thread via GitHub
apoorvmittal10 commented on code in PR #16532: URL: https://github.com/apache/kafka/pull/16532#discussion_r1669355387 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java: ## @@ -3665,6 +3670,18 @@ public void testWhenFetchResponseReturnsALeader

[jira] [Updated] (KAFKA-17099) Improve the process exception logs with the exact processor node name in which exception occur

2024-07-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Loïc Greffier updated KAFKA-17099: -- Description: h2. Current Behaviour When an exception occurs in a processor node, the task exe

[jira] [Updated] (KAFKA-17099) Improve the process exception logs with the exact processor node name in which exception occur

2024-07-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Loïc Greffier updated KAFKA-17099: -- Summary: Improve the process exception logs with the exact processor node name in which except

Re: [PR] KAFKA-16345: Optionally URL-encode clientID and clientSecret in authorization header [kafka]

2024-07-08 Thread via GitHub
bachmanity1 commented on code in PR #15475: URL: https://github.com/apache/kafka/pull/15475#discussion_r1669346859 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/HttpAccessTokenRetrieverTest.java: ## @@ -174,33 +176,39 @@ public void test

[jira] [Updated] (KAFKA-17099) Improve the process exception logs with the exact processor node where the exception occurs

2024-07-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Loïc Greffier updated KAFKA-17099: -- Description: h2. Current Behaviour   When an exception occurs in a processor node, the task e

[jira] [Updated] (KAFKA-17099) Improve the process exception logs with the exact processor node where the exception occurs

2024-07-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Loïc Greffier updated KAFKA-17099: -- Description: h2. Current Behaviour When an exception occurs in a processor node, the task exe

[jira] [Updated] (KAFKA-17099) Improve the process exception logs with the exact processor node where the exception occurs

2024-07-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Loïc Greffier updated KAFKA-17099: -- Description: h3. Current Behaviour   When an exception occurs in a processor node, the task e

[jira] [Created] (KAFKA-17099) Improve the process exception logs with the exact processor node where the exception occurs

2024-07-08 Thread Jira
Loïc Greffier created KAFKA-17099: - Summary: Improve the process exception logs with the exact processor node where the exception occurs Key: KAFKA-17099 URL: https://issues.apache.org/jira/browse/KAFKA-17099

Re: [PR] KAFKA-16345: Optionally URL-encode clientID and clientSecret in authorization header [kafka]

2024-07-08 Thread via GitHub
bachmanity1 commented on code in PR #15475: URL: https://github.com/apache/kafka/pull/15475#discussion_r1669337234 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/HttpAccessTokenRetrieverTest.java: ## @@ -174,33 +176,39 @@ public void test

Re: [PR] KAFKA-16772: Introduce kraft.version to support KIP-853 [kafka]

2024-07-08 Thread via GitHub
cmccabe commented on code in PR #16230: URL: https://github.com/apache/kafka/pull/16230#discussion_r1669277905 ## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapMetadata.java: ## @@ -73,6 +80,22 @@ public static Optional recordToMetadataVersion(ApiMessage r

Re: [PR] KAFKA-16772: Introduce kraft.version to support KIP-853 [kafka]

2024-07-08 Thread via GitHub
cmccabe commented on PR #16230: URL: https://github.com/apache/kafka/pull/16230#issuecomment-2215235517 I have revised this PR. We now get the value of `kraft.version` directly from the raft layer, and metadata layer does not have anything to do with it. This requires passing in a callback

Re: [PR] KAFKA-16772: Introduce kraft.version to support KIP-853 [kafka]

2024-07-08 Thread via GitHub
cmccabe commented on code in PR #16230: URL: https://github.com/apache/kafka/pull/16230#discussion_r1669277755 ## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapMetadata.java: ## @@ -116,6 +139,34 @@ public BootstrapMetadata copyWithOnlyVersion() {

Re: [PR] KAFKA-17011: Fix a bug preventing features from supporting v0 [kafka]

2024-07-08 Thread via GitHub
jolshan commented on code in PR #16421: URL: https://github.com/apache/kafka/pull/16421#discussion_r1669262604 ## clients/src/main/java/org/apache/kafka/common/requests/BrokerRegistrationRequest.java: ## @@ -45,7 +46,21 @@ public short oldestAllowedVersion() { @Overri

Re: [PR] DO NOT MERGE: Repeat OffsetsApiIntegrationTest cases 5 times each [kafka]

2024-07-08 Thread via GitHub
C0urante commented on PR #16551: URL: https://github.com/apache/kafka/pull/16551#issuecomment-2215205173 The full CI run has not completed yet, but based on logs, all tests have passed. It may be worth triggering another run once this one completes. -- This is an automated message from th

[jira] [Updated] (KAFKA-17098) Error Opening RocksDBStore

2024-07-08 Thread Eduwer Camacaro (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eduwer Camacaro updated KAFKA-17098: Priority: Minor (was: Critical) > Error Opening RocksDBStore > --

Re: [PR] KAFKA-17011: Fix a bug preventing features from supporting v0 [kafka]

2024-07-08 Thread via GitHub
chia7712 commented on code in PR #16421: URL: https://github.com/apache/kafka/pull/16421#discussion_r1669192153 ## clients/src/main/java/org/apache/kafka/common/requests/BrokerRegistrationRequest.java: ## @@ -45,7 +46,21 @@ public short oldestAllowedVersion() { @Overr

Re: [PR] KAFKA-16772: Introduce kraft.version to support KIP-853 [kafka]

2024-07-08 Thread via GitHub
cmccabe commented on code in PR #16230: URL: https://github.com/apache/kafka/pull/16230#discussion_r1669239654 ## server-common/src/main/java/org/apache/kafka/server/common/KRaftVersion.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-16772: Introduce kraft.version to support KIP-853 [kafka]

2024-07-08 Thread via GitHub
cmccabe commented on code in PR #16230: URL: https://github.com/apache/kafka/pull/16230#discussion_r1669237196 ## server-common/src/main/java/org/apache/kafka/server/common/Features.java: ## @@ -40,7 +40,8 @@ public enum Features { * See {@link TestFeatureVersion} as an ex

Re: [PR] KAFKA-16772: Introduce kraft.version to support KIP-853 [kafka]

2024-07-08 Thread via GitHub
cmccabe commented on code in PR #16230: URL: https://github.com/apache/kafka/pull/16230#discussion_r1669234970 ## raft/src/main/java/org/apache/kafka/snapshot/RecordsSnapshotWriter.java: ## @@ -146,7 +147,7 @@ final public static class Builder { private Time time = Time

[jira] [Created] (KAFKA-17098) Error Opening RocksDBStore

2024-07-08 Thread Eduwer Camacaro (Jira)
Eduwer Camacaro created KAFKA-17098: --- Summary: Error Opening RocksDBStore Key: KAFKA-17098 URL: https://issues.apache.org/jira/browse/KAFKA-17098 Project: Kafka Issue Type: Bug Co

[jira] [Updated] (KAFKA-16984) New consumer should not complete leave operation until it gets a response

2024-07-08 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16984: --- Description: When the new consumer attempts to leave a group, it sends a leave group request

Re: [PR] KAFKA-14094: Support for first leader bootstrapping the voter set [kafka]

2024-07-08 Thread via GitHub
ahuang98 commented on code in PR #16518: URL: https://github.com/apache/kafka/pull/16518#discussion_r1669188656 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -0,0 +1,271 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

Re: [PR] KAFKA-14094: Support for first leader bootstrapping the voter set [kafka]

2024-07-08 Thread via GitHub
ahuang98 commented on code in PR #16518: URL: https://github.com/apache/kafka/pull/16518#discussion_r1669188332 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -0,0 +1,271 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

Re: [PR] KAFKA-14094: Support for first leader bootstrapping the voter set [kafka]

2024-07-08 Thread via GitHub
ahuang98 commented on code in PR #16518: URL: https://github.com/apache/kafka/pull/16518#discussion_r1669183797 ## raft/src/main/java/org/apache/kafka/raft/internals/VoterSetOffset.java: ## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

Re: [PR] KAFKA-14094: Support for first leader bootstrapping the voter set [kafka]

2024-07-08 Thread via GitHub
ahuang98 commented on code in PR #16518: URL: https://github.com/apache/kafka/pull/16518#discussion_r1669183797 ## raft/src/main/java/org/apache/kafka/raft/internals/VoterSetOffset.java: ## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

Re: [PR] KAFKA-16684: Remove cache in responseData [kafka]

2024-07-08 Thread via GitHub
chia7712 commented on PR #16532: URL: https://github.com/apache/kafka/pull/16532#issuecomment-2215008466 @apoorvmittal10 you had reviewed on #15966, so could you please take a look at this PR? thanks! -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-14401: Fail kafka log read end requests if underneath work thread is dead [kafka]

2024-07-08 Thread via GitHub
C0urante commented on code in PR #14372: URL: https://github.com/apache/kafka/pull/14372#discussion_r1669161112 ## connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java: ## @@ -567,13 +567,12 @@ private class WorkThread extends Thread { public W

[jira] [Updated] (KAFKA-16984) New consumer should not complete leave operation until it gets a response

2024-07-08 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16984: --- Description: When the new consumer attempts to leave a group, it sends a leave group request

[jira] [Updated] (KAFKA-16984) New consumer should not complete leave operation until it gets a response

2024-07-08 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16984: --- Description: When the new consumer attempts to leave a group, it sends a leave group request

Re: [PR] KAFKA-17091: Add @FunctionalInterface to Streams interfaces [kafka]

2024-07-08 Thread via GitHub
mjsax commented on PR #16544: URL: https://github.com/apache/kafka/pull/16544#issuecomment-2214996644 It seems `ForeachAction` is missing? Also wondering about `TransformerSupplier` (and siblings) -- are they not effectively deprecated via https://cwiki.apache.org/confluence/display/

[jira] [Commented] (KAFKA-17095) Fix the typo: CreateableTopicConfig -> CreatableTopicConfig

2024-07-08 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863910#comment-17863910 ] Chia-Ping Tsai commented on KAFKA-17095: [~gharris1727] thanks for response. {q

Re: [PR] KAFKA-10199: Close pending active tasks to init on partitions lost [kafka]

2024-07-08 Thread via GitHub
cadonna merged PR #16550: URL: https://github.com/apache/kafka/pull/16550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Updated] (KAFKA-16984) New consumer should not complete leave operation until it gets a response

2024-07-08 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16984: --- Summary: New consumer should not complete leave operation until it gets a response (was: Ne

Re: [PR] KAFKA-15999 Migrate HeartbeatRequestManagerTest away from ConsumerTestBuilder [kafka]

2024-07-08 Thread via GitHub
brenden20 commented on code in PR #16200: URL: https://github.com/apache/kafka/pull/16200#discussion_r1669143238 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -106,72 +102,90 @@ public class HeartbeatRequestManagerTe

Re: [PR] KAFKA-15999 Migrate HeartbeatRequestManagerTest away from ConsumerTestBuilder [kafka]

2024-07-08 Thread via GitHub
brenden20 commented on code in PR #16200: URL: https://github.com/apache/kafka/pull/16200#discussion_r1669139534 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -106,72 +102,90 @@ public class HeartbeatRequestManagerTe

Re: [PR] KAFKA-14094: Support for first leader bootstrapping the voter set [kafka]

2024-07-08 Thread via GitHub
ahuang98 commented on code in PR #16518: URL: https://github.com/apache/kafka/pull/16518#discussion_r1669133266 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -0,0 +1,271 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

Re: [PR] KAFKA-15999 Migrate HeartbeatRequestManagerTest away from ConsumerTestBuilder [kafka]

2024-07-08 Thread via GitHub
brenden20 commented on code in PR #16200: URL: https://github.com/apache/kafka/pull/16200#discussion_r1669122743 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -106,72 +102,90 @@ public class HeartbeatRequestManagerTe

Re: [PR] MINOR: Fix retry logic in DedicatedMirrorIntegrationTest::awaitTaskConfigurations [kafka]

2024-07-08 Thread via GitHub
C0urante merged PR #16525: URL: https://github.com/apache/kafka/pull/16525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-14094: Support for first leader bootstrapping the voter set [kafka]

2024-07-08 Thread via GitHub
ahuang98 commented on code in PR #16518: URL: https://github.com/apache/kafka/pull/16518#discussion_r1669120830 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -0,0 +1,271 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

Re: [PR] MINOR: Fix retry logic in DedicatedMirrorIntegrationTest::awaitTaskConfigurations [kafka]

2024-07-08 Thread via GitHub
C0urante commented on PR #16525: URL: https://github.com/apache/kafka/pull/16525#issuecomment-2214937353 The latest change is trivial and I'm able to build and run all unit tests for the `:connect:mirror` module, and run the `DedicatedMirrorIntegrationTest` suite locally. Merging... -- T

Re: [PR] MINOR: Fix retry logic in DedicatedMirrorIntegrationTest::awaitTaskConfigurations [kafka]

2024-07-08 Thread via GitHub
C0urante commented on code in PR #16525: URL: https://github.com/apache/kafka/pull/16525#discussion_r1669116891 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/DedicatedMirrorIntegrationTest.java: ## @@ -354,8 +355,10 @@ private void awaitTaskConfig

Re: [PR] KAFKA-15999 Migrate HeartbeatRequestManagerTest away from ConsumerTestBuilder [kafka]

2024-07-08 Thread via GitHub
brenden20 commented on code in PR #16200: URL: https://github.com/apache/kafka/pull/16200#discussion_r1669112935 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -106,72 +102,90 @@ public class HeartbeatRequestManagerTe

Re: [PR] KAFKA-16254: Allow MM2 to fully disable offset sync feature [kafka]

2024-07-08 Thread via GitHub
OmniaGM commented on code in PR #15999: URL: https://github.com/apache/kafka/pull/15999#discussion_r1669096983 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConfig.java: ## @@ -166,6 +167,30 @@ Duration consumerPollTimeout() { return Du

Re: [PR] KAFKA-16254: Allow MM2 to fully disable offset sync feature [kafka]

2024-07-08 Thread via GitHub
OmniaGM commented on code in PR #15999: URL: https://github.com/apache/kafka/pull/15999#discussion_r1669096566 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConfig.java: ## @@ -166,6 +167,30 @@ Duration consumerPollTimeout() { return Du

Re: [PR] KAFKA-14094: Support for first leader bootstrapping the voter set [kafka]

2024-07-08 Thread via GitHub
jsancio commented on code in PR #16518: URL: https://github.com/apache/kafka/pull/16518#discussion_r1669073620 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -0,0 +1,271 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Updated] (KAFKA-17097) Add replace.null.with.default configuration to ValueToKey and ReplaceField (KIP-1040)

2024-07-08 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-17097: Description: {color:#172b4d}See [https://cwiki.apache.org/confluence/pages/viewpage.action?pageId

[jira] [Updated] (KAFKA-17097) Add replace.null.with.default configuration to ValueToKey and ReplaceField (KIP-1040)

2024-07-08 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-17097: Labels: newbie (was: ) > Add replace.null.with.default configuration to ValueToKey and ReplaceFie

[jira] [Created] (KAFKA-17097) Add replace.null.with.default configuration to ValueToKey and ReplaceField (KIP-1040)

2024-07-08 Thread Greg Harris (Jira)
Greg Harris created KAFKA-17097: --- Summary: Add replace.null.with.default configuration to ValueToKey and ReplaceField (KIP-1040) Key: KAFKA-17097 URL: https://issues.apache.org/jira/browse/KAFKA-17097 P

[jira] [Resolved] (KAFKA-15838) [Connect] ExtractField and InsertField NULL Values are replaced by default value even in NULLABLE fields

2024-07-08 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris resolved KAFKA-15838. - Fix Version/s: 3.9.0 Resolution: Fixed The InsertField, ExtractField, HeaderFrom, Cast, S

[jira] [Commented] (KAFKA-17095) Fix the typo: CreateableTopicConfig -> CreatableTopicConfig

2024-07-08 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863890#comment-17863890 ] Greg Harris commented on KAFKA-17095: - Is this a backwards compatible change? If som

Re: [PR] KAFKA-15838: KIP-1040: Add replace.null.with.default to InsertField, ExtractField, HeaderFrom, Cast, SetSchemaMetadata, TimestampConverter, MaskField transforms [kafka]

2024-07-08 Thread via GitHub
gharris1727 commented on PR #15756: URL: https://github.com/apache/kafka/pull/15756#issuecomment-2214862389 Thank you @mfvitale for driving the KIP and implementation! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] KAFKA-15838: KIP-1040: Add replace.null.with.default to InsertField, ExtractField, HeaderFrom, Cast, SetSchemaMetadata, TimestampConverter, MaskField transforms [kafka]

2024-07-08 Thread via GitHub
gharris1727 merged PR #15756: URL: https://github.com/apache/kafka/pull/15756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

Re: [PR] KAFKA-15838: KIP-1040: Add replace.null.with.default to InsertField, ExtractField, HeaderFrom, Cast, SetSchemaMetadata, TimestampConverter, MaskField transforms [kafka]

2024-07-08 Thread via GitHub
gharris1727 commented on PR #15756: URL: https://github.com/apache/kafka/pull/15756#issuecomment-2214855870 Test failures appear unrelated, and connect:transforms:test passes for me locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] MINOR: Fix retry logic in DedicatedMirrorIntegrationTest::awaitTaskConfigurations [kafka]

2024-07-08 Thread via GitHub
gharris1727 commented on code in PR #16525: URL: https://github.com/apache/kafka/pull/16525#discussion_r1669065888 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/DedicatedMirrorIntegrationTest.java: ## @@ -354,8 +355,10 @@ private void awaitTaskCon

Re: [PR] KAFKA-15999 Migrate HeartbeatRequestManagerTest away from ConsumerTestBuilder [kafka]

2024-07-08 Thread via GitHub
lianetm commented on PR #16200: URL: https://github.com/apache/kafka/pull/16200#issuecomment-2214850627 Hey @brenden20 , thanks for the updates! I completed another pass, left some comments. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, pl

  1   2   3   >