dajac commented on PR #15286:
URL: https://github.com/apache/kafka/pull/15286#issuecomment-1916253886
Thanks @rreddy-22! Could you please describe the bug(s) in the description?
Do we need to add new tests for them?
--
This is an automated message from the Apache Git Service.
To respond t
showuon commented on code in PR #15273:
URL: https://github.com/apache/kafka/pull/15273#discussion_r1470688447
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##
@@ -290,7 +320,15 @@ public Optional serverConfigName(String
configName) {
showuon commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1470669307
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2759,11 +2761,20 @@ class ReplicaManager(val config: KafkaConfig,
cmccabe commented on PR #15230:
URL: https://github.com/apache/kafka/pull/15230#issuecomment-1916170746
committed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
cmccabe closed pull request #15230: KAFKA-14616: Fix stray replica of recreated
topics in KRaft mode
URL: https://github.com/apache/kafka/pull/15230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
cmccabe commented on PR #15230:
URL: https://github.com/apache/kafka/pull/15230#issuecomment-1916148593
> Question: why can't we delete these disappeared(deleted) logs directly? I
think this can only happen when topic deleting while the node is offline. If
so, then deleting them should be f
cmccabe commented on code in PR #15230:
URL: https://github.com/apache/kafka/pull/15230#discussion_r1470637685
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -563,6 +565,18 @@ class LogManager(logDirs: Seq[File],
startupWithConfigOverrides(defaultConfig,
fetchTop
[
https://issues.apache.org/jira/browse/KAFKA-16209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812157#comment-17812157
]
Luke Chen commented on KAFKA-16209:
---
Thanks [~goyarpit]!
> fetchSnapshot might return
[
https://issues.apache.org/jira/browse/KAFKA-15776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812155#comment-17812155
]
Kamal Chandraprakash commented on KAFKA-15776:
--
I've opened a KIP to add ne
[
https://issues.apache.org/jira/browse/KAFKA-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812144#comment-17812144
]
Jorge Esteban Quilcate Otoya commented on KAFKA-4759:
-
Thanks [~thesz
showuon commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1470557475
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -874,7 +874,13 @@ class Partition(val topicPartition: TopicPartition,
private def createLogInAssignedDire
[
https://issues.apache.org/jira/browse/KAFKA-16209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812139#comment-17812139
]
Arpit Goyal commented on KAFKA-16209:
-
[~showuon] I am picking it up.
> fetchSnaps
[
https://issues.apache.org/jira/browse/KAFKA-16209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arpit Goyal reassigned KAFKA-16209:
---
Assignee: Arpit Goyal
> fetchSnapshot might return null if topic is created before v2.8
> -
rreddy-22 commented on code in PR #15152:
URL: https://github.com/apache/kafka/pull/15152#discussion_r1470555356
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -452,21 +453,38 @@ public Group group(String groupId, long comm
JimmyWang6 commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1916021518
> h level comments to start with. Are you on the Apache slack? We could also
discuss there offline if you want.
@dajac
Thanks for your reply！
I will remove this part of co
JimmyWang6 commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1916020627
> As a first step, it would be great if we could keep this pull request
focused on the RPC and its implementation on the server side. I would extract
the command line tool part into it
Joker-5 commented on PR #14963:
URL: https://github.com/apache/kafka/pull/14963#issuecomment-1916017056
Hey, @lucasbru, I saw [this pr](https://github.com/apache/kafka/pull/15000)
had been merged, but it seems there's no `Co-authord-by` tag in the final
commit. So there may something wrong
dengziming merged PR #14846:
URL: https://github.com/apache/kafka/pull/14846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apac
github-actions[bot] commented on PR #14309:
URL: https://github.com/apache/kafka/pull/14309#issuecomment-1916012508
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
showuon commented on PR #14615:
URL: https://github.com/apache/kafka/pull/14615#issuecomment-1916003844
[KAFKA-16209](https://issues.apache.org/jira/browse/KAFKA-16209) is created
for this issue. Closing this stale PR.
--
This is an automated message from the Apache Git Service.
To respon
showuon closed pull request #14615: MINOR: Fix NPE during fetchSnapshot
URL: https://github.com/apache/kafka/pull/14615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
Luke Chen created KAFKA-16209:
-
Summary: fetchSnapshot might return null if topic is created
before v2.8
Key: KAFKA-16209
URL: https://issues.apache.org/jira/browse/KAFKA-16209
Project: Kafka
Is
[
https://issues.apache.org/jira/browse/KAFKA-16209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-16209:
--
Labels: newbie newbie++ (was: )
> fetchSnapshot might return null if topic is created before v2.8
> -
rreddy-22 opened a new pull request, #15286:
URL: https://github.com/apache/kafka/pull/15286
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testi
[
https://issues.apache.org/jira/browse/KAFKA-15776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812112#comment-17812112
]
Jorge Esteban Quilcate Otoya commented on KAFKA-15776:
--
Totally agr
[
https://issues.apache.org/jira/browse/KAFKA-15839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15839:
--
Labels: kip-848 kip-848-client-support (was: kip-848
kip-848-client-support kip-848-e2e kip-848-previ
kirktrue commented on PR #15186:
URL: https://github.com/apache/kafka/pull/15186#issuecomment-1915837088
Thanks @dajac!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
[
https://issues.apache.org/jira/browse/KAFKA-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16010:
--
Labels: consumer-threading-refactor consumer-timeout kip-848-client-support
(was: consumer-threading-
[
https://issues.apache.org/jira/browse/KAFKA-16204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-16204:
--
Labels: newbie newbie++ (was: )
> Stray file core/0001.snapshot created when running
[
https://issues.apache.org/jira/browse/KAFKA-16009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16009:
--
Labels: consumer-threading-refactor consumer-timeout kip-848-client-support
(was: consumer-threading-
[
https://issues.apache.org/jira/browse/KAFKA-16008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16008:
--
Labels: consumer-threading-refactor consumer-timeout (was:
consumer-threading-refactor kip-848)
> Fi
[
https://issues.apache.org/jira/browse/KAFKA-15475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15475:
--
Summary: Request might retry forever even if the user API timeout expires
(was: Timeout request might
[
https://issues.apache.org/jira/browse/KAFKA-15475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15475:
--
Labels: consumer-threading-refactor consumer-timeout (was:
consumer-threading-refactor kip-848-previe
[
https://issues.apache.org/jira/browse/KAFKA-15974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15974:
--
Labels: consumer-threading-refactor consumer-timeout kip-848-client-support
(was: consumer-threading-
[
https://issues.apache.org/jira/browse/KAFKA-15848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15848:
--
Labels: consumer-threading-refactor consumer-timeout kip-848-client-support
(was: consumer-threading-
[
https://issues.apache.org/jira/browse/KAFKA-15974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15974:
--
Summary: Enforce that events and requests respect user-provided timeout
(was: Enforce that events and
Kirk True created KAFKA-16208:
-
Summary: Design new Consumer timeout policy
Key: KAFKA-16208
URL: https://issues.apache.org/jira/browse/KAFKA-16208
Project: Kafka
Issue Type: Task
Compo
[
https://issues.apache.org/jira/browse/KAFKA-16199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16199:
--
Labels: consumer-threading-refactor consumer-timeout (was:
consumer-threading-refactor)
> Prune the
[
https://issues.apache.org/jira/browse/KAFKA-16199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16199:
--
Summary: Prune the event queue if event timeout expired before starting
(was: Prune the event queue i
[
https://issues.apache.org/jira/browse/KAFKA-16200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16200:
--
Labels: consumer-threading-refactor consumer-timeout (was:
consumer-threading-refactor)
> Ensure Req
[
https://issues.apache.org/jira/browse/KAFKA-16100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16100:
--
Labels: consumer-threading-refactor consumer-timeout (was:
consumer-threading-refactor)
> Add timeou
cmccabe commented on code in PR #15270:
URL: https://github.com/apache/kafka/pull/15270#discussion_r1470390923
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala:
##
@@ -166,6 +169,11 @@ class BrokerMetadataPublisher(
Option(delta.featuresDelta()).
cmccabe commented on PR #15270:
URL: https://github.com/apache/kafka/pull/15270#issuecomment-1915796839
Thanks @gaurav-narula . The overall approach looks good to me.
There is a consistent test failure here:
```
Gradle Test Run :core:test > Gradle Test Executor 2 >
BrokerMetada
cmccabe commented on code in PR #15270:
URL: https://github.com/apache/kafka/pull/15270#discussion_r1470390923
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala:
##
@@ -166,6 +169,11 @@ class BrokerMetadataPublisher(
Option(delta.featuresDelta()).
cmccabe commented on code in PR #15270:
URL: https://github.com/apache/kafka/pull/15270#discussion_r1470390289
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala:
##
@@ -137,6 +139,7 @@ class BrokerMetadataPublisher(
manifest: LoaderManifest
): Un
cmccabe commented on code in PR #15270:
URL: https://github.com/apache/kafka/pull/15270#discussion_r1470390289
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala:
##
@@ -137,6 +139,7 @@ class BrokerMetadataPublisher(
manifest: LoaderManifest
): Un
Phuc-Hong-Tran commented on code in PR #14327:
URL: https://github.com/apache/kafka/pull/14327#discussion_r1470370840
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1573,6 +1589,33 @@ private void updateGroupsByTopics(
[
https://issues.apache.org/jira/browse/KAFKA-14094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio updated KAFKA-14094:
---
Summary: KIP-853: KRaft controller membership changes (was: KIP-853:
José Armando García Sancio created KAFKA-16207:
--
Summary: Implement KRaft internal listener for KRaftVersionRecord
and VotersRecord
Key: KAFKA-16207
URL: https://issues.apache.org/jira/browse/KAFKA-16
apoorvmittal10 commented on PR #15251:
URL: https://github.com/apache/kafka/pull/15251#issuecomment-1915703872
> @apoorvmittal10 : Thanks for the updated PR. A few more comments.
Thanks for the review and suggestions. I have addressed the comments.
--
This is an automated message fr
jolshan commented on code in PR #15237:
URL: https://github.com/apache/kafka/pull/15237#discussion_r1470235881
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java:
##
@@ -2056,4 +2059,70 @@ public void
testCompleteTransactionWi
cmccabe commented on PR #15193:
URL: https://github.com/apache/kafka/pull/15193#issuecomment-1915696324
Thanks to everyone who reviewed this. It really was pretty messy (and buggy)
originally, and I think it's pretty clear now. I have to commit this now to
unblock the 3.7 release. If you ha
cmccabe merged PR #15193:
URL: https://github.com/apache/kafka/pull/15193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
apoorvmittal10 commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1470310097
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -493,4 +519,123 @@ public void run() {
}
}
}
+
+/
cmccabe commented on PR #15193:
URL: https://github.com/apache/kafka/pull/15193#issuecomment-1915685264
@ppatierno: yes, deprovisioning the kraft controller quorum and electing a
zk-based controller should happen before rolling to remove
`zookeeper.metadata.migration.enable`, etc. Should be
apoorvmittal10 commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1470279663
##
server/src/test/java/org/apache/kafka/server/ClientMetricsManagerTest.java:
##
@@ -299,8 +332,8 @@ public void
testGetTelemetrySameClientImmediateRetryAfterP
apoorvmittal10 commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1470278382
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -288,6 +307,9 @@ private ClientMetricsInstance
createClientInstanceAndUpdateCac
cmccabe commented on PR #15238:
URL: https://github.com/apache/kafka/pull/15238#issuecomment-1915649469
committed, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
cmccabe closed pull request #15238: KAFKA-16171 Fix hybrid mode controller race
URL: https://github.com/apache/kafka/pull/15238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
apoorvmittal10 commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1470269365
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -493,4 +519,123 @@ public void run() {
}
}
}
+
+/
mumrah commented on code in PR #15238:
URL: https://github.com/apache/kafka/pull/15238#discussion_r1470254717
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -635,12 +635,24 @@ class BecomeZkControllerEvent extends MigrationEvent {
mumrah commented on code in PR #15238:
URL: https://github.com/apache/kafka/pull/15238#discussion_r1470254717
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -635,12 +635,24 @@ class BecomeZkControllerEvent extends MigrationEvent {
cmccabe commented on code in PR #15238:
URL: https://github.com/apache/kafka/pull/15238#discussion_r1470231664
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -635,12 +635,24 @@ class BecomeZkControllerEvent extends MigrationEvent {
cmccabe commented on code in PR #15238:
URL: https://github.com/apache/kafka/pull/15238#discussion_r1470231305
##
metadata/src/test/java/org/apache/kafka/metadata/migration/CapturingMigrationClient.java:
##
@@ -139,14 +139,18 @@ public ZkMigrationLeadershipState
setMigrationRec
mumrah commented on code in PR #15193:
URL: https://github.com/apache/kafka/pull/15193#discussion_r1470215533
##
docs/ops.html:
##
@@ -3992,6 +3980,136 @@ Finalizing the migration
# Other configs ...
+ Reverting to ZooKeeper mode During the Migration
+
+While the clu
dajac commented on PR #15271:
URL: https://github.com/apache/kafka/pull/15271#issuecomment-1915528645
Sure. Will review it tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
dongnuo123 commented on code in PR #15268:
URL: https://github.com/apache/kafka/pull/15268#discussion_r1470177662
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -3467,6 +3476,358 @@ public void maybeDeleteGroup(String group
lucasbru merged PR #15000:
URL: https://github.com/apache/kafka/pull/15000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
lucasbru commented on PR #15000:
URL: https://github.com/apache/kafka/pull/15000#issuecomment-1915503178
Test failures are unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
lucasbru commented on PR #15271:
URL: https://github.com/apache/kafka/pull/15271#issuecomment-1915499373
@dajac Could you please take a look when you have time? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
C0urante commented on PR #14316:
URL: https://github.com/apache/kafka/pull/14316#issuecomment-1915480693
Hmm... looks like this is causing a spike in CI failures. Even though all of
the tests are known to be flaky, I'm going to try to look into the tests more
closely before merging.
--
T
C0urante commented on PR #15249:
URL: https://github.com/apache/kafka/pull/15249#issuecomment-1915476191
[The next CI
run](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-15249/7/tests/)
also completed with no failures in the `ConnectorRestartApiIntegratio
jolshan commented on code in PR #15176:
URL: https://github.com/apache/kafka/pull/15176#discussion_r1470117099
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -813,19 +816,19 @@ class ReplicaManager(val config: KafkaConfig,
val transactionalProducerInfo =
mike-lloyd03 opened a new pull request, #15284:
URL: https://github.com/apache/kafka/pull/15284
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of te
dajac commented on code in PR #15176:
URL: https://github.com/apache/kafka/pull/15176#discussion_r1470109481
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -813,19 +816,19 @@ class ReplicaManager(val config: KafkaConfig,
val transactionalProducerInfo = mu
jolshan commented on code in PR #15196:
URL: https://github.com/apache/kafka/pull/15196#discussion_r1470110954
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -1062,10 +1062,10 @@ private static boolean isGroupIdNotEmpty(
dajac commented on code in PR #15176:
URL: https://github.com/apache/kafka/pull/15176#discussion_r1470109774
##
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorConcurrencyTest.scala:
##
@@ -85,6 +85,10 @@ class GroupCoordinatorConcurrencyTest extends
AbstractCo
jolshan commented on code in PR #15196:
URL: https://github.com/apache/kafka/pull/15196#discussion_r1470109704
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -1099,29 +1055,48 @@ private static boolean isGroupIdNotEmpty(
dajac commented on code in PR #15176:
URL: https://github.com/apache/kafka/pull/15176#discussion_r1470109481
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -813,19 +816,19 @@ class ReplicaManager(val config: KafkaConfig,
val transactionalProducerInfo = mu
dajac commented on code in PR #15196:
URL: https://github.com/apache/kafka/pull/15196#discussion_r1470107871
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -1099,29 +1055,48 @@ private static boolean isGroupIdNotEmpty(St
jolshan commented on code in PR #15176:
URL: https://github.com/apache/kafka/pull/15176#discussion_r1470098563
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -982,24 +996,21 @@ class ReplicaManager(val config: KafkaConfig,
producerId: Long,
producerEpo
jolshan commented on code in PR #15176:
URL: https://github.com/apache/kafka/pull/15176#discussion_r1470096146
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##
@@ -935,8 +935,12 @@ private[group] class GroupCoordinator(
producerId,
lianetm commented on code in PR #15271:
URL: https://github.com/apache/kafka/pull/15271#discussion_r1470081608
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -997,11 +985,13 @@ void markReconciliationCompleted() {
*
jolshan commented on code in PR #15196:
URL: https://github.com/apache/kafka/pull/15196#discussion_r1470078455
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -1099,29 +1055,48 @@ private static boolean isGroupIdNotEmpty(
dajac commented on code in PR #15196:
URL: https://github.com/apache/kafka/pull/15196#discussion_r1470072535
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -523,7 +524,7 @@ public CompletableFuture listGroups(
philipnee commented on PR #15216:
URL: https://github.com/apache/kafka/pull/15216#issuecomment-1915374713
Hi @lucasbru - This PR is ready for review. I did a bit of refactor in this
PR so not everything here is in the scope. Let me know what do you think!
--
This is an automated message
jolshan commented on code in PR #15196:
URL: https://github.com/apache/kafka/pull/15196#discussion_r1470066073
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -523,7 +524,7 @@ public CompletableFuture listGroups(
jolshan commented on code in PR #15196:
URL: https://github.com/apache/kafka/pull/15196#discussion_r1470066073
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -523,7 +524,7 @@ public CompletableFuture listGroups(
junrao commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1470043472
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -288,6 +307,9 @@ private ClientMetricsInstance
createClientInstanceAndUpdateCache(Uuid
philipnee commented on code in PR #15216:
URL: https://github.com/apache/kafka/pull/15216#discussion_r1470063334
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -671,18 +718,8 @@ private ConsumerConfig config() {
philipnee commented on code in PR #15216:
URL: https://github.com/apache/kafka/pull/15216#discussion_r1470058217
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/metrics/KafkaConsumerMetrics.java:
##
@@ -26,20 +26,20 @@
import java.util.concurrent.TimeUnit
OmniaGM commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1470001208
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -183,7 +183,7 @@ object HostedPartition {
/**
* This broker hosts the partition, but it is in an
AndrewJSchofield commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r146343
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -493,4 +519,123 @@ public void run() {
}
}
}
+
+
OmniaGM commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1469993396
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -183,7 +183,7 @@ object HostedPartition {
/**
* This broker hosts the partition, but it is in an
[
https://issues.apache.org/jira/browse/KAFKA-16206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-16206:
-
Summary: KRaftMigrationZkWriter tries to delete deleted topic configs twice
(was: ZkConfigMigra
[
https://issues.apache.org/jira/browse/KAFKA-16171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-16171:
-
Component/s: controller
> Controller failover during ZK migration can prevent metadata updates t
[
https://issues.apache.org/jira/browse/KAFKA-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-16205:
-
Component/s: controller
> Reduce number of metadata requests during hybrid mode
> --
[
https://issues.apache.org/jira/browse/KAFKA-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-16205:
-
Component/s: (was: controller)
> Reduce number of metadata requests during hybrid mode
> ---
[
https://issues.apache.org/jira/browse/KAFKA-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-16205:
-
Component/s: migration
> Reduce number of metadata requests during hybrid mode
> ---
[
https://issues.apache.org/jira/browse/KAFKA-16171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-16171:
-
Component/s: migration
(was: controller)
> Controller failover during ZK mi
1 - 100 of 181 matches
Mail list logo
