cmccabe commented on PR #15270:
URL: https://github.com/apache/kafka/pull/15270#issuecomment-1915796839
Thanks @gaurav-narula . The overall approach looks good to me.
There is a consistent test failure here:
```
Gradle Test Run :core:test > Gradle Test Executor 2 >
BrokerMetadataPublisherTest > testFindStrayReplicas() FAILED
org.mockito.exceptions.misusing.UnfinishedVerificationException:
Missing method call for verify(mock) here:
-> at
kafka.server.metadata.BrokerMetadataPublisherTest.testMetadataVersionUpdateToIBP_3_7_IV2OrAboveTriggersBrokerReRegistration(BrokerMetadataPublisherTest.scala:402)
Example of correct verification:
verify(mock).doSomething()
Also, this error might show up because you verify either of:
final/private/equals()/hashCode() methods.
Those methods *cannot* be stubbed/verified.
Mocking methods declared on non-public parent classes is not supported.
at
app//kafka.server.metadata.BrokerMetadataPublisherTest.mockLog(BrokerMetadataPublisherTest.scala:153)
at
app//kafka.server.metadata.BrokerMetadataPublisherTest.testFindStrayReplicas(BrokerMetadataPublisherTest.scala:100)```
I expect the test needs to be updated to fix the mock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
