[
https://issues.apache.org/jira/browse/KAFKA-15659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Levani Kokhreidze updated KAFKA-15659:
--
Fix Version/s: 3.7.0
> Flaky test
> RestoreIntegrationTest.shouldInvokeUserDefinedGlo
[
https://issues.apache.org/jira/browse/KAFKA-15659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Levani Kokhreidze resolved KAFKA-15659.
---
Resolution: Fixed
> Flaky test
> RestoreIntegrationTest.shouldInvokeUserDefinedGlob
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1374138454
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -528,72 +483,64 @@ public void testRestartConnectorAndT
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1374136601
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -528,72 +483,64 @@ public void testRestartConnectorAndT
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1374136601
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -528,72 +483,64 @@ public void testRestartConnectorAndT
[
https://issues.apache.org/jira/browse/KAFKA-15686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780187#comment-17780187
]
Philip Nee commented on KAFKA-15686:
Hi [~ihavenoem...@163.com] - If the leader is n
[
https://issues.apache.org/jira/browse/KAFKA-15701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiao Zhang updated KAFKA-15701:
---
Description:
One use case of CreateTopicPolicy we have experienced is allow/reject topic
creation b
[
https://issues.apache.org/jira/browse/KAFKA-15701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiao Zhang updated KAFKA-15701:
---
Description:
One use case of CreateTopicPolicy we have experienced is allow/reject topic
creation b
[
https://issues.apache.org/jira/browse/KAFKA-15701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiao Zhang updated KAFKA-15701:
---
Description:
One use case of CreateTopicPolicy we have experienced is allow/reject topic
creation b
[
https://issues.apache.org/jira/browse/KAFKA-15701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiao Zhang updated KAFKA-15701:
---
Description:
One use case of CreateTopicPolicy we have experienced is allow/reject topic
creation b
Jiao Zhang created KAFKA-15701:
--
Summary: Allow use of user policy in CreateTopicPolicy
Key: KAFKA-15701
URL: https://issues.apache.org/jira/browse/KAFKA-15701
Project: Kafka
Issue Type: Improv
mjsax commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1374065471
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/LastValueTracker.java:
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
[
https://issues.apache.org/jira/browse/KAFKA-15695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780166#comment-17780166
]
Kamal Chandraprakash commented on KAFKA-15695:
--
[~nikramakrishnan]
I rememb
philipnee commented on PR #14639:
URL: https://github.com/apache/kafka/pull/14639#issuecomment-1782275615
Hi @lucasbru - Thanks for taking the time to review my PR. I addressed all
but 2 comments:
1. Mockito: Could you be more specific on how you expect to mock the
response object?
2
philipnee commented on code in PR #14639:
URL: https://github.com/apache/kafka/pull/14639#discussion_r1374057359
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -127,7 +146,7 @@ public void maybeAutoCommit(final Map offsets
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1374013380
##
streams/src/main/java/org/apache/kafka/streams/state/internals/WrappedStateStore.java:
##
@@ -34,6 +34,9 @@
public abstract class WrappedStateStore implements
mjsax commented on code in PR #14619:
URL: https://github.com/apache/kafka/pull/14619#discussion_r1374019186
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/MetricNamingConvention.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/KAFKA-15390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deng Ziming resolved KAFKA-15390.
-
Fix Version/s: 3.6.0
Resolution: Fixed
> FetchResponse.preferredReplica may contains fenc
philipnee commented on code in PR #14639:
URL: https://github.com/apache/kafka/pull/14639#discussion_r1374040965
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -382,9 +522,49 @@ private ClientResponse buildOffsetFetchCli
philipnee commented on code in PR #14575:
URL: https://github.com/apache/kafka/pull/14575#discussion_r1374037210
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/MetricKey.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
philipnee commented on PR #14642:
URL: https://github.com/apache/kafka/pull/14642#issuecomment-1782236753
Hi @kirktrue Thanks for taking time reviewing my code. I made changes
according to your suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the me
philipnee commented on code in PR #14642:
URL: https://github.com/apache/kafka/pull/14642#discussion_r1374036176
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -105,6 +105,24 @@ public class ConsumerConfig extends AbstractConfig {
publ
philipnee commented on code in PR #14642:
URL: https://github.com/apache/kafka/pull/14642#discussion_r1374035895
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -610,6 +628,18 @@ public class ConsumerConfig extends AbstractConfig {
philipnee commented on code in PR #14642:
URL: https://github.com/apache/kafka/pull/14642#discussion_r1374035641
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -610,6 +628,18 @@ public class ConsumerConfig extends AbstractConfig {
sanjay-awatramani commented on code in PR #14552:
URL: https://github.com/apache/kafka/pull/14552#discussion_r1374022606
##
docker/docker_release.py:
##
@@ -0,0 +1,80 @@
+#!/usr/bin/env python
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contribu
ocadaruma commented on code in PR #14242:
URL: https://github.com/apache/kafka/pull/14242#discussion_r1374014105
##
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java:
##
@@ -462,22 +462,32 @@ public Optional lastEntry(long
producerId) {
mjsax commented on code in PR #14618:
URL: https://github.com/apache/kafka/pull/14618#discussion_r1374016565
##
build.gradle:
##
@@ -295,7 +296,12 @@ subprojects {
}
publications {
mavenJava(MavenPublication) {
- from components.java
+ if
mjsax commented on code in PR #14575:
URL: https://github.com/apache/kafka/pull/14575#discussion_r1374007941
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/MetricKey.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
ocadaruma commented on code in PR #14242:
URL: https://github.com/apache/kafka/pull/14242#discussion_r1374014105
##
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java:
##
@@ -462,22 +462,32 @@ public Optional lastEntry(long
producerId) {
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1374013380
##
streams/src/main/java/org/apache/kafka/streams/state/internals/WrappedStateStore.java:
##
@@ -34,6 +34,9 @@
public abstract class WrappedStateStore implements
Owen-CH-Leung commented on code in PR #14645:
URL: https://github.com/apache/kafka/pull/14645#discussion_r1374005528
##
release.py:
##
@@ -730,7 +730,7 @@ def select_gpg_key():
fail("Ok, giving up")
if not user_ok("Ok to push RC tag %s (y/n)?: " % rc_tag):
fail("Ok, g
yyu1993 commented on code in PR #14545:
URL: https://github.com/apache/kafka/pull/14545#discussion_r1373996821
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1216,15 +1228,21 @@ class LogManager(logDirs: Seq[File],
cleaner.updateCheckpoints(removedLog.par
showuon commented on PR #14646:
URL: https://github.com/apache/kafka/pull/14646#issuecomment-1782174276
@ppatierno , please resolve the conflicts. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
[
https://issues.apache.org/jira/browse/KAFKA-15319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15319:
Fix Version/s: 3.5.2
> Upgrade rocksdb to fix CVE-2022-37434
> ---
mjsax commented on PR #14216:
URL: https://github.com/apache/kafka/pull/14216#issuecomment-1782162923
Cherry-picked this to `3.5` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
mjsax commented on code in PR #14596:
URL: https://github.com/apache/kafka/pull/14596#discussion_r1373965049
##
streams/src/main/java/org/apache/kafka/streams/query/VersionedKeyQuery.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
mjsax commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1373981478
##
streams/src/main/java/org/apache/kafka/streams/state/internals/WrappedStateStore.java:
##
@@ -34,6 +34,9 @@
public abstract class WrappedStateStore implements
StateS
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1373977415
##
streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java:
##
@@ -346,6 +346,23 @@ public static Function
getDeserializeValue(final S
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1373970782
##
streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java:
##
@@ -346,6 +346,23 @@ public static Function
getDeserializeValue(final S
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1373970782
##
streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java:
##
@@ -346,6 +346,23 @@ public static Function
getDeserializeValue(final S
mjsax merged PR #14600:
URL: https://github.com/apache/kafka/pull/14600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
mjsax commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1373953314
##
streams/src/main/java/org/apache/kafka/streams/state/internals/KeyValueToTimestampedKeyValueByteStoreAdapter.java:
##
@@ -126,15 +128,22 @@ public QueryResult query(
[
https://issues.apache.org/jira/browse/KAFKA-15690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15690:
Component/s: streams
unit tests
> EosIntegrationTest is flaky.
>
kirktrue commented on code in PR #14642:
URL: https://github.com/apache/kafka/pull/14642#discussion_r1373924481
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -105,6 +105,24 @@ public class ConsumerConfig extends AbstractConfig {
publi
agavra opened a new pull request, #14648:
URL: https://github.com/apache/kafka/pull/14648
### Overview
Implementation for
[KIP-954](https://cwiki.apache.org/confluence/display/KAFKA/KIP-954%3A+expand+default+DSL+store+configuration+to+custom+types)
### Testing Strategy
* Updated
C0urante commented on PR #14630:
URL: https://github.com/apache/kafka/pull/14630#issuecomment-1782075383
I can take a look next week. In the meantime, do you think you could add
some unit tests for this change?
--
This is an automated message from the Apache Git Service.
To respond to the
jolshan commented on code in PR #14627:
URL: https://github.com/apache/kafka/pull/14627#discussion_r1373924152
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -360,7 +360,9 @@ public short partitionRecordVersion() {
}
public
[
https://issues.apache.org/jira/browse/KAFKA-14419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-14419:
---
Summary: Failed SyncGroup leading to partitions lost due to processing
durin
[
https://issues.apache.org/jira/browse/KAFKA-14419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780119#comment-17780119
]
A. Sophie Blee-Goldman commented on KAFKA-14419:
[~Carlstedt] first off,
[
https://issues.apache.org/jira/browse/KAFKA-14419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779731#comment-17779731
]
A. Sophie Blee-Goldman edited comment on KAFKA-14419 at 10/26/23 10:49 PM:
---
ocadaruma commented on code in PR #14242:
URL: https://github.com/apache/kafka/pull/14242#discussion_r1373898465
##
storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java:
##
@@ -308,7 +308,14 @@ public void truncateFromEnd(long endOffset) {
[
https://issues.apache.org/jira/browse/KAFKA-15690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Calvin Liu updated KAFKA-15690:
---
Description:
EosIntegrationTest
shouldNotViolateEosIfOneTaskGetsFencedUsingIsolatedAppInstances[exa
CalvinConfluent commented on PR #14603:
URL: https://github.com/apache/kafka/pull/14603#issuecomment-1781972169
https://issues.apache.org/jira/browse/KAFKA-15699
https://issues.apache.org/jira/browse/KAFKA-15700
--
This is an automated message from the Apache Git Service.
To respond to
Calvin Liu created KAFKA-15700:
--
Summary: FetchFromFollowerIntegrationTest is flaky
Key: KAFKA-15700
URL: https://issues.apache.org/jira/browse/KAFKA-15700
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-15699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Calvin Liu updated KAFKA-15699:
---
Description:
It may relate to inappropriate test timeout
testReplicateSourceDefault()
{code:java}
o
[
https://issues.apache.org/jira/browse/KAFKA-15699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Calvin Liu updated KAFKA-15699:
---
Description:
May relate to inaproparate
testReplicateSourceDefault() * testOffsetSyncsTopicsOnTarg
mumrah merged PR #14545:
URL: https://github.com/apache/kafka/pull/14545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
[
https://issues.apache.org/jira/browse/KAFKA-15690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Calvin Liu updated KAFKA-15690:
---
Summary: EosIntegrationTest is flaky. (was: Flaky integration tests)
> EosIntegrationTest is flaky.
Calvin Liu created KAFKA-15699:
--
Summary: MirrorConnectorsIntegrationBaseTest is flaky
Key: KAFKA-15699
URL: https://issues.apache.org/jira/browse/KAFKA-15699
Project: Kafka
Issue Type: Bug
mumrah commented on PR #14545:
URL: https://github.com/apache/kafka/pull/14545#issuecomment-1781961533
Test failures look unrelated.
https://github.com/apache/kafka/assets/55116/b0eb9cec-76df-4d5e-ab73-dfd2ca4d5978";>
--
This is an automated message from the Apache Git Service.
mumrah commented on code in PR #14545:
URL: https://github.com/apache/kafka/pull/14545#discussion_r1373863647
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1216,15 +1228,21 @@ class LogManager(logDirs: Seq[File],
cleaner.updateCheckpoints(removedLog.pare
David Arthur created KAFKA-15698:
Summary: KRaft mode brokers should clean up stray partitions from
migration
Key: KAFKA-15698
URL: https://issues.apache.org/jira/browse/KAFKA-15698
Project: Kafka
ableegoldman merged PR #14608:
URL: https://github.com/apache/kafka/pull/14608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
ableegoldman commented on code in PR #14608:
URL: https://github.com/apache/kafka/pull/14608#discussion_r1373854238
##
streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java:
##
@@ -523,13 +527,13 @@ public void
shouldInvokeUserDefinedGlobalState
ableegoldman commented on PR #14608:
URL: https://github.com/apache/kafka/pull/14608#issuecomment-1781945353
Test failures are unrelated, and the relevant test passed in all cases, so
let's merge this
--
This is an automated message from the Apache Git Service.
To respond to the message,
ableegoldman commented on code in PR #14608:
URL: https://github.com/apache/kafka/pull/14608#discussion_r1373854238
##
streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java:
##
@@ -523,13 +527,13 @@ public void
shouldInvokeUserDefinedGlobalState
dongnuo123 commented on code in PR #14589:
URL: https://github.com/apache/kafka/pull/14589#discussion_r1373846331
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -4385,15 +4451,39 @@ class KafkaApisTest {
.setGroupId("group-3")
.setErrorCode
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373822529
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -407,36 +414,41 @@ object StorageTool extends Logging {
if (directories.isEmpty) {
throw new Ter
dongnuo123 commented on code in PR #14589:
URL: https://github.com/apache/kafka/pull/14589#discussion_r1373847099
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -4385,15 +4451,39 @@ class KafkaApisTest {
.setGroupId("group-3")
.setErrorCode
dongnuo123 commented on code in PR #14589:
URL: https://github.com/apache/kafka/pull/14589#discussion_r1373846331
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -4385,15 +4451,39 @@ class KafkaApisTest {
.setGroupId("group-3")
.setErrorCode
[
https://issues.apache.org/jira/browse/KAFKA-15316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780100#comment-17780100
]
Philip Nee commented on KAFKA-15316:
I think this is fixed. I will check
> CommitRe
[
https://issues.apache.org/jira/browse/KAFKA-15316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee reassigned KAFKA-15316:
--
Assignee: Philip Nee
> CommitRequestManager not calling RequestState callbacks
> ---
[
https://issues.apache.org/jira/browse/KAFKA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15556:
--
Labels: consumer-threading-refactor kip-848 (was:
consumer-threading-refactor kip-848-preview)
> Rem
[
https://issues.apache.org/jira/browse/KAFKA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15556:
--
Labels: consumer-threading-refactor (was: consumer-threading-refactor
kip-848)
> Remove NetworkClien
dongnuo123 commented on code in PR #14537:
URL: https://github.com/apache/kafka/pull/14537#discussion_r1373833449
##
core/src/test/scala/unit/kafka/server/OffsetDeleteRequestTest.scala:
##
@@ -0,0 +1,165 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or m
CalvinConfluent commented on code in PR #14594:
URL: https://github.com/apache/kafka/pull/14594#discussion_r1373832091
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -1106,6 +1115,12 @@ class Partition(val topicPartition: TopicPartition,
* @return true if the HW
C0urante commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1373831428
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -528,72 +483,64 @@ public void testRestartConnectorAndTas
dongnuo123 commented on code in PR #14537:
URL: https://github.com/apache/kafka/pull/14537#discussion_r1373831315
##
core/src/test/scala/unit/kafka/server/OffsetDeleteRequestTest.scala:
##
@@ -0,0 +1,165 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or m
C0urante commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1373830704
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -528,72 +483,64 @@ public void testRestartConnectorAndTas
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373824387
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -267,35 +267,27 @@ class LogManager(logDirs: Seq[File],
/**
* Retrieves the Uuid for the directory, give
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373824387
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -267,35 +267,27 @@ class LogManager(logDirs: Seq[File],
/**
* Retrieves the Uuid for the directory, give
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373822529
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -407,36 +414,41 @@ object StorageTool extends Logging {
if (directories.isEmpty) {
throw new Ter
[
https://issues.apache.org/jira/browse/KAFKA-15691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15691:
--
Summary: Upgrade existing and add new system tests to use new consumer
(was: Upgrade existing and add
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373820141
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -228,23 +226,26 @@ class KafkaServer(
info(s"Cluster ID = $clusterId")
/* load metadata
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373816778
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogDirFailureChannel.java:
##
@@ -57,7 +56,7 @@ public boolean hasOfflineLogDir(String logDir) {
*
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373817350
##
core/src/main/scala/kafka/server/KafkaRaftServer.scala:
##
@@ -135,39 +136,52 @@ object KafkaRaftServer {
* @return A tuple containing the loaded meta properties
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373817350
##
core/src/main/scala/kafka/server/KafkaRaftServer.scala:
##
@@ -135,39 +136,52 @@ object KafkaRaftServer {
* @return A tuple containing the loaded meta properties
chb2ab commented on code in PR #14627:
URL: https://github.com/apache/kafka/pull/14627#discussion_r1373815620
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -360,7 +360,9 @@ public short partitionRecordVersion() {
}
public s
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373815484
##
metadata/src/main/java/org/apache/kafka/metadata/properties/MetaPropertiesVersion.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
chb2ab commented on code in PR #14627:
URL: https://github.com/apache/kafka/pull/14627#discussion_r1373814111
##
clients/src/main/resources/common/message/FetchRequest.json:
##
@@ -53,7 +53,9 @@
//
// Version 15 adds the ReplicaState which includes new field ReplicaEpoch
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373813203
##
core/src/test/java/kafka/testkit/KafkaClusterTestKit.java:
##
@@ -227,8 +231,12 @@ public KafkaClusterTestKit build() throws Exception {
setupNo
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373812595
##
metadata/src/main/java/org/apache/kafka/metadata/properties/MetaPropertiesEnsemble.java:
##
@@ -0,0 +1,497 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373810872
##
metadata/src/main/java/org/apache/kafka/metadata/properties/PropertiesUtils.java:
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373808533
##
metadata/src/main/java/org/apache/kafka/metadata/properties/MetaProperties.java:
##
@@ -0,0 +1,266 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
jolshan commented on code in PR #14629:
URL: https://github.com/apache/kafka/pull/14629#discussion_r1373793336
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig,
}
}
+ /*
+ * Note: This me
dongnuo123 commented on code in PR #14537:
URL: https://github.com/apache/kafka/pull/14537#discussion_r1373787330
##
core/src/test/scala/unit/kafka/server/ListGroupsRequestTest.scala:
##
@@ -0,0 +1,236 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
artemlivshits commented on code in PR #14594:
URL: https://github.com/apache/kafka/pull/14594#discussion_r1373758559
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -1106,6 +1115,12 @@ class Partition(val topicPartition: TopicPartition,
* @return true if the HW w
wcarlson5 merged PR #14575:
URL: https://github.com/apache/kafka/pull/14575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
wcarlson5 commented on code in PR #14575:
URL: https://github.com/apache/kafka/pull/14575#discussion_r1373750580
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetrySender.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundatio
alok123t commented on PR #14607:
URL: https://github.com/apache/kafka/pull/14607#issuecomment-1781801313
@junrao I think the test failures should be unrelated to the PR from a quick
look - not sure if these are known flaky tests, I will wait for another run
from the latest commit
--
Thi
1 - 100 of 262 matches
Mail list logo
