cmccabe commented on code in PR #14628: URL: https://github.com/apache/kafka/pull/14628#discussion_r1373816778
########## storage/src/main/java/org/apache/kafka/storage/internals/log/LogDirFailureChannel.java: ########## @@ -57,7 +56,7 @@ public boolean hasOfflineLogDir(String logDir) { * @param msg Error message. * @param e Exception instance. */ - public void maybeAddOfflineLogDir(String logDir, String msg, IOException e) { + public void maybeAddOfflineLogDir(String logDir, String msg, Exception e) { Review Comment: Fair enough. I changed it above to just catch IOE so I will change it here as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org