[GitHub] [kafka] showuon merged pull request #14424: MINOR: Fix kraft upgrade system test

2023-09-22 Thread via GitHub
showuon merged PR #14424: URL: https://github.com/apache/kafka/pull/14424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] satishd commented on pull request #14424: MINOR: Fix kraft upgrade system test

2023-09-22 Thread via GitHub
satishd commented on PR #14424: URL: https://github.com/apache/kafka/pull/14424#issuecomment-1732193964 This is not a blocker for 3.6.0 release as the fix is in a test file, but we can merge it into 3.6 branch so that any subsequent 3.6 minor releases can pick up this change. -- This is

[GitHub] [kafka] showuon merged pull request #14355: KAFKA-14595 ReassignPartitionsUnitTest rewritten in java

2023-09-22 Thread via GitHub
showuon merged PR #14355: URL: https://github.com/apache/kafka/pull/14355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] showuon commented on pull request #14355: KAFKA-14595 ReassignPartitionsUnitTest rewritten in java

2023-09-22 Thread via GitHub
showuon commented on PR #14355: URL: https://github.com/apache/kafka/pull/14355#issuecomment-1732174431 Failed tests are unrelated: ``` Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.integration.ConnectorRestartApiIntegrationTest.testMultiWorkerRestartOnlyConnector

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334894116 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestManagers.java: ## @@ -16,41 +16,149 @@ */ package org.apache.kafka.clients.consumer.inte

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334893631 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestManager.java: ## @@ -18,11 +18,18 @@ import org.apache.kafka.clients.consumer.internals

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334893046 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java: ## @@ -79,6 +100,7 @@ public void clearBufferedDataForUnassignedPartitions(Collecti

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334892999 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CompletedFetch.java: ## @@ -249,7 +250,9 @@ private Record nextFetchedRecord(FetchConfig fetchCo

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334888478 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CompletedFetch.java: ## @@ -135,7 +135,8 @@ void recordAggregatedMetrics(int bytes, int records) {

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334888478 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CompletedFetch.java: ## @@ -135,7 +135,8 @@ void recordAggregatedMetrics(int bytes, int records) {

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334886820 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -684,7 +1011,7 @@ private boolean isCommittedOffsetsManagementE

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334886595 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -622,12 +837,18 @@ public void assign(Collection partitions) {

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334886142 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -636,42 +857,148 @@ public void assign(Collection partitions)

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334885719 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -596,12 +786,38 @@ public Set subscription() { @Override

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334885217 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -526,13 +677,57 @@ public void close() { close(Duratio

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334884022 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -526,13 +677,57 @@ public void close() { close(Duratio

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334882689 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -636,42 +857,148 @@ public void assign(Collection partitions)

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334882482 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -636,42 +857,148 @@ public void assign(Collection partitions)

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334881860 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -192,71 +321,38 @@ public PrototypeAsyncConsumer(final Consumer

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334881403 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -192,71 +321,38 @@ public PrototypeAsyncConsumer(final Consumer

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334879279 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchRequestManager.java: ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334878765 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/BackgroundEventProcessor.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334878210 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -636,42 +857,148 @@ public void assign(Collection partitions)

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334876767 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -636,42 +857,148 @@ public void assign(Collection partitions)

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334873271 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultEventHandler.java: ## @@ -141,11 +77,25 @@ public T addAndGet(final CompletableApplicatio

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334872655 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java: ## @@ -259,17 +144,41 @@ long handlePollResult(NetworkClientDelegate

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334872019 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java: ## @@ -259,17 +144,41 @@ long handlePollResult(NetworkClientDelegate

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334871627 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java: ## @@ -217,29 +98,33 @@ public void run() { }

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334871262 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java: ## @@ -16,197 +16,78 @@ */ package org.apache.kafka.clients.consu

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334870782 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ErrorEventHandler.java: ## @@ -22,13 +22,18 @@ import java.util.Queue; public class ErrorEvent

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334870694 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java: ## @@ -16,197 +16,78 @@ */ package org.apache.kafka.clients.consu

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334870549 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/BackgroundEventProcessor.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334870059 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchRequestManager.java: ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] kirktrue commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1334869446 ## checkstyle/import-control.xml: ## @@ -205,6 +205,10 @@ + Review Comment: Yes, just to set off the child `subpackage` element more cleanly. But I

[GitHub] [kafka] cmccabe commented on a diff in pull request #14399: KAFKA-15466: Add KIP-919 support for some admin APIs

2023-09-22 Thread via GitHub
cmccabe commented on code in PR #14399: URL: https://github.com/apache/kafka/pull/14399#discussion_r1334858055 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -79,14 +79,17 @@ object KafkaRequestHandler { /** * A thread that answers kafka requests. */ -

[GitHub] [kafka] cmccabe commented on a diff in pull request #14399: KAFKA-15466: Add KIP-919 support for some admin APIs

2023-09-22 Thread via GitHub
cmccabe commented on code in PR #14399: URL: https://github.com/apache/kafka/pull/14399#discussion_r1334857465 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -4009,12 +4134,11 @@ void handleFailure(Throwable throwable) { @Override

[GitHub] [kafka] cmccabe commented on a diff in pull request #14399: KAFKA-15466: Add KIP-919 support for some admin APIs

2023-09-22 Thread via GitHub
cmccabe commented on code in PR #14399: URL: https://github.com/apache/kafka/pull/14399#discussion_r1334856841 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -719,38 +726,66 @@ public Node provide() { abstract class Call { pr

[jira] [Created] (KAFKA-15488) Add StarRocks to the database integration list

2023-09-22 Thread Albert Wong (Jira)
Albert Wong created KAFKA-15488: --- Summary: Add StarRocks to the database integration list Key: KAFKA-15488 URL: https://issues.apache.org/jira/browse/KAFKA-15488 Project: Kafka Issue Type: Imp

[jira] [Commented] (KAFKA-15463) StreamsException: Accessing from an unknown node

2023-09-22 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768141#comment-17768141 ] A. Sophie Blee-Goldman commented on KAFKA-15463: [~yevsh] try moving the

[GitHub] [kafka] junrao commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-22 Thread via GitHub
junrao commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r193941 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -636,42 +857,148 @@ public void assign(Collection partitions) {

[GitHub] [kafka] philipnee commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

2023-09-22 Thread via GitHub
philipnee commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1334734541 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] ijuma commented on a diff in pull request #14427: KAFKA-15485: Fix "this-escape" compiler warnings introduced by JDK 21 (1/N)

2023-09-22 Thread via GitHub
ijuma commented on code in PR #14427: URL: https://github.com/apache/kafka/pull/14427#discussion_r1334734260 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java: ## @@ -50,6 +50,7 @@ public class RemoteLogMetadat

[GitHub] [kafka] rondagostino merged pull request #14405: [MINOR] QuorumController tests use testToImage

2023-09-22 Thread via GitHub
rondagostino merged PR #14405: URL: https://github.com/apache/kafka/pull/14405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[GitHub] [kafka] rondagostino commented on pull request #14405: [MINOR] QuorumController tests use testToImage

2023-09-22 Thread via GitHub
rondagostino commented on PR #14405: URL: https://github.com/apache/kafka/pull/14405#issuecomment-1731898597 None of the failed tests are from the affected file `QuorumControllerTest.java`, so the test failures are unrelated. Merging to trunk. -- This is an automated message from the Ap

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14417: KAFKA-14519; [1/N] Implement coordinator runtime metrics

2023-09-22 Thread via GitHub
jeffkbkim commented on code in PR #14417: URL: https://github.com/apache/kafka/pull/14417#discussion_r1334705172 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/CoordinatorRuntimeMetrics.java: ## @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Soft

[GitHub] [kafka] lianetm commented on a diff in pull request #14357: KAFKA-15276: Implement partition assignment reconciliation

2023-09-22 Thread via GitHub
lianetm commented on code in PR #14357: URL: https://github.com/apache/kafka/pull/14357#discussion_r1334676439 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -237,4 +253,64 @@ public void updateAssignment(ConsumerGroupHear

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14417: KAFKA-14519; [1/N] Implement coordinator runtime metrics

2023-09-22 Thread via GitHub
jeffkbkim commented on code in PR #14417: URL: https://github.com/apache/kafka/pull/14417#discussion_r1334673715 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -1242,7 +1304,11 @@ public void scheduleLoadOperation(

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

2023-09-22 Thread via GitHub
lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1334668800 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14417: KAFKA-14519; [1/N] Implement coordinator runtime metrics

2023-09-22 Thread via GitHub
jeffkbkim commented on code in PR #14417: URL: https://github.com/apache/kafka/pull/14417#discussion_r1334663114 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -1242,7 +1304,11 @@ public void scheduleLoadOperation(

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14417: KAFKA-14519; [1/N] Implement coordinator runtime metrics

2023-09-22 Thread via GitHub
jeffkbkim commented on code in PR #14417: URL: https://github.com/apache/kafka/pull/14417#discussion_r1334661304 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/CoordinatorRuntimeMetrics.java: ## @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Soft

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14417: KAFKA-14519; [1/N] Implement coordinator runtime metrics

2023-09-22 Thread via GitHub
jeffkbkim commented on code in PR #14417: URL: https://github.com/apache/kafka/pull/14417#discussion_r1334659282 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/CoordinatorRuntimeMetrics.java: ## @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Soft

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

2023-09-22 Thread via GitHub
lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1334659219 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

2023-09-22 Thread via GitHub
lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1334657428 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

2023-09-22 Thread via GitHub
lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1334652824 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14427: KAFKA-15485: Fix "this-escape" compiler warnings introduced by JDK 21 (1/N)

2023-09-22 Thread via GitHub
divijvaidya commented on code in PR #14427: URL: https://github.com/apache/kafka/pull/14427#discussion_r1334649199 ## storage/src/main/java/org/apache/kafka/storage/internals/log/TimeIndex.java: ## @@ -60,6 +60,7 @@ public TimeIndex(File file, long baseOffset, int maxIndexSize)

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

2023-09-22 Thread via GitHub
lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1334645635 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14427: KAFKA-15485: Fix "this-escape" compiler warnings introduced by JDK 21 (1/N)

2023-09-22 Thread via GitHub
divijvaidya commented on code in PR #14427: URL: https://github.com/apache/kafka/pull/14427#discussion_r1334642477 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java: ## @@ -50,6 +50,7 @@ public class RemoteLogM

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

2023-09-22 Thread via GitHub
lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1334636930 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

2023-09-22 Thread via GitHub
lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1334633010 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

2023-09-22 Thread via GitHub
lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1334633010 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

2023-09-22 Thread via GitHub
lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1334626047 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java: ## @@ -190,13 +194,23 @@ public DefaultBackgroundThread(final Time ti

[GitHub] [kafka] CalvinConfluent commented on pull request #14053: KAFKA-15221; Fix the race between fetch requests from a rebooted follower.

2023-09-22 Thread via GitHub
CalvinConfluent commented on PR #14053: URL: https://github.com/apache/kafka/pull/14053#issuecomment-1731725183 @splett2 @hachikuji Any comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] C0urante commented on a diff in pull request #14427: KAFKA-15485: Fix "this-escape" compiler warnings introduced by JDK 21 (1/N)

2023-09-22 Thread via GitHub
C0urante commented on code in PR #14427: URL: https://github.com/apache/kafka/pull/14427#discussion_r1334606614 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java: ## @@ -381,15 +381,15 @@ private void doTransitionTo(TargetState targetState)

[GitHub] [kafka] ijuma commented on pull request #14427: KAFKA-15485: Fix "this-escape" compiler warnings introduced by JDK 21 (1/N)

2023-09-22 Thread via GitHub
ijuma commented on PR #14427: URL: https://github.com/apache/kafka/pull/14427#issuecomment-1731708017 > Please add to the description - "this-escape" is related to new lint warning Done. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] ijuma commented on a diff in pull request #14427: KAFKA-15485: Fix "this-escape" compiler warnings introduced by JDK 21 (1/N)

2023-09-22 Thread via GitHub
ijuma commented on code in PR #14427: URL: https://github.com/apache/kafka/pull/14427#discussion_r1334596556 ## storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java: ## @@ -56,6 +56,7 @@ public class LeaderEpochFileCache { * @param topic

[GitHub] [kafka] ijuma commented on a diff in pull request #14427: KAFKA-15485: Fix "this-escape" compiler warnings introduced by JDK 21 (1/N)

2023-09-22 Thread via GitHub
ijuma commented on code in PR #14427: URL: https://github.com/apache/kafka/pull/14427#discussion_r1334585052 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java: ## @@ -50,6 +50,7 @@ public class RemoteLogMetadat

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14427: KAFKA-15485: Fix "this-escape" compiler warnings introduced by JDK 21 (1/N)

2023-09-22 Thread via GitHub
divijvaidya commented on code in PR #14427: URL: https://github.com/apache/kafka/pull/14427#discussion_r1334524883 ## storage/src/main/java/org/apache/kafka/storage/internals/log/TimeIndex.java: ## @@ -60,6 +60,7 @@ public TimeIndex(File file, long baseOffset, int maxIndexSize)

[GitHub] [kafka] dajac commented on a diff in pull request #14417: KAFKA-14519; [1/N] Implement coordinator runtime metrics

2023-09-22 Thread via GitHub
dajac commented on code in PR #14417: URL: https://github.com/apache/kafka/pull/14417#discussion_r1334540685 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorLoader.java: ## @@ -46,6 +46,35 @@ public short unknownType() { } }

[GitHub] [kafka] dajac commented on a diff in pull request #14408: KAFKA-14506: Implement DeleteGroups API and OffsetDelete API

2023-09-22 Thread via GitHub
dajac commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1334519906 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java: ## @@ -90,4 +90,29 @@ void validateOffsetFetch( int memberEpoch, long

[GitHub] [kafka] dajac commented on pull request #14327: KAFKA-14048:Implement regex subscriptions

2023-09-22 Thread via GitHub
dajac commented on PR #14327: URL: https://github.com/apache/kafka/pull/14327#issuecomment-1731579985 @JimmyWang6 I am really sorry but I haven't had the time to dive into this yet. At a high level, I think that the approach taken so far does not cover all the aspects. For instance, how is

[GitHub] [kafka] dajac commented on a diff in pull request #14408: KAFKA-14506: Implement DeleteGroups API and OffsetDelete API

2023-09-22 Thread via GitHub
dajac commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1334471084 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -523,9 +526,63 @@ public CompletableFuture> groupsByTopicPartit

[GitHub] [kafka] dajac commented on a diff in pull request #14418: MINOR: Move TopicIdPartition class to server-common

2023-09-22 Thread via GitHub
dajac commented on code in PR #14418: URL: https://github.com/apache/kafka/pull/14418#discussion_r1334469581 ## server-common/src/main/java/org/apache/kafka/server/common/TopicIdPartition.java: ## @@ -14,43 +14,62 @@ * See the License for the specific language governing permis

[GitHub] [kafka] dajac commented on a diff in pull request #14418: MINOR: Move TopicIdPartition class to server-common

2023-09-22 Thread via GitHub
dajac commented on code in PR #14418: URL: https://github.com/apache/kafka/pull/14418#discussion_r1334469294 ## server-common/src/main/java/org/apache/kafka/server/common/TopicIdPartition.java: ## @@ -14,43 +14,62 @@ * See the License for the specific language governing permis

[GitHub] [kafka] ijuma commented on a diff in pull request #14427: KAFKA-15485: Fix "this-escape" compiler warnings introduced by JDK 21 (1/N)

2023-09-22 Thread via GitHub
ijuma commented on code in PR #14427: URL: https://github.com/apache/kafka/pull/14427#discussion_r1334438340 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -227,8 +226,9 @@ private T createDelegate(ClassLoader classLoader, String className) { }

[jira] [Updated] (KAFKA-15487) CVE-2023-40167, CVE-2023-36479 - Upgrade jetty to 9.4.52, 10.0.16, 11.0.16, 12.0.1

2023-09-22 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15487: - Affects Version/s: 3.5.1 3.4.1 3.6.0 > CVE-2023-40

[jira] [Commented] (KAFKA-15487) CVE-2023-40167, CVE-2023-36479 - Upgrade jetty to 9.4.52, 10.0.16, 11.0.16, 12.0.1

2023-09-22 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768031#comment-17768031 ] Divij Vaidya commented on KAFKA-15487: -- Current release candidate 3.6 uses Jetty 9.

[GitHub] [kafka] ijuma commented on a diff in pull request #14427: KAFKA-15485: Fix "this-escape" compiler warnings introduced by JDK 21 (1/N)

2023-09-22 Thread via GitHub
ijuma commented on code in PR #14427: URL: https://github.com/apache/kafka/pull/14427#discussion_r1334428308 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java: ## @@ -381,15 +381,15 @@ private void doTransitionTo(TargetState targetState) thr

[jira] [Commented] (KAFKA-15485) Upgrade to JDK-21 (LTS release)

2023-09-22 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768028#comment-17768028 ] Ismael Juma commented on KAFKA-15485: - First PR: https://github.com/apache/kafka/pul

[GitHub] [kafka] lianetm commented on pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

2023-09-22 Thread via GitHub
lianetm commented on PR #14364: URL: https://github.com/apache/kafka/pull/14364#issuecomment-1731476330 Hey @philipnee , I see several updates here, thanks! let me know when you want to me give it another pass (there are still some test failures) -- This is an automated message from the A

[GitHub] [kafka] divijvaidya commented on pull request #14404: KAFKA-14133: Move MeteredSessionStoreTest, MeteredWindowStoreTest and ReadOnlyKeyValueStoreFacadeTest to Mockito

2023-09-22 Thread via GitHub
divijvaidya commented on PR #14404: URL: https://github.com/apache/kafka/pull/14404#issuecomment-1731447816 The tests failures are unrelated and build is successful - https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14404/1/pipeline -- This is an automa

[GitHub] [kafka] ijuma opened a new pull request, #14427: MINOR: Fix "this-escape" compiler warnings introduced by JDK 21

2023-09-22 Thread via GitHub
ijuma opened a new pull request, #14427: URL: https://github.com/apache/kafka/pull/14427 This is one of the steps required for kafka to compile with Java 21. The fixes are one of two types: 1. Suppress warning if fixing would potentially result in an incompatible change (for public

[jira] [Updated] (KAFKA-15487) CVE-2023-40167, CVE-2023-36479 - Upgrade jetty to 9.4.52, 10.0.16, 11.0.16, 12.0.1

2023-09-22 Thread Rafael Rios Saavedra (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael Rios Saavedra updated KAFKA-15487: - Description: CVE-2023-40167 and CVE-2023-36479 vulnerabilities affects Jetty ver

[jira] [Created] (KAFKA-15487) CVE-2023-40167, CVE-2023-36479 - Upgrade jetty to 9.4.52, 10.0.16, 11.0.16, 12.0.1

2023-09-22 Thread Rafael Rios Saavedra (Jira)
Rafael Rios Saavedra created KAFKA-15487: Summary: CVE-2023-40167, CVE-2023-36479 - Upgrade jetty to 9.4.52, 10.0.16, 11.0.16, 12.0.1 Key: KAFKA-15487 URL: https://issues.apache.org/jira/browse/KAFKA-15487

[jira] [Updated] (KAFKA-15486) Include NIO exceptions as I/O exceptions to be part of the disk failure handling mechanism

2023-09-22 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-15486: -- Description: Currently, Apache Kafka offers the ability to detect and capture I/O erro

[jira] [Updated] (KAFKA-15486) Include NIO exceptions as I/O exceptions to be part of the disk failure handling mechanism

2023-09-22 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-15486: -- Description: Currently, Apache Kafka offers the ability to detect and capture I/O erro

[jira] [Updated] (KAFKA-15486) Include NIO exceptions as I/O exceptions to be part of the disk failure handling mechanism

2023-09-22 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-15486: -- Summary: Include NIO exceptions as I/O exceptions to be part of the disk failure handl

[jira] [Commented] (KAFKA-15485) Upgrade to JDK-21 (LTS release)

2023-09-22 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768002#comment-17768002 ] Ismael Juma commented on KAFKA-15485: - Can we create a separate Jira ticket for expl

[jira] [Created] (KAFKA-15486) Include NIO exceptions as I/O exceptions to be part of disk failure handling

2023-09-22 Thread Alexandre Dupriez (Jira)
Alexandre Dupriez created KAFKA-15486: - Summary: Include NIO exceptions as I/O exceptions to be part of disk failure handling Key: KAFKA-15486 URL: https://issues.apache.org/jira/browse/KAFKA-15486

[jira] [Commented] (KAFKA-15485) Upgrade to JDK-21 (LTS release)

2023-09-22 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768001#comment-17768001 ] Ismael Juma commented on KAFKA-15485: - I started some work for this, so assigned it

[jira] [Assigned] (KAFKA-15485) Upgrade to JDK-21 (LTS release)

2023-09-22 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma reassigned KAFKA-15485: --- Assignee: Ismael Juma > Upgrade to JDK-21 (LTS release) > --- >

[GitHub] [kafka] nizhikov commented on pull request #14355: KAFKA-14595 ReassignPartitionsUnitTest rewritten in java

2023-09-22 Thread via GitHub
nizhikov commented on PR #14355: URL: https://github.com/apache/kafka/pull/14355#issuecomment-1731325027 @showuon Looks like tests are OK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[jira] [Comment Edited] (KAFKA-15417) JoinWindow does not seem to work properly with a KStream - KStream - LeftJoin()

2023-09-22 Thread Victor van den Hoven (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767979#comment-17767979 ] Victor van den Hoven edited comment on KAFKA-15417 at 9/22/23 12:18 PM: --

[jira] [Commented] (KAFKA-15417) JoinWindow does not seem to work properly with a KStream - KStream - LeftJoin()

2023-09-22 Thread Victor van den Hoven (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767979#comment-17767979 ] Victor van den Hoven commented on KAFKA-15417: -- There is a PR submitted for

[GitHub] [kafka] yashmayya commented on pull request #14093: KAFKA-15248 Add BooleanConverter

2023-09-22 Thread via GitHub
yashmayya commented on PR #14093: URL: https://github.com/apache/kafka/pull/14093#issuecomment-1731222665 @hgeraldino the Connect integration tests are failing with errors like: ``` org.apache.kafka.connect.errors.ConnectException: One or more plugins are missing ServiceLoader mani

[GitHub] [kafka] Nickstery opened a new pull request, #14425: KAFKA-15401: Segment with corrupted index should not be uploaded to r…

2023-09-22 Thread via GitHub
Nickstery opened a new pull request, #14425: URL: https://github.com/apache/kafka/pull/14425 Prior to uploading segment to remote storage, we have to unsure that there is no index corruption take place. -- This is an automated message from the Apache Git Service. To respond to the message

[jira] [Assigned] (KAFKA-14516) Implement static membeship

2023-09-22 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-14516: - Assignee: Sagar Rao (was: David Jacot) > Implement static membeship >

[GitHub] [kafka] showuon commented on pull request #14424: MINOR: Fix kraft upgrade system test

2023-09-22 Thread via GitHub
showuon commented on PR #14424: URL: https://github.com/apache/kafka/pull/14424#issuecomment-1731162530 @satishd , PR to fix the failed system tests. I've confirmed the change will make the tests pass. Thanks. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] showuon opened a new pull request, #14424: MINOR: Fix kraft upgrade system test

2023-09-22 Thread via GitHub
showuon opened a new pull request, #14424: URL: https://github.com/apache/kafka/pull/14424 We should use `DEV_BRANCH` instead of `DEV_VERSION` in this case, otherwise, error will be thrown: ``` RunnerClient: kafkatest.tests.core.kraft_upgrade_test.TestKRaftUpgrade.test_isolated_mode_u

[jira] [Commented] (KAFKA-14516) Implement static membeship

2023-09-22 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767939#comment-17767939 ] Sagar Rao commented on KAFKA-14516: --- [~dajac], sure , thank you very much! > Implemen

[GitHub] [kafka] sangyongchoi opened a new pull request, #14423: remove meaningless lines

2023-09-22 Thread via GitHub
sangyongchoi opened a new pull request, #14423: URL: https://github.com/apache/kafka/pull/14423 I found meaningless lines when look at the code. So I send pr to remove. thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

  1   2   >