kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1334872019
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java:
##########
@@ -259,17 +144,41 @@ long handlePollResult(NetworkClientDelegate.PollResult
res) {
}
public boolean isRunning() {
- return this.running;
+ return running;
}
public void wakeup() {
- networkClientDelegate.wakeup();
+ if (networkClientDelegate != null)
Review Comment:
Do you mean if `networkClientDelegate` is still `null`? Yes. That can happen
if the object is constructed and then used without calling
`initializeResources` beforehand. Perhaps a comment or a restructuring of the
code could be made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
