hudeqi commented on code in PR #13697:
URL: https://github.com/apache/kafka/pull/13697#discussion_r1191942365
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1586,11 +1578,6 @@ private void resetToEmptyState() {
*/
private final Fau
dengziming merged PR #13697:
URL: https://github.com/apache/kafka/pull/13697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apac
dengziming commented on code in PR #13697:
URL: https://github.com/apache/kafka/pull/13697#discussion_r1191937851
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1586,11 +1578,6 @@ private void resetToEmptyState() {
*/
private final
atu-sharm commented on PR #13633:
URL: https://github.com/apache/kafka/pull/13633#issuecomment-1545201789
Thanks, @vvcephei @mjsax @machi1990 for your valuable suggestions, i think
it's better to apply this property to the whole project, made changes according
to that
--
This is an autom
dengziming merged PR #13679:
URL: https://github.com/apache/kafka/pull/13679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apac
dengziming commented on PR #13679:
URL: https://github.com/apache/kafka/pull/13679#issuecomment-1545197689
The failed tests are flaky and also failed recently in other PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
dajac commented on code in PR #13678:
URL: https://github.com/apache/kafka/pull/13678#discussion_r1191927989
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -186,6 +187,7 @@ public ConsumerCoordinator(GroupRebalanceConfig
reb
[
https://issues.apache.org/jira/browse/KAFKA-13349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahesh Madushan reassigned KAFKA-13349:
---
Assignee: Mahesh Madushan
> Allow Iterator.remove on KeyValueIterator
> ---
[
https://issues.apache.org/jira/browse/KAFKA-13349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722007#comment-17722007
]
Mahesh Madushan commented on KAFKA-13349:
-
[~mjsax] Thank you for the response.
[
https://issues.apache.org/jira/browse/KAFKA-13349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722005#comment-17722005
]
Matthias J. Sax commented on KAFKA-13349:
-
Yes, we want to add `remove()` to int
aaron-ai opened a new pull request, #13710:
URL: https://github.com/apache/kafka/pull/13710
Fix the outdated comments of `ConfigDef` since the signature of the
corresponding method has been updated.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and impl
[
https://issues.apache.org/jira/browse/KAFKA-14911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722004#comment-17722004
]
Matthias J. Sax commented on KAFKA-14911:
-
No worries. And thanks for helping on
[
https://issues.apache.org/jira/browse/KAFKA-14981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722003#comment-17722003
]
Matthias J. Sax commented on KAFKA-14981:
-
I was not aware that there was (or ma
showuon merged PR #13517:
URL: https://github.com/apache/kafka/pull/13517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #13517:
URL: https://github.com/apache/kafka/pull/13517#issuecomment-1545024000
Failed tests are unrelated:
```
Build / JDK 8 and Scala 2.12 /
org.apache.kafka.connect.integration.ExactlyOnceSourceIntegrationTest.testConnectorBoundary
Build / JDK 8 an
[
https://issues.apache.org/jira/browse/KAFKA-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721959#comment-17721959
]
tony mancill commented on KAFKA-8154:
-
Thank you for that observation [~keith.paulson
mehbey opened a new pull request, #13709:
URL: https://github.com/apache/kafka/pull/13709
### What changed
Added a validation to check if the record timestamp is in the future
compared to the broker's timestamp and throw an exception to reject the record.
The current validation for
mehbey commented on PR #13681:
URL: https://github.com/apache/kafka/pull/13681#issuecomment-1544909428
>
Thank you for the review @clolov - I will address the comments shortly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
Alyssa Huang created KAFKA-14992:
Summary: Add partition limit or improve error msg for adminzkclient
Key: KAFKA-14992
URL: https://issues.apache.org/jira/browse/KAFKA-14992
Project: Kafka
Is
[
https://issues.apache.org/jira/browse/KAFKA-14941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721935#comment-17721935
]
Bikash Adhikari commented on KAFKA-14941:
-
I will work on this documentation.
splett2 commented on code in PR #13707:
URL: https://github.com/apache/kafka/pull/13707#discussion_r1191702662
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1956,10 +1956,10 @@ class KafkaConfig private(doLog: Boolean, val props:
java.util.Map[_, _], dynami
v
rreddy-22 commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1191678769
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,958 @@
+/*
+ * Licensed to the Apache Software Foundati
jeffkbkim commented on PR #13704:
URL: https://github.com/apache/kafka/pull/13704#issuecomment-1544658481
i'm seeing
```
Class Data Abstraction Coupling is 31 (max allowed is 25) classes
[ApiMessageAndVersion, ClientAssignor, ConsumerGroupCurrentMemberAssignmentKey,
ConsumerGroupCurr
philipnee commented on code in PR #13678:
URL: https://github.com/apache/kafka/pull/13678#discussion_r1191665112
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -1223,6 +1233,26 @@ public void maybeAutoCommitOffsetsAsync(long
jeffkbkim opened a new pull request, #13708:
URL: https://github.com/apache/kafka/pull/13708
Adds the purgatory interface that will be used by the new group coordinator.
* PurgatoryScheduler: used by GroupMetadataManager (introduced in
https://github.com/apache/kafka/pull/13639) to add a
Mehari Beyene created KAFKA-14991:
-
Summary: Improving Producer's record timestamp validation
Key: KAFKA-14991
URL: https://issues.apache.org/jira/browse/KAFKA-14991
Project: Kafka
Issue Type
jolshan commented on PR #13608:
URL: https://github.com/apache/kafka/pull/13608#issuecomment-1544627294
I forgot this also covers the race for end txn marker being written before
the produce completes.
(We reset verification status to empty on the marker, so a produce request
will fail)
dajac commented on code in PR #13704:
URL: https://github.com/apache/kafka/pull/13704#discussion_r1191653253
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/RecordHelpersTest.java:
##
@@ -399,8 +403,12 @@ public void testNewCurrentAssignmentTombstoneRecord(
splett2 commented on code in PR #13707:
URL: https://github.com/apache/kafka/pull/13707#discussion_r1191611324
##
core/src/test/scala/integration/kafka/api/ProducerIdExpirationTest.scala:
##
@@ -183,7 +183,11 @@ class ProducerIdExpirationTest extends
KafkaServerTestHarness {
jeffkbkim commented on code in PR #13704:
URL: https://github.com/apache/kafka/pull/13704#discussion_r1191604696
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/RecordHelpersTest.java:
##
@@ -399,8 +403,12 @@ public void testNewCurrentAssignmentTombstoneRec
jeffkbkim commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1191602652
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,1012 @@
+/*
+ * Licensed to the Apache Software Foundat
jeffkbkim commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1191602126
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,998 @@
+/*
+ * Licensed to the Apache Software Foundati
Hangleton commented on code in PR #13584:
URL: https://github.com/apache/kafka/pull/13584#discussion_r1191598672
##
core/src/test/scala/unit/kafka/log/LogSegmentTest.scala:
##
@@ -65,6 +68,32 @@ class LogSegmentTest {
Utils.delete(logDir)
}
+ /**
+ * LogSegmentOffse
Hangleton commented on code in PR #13584:
URL: https://github.com/apache/kafka/pull/13584#discussion_r1191598230
##
core/src/test/scala/unit/kafka/log/LogSegmentTest.scala:
##
@@ -65,6 +68,32 @@ class LogSegmentTest {
Utils.delete(logDir)
}
+ /**
+ * LogSegmentOffse
splett2 commented on code in PR #13707:
URL: https://github.com/apache/kafka/pull/13707#discussion_r1191586683
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1956,10 +1956,10 @@ class KafkaConfig private(doLog: Boolean, val props:
java.util.Map[_, _], dynami
v
jolshan commented on code in PR #13707:
URL: https://github.com/apache/kafka/pull/13707#discussion_r1191577885
##
core/src/test/scala/integration/kafka/api/ProducerIdExpirationTest.scala:
##
@@ -183,7 +183,11 @@ class ProducerIdExpirationTest extends
KafkaServerTestHarness {
jolshan commented on code in PR #13707:
URL: https://github.com/apache/kafka/pull/13707#discussion_r1191576738
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1956,10 +1956,10 @@ class KafkaConfig private(doLog: Boolean, val props:
java.util.Map[_, _], dynami
v
splett2 opened a new pull request, #13707:
URL: https://github.com/apache/kafka/pull/13707
Dynamic overrides for the producer ID expiration config are not picked up on
broker restart in Zookeeper mode. Based on the integration test, this does not
apply to KRaft mode.
Adds a broker re
David Mao created KAFKA-14990:
-
Summary: Dynamic producer ID expiration is not applied on broker
restart
Key: KAFKA-14990
URL: https://issues.apache.org/jira/browse/KAFKA-14990
Project: Kafka
Is
hoangphuocbk commented on PR #12371:
URL: https://github.com/apache/kafka/pull/12371#issuecomment-1544342962
@iblislin, I had same problem. Did your solution work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
dajac commented on code in PR #13704:
URL: https://github.com/apache/kafka/pull/13704#discussion_r1191453623
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -365,6 +365,20 @@ public short listOffsetRequestVersion() {
}
}
dajac commented on code in PR #13704:
URL: https://github.com/apache/kafka/pull/13704#discussion_r1191452753
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/RecordHelpersTest.java:
##
@@ -399,8 +403,12 @@ public void testNewCurrentAssignmentTombstoneRecord(
jeffkbkim commented on code in PR #13704:
URL: https://github.com/apache/kafka/pull/13704#discussion_r1191438825
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/RecordHelpersTest.java:
##
@@ -383,4 +398,84 @@ public void testNewCurrentAssignmentTombstoneRec
fvaleri commented on PR #13517:
URL: https://github.com/apache/kafka/pull/13517#issuecomment-1544315826
@showuon thanks for keeping the time to review all these PRs. We should be
good now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
fvaleri commented on code in PR #13517:
URL: https://github.com/apache/kafka/pull/13517#discussion_r1191435518
##
examples/src/main/java/kafka/examples/KafkaConsumerProducerDemo.java:
##
@@ -16,29 +16,59 @@
*/
package kafka.examples;
-import org.apache.kafka.common.errors.T
clolov commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1191430711
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,998 @@
+/*
+ * Licensed to the Apache Software Foundation
clolov commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1191430711
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,998 @@
+/*
+ * Licensed to the Apache Software Foundation
satishd merged PR #13060:
URL: https://github.com/apache/kafka/pull/13060
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
satishd commented on PR #13060:
URL: https://github.com/apache/kafka/pull/13060#issuecomment-1544287256
There were a couple of test failures that are unrelated to this PR, will
merge to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
philipnee commented on code in PR #13678:
URL: https://github.com/apache/kafka/pull/13678#discussion_r1191400253
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -186,6 +187,7 @@ public ConsumerCoordinator(GroupRebalanceConfig
philipnee commented on code in PR #13678:
URL: https://github.com/apache/kafka/pull/13678#discussion_r1191400253
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -186,6 +187,7 @@ public ConsumerCoordinator(GroupRebalanceConfig
philipnee commented on code in PR #13678:
URL: https://github.com/apache/kafka/pull/13678#discussion_r1191400253
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -186,6 +187,7 @@ public ConsumerCoordinator(GroupRebalanceConfig
dajac commented on code in PR #13704:
URL: https://github.com/apache/kafka/pull/13704#discussion_r1191395592
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java:
##
@@ -357,6 +366,94 @@ public static Record newCurrentAssignmentTombstoneRecord
jlprat merged PR #13706:
URL: https://github.com/apache/kafka/pull/13706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
jeffkbkim commented on code in PR #13704:
URL: https://github.com/apache/kafka/pull/13704#discussion_r1191390607
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java:
##
@@ -357,6 +366,94 @@ public static Record newCurrentAssignmentTombstoneRe
philipnee commented on code in PR #13678:
URL: https://github.com/apache/kafka/pull/13678#discussion_r1191387973
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -1223,6 +1233,26 @@ public void maybeAutoCommitOffsetsAsync(long
jlprat commented on PR #13706:
URL: https://github.com/apache/kafka/pull/13706#issuecomment-1544246745
All test failures seem to be unrelated to the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dajac commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1191381128
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,1012 @@
+/*
+ * Licensed to the Apache Software Foundation
jeffkbkim commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1191374954
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/generic/GenericGroupTest.java:
##
@@ -0,0 +1,935 @@
+/*
+ * Licensed to the Apache Software Foun
jeffkbkim commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1191359030
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/generic/GenericGroupTest.java:
##
@@ -0,0 +1,935 @@
+/*
+ * Licensed to the Apache Software Foun
[
https://issues.apache.org/jira/browse/KAFKA-14978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14978:
--
Fix Version/s: 3.4.1
> ExactlyOnceWorkerSourceTask does not remove parent metrics
> --
jeffkbkim commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1191340188
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,998 @@
+/*
+ * Licensed to the Apache Software Foundati
kirktrue commented on code in PR #12685:
URL: https://github.com/apache/kafka/pull/12685#discussion_r1191281659
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1383,9 +1386,13 @@ private ClusterResourceListeners
configureClusterResourceList
jeffkbkim commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1191303709
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,998 @@
+/*
+ * Licensed to the Apache Software Foundati
lanshiqin commented on code in PR #13584:
URL: https://github.com/apache/kafka/pull/13584#discussion_r1191256878
##
core/src/test/scala/unit/kafka/log/LogSegmentTest.scala:
##
@@ -65,6 +68,32 @@ class LogSegmentTest {
Utils.delete(logDir)
}
+ /**
+ * LogSegmentOffse
lanshiqin commented on code in PR #13584:
URL: https://github.com/apache/kafka/pull/13584#discussion_r1191252780
##
core/src/test/scala/unit/kafka/log/LogSegmentTest.scala:
##
@@ -65,6 +68,32 @@ class LogSegmentTest {
Utils.delete(logDir)
}
+ /**
+ * LogSegmentOffse
lanshiqin commented on code in PR #13584:
URL: https://github.com/apache/kafka/pull/13584#discussion_r1191248219
##
core/src/test/scala/unit/kafka/log/LogSegmentTest.scala:
##
@@ -65,6 +68,32 @@ class LogSegmentTest {
Utils.delete(logDir)
}
+ /**
+ * LogSegmentOffse
dajac commented on code in PR #13704:
URL: https://github.com/apache/kafka/pull/13704#discussion_r1191225920
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java:
##
@@ -357,6 +366,94 @@ public static Record newCurrentAssignmentTombstoneRecord
clolov commented on code in PR #13681:
URL: https://github.com/apache/kafka/pull/13681#discussion_r1191109013
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -845,17 +847,16 @@ public void shouldRecycleTasksRemovedFromStateUpdate
dajac commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1191160971
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,967 @@
+/*
+ * Licensed to the Apache Software Foundation (
dengziming commented on PR #13679:
URL: https://github.com/apache/kafka/pull/13679#issuecomment-1543964126
I rerun the failed tests locally and they work correctly, I create a JIRA to
track this problem.
https://issues.apache.org/jira/browse/KAFKA-14989
--
This is an automated message
[
https://issues.apache.org/jira/browse/KAFKA-14989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721762#comment-17721762
]
Deng Ziming commented on KAFKA-14989:
-
https://ci-builds.apache.org/job/Kafka/job/ka
Deng Ziming created KAFKA-14989:
---
Summary: Flaky test TransactionsTest.testFailureToFenceEpoch
Key: KAFKA-14989
URL: https://issues.apache.org/jira/browse/KAFKA-14989
Project: Kafka
Issue Type:
jlprat commented on PR #13706:
URL: https://github.com/apache/kafka/pull/13706#issuecomment-1543873607
Thanks @machi1990 I fixed the typo as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
dajac merged PR #13694:
URL: https://github.com/apache/kafka/pull/13694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
machi1990 commented on PR #12045:
URL: https://github.com/apache/kafka/pull/12045#issuecomment-1543816986
> @machi1990 since you opened a PR to fix this flaky test, you might be
familiar with this part of code. May I request you to review this PR please.
Hey @divijvaidya I am new to K
viktorsomogyi commented on PR #13701:
URL: https://github.com/apache/kafka/pull/13701#issuecomment-1543791889
@vamossagar12 yes, trunk and backports to 3.5 and 3.4 have been merged
already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
viktorsomogyi merged PR #13699:
URL: https://github.com/apache/kafka/pull/13699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.a
viktorsomogyi merged PR #13698:
URL: https://github.com/apache/kafka/pull/13698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.a
Hangleton commented on code in PR #13535:
URL: https://github.com/apache/kafka/pull/13535#discussion_r1190991070
##
core/src/test/java/kafka/log/remote/RemoteLogReaderTest.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * co
[
https://issues.apache.org/jira/browse/KAFKA-14975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew de Detrich updated KAFKA-14975:
---
Parent: KAFKA-7739
Issue Type: Sub-task (was: Task)
> Make TopicBasedRemote
showuon commented on code in PR #13517:
URL: https://github.com/apache/kafka/pull/13517#discussion_r1190888533
##
examples/src/main/java/kafka/examples/KafkaConsumerProducerDemo.java:
##
@@ -16,29 +16,59 @@
*/
package kafka.examples;
-import org.apache.kafka.common.errors.T
akatona84 commented on PR #11565:
URL: https://github.com/apache/kafka/pull/11565#issuecomment-1543645307
thx. rebased again and did som adjustments. (this time I built it and ran my
modified unit tests as well :) )
--
This is an automated message from the Apache Git Service.
To respond t
showuon merged PR #13516:
URL: https://github.com/apache/kafka/pull/13516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #13516:
URL: https://github.com/apache/kafka/pull/13516#issuecomment-1543640638
Failed tests are unrelated:
```
Build / JDK 17 and Scala 2.13 /
org.apache.kafka.common.security.authenticator.SaslAuthenticatorTest.testMultipleServerMechanisms()
Build /
showuon commented on code in PR #13516:
URL: https://github.com/apache/kafka/pull/13516#discussion_r1190880657
##
examples/src/main/java/kafka/examples/ExactlyOnceMessageProcessor.java:
##
@@ -79,111 +86,114 @@ public ExactlyOnceMessageProcessor(final String
inputTopic,
mimaison merged PR #13170:
URL: https://github.com/apache/kafka/pull/13170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
AB027PS commented on PR #12331:
URL: https://github.com/apache/kafka/pull/12331#issuecomment-1543611485
I work with Martin Pelak and he suggested that I add my change to this PR,
but my change is unrelated to the rest of this PR. So this doesn't address the
errors mentioned in the first com
[
https://issues.apache.org/jira/browse/KAFKA-13349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721696#comment-17721696
]
Mahesh Madushan commented on KAFKA-13349:
-
Hello [~guozhang] . While I'm looking
jlprat commented on PR #13706:
URL: https://github.com/apache/kafka/pull/13706#issuecomment-1543608786
@mimaison I took inspiration from your PR to clean up some more unused
methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
jlprat commented on code in PR #13170:
URL: https://github.com/apache/kafka/pull/13170#discussion_r1190857226
##
core/src/test/scala/unit/kafka/utils/CoreUtilsTest.scala:
##
@@ -223,7 +204,7 @@ class CoreUtilsTest extends Logging {
val map = new ConcurrentHashMap[Int, Atomi
jlprat opened a new pull request, #13706:
URL: https://github.com/apache/kafka/pull/13706
Inspired by https://github.com/apache/kafka/pull/13170 I decided to check
some other core utils classes and remove some unused methods.
### Committer Checklist (excluded from commit message)
-
mimaison commented on code in PR #13170:
URL: https://github.com/apache/kafka/pull/13170#discussion_r1190855504
##
core/src/test/scala/unit/kafka/utils/CoreUtilsTest.scala:
##
@@ -223,7 +204,7 @@ class CoreUtilsTest extends Logging {
val map = new ConcurrentHashMap[Int, Ato
[
https://issues.apache.org/jira/browse/KAFKA-14988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-14988:
-
Fix Version/s: 3.6.0
> Upgrade scalaCollectionCompact to v2.9 for CVE-2022-36944
> -
[
https://issues.apache.org/jira/browse/KAFKA-14988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-14988:
-
Description:
Current version of ScalaCollectionCompact library in trunk 2.6.0 suffers from a
cr
[
https://issues.apache.org/jira/browse/KAFKA-14988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721691#comment-17721691
]
Divij Vaidya edited comment on KAFKA-14988 at 5/11/23 8:46 AM:
---
[
https://issues.apache.org/jira/browse/KAFKA-14988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721691#comment-17721691
]
Divij Vaidya commented on KAFKA-14988:
--
Fixed by [https://github.com/apache/kafka/p
Hangleton commented on PR #12331:
URL: https://github.com/apache/kafka/pull/12331#issuecomment-1543590907
Hi Julius (@AB027PS) - just to clarify, this isn't the same as the
`AccessDeniedException` addressed by this CR right?
--
This is an automated message from the Apache Git Service.
To
divijvaidya commented on PR #12045:
URL: https://github.com/apache/kafka/pull/12045#issuecomment-1543589903
@machi1990 since you opened a PR to fix this flaky test, you might be
familiar with this part of code. May I request you to review this PR please.
--
This is an automated message fr
Divij Vaidya created KAFKA-14988:
Summary: Upgrade scalaCollectionCompact to v2.9 for CVE-2022-36944
Key: KAFKA-14988
URL: https://issues.apache.org/jira/browse/KAFKA-14988
Project: Kafka
Iss
1 - 100 of 111 matches
Mail list logo
