machi1990 commented on PR #12045:
URL: https://github.com/apache/kafka/pull/12045#issuecomment-1543816986

   > @machi1990 since you opened a PR to fix this flaky test, you might be 
familiar with this part of code. May I request you to review this PR please.
   
   Hey @divijvaidya I am new to Kafka and to this part of the code. It'll be 
good to get another round of reviews from committers since some of them have 
started to have a look at this PR. My attempt to fix the the flaky test in 
https://github.com/apache/kafka/pull/13702 was by slightly modifying the 
assertions which was more of having a quick win and stabilize the test. While 
this PR attempts to sort out the underlying issue with quota computation. I 
think it'll be good to get more eyes on the PR as suggested by 
https://github.com/apache/kafka/pull/12045#pullrequestreview-1004087364 and  
https://github.com/apache/kafka/pull/12045#pullrequestreview-959047597 what do 
you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to