[
https://issues.apache.org/jira/browse/KAFKA-14691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-14691:
Description:
The goal of this jira is to implement the version 9 of the OffsetFetch API as
descri
[
https://issues.apache.org/jira/browse/KAFKA-14690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-14690:
Description:
The goal of this jira is to implement the version 9 of the OffsetCommit API as
descr
David Jacot created KAFKA-14691:
---
Summary: OffsetFetch API Version 9
Key: KAFKA-14691
URL: https://issues.apache.org/jira/browse/KAFKA-14691
Project: Kafka
Issue Type: Sub-task
Repo
David Jacot created KAFKA-14690:
---
Summary: OffsetCommit API Version 9
Key: KAFKA-14690
URL: https://issues.apache.org/jira/browse/KAFKA-14690
Project: Kafka
Issue Type: Sub-task
Rep
fvaleri commented on PR #13216:
URL: https://github.com/apache/kafka/pull/13216#issuecomment-1422141061
Hi @scholzj, thanks. I think this is not needed anymore, but we should
probably keep the system tests aligned:
`tests/kafkatest/services/templates/connect_log4j.properties`.
--
This is
[
https://issues.apache.org/jira/browse/KAFKA-14401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sagar Rao updated KAFKA-14401:
--
Labels: (was: KafkaConnect)
> Connector/Tasks reading offsets can get stuck if underneath WorkThread
[
https://issues.apache.org/jira/browse/KAFKA-14401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sagar Rao updated KAFKA-14401:
--
Component/s: KafkaConnect
> Connector/Tasks reading offsets can get stuck if underneath WorkThread die
[
https://issues.apache.org/jira/browse/KAFKA-14401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sagar Rao updated KAFKA-14401:
--
Labels: KafkaConnect (was: Connect)
> Connector/Tasks reading offsets can get stuck if underneath Wor
[
https://issues.apache.org/jira/browse/KAFKA-14401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sagar Rao updated KAFKA-14401:
--
Labels: Connect (was: )
> Connector/Tasks reading offsets can get stuck if underneath WorkThread dies
[
https://issues.apache.org/jira/browse/KAFKA-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-14660:
Fix Version/s: 3.4.1
> Divide by zero security vulnerability (sonatype-2019-0422)
> --
mjsax commented on PR #13175:
URL: https://github.com/apache/kafka/pull/13175#issuecomment-1422045815
Cherry-picked to `3.4` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
mattwong949 commented on code in PR #13206:
URL: https://github.com/apache/kafka/pull/13206#discussion_r1099642781
##
core/src/main/java/kafka/server/ReplicaFetcherTierStateMachine.java:
##
@@ -0,0 +1,246 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
mattwong949 commented on code in PR #13206:
URL: https://github.com/apache/kafka/pull/13206#discussion_r1099642781
##
core/src/main/java/kafka/server/ReplicaFetcherTierStateMachine.java:
##
@@ -0,0 +1,246 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
mattwong949 commented on code in PR #13206:
URL: https://github.com/apache/kafka/pull/13206#discussion_r1099641934
##
core/src/main/java/kafka/server/ReplicaFetcherTierStateMachine.java:
##
@@ -0,0 +1,246 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
mattwong949 commented on code in PR #13206:
URL: https://github.com/apache/kafka/pull/13206#discussion_r1099635815
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -400,12 +386,7 @@ abstract class AbstractFetcherThread(name: String,
case Er
satishd commented on code in PR #13046:
URL: https://github.com/apache/kafka/pull/13046#discussion_r1099624434
##
storage/src/main/java/org/apache/kafka/server/log/internals/LeaderEpochCheckpoint.java:
##
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
satishd merged PR #13213:
URL: https://github.com/apache/kafka/pull/13213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
satishd commented on PR #13213:
URL: https://github.com/apache/kafka/pull/13213#issuecomment-1421954683
Test failure is not related to this change, will merge the changes to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
ijuma opened a new pull request, #13218:
URL: https://github.com/apache/kafka/pull/13218
The remote index classes use `LazyIndex`, but immediately force
materialization. This results in more verbose code and it's misleading
since the indexes are not lazily used in practice.
Also
[
https://issues.apache.org/jira/browse/KAFKA-14689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deng Ziming resolved KAFKA-14689.
-
Resolution: Duplicate
This is the same with KAFKA-14273
> Kafka won't start on Windows in KRaft
[
https://issues.apache.org/jira/browse/KAFKA-14687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Toumi resolved KAFKA-14687.
-
Resolution: Fixed
I see that was fixed at this revision number :
d2556e02a25af28cf4cc093a190cc0
[
https://issues.apache.org/jira/browse/KAFKA-14687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685610#comment-17685610
]
Ahmed Toumi edited comment on KAFKA-14687 at 2/7/23 11:33 PM:
vcrfxia commented on code in PR #13188:
URL: https://github.com/apache/kafka/pull/13188#discussion_r1099321787
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java:
##
@@ -0,0 +1,792 @@
+/*
+ * Licensed to the Apache Software Foundation (A
philipnee opened a new pull request, #13217:
URL: https://github.com/apache/kafka/pull/13217
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testi
guozhangwang commented on PR #13025:
URL: https://github.com/apache/kafka/pull/13025#issuecomment-1421340480
I do not have further comments. @cadonna do you want to take a final look?
If not I can go ahead and merge it.
--
This is an automated message from the Apache Git Service.
To respo
philipnee commented on PR #13021:
URL: https://github.com/apache/kafka/pull/13021#issuecomment-1421340357
much thanks @guozhangwang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
scholzj opened a new pull request, #13216:
URL: https://github.com/apache/kafka/pull/13216
The `connect-log4j.properties` file configures the log level for the
ZooKeeper logger. That seems unnecessary since Kafka Connect does not use
ZooKeeper directly in any way. This PR removes it from th
guozhangwang commented on PR #13179:
URL: https://github.com/apache/kafka/pull/13179#issuecomment-1421336158
Merged to trunk after updating the javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
guozhangwang merged PR #13179:
URL: https://github.com/apache/kafka/pull/13179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
guozhangwang commented on PR #13021:
URL: https://github.com/apache/kafka/pull/13021#issuecomment-1421334205
Made another look, LGTM. Leaving for @hachikuji for a final look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
guozhangwang commented on code in PR #13021:
URL: https://github.com/apache/kafka/pull/13021#discussion_r1096350392
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software Founda
mjsax merged PR #13209:
URL: https://github.com/apache/kafka/pull/13209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac commented on PR #12813:
URL: https://github.com/apache/kafka/pull/12813#issuecomment-1421316241
@guozhangwang Thanks. I will do this tomorrow. In the mean time, I have
re-triggered the CI as they were multiple failures.
--
This is an automated message from the Apache Git Service.
To
dajac commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1099087860
##
core/src/test/scala/unit/kafka/server/ApiVersionsRequestTest.scala:
##
@@ -44,6 +44,13 @@ class ApiVersionsRequestTest(cluster: ClusterInstance)
extends AbstractApiVe
guozhangwang commented on PR #12813:
URL: https://github.com/apache/kafka/pull/12813#issuecomment-1421307753
I made another pass and it LGTM now. leaving to @dajac for a final look and
merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
guozhangwang commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1099085546
##
core/src/test/scala/unit/kafka/server/ApiVersionsRequestTest.scala:
##
@@ -44,6 +44,13 @@ class ApiVersionsRequestTest(cluster: ClusterInstance)
extends Abstra
dajac commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1099084820
##
generator/src/main/java/org/apache/kafka/message/ApiMessageTypeGenerator.java:
##
@@ -408,6 +410,23 @@ private void generateListenerTypesEnum() {
buffer.print
[
https://issues.apache.org/jira/browse/KAFKA-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-14648:
-
Assignee: Philip Nee (was: Kirk True)
> Do not fail clients if bootstrap servers is not immedi
guozhangwang commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1099081262
##
clients/src/main/resources/common/message/ConsumerGroupHeartbeatRequest.json:
##
@@ -0,0 +1,66 @@
+// Licensed to the Apache Software Foundation (ASF) under one
hachikuji commented on code in PR #13207:
URL: https://github.com/apache/kafka/pull/13207#discussion_r1099065953
##
raft/src/main/java/org/apache/kafka/raft/internals/KafkaRaftMetrics.java:
##
@@ -133,26 +131,27 @@ public KafkaRaftMetrics(Metrics metrics, String
metricGrpPrefix
[
https://issues.apache.org/jira/browse/KAFKA-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-14648:
-
Assignee: Kirk True
> Do not fail clients if bootstrap servers is not immediately resolvable
>
hachikuji commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1099052637
##
generator/src/main/java/org/apache/kafka/message/ApiMessageTypeGenerator.java:
##
@@ -408,6 +410,23 @@ private void generateListenerTypesEnum() {
buffer.p
[
https://issues.apache.org/jira/browse/KAFKA-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685418#comment-17685418
]
Kirk True edited comment on KAFKA-14648 at 2/7/23 6:30 PM:
---
Wo
[
https://issues.apache.org/jira/browse/KAFKA-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685418#comment-17685418
]
Kirk True edited comment on KAFKA-14648 at 2/7/23 6:29 PM:
---
Wo
[
https://issues.apache.org/jira/browse/KAFKA-14648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685418#comment-17685418
]
Kirk True commented on KAFKA-14648:
---
Would a fix for this cover the case where
`Clien
kirktrue commented on PR #13211:
URL: https://github.com/apache/kafka/pull/13211#issuecomment-1421255523
@rajinisivaram - LGTM.
It took me a second to verify that the `configs` that was passed into the
`LoginMetadata ` wasn't being used directly in the `hashCode` and `equals`
methods
jsancio commented on code in PR #13207:
URL: https://github.com/apache/kafka/pull/13207#discussion_r1098994575
##
raft/src/main/java/org/apache/kafka/raft/internals/KafkaRaftMetrics.java:
##
@@ -133,26 +131,27 @@ public KafkaRaftMetrics(Metrics metrics, String
metricGrpPrefix,
fvaleri commented on PR #13215:
URL: https://github.com/apache/kafka/pull/13215#issuecomment-1421199547
@mimaison @OmniaGM @clolov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
fvaleri opened a new pull request, #13215:
URL: https://github.com/apache/kafka/pull/13215
```sh
=== test data
bin/kafka-producer-perf-test.sh --num-records 3 --record-size 1000
--throughput 200 --topic my-topic --producer-props bootstrap.servers=:9092
linger.ms=0 batch.size=16384
guozhangwang commented on PR #13125:
URL: https://github.com/apache/kafka/pull/13125#issuecomment-1421133959
@yufeiyan1220 just following up on this PR. Do you want to address the
latest comment, I'm thinking if we can just move `throttleTimeSensor` to the
Selector while keeping its group n
dajac commented on PR #12972:
URL: https://github.com/apache/kafka/pull/12972#issuecomment-1421105810
@hachikuji Thanks for your review. I have addressed your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
mimaison merged PR #13210:
URL: https://github.com/apache/kafka/pull/13210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-14689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kedar Joshi updated KAFKA-14689:
Description:
Kafka 3.4 is unable to start in KRaft mode on Windows 10.
Kafka is started in Kafka
Kedar Joshi created KAFKA-14689:
---
Summary: Kafka won't start on Windows in KRaft mode
Key: KAFKA-14689
URL: https://issues.apache.org/jira/browse/KAFKA-14689
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-14484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Dupriez reassigned KAFKA-14484:
-
Assignee: Alexandre Dupriez
> Move UnifiedLog to storage module
> -
[
https://issues.apache.org/jira/browse/KAFKA-14482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Dupriez reassigned KAFKA-14482:
-
Assignee: Alexandre Dupriez
> Move LogLoader to storage module
> --
mimaison commented on PR #12366:
URL: https://github.com/apache/kafka/pull/12366#issuecomment-1421014723
Thanks Chris for the quick reply! I'll take a look this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
[
https://issues.apache.org/jira/browse/KAFKA-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Dupriez reassigned KAFKA-14579:
-
Assignee: Alexandre Dupriez
> Move DumpLogSegments to tools
> -
C0urante commented on PR #12366:
URL: https://github.com/apache/kafka/pull/12366#issuecomment-1421008599
@mimaison Thanks, I've rebased. I've also removed the changes to the offset
sync semaphore since https://github.com/apache/kafka/pull/13181 should obviate
them.
--
This is an automate
[
https://issues.apache.org/jira/browse/KAFKA-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685366#comment-17685366
]
Alexandre Dupriez commented on KAFKA-14593:
---
Thanks for following-up. I picke
Hangleton opened a new pull request, #13214:
URL: https://github.com/apache/kafka/pull/13214
Code move for the `consoleProducer` as part of KAFKA-14525 - Move CLI tools
from `core` to `tools` module. The copy is as identical as possible as the
original class and provides iso-functionality.
jeqo commented on code in PR #13177:
URL: https://github.com/apache/kafka/pull/13177#discussion_r1096076032
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/common/metrics/SensorBenchmark.java:
##
@@ -0,0 +1,145 @@
+package org.apache.kafka.jmh.common.metrics;
+
+import org.
[
https://issues.apache.org/jira/browse/KAFKA-14675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-14675:
--
Reviewer: Jason Gustafson
> Extract metadata-related tasks from Fetcher into MetadataFetcher
> ---
[
https://issues.apache.org/jira/browse/KAFKA-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685353#comment-17685353
]
Kirk True commented on KAFKA-14317:
---
[~dajac] could you take another look at the PR? T
kirktrue commented on code in PR #12813:
URL: https://github.com/apache/kafka/pull/12813#discussion_r1098825578
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##
@@ -549,7 +549,13 @@ private boolean awaitNodeReady(Node node,
FindCoordinatorReq
divijvaidya commented on code in PR #13212:
URL: https://github.com/apache/kafka/pull/13212#discussion_r1098802862
##
clients/src/main/java/org/apache/kafka/clients/admin/AlterClientQuotasOptions.java:
##
@@ -19,6 +19,8 @@
import org.apache.kafka.common.annotation.InterfaceSt
mimaison commented on code in PR #13195:
URL: https://github.com/apache/kafka/pull/13195#discussion_r1098805966
##
docs/upgrade.html:
##
@@ -19,6 +19,16 @@
C0urante commented on PR #13191:
URL: https://github.com/apache/kafka/pull/13191#issuecomment-1420949503
@clolov I've provided some information on that front in the description for
[the ticket I linked](https://issues.apache.org/jira/browse/KAFKA-14682).
TL;DR: I believe it's because we use
clolov commented on PR #13191:
URL: https://github.com/apache/kafka/pull/13191#issuecomment-1420944086
> It's also worth noting that there are unused stubbings in some of these
tests, which should be failing the build but are not at the moment due to
[KAFKA-14682](https://issues.apache.org/
dajac commented on code in PR #13196:
URL: https://github.com/apache/kafka/pull/13196#discussion_r1098775244
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -334,6 +334,29 @@ class ReplicaManager(val config: KafkaConfig,
topicPartitions.foreach(tp =>
delaye
clolov commented on PR #13122:
URL: https://github.com/apache/kafka/pull/13122#issuecomment-1420901116
Heya @fvaleri, I hope I have addressed all your comments.
Unless I am wrong, the only difference between the two outputs is that in
the old the error was
```
"error": null
```
satishd commented on PR #13213:
URL: https://github.com/apache/kafka/pull/13213#issuecomment-1420880690
Thanks @ijuma for your review. spotBugs task is fixed with the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
ijuma commented on code in PR #13213:
URL: https://github.com/apache/kafka/pull/13213#discussion_r1098706079
##
storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java:
##
@@ -64,8 +65,7 @@ private enum SearchResultType {
*/
private volatile in
satishd commented on code in PR #13213:
URL: https://github.com/apache/kafka/pull/13213#discussion_r1098698848
##
storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java:
##
@@ -64,8 +65,7 @@ private enum SearchResultType {
*/
private volatile
satishd commented on code in PR #13213:
URL: https://github.com/apache/kafka/pull/13213#discussion_r1098698848
##
storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java:
##
@@ -64,8 +65,7 @@ private enum SearchResultType {
*/
private volatile
satishd commented on code in PR #13213:
URL: https://github.com/apache/kafka/pull/13213#discussion_r1098698848
##
storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java:
##
@@ -64,8 +65,7 @@ private enum SearchResultType {
*/
private volatile
dajac commented on code in PR #13203:
URL: https://github.com/apache/kafka/pull/13203#discussion_r1098693395
##
group-coordinator/src/main/resources/common/message/ConsumerGroupPartitionMetadataValue.json:
##
@@ -0,0 +1,30 @@
+// Licensed to the Apache Software Foundation (ASF)
dajac commented on code in PR #13203:
URL: https://github.com/apache/kafka/pull/13203#discussion_r1098691309
##
group-coordinator/src/main/resources/common/message/ConsumerGroupCurrentMemberAssignmentKey.json:
##
@@ -0,0 +1,26 @@
+// Licensed to the Apache Software Foundation (A
dajac commented on code in PR #13203:
URL: https://github.com/apache/kafka/pull/13203#discussion_r1098689954
##
group-coordinator/src/main/resources/common/message/ConsumerGroupCurrentMemberAssignmentKey.json:
##
@@ -0,0 +1,26 @@
+// Licensed to the Apache Software Foundation (A
dajac commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1098685000
##
core/src/test/scala/unit/kafka/server/ApiVersionManagerTest.scala:
##
@@ -40,10 +40,15 @@ class ApiVersionManagerTest {
listenerType = apiScope,
forwardi
dajac commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1098684544
##
clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java:
##
@@ -212,6 +215,36 @@ public boolean isVersionSupported(short apiVersion) {
return apiV
lucasbru commented on code in PR #13025:
URL: https://github.com/apache/kafka/pull/13025#discussion_r1097298086
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1534,7 +1540,13 @@ Set standbyTaskIds() {
Map allTasks() {
ijuma commented on code in PR #13213:
URL: https://github.com/apache/kafka/pull/13213#discussion_r1098655061
##
storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java:
##
@@ -64,8 +65,7 @@ private enum SearchResultType {
*/
private volatile in
clolov commented on PR #13212:
URL: https://github.com/apache/kafka/pull/13212#issuecomment-1420762600
```
[2023-02-07T11:33:01.745Z] > Task :clients:compileJava
[2023-02-07T11:33:01.745Z]
/home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-13212/clients/src/main/java/org/apach
urbandan commented on PR #13163:
URL: https://github.com/apache/kafka/pull/13163#issuecomment-1420758683
@C0urante Thanks for the comments, addressed them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
dajac commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1098642239
##
generator/src/main/java/org/apache/kafka/message/RequestApiStabilityType.java:
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
dajac commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1098641948
##
generator/src/main/java/org/apache/kafka/message/MessageSpec.java:
##
@@ -70,6 +74,12 @@ public MessageSpec(@JsonProperty("name") String name,
"messag
dajac commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1098634689
##
core/src/main/scala/kafka/server/ApiVersionManager.scala:
##
@@ -45,55 +45,70 @@ object ApiVersionManager {
listenerType,
forwardingManager,
suppo
dajac commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1098634292
##
clients/src/main/resources/common/message/ConsumerGroupHeartbeatResponse.json:
##
@@ -0,0 +1,70 @@
+// Licensed to the Apache Software Foundation (ASF) under one or mo
dajac commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1098633270
##
clients/src/main/resources/common/message/ConsumerGroupHeartbeatResponse.json:
##
@@ -0,0 +1,70 @@
+// Licensed to the Apache Software Foundation (ASF) under one or mo
dajac commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1098630635
##
clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java:
##
@@ -212,6 +215,36 @@ public boolean isVersionSupported(short apiVersion) {
return apiV
dajac commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1098628288
##
clients/src/main/java/org/apache/kafka/common/errors/FencedMemberEpochException.java:
##
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
dajac commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1098623901
##
core/src/main/scala/kafka/server/ControllerApis.scala:
##
@@ -322,15 +325,37 @@ class ControllerApis(val requestChannel: RequestChannel,
}
}
showuon commented on PR #13099:
URL: https://github.com/apache/kafka/pull/13099#issuecomment-1420692624
@ijuma @tombentley @clolov , I've updated the PR to throw exception when
overflowed. Please take a look again. Thank you.
--
This is an automated message from the Apache Git Service.
To
showuon commented on code in PR #13099:
URL: https://github.com/apache/kafka/pull/13099#discussion_r1098593520
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1496,4 +1496,32 @@ public static String replaceSuffix(String str, String
oldSuffix, String ne
showuon commented on code in PR #13099:
URL: https://github.com/apache/kafka/pull/13099#discussion_r1098593071
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1496,4 +1496,32 @@ public static String replaceSuffix(String str, String
oldSuffix, String ne
satishd commented on code in PR #13213:
URL: https://github.com/apache/kafka/pull/13213#discussion_r1098558585
##
storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java:
##
@@ -64,8 +65,7 @@ private enum SearchResultType {
*/
private volatile
satishd opened a new pull request, #13213:
URL: https://github.com/apache/kafka/pull/13213
KAFKA-14688 Move package org.apache.kafka.server.log.internals to
org.apache.kafka.storage.internals.log
This is a followup item from https://github.com/apache/kafka/pull/13046 with
the [commen
[
https://issues.apache.org/jira/browse/KAFKA-14688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated KAFKA-14688:
---
Description: This is a followup item from
https://github.com/apache/kafka/pull/13046 with th
Satish Duggana created KAFKA-14688:
--
Summary: Move org.apache.kafka.server.log.internals to
org.apache.kafka.storage.internals.log
Key: KAFKA-14688
URL: https://issues.apache.org/jira/browse/KAFKA-14688
1 - 100 of 123 matches
Mail list logo
