ijuma commented on code in PR #13056:
URL: https://github.com/apache/kafka/pull/13056#discussion_r1059261768
##
core/src/main/scala/kafka/utils/Throttler.scala:
##
@@ -83,6 +86,17 @@ class Throttler(@volatile var desiredRatePerSec: Double,
def updateDesiredRatePerSec(updatedD
ijuma commented on code in PR #13056:
URL: https://github.com/apache/kafka/pull/13056#discussion_r1059261143
##
core/src/main/scala/kafka/utils/Throttler.scala:
##
@@ -27,32 +27,35 @@ import scala.math._
/**
* A class to measure and throttle the rate of some process. The th
ijuma commented on code in PR #13056:
URL: https://github.com/apache/kafka/pull/13056#discussion_r1059260869
##
core/src/main/scala/kafka/utils/Throttler.scala:
##
@@ -83,6 +86,17 @@ class Throttler(@volatile var desiredRatePerSec: Double,
def updateDesiredRatePerSec(updatedD
ijuma commented on code in PR #13056:
URL: https://github.com/apache/kafka/pull/13056#discussion_r1059260700
##
core/src/main/scala/kafka/utils/Throttler.scala:
##
@@ -27,32 +27,35 @@ import scala.math._
/**
* A class to measure and throttle the rate of some process. The th
[
https://issues.apache.org/jira/browse/KAFKA-14558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated KAFKA-14558:
---
Description: Move LastRecord, TxnMetadata, BatchMetadata,
ProducerStateEntry, and ProducerAp
Satish Duggana created KAFKA-14558:
--
Summary: Move LastRecord, TxnMetadata, BatchMetadata,
ProducerStateEntry, and ProducerAppendInfo to the storage module.
Key: KAFKA-14558
URL: https://issues.apache.org/jira/br
[
https://issues.apache.org/jira/browse/KAFKA-14551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated KAFKA-14551:
---
Fix Version/s: 3.5.0
> Move LeaderEpochFileCache to storage module
> ---
[
https://issues.apache.org/jira/browse/KAFKA-14550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated KAFKA-14550:
---
Fix Version/s: 3.5.0
> MoveSnapshotFile and CorruptSnapshotException to storage module
> ---
satishd commented on PR #13039:
URL: https://github.com/apache/kafka/pull/13039#issuecomment-1367740483
@ijuma These changes are updated with the latest trunk and resolved the
conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kamalcph commented on code in PR #13059:
URL: https://github.com/apache/kafka/pull/13059#discussion_r1059249655
##
core/src/main/scala/kafka/admin/ConfigCommand.scala:
##
@@ -580,7 +580,7 @@ object ConfigCommand extends Logging {
.filter(entry => configSourceFilter match
kamalcph commented on PR #13059:
URL: https://github.com/apache/kafka/pull/13059#issuecomment-1367737942
@showuon @chia7712
Please take a look when you get a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
kamalcph opened a new pull request, #13059:
URL: https://github.com/apache/kafka/pull/13059
Side fix: Print the topic/broker/broker-loggers configurations in
alphabetical/sorted order. This will be useful when the user supplies the
'--all' flag.
### Committer Checklist (excluded from
[
https://issues.apache.org/jira/browse/KAFKA-14498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-14498:
---
Fix Version/s: 3.4.0
(was: 3.5.0)
> flaky org.apache.
ableegoldman commented on PR #13016:
URL: https://github.com/apache/kafka/pull/13016#issuecomment-1367736649
@showuon yes, thanks, I'll backport it to 3.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
satishd commented on code in PR #13046:
URL: https://github.com/apache/kafka/pull/13046#discussion_r1059247572
##
core/src/main/scala/kafka/server/checkpoints/OffsetCheckpointFile.scala:
##
@@ -62,12 +62,17 @@ trait OffsetCheckpoint {
* -checkpoint file end--
*/
satishd commented on code in PR #13046:
URL: https://github.com/apache/kafka/pull/13046#discussion_r1059039639
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -995,11 +994,12 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
}
- def latestEpoch: Optio
showuon commented on code in PR #13050:
URL: https://github.com/apache/kafka/pull/13050#discussion_r1059246945
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -432,8 +432,8 @@ private Throwable handleEventException(String name,
ableegoldman commented on PR #12988:
URL: https://github.com/apache/kafka/pull/12988#issuecomment-1367733438
Ah, yeah, sorry -- it's `partitioner.class`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/KAFKA-13295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653025#comment-17653025
]
A. Sophie Blee-Goldman commented on KAFKA-13295:
[~mjsax] unfortunately
[
https://issues.apache.org/jira/browse/KAFKA-13295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-13295:
---
Fix Version/s: 3.5.0
> Long restoration times for new tasks can lead to tran
[
https://issues.apache.org/jira/browse/KAFKA-14555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653024#comment-17653024
]
A. Sophie Blee-Goldman commented on KAFKA-14555:
[~gharris1727] can you
[
https://issues.apache.org/jira/browse/KAFKA-14404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653022#comment-17653022
]
A. Sophie Blee-Goldman commented on KAFKA-14404:
[~sujayopensource] tha
[
https://issues.apache.org/jira/browse/KAFKA-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653021#comment-17653021
]
A. Sophie Blee-Goldman commented on KAFKA-14459:
[~sujayopensource] go f
ableegoldman commented on code in PR #12985:
URL: https://github.com/apache/kafka/pull/12985#discussion_r1059241223
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java:
##
@@ -159,7 +159,8 @@ public void send(final String topic,
[
https://issues.apache.org/jira/browse/KAFKA-14419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653017#comment-17653017
]
A. Sophie Blee-Goldman commented on KAFKA-14419:
Hm. Could you try and r
[
https://issues.apache.org/jira/browse/KAFKA-13602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman resolved KAFKA-13602.
Resolution: Fixed
> Allow to broadcast a result record
> -
[
https://issues.apache.org/jira/browse/KAFKA-13602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-13602:
---
Fix Version/s: 3.4.0
(was: 3.5.0)
> Allow to broadcas
dengziming commented on code in PR #13058:
URL: https://github.com/apache/kafka/pull/13058#discussion_r1059224316
##
core/src/test/scala/unit/kafka/raft/RaftManagerTest.scala:
##
@@ -81,25 +100,99 @@ class RaftManagerTest {
)
}
- @Test
- def testNodeIdPresentIfBroker
dengziming commented on code in PR #13050:
URL: https://github.com/apache/kafka/pull/13050#discussion_r1059223359
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -432,8 +432,8 @@ private Throwable handleEventException(String name,
jsancio opened a new pull request, #13058:
URL: https://github.com/apache/kafka/pull/13058
This change makes sure that Kafka grabs a log dir lock in the following
additional cases:
1. When a Kafka node runs in controller only. The current implementation
doesn't grab a file lock becau
mjsax commented on code in PR #12742:
URL: https://github.com/apache/kafka/pull/12742#discussion_r1059135143
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -737,6 +737,91 @@ public synchronized Topology addStateStore(final
StoreBuilder storeBuilder,
mjsax commented on code in PR #12740:
URL: https://github.com/apache/kafka/pull/12740#discussion_r1059149907
##
streams/src/test/java/org/apache/kafka/test/MockProcessor.java:
##
@@ -41,16 +44,16 @@ public MockProcessor() {
delegate = new MockApiProcessor<>();
}
José Armando García Sancio created KAFKA-14557:
--
Summary: Missing .lock file when using metadata.log.dir
Key: KAFKA-14557
URL: https://issues.apache.org/jira/browse/KAFKA-14557
Project: Ka
mjsax commented on PR #13055:
URL: https://github.com/apache/kafka/pull/13055#issuecomment-1367480412
Cherry-picked this commit to `3.4` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
mjsax commented on PR #13055:
URL: https://github.com/apache/kafka/pull/13055#issuecomment-1367472851
Thanks for the quick fix! -- And sorry for breaking `trunk` -- I did some
catchup work on the backlog and it was a somewhat older PR that I merged...
--
This is an automated message from
[
https://issues.apache.org/jira/browse/KAFKA-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sujay Hegde reassigned KAFKA-14459:
---
Assignee: Sujay Hegde
> Document how to use and close a 'Statistics' in the example
> Rock
[
https://issues.apache.org/jira/browse/KAFKA-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652897#comment-17652897
]
Sujay Hegde commented on KAFKA-14459:
-
Hi [~ableegoldman] ,
Would be taking up this
emilnkrastev commented on PR #11818:
URL: https://github.com/apache/kafka/pull/11818#issuecomment-1367459349
@C0urante your assessment of the goal is correct - the PR changes are aiming
to allow syncs to take place where they should be.
I believe there are 2 different problems - one t
vvcephei commented on PR #13021:
URL: https://github.com/apache/kafka/pull/13021#issuecomment-1367452673
Thanks @philipnee !
I just made a quick pass. I'm sorry; I haven't been keeping up with the
progress of your project, so I'm a little hazy on the details.
It looks like the
[
https://issues.apache.org/jira/browse/KAFKA-14404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sujay Hegde reassigned KAFKA-14404:
---
Assignee: Sujay Hegde
> Fix & update docs on client configs controlled by Streams
> ---
[
https://issues.apache.org/jira/browse/KAFKA-14404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652894#comment-17652894
]
Sujay Hegde commented on KAFKA-14404:
-
Hi [~ableegoldman] ,
Would be taking up this
C0urante commented on PR #11818:
URL: https://github.com/apache/kafka/pull/11818#issuecomment-1367408152
Thanks for this fix, @emilnkrastev. I want to make sure I understand the
goal here before commenting on the actual code changes (although I've made sure
to read through them carefully).
ijuma commented on PR #13055:
URL: https://github.com/apache/kafka/pull/13055#issuecomment-1367399294
@satishd please include the reviewers line in the commit message when
merging. Thanks for the fix!
--
This is an automated message from the Apache Git Service.
To respond to the message,
rubin55 opened a new pull request, #13057:
URL: https://github.com/apache/kafka/pull/13057
KAFKA-9710 documents a failure on Windows systems when Kafka is installed on
a path with spaces (which is common - like `C:\Program Files` for example).
This PR removes the erroneous quotes arou
[
https://issues.apache.org/jira/browse/KAFKA-12558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reassigned KAFKA-12558:
-
Assignee: (was: Ryanne Dolan)
> MM2 may not sync partition offsets correctly
>
satishd merged PR #13055:
URL: https://github.com/apache/kafka/pull/13055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
satishd commented on PR #13055:
URL: https://github.com/apache/kafka/pull/13055#issuecomment-1367237655
Thanks @omkreddy reviewing the PR. Few failed tests do not seem to be
related to these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message,
showuon commented on code in PR #13056:
URL: https://github.com/apache/kafka/pull/13056#discussion_r1058814688
##
core/src/main/scala/kafka/utils/Throttler.scala:
##
@@ -83,6 +86,17 @@ class Throttler(@volatile var desiredRatePerSec: Double,
def updateDesiredRatePerSec(update
[
https://issues.apache.org/jira/browse/KAFKA-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-14556:
--
Summary: log cleaner throttler start time is wrong when 1st run (was: log
cleaner throttler start tim
[
https://issues.apache.org/jira/browse/KAFKA-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-14556:
-
Assignee: Luke Chen
> log cleaner throttler start time is correct
> ---
showuon commented on code in PR #13056:
URL: https://github.com/apache/kafka/pull/13056#discussion_r1058811334
##
core/src/main/scala/kafka/utils/Throttler.scala:
##
@@ -70,7 +73,7 @@ class Throttler(@volatile var desiredRatePerSec: Double,
val elapsedMs = TimeUnit.NA
showuon commented on code in PR #13056:
URL: https://github.com/apache/kafka/pull/13056#discussion_r1058810948
##
core/src/main/scala/kafka/utils/Throttler.scala:
##
@@ -27,32 +27,35 @@ import scala.math._
/**
* A class to measure and throttle the rate of some process. The
showuon commented on code in PR #13056:
URL: https://github.com/apache/kafka/pull/13056#discussion_r1058810732
##
core/src/main/scala/kafka/utils/Throttler.scala:
##
@@ -27,32 +27,35 @@ import scala.math._
/**
* A class to measure and throttle the rate of some process. The
showuon commented on code in PR #13056:
URL: https://github.com/apache/kafka/pull/13056#discussion_r1058810135
##
core/src/main/scala/kafka/utils/Throttler.scala:
##
@@ -27,32 +27,35 @@ import scala.math._
/**
* A class to measure and throttle the rate of some process. The
showuon commented on code in PR #13056:
URL: https://github.com/apache/kafka/pull/13056#discussion_r1058809664
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -413,21 +408,25 @@ class LogCleaner(initialConfig: CleanerConfig,
def recordStats(id: Int, name: String, f
showuon opened a new pull request, #13056:
URL: https://github.com/apache/kafka/pull/13056
Log cleaner throttler will do throttling check very 300ms. The expected
throttling work is like this:
disk IO operation for 300ms -> check if throttling is needed (sleep to slow
down the IO) ->
Luke Chen created KAFKA-14556:
-
Summary: log cleaner throttler start time is correct
Key: KAFKA-14556
URL: https://issues.apache.org/jira/browse/KAFKA-14556
Project: Kafka
Issue Type: Bug
57 matches
Mail list logo
