ableegoldman commented on code in PR #12985:
URL: https://github.com/apache/kafka/pull/12985#discussion_r1059241223
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java:
##########
@@ -159,7 +159,8 @@ public <K, V> void send(final String topic,
final Set<Integer> multicastPartitions =
maybeMulticastPartitions.get();
if (multicastPartitions.isEmpty()) {
// If a record is not to be sent to any partition,
mark it as a dropped record.
- log.debug("Not sending the record with key {} , value
{} to any partition", key, value);
+ log.warn("Skipping record as partitioner returned
empty partitions. "
Review Comment:
My impression was that it's been standard practice to allow logging
keys/values, but only at the TRACE level -- might be worth checking with the
security team?
I guess my feeling here is that this definitely shouldn't be logged at WARN
for every record, but could be done as a regular summary (a practice I think we
should be adopting more often than we have in the past) or as I said, at TRACE.
I would favor the summary unless we can include the key/value as a TRACE log,
which again we should try to confirm the standard here. I suppose it's useful
to know that records are being dropped due to the partitioner, which makes the
WARN summary useful, but I do wonder if users might still have trouble
debugging this partitioner choice without access to the key/values it's
dropping?
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
