[GitHub] [kafka] cadonna merged pull request #13026: KAFKA-14299: Avoid interrupted exceptions during clean shutdown

2022-12-20 Thread GitBox
cadonna merged PR #13026: URL: https://github.com/apache/kafka/pull/13026 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] cadonna commented on pull request #13026: KAFKA-14299: Avoid interrupted exceptions during clean shutdown

2022-12-20 Thread GitBox
cadonna commented on PR #13026: URL: https://github.com/apache/kafka/pull/13026#issuecomment-1360964756 Build failures are unrelated: ``` Build / JDK 11 and Scala 2.13 / kafka.api.SslEndToEndAuthorizationTest.testNoConsumeWithoutDescribeAclViaSubscribe(String).quorum=kraft Build / J

[GitHub] [kafka] showuon commented on a diff in pull request #13032: KAFKA-14540: Fix DataOutputStreamWritable#writeByteBuffer

2022-12-20 Thread GitBox
showuon commented on code in PR #13032: URL: https://github.com/apache/kafka/pull/13032#discussion_r1054067080 ## clients/src/main/java/org/apache/kafka/common/protocol/DataOutputStreamWritable.java: ## @@ -99,7 +99,7 @@ public void writeUnsignedVarint(int i) { public void

[GitHub] [kafka] michaeljmarshall opened a new pull request, #13032: KAFKA-14540: Fix DataOutputStreamWritable#writeByteBuffer

2022-12-20 Thread GitBox
michaeljmarshall opened a new pull request, #13032: URL: https://github.com/apache/kafka/pull/13032 When writing a `ByteBuffer` backed by a `HeapBuffer` to a `DataOutputStream`, it is necessary to pass in the offset, not the position. The current code results in writing the wrong data to `D

[jira] [Created] (KAFKA-14540) DataOutputStreamWritable#writeByteBuffer writes the wrong portion of the parameterized buffer

2022-12-20 Thread Michael Marshall (Jira)
Michael Marshall created KAFKA-14540: Summary: DataOutputStreamWritable#writeByteBuffer writes the wrong portion of the parameterized buffer Key: KAFKA-14540 URL: https://issues.apache.org/jira/browse/KAFKA-14

[jira] [Created] (KAFKA-14539) Simplify StreamsMetadataState by replacing the Cluster metadata with partition info map

2022-12-20 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-14539: -- Summary: Simplify StreamsMetadataState by replacing the Cluster metadata with partition info map Key: KAFKA-14539 URL: https://issues.apache.org/jira/browse/KA

[GitHub] [kafka] ijuma commented on pull request #13012: KAFKA-14477: Move LogValidator and related to storage module

2022-12-20 Thread GitBox
ijuma commented on PR #13012: URL: https://github.com/apache/kafka/pull/13012#issuecomment-1360836868 cc @satishd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [kafka] showuon commented on pull request #13031: MINOR: increase connectionMaxIdleMs to make test reliable

2022-12-20 Thread GitBox
showuon commented on PR #13031: URL: https://github.com/apache/kafka/pull/13031#issuecomment-1360821011 @rajinisivaram , please take a look. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kafka] showuon opened a new pull request, #13031: MINOR: increase connectionMaxIdleMs to make test reliable

2022-12-20 Thread GitBox
showuon opened a new pull request, #13031: URL: https://github.com/apache/kafka/pull/13031 Saw this flaky test in recent builds: [#1452](https://ci-builds.apache.org/job/Kafka/job/kafka/job/trunk/1452/testReport/junit/org.apache.kafka.common.network/SslTransportLayerTest/Build___JDK_17_and_S

[GitHub] [kafka] showuon commented on pull request #13016: KAFKA-14498: reduce the startup nodes to avoid timeout error

2022-12-20 Thread GitBox
showuon commented on PR #13016: URL: https://github.com/apache/kafka/pull/13016#issuecomment-1360804418 @ableegoldman , this is to help make some tests reliable by decreasing the testing nodes (low risk). Do you think this should backport to 3.4? -- This is an automated message from the

[jira] [Updated] (KAFKA-14498) flaky org.apache.kafka.tools.MetadataQuorumCommandTest

2022-12-20 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14498: -- Fix Version/s: 3.5.0 > flaky org.apache.kafka.tools.MetadataQuorumCommandTest > --

[GitHub] [kafka] showuon merged pull request #13016: KAFKA-14498: reduce the startup nodes to avoid timeout error

2022-12-20 Thread GitBox
showuon merged PR #13016: URL: https://github.com/apache/kafka/pull/13016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] showuon commented on pull request #13016: KAFKA-14498: reduce the startup nodes to avoid timeout error

2022-12-20 Thread GitBox
showuon commented on PR #13016: URL: https://github.com/apache/kafka/pull/13016#issuecomment-1360802421 Failed tests are unrelated ``` Build / JDK 8 and Scala 2.12 / kafka.network.SocketServerTest.idleExpiryWithBufferedReceives() Build / JDK 17 and Scala 2.13 / kafka.server

[GitHub] [kafka] ijuma commented on a diff in pull request #13030: MINOR; Add log message when Log high watermark differs

2022-12-20 Thread GitBox
ijuma commented on code in PR #13030: URL: https://github.com/apache/kafka/pull/13030#discussion_r1053941502 ## core/src/main/scala/kafka/raft/KafkaMetadataLog.scala: ## @@ -187,17 +187,25 @@ final class KafkaMetadataLog private ( } override def updateHighWatermark(offse

[GitHub] [kafka] showuon commented on pull request #13016: KAFKA-14498: reduce the startup nodes to avoid timeout error

2022-12-20 Thread GitBox
showuon commented on PR #13016: URL: https://github.com/apache/kafka/pull/13016#issuecomment-1360802090 > I guess you're saying we don't care about the ability to tolerate failures in this particular test. Fair enough. Yes, you're right. Thanks for the comment. -- This is an automa

[GitHub] [kafka] ijuma commented on pull request #13016: KAFKA-14498: reduce the startup nodes to avoid timeout error

2022-12-20 Thread GitBox
ijuma commented on PR #13016: URL: https://github.com/apache/kafka/pull/13016#issuecomment-1360800889 I guess you're saying we don't care about the ability to tolerate failures in this particular test. Fair enough. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] ijuma merged pull request #13010: KAFKA-14475: Move TimeIndex/LazyIndex to storage module

2022-12-20 Thread GitBox
ijuma merged PR #13010: URL: https://github.com/apache/kafka/pull/13010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] ijuma commented on pull request #13010: KAFKA-14475: Move TimeIndex/LazyIndex to storage module

2022-12-20 Thread GitBox
ijuma commented on PR #13010: URL: https://github.com/apache/kafka/pull/13010#issuecomment-1360794255 JDK 8 and JDK 17 builds passed, JDK 11 failures are unrelated: > Build / JDK 11 and Scala 2.13 / kafka.api.TransactionsTest.testBumpTransactionalEpoch(String).quorum=kraft 1 min 18 s

[GitHub] [kafka] showuon commented on pull request #13016: KAFKA-14498: reduce the startup nodes to avoid timeout error

2022-12-20 Thread GitBox
showuon commented on PR #13016: URL: https://github.com/apache/kafka/pull/13016#issuecomment-1360793825 > Actually, do we support running kraft with just 2 members in the controller quorum? Yes, I don't see why we can't support that. The quorum of 2 members will be 2. It just doesn't

[GitHub] [kafka] ijuma commented on pull request #13024: MINOR: Avoid unnecessary allocations in index binary search

2022-12-20 Thread GitBox
ijuma commented on PR #13024: URL: https://github.com/apache/kafka/pull/13024#issuecomment-1360792320 Test failures are unrelated: > Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsWithCustomForwardingAdminIntegrationTest.testReplicationIsCr

[GitHub] [kafka] philipnee commented on a diff in pull request #13023: KAFKA-14532: Correctly handle failed fetch when partitions unassigned

2022-12-20 Thread GitBox
philipnee commented on code in PR #13023: URL: https://github.com/apache/kafka/pull/13023#discussion_r1053900444 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java: ## @@ -620,7 +620,12 @@ public synchronized Optional preferredReadReplic

[GitHub] [kafka] jsancio opened a new pull request, #13030: MINOR; Add log message when Log high watermark differs

2022-12-20 Thread GitBox
jsancio opened a new pull request, #13030: URL: https://github.com/apache/kafka/pull/13030 When KRaft updates the log layer's high-watermark it is possible for the log layer to record a different high watermark. KRaft should log a warn message when this happens. ### Committer Checkli

[GitHub] [kafka] jolshan commented on pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

2022-12-20 Thread GitBox
jolshan commented on PR #12886: URL: https://github.com/apache/kafka/pull/12886#issuecomment-1360502862 Looks like this needs a rebase. I will take another pass when that is complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] jolshan commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

2022-12-20 Thread GitBox
jolshan commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r1053854859 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -407,136 +416,200 @@ class KafkaApis(val requestChannel: RequestChannel, * Handle an offset commit reques

[GitHub] [kafka] ijuma commented on a diff in pull request #13010: KAFKA-14475: Move TimeIndex/LazyIndex to storage module

2022-12-20 Thread GitBox
ijuma commented on code in PR #13010: URL: https://github.com/apache/kafka/pull/13010#discussion_r1053853496 ## storage/src/main/java/org/apache/kafka/server/log/internals/TimeIndex.java: ## @@ -0,0 +1,290 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] mumrah commented on a diff in pull request #13028: KAFKA-14458: Introduce RPC support during ZK migration

2022-12-20 Thread GitBox
mumrah commented on code in PR #13028: URL: https://github.com/apache/kafka/pull/13028#discussion_r1053840330 ## core/src/main/scala/kafka/controller/ControllerChannelManager.scala: ## @@ -313,35 +313,76 @@ class RequestSendThread(val controllerId: Int, } } -class Controll

[jira] [Updated] (KAFKA-14538) Implement KRaft metadata transactions

2022-12-20 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-14538: - Summary: Implement KRaft metadata transactions (was: Implement metadata transactions at arbitra

[jira] [Updated] (KAFKA-14538) Implement KRaft metadata transactions

2022-12-20 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-14538: - Description: Implement KRaft metadata transactions (was: Implement metadata transactions at arb

[GitHub] [kafka] junrao commented on a diff in pull request #13010: KAFKA-14475: Move TimeIndex/LazyIndex to storage module

2022-12-20 Thread GitBox
junrao commented on code in PR #13010: URL: https://github.com/apache/kafka/pull/13010#discussion_r1053827554 ## storage/src/main/java/org/apache/kafka/server/log/internals/TimeIndex.java: ## @@ -0,0 +1,290 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] jolshan commented on pull request #12870: KAFKA-14367; Add `OffsetFetch` to the new `GroupCoordinator` interface

2022-12-20 Thread GitBox
jolshan commented on PR #12870: URL: https://github.com/apache/kafka/pull/12870#issuecomment-1360390779 Was looking for the tests and then remembered this comment: https://github.com/apache/kafka/pull/12870#issuecomment-1318954178 Reminder on this 😄 -- This is an automated messa

[GitHub] [kafka] jolshan commented on a diff in pull request #12870: KAFKA-14367; Add `OffsetFetch` to the new `GroupCoordinator` interface

2022-12-20 Thread GitBox
jolshan commented on code in PR #12870: URL: https://github.com/apache/kafka/pull/12870#discussion_r1053796897 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinator.java: ## @@ -52,6 +54,7 @@ CompletableFuture joinGroup( ); /** +<

[GitHub] [kafka] jolshan commented on a diff in pull request #12870: KAFKA-14367; Add `OffsetFetch` to the new `GroupCoordinator` interface

2022-12-20 Thread GitBox
jolshan commented on code in PR #12870: URL: https://github.com/apache/kafka/pull/12870#discussion_r1053796764 ## core/src/test/scala/unit/kafka/server/OffsetFetchRequestTest.scala: ## @@ -150,42 +149,6 @@ class OffsetFetchRequestTest extends BaseRequestTest { } } - @

[GitHub] [kafka] akhileshchg opened a new pull request, #13029: MINOR: Add zk migration field to the ApiVersionsResponse

2022-12-20 Thread GitBox
akhileshchg opened a new pull request, #13029: URL: https://github.com/apache/kafka/pull/13029 This field will be used by the KRaft controller to see if the quorum is ready to handle zk -> kraft migration. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] akhileshchg opened a new pull request, #13028: KAFKA-14458: Introduce RPC support from KRaft controller to communica…

2022-12-20 Thread GitBox
akhileshchg opened a new pull request, #13028: URL: https://github.com/apache/kafka/pull/13028 …te with ZkBrokers during migration Introduced two new classes, KRaftControllerBrokerRequestBatch and KRaftControllerToZkBrokersRpcClient, that use AbstractControllerBrokerRequestBatch an

[jira] [Resolved] (KAFKA-14531) KRaft controller time-based snapshots are too frequent

2022-12-20 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur resolved KAFKA-14531. -- Resolution: Fixed > KRaft controller time-based snapshots are too frequent > -

[GitHub] [kafka] akhileshchg commented on a diff in pull request #13027: MINOR Send ZK broker epoch in registration

2022-12-20 Thread GitBox
akhileshchg commented on code in PR #13027: URL: https://github.com/apache/kafka/pull/13027#discussion_r1053715359 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -359,6 +354,11 @@ class KafkaServer( val brokerInfo = createBrokerInfo val brokerEpoc

[GitHub] [kafka] ijuma merged pull request #13011: KAFKA-14521: Replace BrokerCompressionCodec with BrokerCompressionType

2022-12-20 Thread GitBox
ijuma merged PR #13011: URL: https://github.com/apache/kafka/pull/13011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] ijuma commented on pull request #13011: KAFKA-14521: Replace BrokerCompressionCodec with BrokerCompressionType

2022-12-20 Thread GitBox
ijuma commented on PR #13011: URL: https://github.com/apache/kafka/pull/13011#issuecomment-1360076891 JDK 8 build passed, the other failures are unrelated. @dengziming I will go ahead and merge since you approved, but please do let me know if you have additional comments with regards

[GitHub] [kafka] ijuma merged pull request #13009: KAFKA-14474: Move OffsetIndex to storage module

2022-12-20 Thread GitBox
ijuma merged PR #13009: URL: https://github.com/apache/kafka/pull/13009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] ijuma commented on pull request #13009: KAFKA-14474: Move OffsetIndex to storage module

2022-12-20 Thread GitBox
ijuma commented on PR #13009: URL: https://github.com/apache/kafka/pull/13009#issuecomment-1360070072 Failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] mumrah opened a new pull request, #13027: MINOR Send ZK broker epoch in registration

2022-12-20 Thread GitBox
mumrah opened a new pull request, #13027: URL: https://github.com/apache/kafka/pull/13027 Rather than a boolean `isMigratingZkBroker`, this patch includes the broker epoch. The broker epoch, as it exists in ZK, is needed to construct valid UpdateMetadataRequests. The logic for determ

[GitHub] [kafka] philipnee commented on a diff in pull request #13021: KAFKA-14468: Implement CommitRequestManager to manage the commit and autocommit requests

2022-12-20 Thread GitBox
philipnee commented on code in PR #13021: URL: https://github.com/apache/kafka/pull/13021#discussion_r1053661970 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java: ## @@ -111,21 +120,36 @@ public DefaultBackgroundThread(final Time

[jira] [Resolved] (KAFKA-14457) Inconsistent in quorum controller fenced broker metric

2022-12-20 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio resolved KAFKA-14457. Resolution: Fixed > Inconsistent in quorum controller fenced broke

[GitHub] [kafka] jsancio merged pull request #12994: KAFKA-14457; Controller metrics should only expose committed data

2022-12-20 Thread GitBox
jsancio merged PR #12994: URL: https://github.com/apache/kafka/pull/12994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] jsancio commented on a diff in pull request #13019: KAFKA-14531 Fix controller snapshot interval

2022-12-20 Thread GitBox
jsancio commented on code in PR #13019: URL: https://github.com/apache/kafka/pull/13019#discussion_r1053638059 ## core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala: ## @@ -917,4 +919,34 @@ class KRaftClusterTest { cluster.close() } } + + @Test +

[jira] [Created] (KAFKA-14538) Implement metadata transactions at arbitrary locations in the log

2022-12-20 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-14538: Summary: Implement metadata transactions at arbitrary locations in the log Key: KAFKA-14538 URL: https://issues.apache.org/jira/browse/KAFKA-14538 Project: Kafka

[GitHub] [kafka] ijuma commented on a diff in pull request #13009: KAFKA-14474: Move OffsetIndex to storage module

2022-12-20 Thread GitBox
ijuma commented on code in PR #13009: URL: https://github.com/apache/kafka/pull/13009#discussion_r1053590225 ## core/src/test/scala/unit/kafka/log/remote/RemoteLogManagerTest.scala: ## @@ -273,4 +274,4 @@ class RemoteLogManagerTest { new RemoteLogManagerConfig(config) }

[GitHub] [kafka] ijuma commented on a diff in pull request #13009: KAFKA-14474: Move OffsetIndex to storage module

2022-12-20 Thread GitBox
ijuma commented on code in PR #13009: URL: https://github.com/apache/kafka/pull/13009#discussion_r1053590225 ## core/src/test/scala/unit/kafka/log/remote/RemoteLogManagerTest.scala: ## @@ -273,4 +274,4 @@ class RemoteLogManagerTest { new RemoteLogManagerConfig(config) }

[jira] [Assigned] (KAFKA-14534) Flaky Test TransactionsExpirationTest.testTransactionAfterProducerIdExpires

2022-12-20 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris reassigned KAFKA-14534: --- Assignee: Greg Harris > Flaky Test TransactionsExpirationTest.testTransactionAfterProducerI

[GitHub] [kafka] junrao commented on a diff in pull request #13009: KAFKA-14474: Move OffsetIndex to storage module

2022-12-20 Thread GitBox
junrao commented on code in PR #13009: URL: https://github.com/apache/kafka/pull/13009#discussion_r1053591043 ## core/src/test/scala/unit/kafka/log/remote/RemoteLogManagerTest.scala: ## @@ -273,4 +274,4 @@ class RemoteLogManagerTest { new RemoteLogManagerConfig(config) }

[GitHub] [kafka] ijuma commented on a diff in pull request #13009: KAFKA-14474: Move OffsetIndex to storage module

2022-12-20 Thread GitBox
ijuma commented on code in PR #13009: URL: https://github.com/apache/kafka/pull/13009#discussion_r1053590225 ## core/src/test/scala/unit/kafka/log/remote/RemoteLogManagerTest.scala: ## @@ -273,4 +274,4 @@ class RemoteLogManagerTest { new RemoteLogManagerConfig(config) }

[GitHub] [kafka] ijuma commented on a diff in pull request #13009: KAFKA-14474: Move OffsetIndex to storage module

2022-12-20 Thread GitBox
ijuma commented on code in PR #13009: URL: https://github.com/apache/kafka/pull/13009#discussion_r1053590225 ## core/src/test/scala/unit/kafka/log/remote/RemoteLogManagerTest.scala: ## @@ -273,4 +274,4 @@ class RemoteLogManagerTest { new RemoteLogManagerConfig(config) }

[GitHub] [kafka] junrao commented on a diff in pull request #13009: KAFKA-14474: Move OffsetIndex to storage module

2022-12-20 Thread GitBox
junrao commented on code in PR #13009: URL: https://github.com/apache/kafka/pull/13009#discussion_r1053582340 ## core/src/test/scala/unit/kafka/log/remote/RemoteLogManagerTest.scala: ## @@ -273,4 +274,4 @@ class RemoteLogManagerTest { new RemoteLogManagerConfig(config) }

[GitHub] [kafka] cadonna commented on a diff in pull request #13014: KAFKA-14461: Move StoreQueryIntegrationTest to junit5 and fixing logic in a couple of tests for finding active streams

2022-12-20 Thread GitBox
cadonna commented on code in PR #13014: URL: https://github.com/apache/kafka/pull/13014#discussion_r1053578553 ## streams/src/test/java/org/apache/kafka/streams/integration/StoreQueryIntegrationTest.java: ## @@ -650,12 +659,11 @@ private void produceValueRange(final int key, fin

[GitHub] [kafka] vamossagar12 commented on pull request #13014: KAFKA-14461: Move StoreQueryIntegrationTest to junit5 and fixing logic in a couple of tests for finding active streams

2022-12-20 Thread GitBox
vamossagar12 commented on PR #13014: URL: https://github.com/apache/kafka/pull/13014#issuecomment-1359867743 `` > Thanks for the KIP @vamossagar12 ! > > I have just one minor comment! Thanks @cadonna . I made the requested change. -- This is an automated message from t

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13014: KAFKA-14461: Move StoreQueryIntegrationTest to junit5 and fixing logic in a couple of tests for finding active streams

2022-12-20 Thread GitBox
vamossagar12 commented on code in PR #13014: URL: https://github.com/apache/kafka/pull/13014#discussion_r1053568958 ## streams/src/test/java/org/apache/kafka/streams/integration/StoreQueryIntegrationTest.java: ## @@ -650,12 +659,12 @@ private void produceValueRange(final int key

[GitHub] [kafka] cadonna commented on a diff in pull request #13017: KAFKA-14530: Check state updater more often

2022-12-20 Thread GitBox
cadonna commented on code in PR #13017: URL: https://github.com/apache/kafka/pull/13017#discussion_r1053559527 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java: ## @@ -880,9 +885,7 @@ void runOnce() { private void initializeAndRestoreP

[GitHub] [kafka] cadonna commented on a diff in pull request #13025: KAFKA-14299: Make sure no progress is made on paused topologies

2022-12-20 Thread GitBox
cadonna commented on code in PR #13025: URL: https://github.com/apache/kafka/pull/13025#discussion_r1053549663 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -276,6 +276,11 @@ private void addTask(final Task task) {

[jira] [Commented] (KAFKA-14537) Materialized with / as ordering issues

2022-12-20 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649894#comment-17649894 ] Matthias J. Sax commented on KAFKA-14537: - What you observe is behavior as desig

[jira] [Resolved] (KAFKA-14537) Materialized with / as ordering issues

2022-12-20 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-14537. - Resolution: Not A Bug > Materialized with / as ordering issues > ---

[jira] [Resolved] (KAFKA-14536) SessionId in FetchResponse should be ignorable

2022-12-20 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-14536. - Resolution: Not A Problem > SessionId in FetchResponse should be ignorable > ---

[jira] [Commented] (KAFKA-14536) SessionId in FetchResponse should be ignorable

2022-12-20 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649893#comment-17649893 ] David Jacot commented on KAFKA-14536: - Nevermind, I found the logic which handles th

[GitHub] [kafka] lucasbru commented on pull request #13026: KAFKA-14299: Avoid interrupted exceptions during clean shutdown

2022-12-20 Thread GitBox
lucasbru commented on PR #13026: URL: https://github.com/apache/kafka/pull/13026#issuecomment-1359712729 @cadonna Could you have a look please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Created] (KAFKA-14537) Materialized with / as ordering issues

2022-12-20 Thread Matt Allwood (Jira)
Matt Allwood created KAFKA-14537: Summary: Materialized with / as ordering issues Key: KAFKA-14537 URL: https://issues.apache.org/jira/browse/KAFKA-14537 Project: Kafka Issue Type: Bug

[GitHub] [kafka] lucasbru opened a new pull request, #13026: KAFKA-14299: Avoid interrupted exceptions during clean shutdown

2022-12-20 Thread GitBox
lucasbru opened a new pull request, #13026: URL: https://github.com/apache/kafka/pull/13026 The call to `interrupt` on the state updater thread during shutdown could interrupt the thread while writing the checkpoint file. This can cause a failure to write the checkpoint file and a misle

[GitHub] [kafka] lucasbru commented on pull request #13025: KAFKA-14299: Make sure no progress is made on paused topologies

2022-12-20 Thread GitBox
lucasbru commented on PR #13025: URL: https://github.com/apache/kafka/pull/13025#issuecomment-1359682705 @cadonna Could you have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [kafka] lucasbru opened a new pull request, #13025: KAFKA-14299: Make sure no progress is made on paused topologies

2022-12-20 Thread GitBox
lucasbru opened a new pull request, #13025: URL: https://github.com/apache/kafka/pull/13025 The state updater performed at least one call to `poll` on the restore consumer before realizing that a newly added task was already in paused state when being added. To be fully correct, no prog

[jira] [Commented] (KAFKA-14536) SessionId in FetchResponse should be ignorable

2022-12-20 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649884#comment-17649884 ] Ismael Juma commented on KAFKA-14536: - Interesting that we didn't get bug reports ei

[GitHub] [kafka] ijuma commented on pull request #13024: MINOR: Avoid unnecessary allocations in index binary search

2022-12-20 Thread GitBox
ijuma commented on PR #13024: URL: https://github.com/apache/kafka/pull/13024#issuecomment-1359675311 @chia7712 `OffsetIndexTest` does fail without the fix and pass with the fix. And the CI build is queued now. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] ijuma commented on pull request #13024: MINOR: Avoid unnecessary allocations in index binary search

2022-12-20 Thread GitBox
ijuma commented on PR #13024: URL: https://github.com/apache/kafka/pull/13024#issuecomment-1359643024 > Are there failed tests related to that bug (inverse usage of SearchType) ? Not sure why I don't see the QA triggered by this PR I was wondering the same thing for both and am invest

[jira] [Created] (KAFKA-14536) SessionId in FetchResponse should be ignorable

2022-12-20 Thread David Jacot (Jira)
David Jacot created KAFKA-14536: --- Summary: SessionId in FetchResponse should be ignorable Key: KAFKA-14536 URL: https://issues.apache.org/jira/browse/KAFKA-14536 Project: Kafka Issue Type: Bug

[GitHub] [kafka] chia7712 commented on pull request #13024: MINOR: Avoid unnecessary allocations in index binary search

2022-12-20 Thread GitBox
chia7712 commented on PR #13024: URL: https://github.com/apache/kafka/pull/13024#issuecomment-1359594391 > Fixed the bug and also tweaked the name of the enum and variable to avoid confusion with SearchEntityType. Are there failed tests related to that bug (inverse usage of SearchType

[GitHub] [kafka] ijuma commented on pull request #13024: MINOR: Avoid unnecessary allocations in index binary search

2022-12-20 Thread GitBox
ijuma commented on PR #13024: URL: https://github.com/apache/kafka/pull/13024#issuecomment-1359582927 @chia7712 Fixed the bug and also tweaked the name of the enum and variable to avoid confusion with `SearchEntityType`. -- This is an automated message from the Apache Git Service. To resp

[GitHub] [kafka] ijuma commented on a diff in pull request #13024: MINOR: Avoid unnecessary allocations in index binary search

2022-12-20 Thread GitBox
ijuma commented on code in PR #13024: URL: https://github.com/apache/kafka/pull/13024#discussion_r1053451180 ## storage/src/main/java/org/apache/kafka/server/log/internals/AbstractIndex.java: ## @@ -484,27 +478,35 @@ private static MappedByteBuffer createMappedBuffer(RandomAcce

[GitHub] [kafka] ijuma commented on a diff in pull request #13024: MINOR: Avoid unnecessary allocations in index binary search

2022-12-20 Thread GitBox
ijuma commented on code in PR #13024: URL: https://github.com/apache/kafka/pull/13024#discussion_r1053450391 ## storage/src/main/java/org/apache/kafka/server/log/internals/AbstractIndex.java: ## @@ -484,27 +478,35 @@ private static MappedByteBuffer createMappedBuffer(RandomAcce

[jira] [Comment Edited] (KAFKA-7205) KafkaConsumer / KafkaProducer should allow Reconfiguration of SSL Configuration

2022-12-20 Thread Marten Richert (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649830#comment-17649830 ] Marten Richert edited comment on KAFKA-7205 at 12/20/22 3:26 PM: --

[jira] [Commented] (KAFKA-7205) KafkaConsumer / KafkaProducer should allow Reconfiguration of SSL Configuration

2022-12-20 Thread Marten Richert (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649830#comment-17649830 ] Marten Richert commented on KAFKA-7205: --- [~kirktrue] For now I do not plan to write

[GitHub] [kafka] mumrah merged pull request #13019: KAFKA-14531 Fix controller snapshot interval

2022-12-20 Thread GitBox
mumrah merged PR #13019: URL: https://github.com/apache/kafka/pull/13019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[GitHub] [kafka] ijuma commented on a diff in pull request #13011: KAFKA-14521: Replace BrokerCompressionCodec with BrokerCompressionType

2022-12-20 Thread GitBox
ijuma commented on code in PR #13011: URL: https://github.com/apache/kafka/pull/13011#discussion_r1053421666 ## server-common/src/main/java/org/apache/kafka/server/record/BrokerCompressionType.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [kafka] lucasbru commented on a diff in pull request #13023: KAFKA-14532: Correctly handle failed fetch when partitions unassigned

2022-12-20 Thread GitBox
lucasbru commented on code in PR #13023: URL: https://github.com/apache/kafka/pull/13023#discussion_r1053392985 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java: ## @@ -4762,6 +4763,39 @@ public void testFetchDisconnectedShouldClearPreferred

[GitHub] [kafka] ijuma commented on pull request #13009: KAFKA-14474: Move OffsetIndex to storage module

2022-12-20 Thread GitBox
ijuma commented on PR #13009: URL: https://github.com/apache/kafka/pull/13009#issuecomment-1359468819 Test failures look unrelated, re-running just in case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] ijuma commented on pull request #13010: KAFKA-14475: Move TimeIndex/LazyIndex to storage module

2022-12-20 Thread GitBox
ijuma commented on PR #13010: URL: https://github.com/apache/kafka/pull/13010#issuecomment-1359466826 Test failures look unrelated. Re-running the tests just in case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] mimaison merged pull request #13005: MINOR: Don't throw if MirrorMaker topics already exist

2022-12-20 Thread GitBox
mimaison merged PR #13005: URL: https://github.com/apache/kafka/pull/13005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] divijvaidya commented on pull request #13024: MINOR: Avoid unnecessary allocations in index binary search

2022-12-20 Thread GitBox
divijvaidya commented on PR #13024: URL: https://github.com/apache/kafka/pull/13024#issuecomment-1359348307 ^ please ignore my approval. @chia7712's comments need to be fixed first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] dajac commented on pull request #13023: KAFKA-14532: Correctly handle failed fetch when partitions unassigned

2022-12-20 Thread GitBox
dajac commented on PR #13023: URL: https://github.com/apache/kafka/pull/13023#issuecomment-1359310514 The bug was introduced in https://github.com/apache/kafka/pull/12956. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Updated] (KAFKA-14532) IllegalStateException when fetch failure happens after assignment changed

2022-12-20 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-14532: Fix Version/s: 3.3.2 > IllegalStateException when fetch failure happens after assignment changed >

[jira] [Commented] (KAFKA-14532) IllegalStateException when fetch failure happens after assignment changed

2022-12-20 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649734#comment-17649734 ] David Jacot commented on KAFKA-14532: - cc [~ableegoldman] > IllegalStateException w

[GitHub] [kafka] dajac commented on a diff in pull request #13023: KAFKA-14532: Correctly handle failed fetch when partitions unassigned

2022-12-20 Thread GitBox
dajac commented on code in PR #13023: URL: https://github.com/apache/kafka/pull/13023#discussion_r1053276546 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java: ## @@ -4762,6 +4763,39 @@ public void testFetchDisconnectedShouldClearPreferredRea

[jira] [Updated] (KAFKA-14532) IllegalStateException when fetch failure happens after assignment changed

2022-12-20 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-14532: Fix Version/s: 3.4.0 > IllegalStateException when fetch failure happens after assignment changed >

[GitHub] [kafka] showuon commented on pull request #12979: MINOR: remove "is-future" from metrics tags after replace current log…

2022-12-20 Thread GitBox
showuon commented on PR #12979: URL: https://github.com/apache/kafka/pull/12979#issuecomment-1359274755 Thanks for the patch. I'll take a look this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] chia7712 commented on a diff in pull request #13024: MINOR: Avoid unnecessary allocations in index binary search

2022-12-20 Thread GitBox
chia7712 commented on code in PR #13024: URL: https://github.com/apache/kafka/pull/13024#discussion_r1053182775 ## storage/src/main/java/org/apache/kafka/server/log/internals/AbstractIndex.java: ## @@ -484,27 +478,35 @@ private static MappedByteBuffer createMappedBuffer(RandomA

[GitHub] [kafka] mimaison commented on pull request #13005: MINOR: Don't throw if MirrorMaker topics already exist

2022-12-20 Thread GitBox
mimaison commented on PR #13005: URL: https://github.com/apache/kafka/pull/13005#issuecomment-1359157191 Thanks @showuon for the review! I've pushed an update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [kafka] cadonna commented on a diff in pull request #13014: KAFKA-14461: Move StoreQueryIntegrationTest to junit5 and fixing logic in a couple of tests for finding active streams

2022-12-20 Thread GitBox
cadonna commented on code in PR #13014: URL: https://github.com/apache/kafka/pull/13014#discussion_r1053065865 ## streams/src/test/java/org/apache/kafka/streams/integration/StoreQueryIntegrationTest.java: ## @@ -650,12 +659,12 @@ private void produceValueRange(final int key, fin

[jira] [Resolved] (KAFKA-14343) Write upgrade/downgrade tests for enabling the state updater

2022-12-20 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy resolved KAFKA-14343. Resolution: Fixed > Write upgrade/downgrade tests for enabling the state updater > --

[GitHub] [kafka] cadonna merged pull request #12801: KAFKA-14343: Upgrade tests for state updater

2022-12-20 Thread GitBox
cadonna merged PR #12801: URL: https://github.com/apache/kafka/pull/12801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] cadonna commented on pull request #12801: KAFKA-14343: Upgrade tests for state updater

2022-12-20 Thread GitBox
cadonna commented on PR #12801: URL: https://github.com/apache/kafka/pull/12801#issuecomment-1359004467 Build failures are unrelated: ``` Build / JDK 17 and Scala 2.13 / kafka.api.PlaintextEndToEndAuthorizationTest.testNoConsumeWithoutDescribeAclViaSubscribe(String).quorum=zk Build

[jira] [Updated] (KAFKA-13085) Offsets clean up based on largest Timestamp in a Log segment

2022-12-20 Thread Mohamed Aashif (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohamed Aashif updated KAFKA-13085: --- Description: This is to confirm the behaviour of [retention.ms|https://kafka.apache.org/doc