ijuma commented on code in PR #13009:
URL: https://github.com/apache/kafka/pull/13009#discussion_r1053590225
##########
core/src/test/scala/unit/kafka/log/remote/RemoteLogManagerTest.scala:
##########
@@ -273,4 +274,4 @@ class RemoteLogManagerTest {
new RemoteLogManagerConfig(config)
}
-}
\ No newline at end of file
+}
Review Comment:
@junrao I think most editors expect a new line at the end. For example,
IntelliJ adds it automatically after I delete it and save the file (I tried it
just now). And vim doesn't even show that there is a new line. So, I think we
should probably leave it in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
