[jira] [Resolved] (KAFKA-14286) Time based cluster metadata snapshots

2022-12-09 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio resolved KAFKA-14286. Resolution: Fixed > Time based cluster metadata snapshots > --

[jira] [Commented] (KAFKA-14260) InMemoryKeyValueStore iterator still throws ConcurrentModificationException

2022-12-09 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645545#comment-17645545 ] A. Sophie Blee-Goldman commented on KAFKA-14260: Well, actually, it turn

[jira] [Updated] (KAFKA-14403) Snapshot failure metrics

2022-12-09 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-14403: --- Parent: (was: KAFKA-14286) Issue Type: New Feature (was:

[jira] [Updated] (KAFKA-14323) KRaft broker time based snapshots

2022-12-09 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-14323: --- Parent: (was: KAFKA-14286) Issue Type: New Feature (was:

[jira] [Created] (KAFKA-14460) In-memory store iterators can return results with null values

2022-12-09 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-14460: -- Summary: In-memory store iterators can return results with null values Key: KAFKA-14460 URL: https://issues.apache.org/jira/browse/KAFKA-14460 Pro

[jira] [Assigned] (KAFKA-14403) Snapshot failure metrics

2022-12-09 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio reassigned KAFKA-14403: -- Assignee: José Armando García Sancio > Snapshot failure metri

[jira] [Commented] (KAFKA-14362) Same message consumed by two consumers in the same group after client restart

2022-12-09 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645541#comment-17645541 ] A. Sophie Blee-Goldman commented on KAFKA-14362: Nice find, I would not

[jira] [Commented] (KAFKA-14419) Same message consumed again by the same stream task after partition is lost and reassigned

2022-12-09 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645540#comment-17645540 ] A. Sophie Blee-Goldman commented on KAFKA-14419: [~Carlstedt] can you tr

[jira] [Updated] (KAFKA-14459) Document how to use and close a 'Statistics' in the example RocksDBConfigSetter

2022-12-09 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-14459: --- Description: We fixed a memory leak in KAFKA-14432 where we were sometimes f

[GitHub] [kafka] ableegoldman commented on a diff in pull request #12935: KAFKA-14432: RocksDBStore relies on finalizers to not leak memory

2022-12-09 Thread GitBox
ableegoldman commented on code in PR #12935: URL: https://github.com/apache/kafka/pull/12935#discussion_r1044948661 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java: ## @@ -526,6 +521,9 @@ public synchronized void close() { fOptions.cl

[jira] [Updated] (KAFKA-14459) Document how to use and close a 'Statistics' in the example RocksDBConfigSetter

2022-12-09 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-14459: --- Labels: docs newbie (was: ) > Document how to use and close a 'Statistics'

[jira] [Created] (KAFKA-14459) Document how to use and close a 'Statistics' in the example RocksDBConfigSetter

2022-12-09 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-14459: -- Summary: Document how to use and close a 'Statistics' in the example RocksDBConfigSetter Key: KAFKA-14459 URL: https://issues.apache.org/jira/browse/KAFKA-1445

[jira] [Resolved] (KAFKA-14454) KTableKTableForeignKeyInnerJoinCustomPartitionerIntegrationTest#shouldThrowIllegalArgumentExceptionWhenCustomPartionerReturnsMultiplePartitions passes when run individu

2022-12-09 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-14454. Resolution: Fixed > KTableKTableForeignKeyInnerJoinCustomPartitionerIntegr

[GitHub] [kafka] ableegoldman commented on pull request #12971: KAFKA-14454: Making unique StreamsConfig for tests

2022-12-09 Thread GitBox
ableegoldman commented on PR #12971: URL: https://github.com/apache/kafka/pull/12971#issuecomment-1344973861 Merged to trunk and cherrypicked to 3.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kafka] ableegoldman merged pull request #12971: KAFKA-14454: Making unique StreamsConfig for tests

2022-12-09 Thread GitBox
ableegoldman merged PR #12971: URL: https://github.com/apache/kafka/pull/12971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[GitHub] [kafka] hachikuji commented on pull request #12956: KAFKA-14379: consumer should refresh preferred read replica on update metadata

2022-12-09 Thread GitBox
hachikuji commented on PR #12956: URL: https://github.com/apache/kafka/pull/12956#issuecomment-1344961172 Note there are some failures on `FetcherTest` in the builds above which seem related to this change. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [kafka] cmccabe merged pull request #12856: KAFKA-14392: KRaft broker heartbeat timeout should not exceed broker.session.timeout.ms

2022-12-09 Thread GitBox
cmccabe merged PR #12856: URL: https://github.com/apache/kafka/pull/12856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Created] (KAFKA-14458) RPC Handler to ZkBrokers from KRaft Controller

2022-12-09 Thread Akhilesh Chaganti (Jira)
Akhilesh Chaganti created KAFKA-14458: - Summary: RPC Handler to ZkBrokers from KRaft Controller Key: KAFKA-14458 URL: https://issues.apache.org/jira/browse/KAFKA-14458 Project: Kafka Issu

[GitHub] [kafka] cmccabe commented on a diff in pull request #12856: KAFKA-14392: KRaft broker heartbeat timeout should not exceed broker.session.timeout.ms

2022-12-09 Thread GitBox
cmccabe commented on code in PR #12856: URL: https://github.com/apache/kafka/pull/12856#discussion_r1044929305 ## core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala: ## @@ -211,7 +211,7 @@ class BrokerToControllerChannelManagerImpl( 50, Sel

[jira] [Created] (KAFKA-14457) Inconsistent in quorum controller fenced broker metric

2022-12-09 Thread Jira
José Armando García Sancio created KAFKA-14457: -- Summary: Inconsistent in quorum controller fenced broker metric Key: KAFKA-14457 URL: https://issues.apache.org/jira/browse/KAFKA-14457 Pro

[GitHub] [kafka] jsancio opened a new pull request, #12975: MINOR; Improve high watermark log messages

2022-12-09 Thread GitBox
jsancio opened a new pull request, #12975: URL: https://github.com/apache/kafka/pull/12975 While debugging KRaft and the metadata state machines it is helpful to always log the first time the replica discovers the high watermark. All other updates to the high watermark are logged at trace b

[GitHub] [kafka] jolshan closed pull request #12966: KAFKA-14417: Producer doesn't handle REQUEST_TIMED_OUT for InitProducerIdRequest, treats as fatal error -- server-side

2022-12-09 Thread GitBox
jolshan closed pull request #12966: KAFKA-14417: Producer doesn't handle REQUEST_TIMED_OUT for InitProducerIdRequest, treats as fatal error -- server-side URL: https://github.com/apache/kafka/pull/12966 -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [kafka] hachikuji commented on a diff in pull request #12956: KAFKA-14379: consumer should refresh preferred read replica on update metadata

2022-12-09 Thread GitBox
hachikuji commented on code in PR #12956: URL: https://github.com/apache/kafka/pull/12956#discussion_r1044913099 ## clients/src/main/java/org/apache/kafka/common/Cluster.java: ## @@ -253,7 +253,11 @@ public Node nodeById(int id) { public Optional nodeIfOnline(TopicPartition

[GitHub] [kafka] kirktrue opened a new pull request, #12974: KAFKA-13421: Fix ConsumerBounceTest#testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup

2022-12-09 Thread GitBox
kirktrue opened a new pull request, #12974: URL: https://github.com/apache/kafka/pull/12974 Initial investigation into the source of the flakiness. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI bui

[GitHub] [kafka] ableegoldman merged pull request #12962: KAFKA-14318: KIP-878, Introduce partition autoscaling configs

2022-12-09 Thread GitBox
ableegoldman merged PR #12962: URL: https://github.com/apache/kafka/pull/12962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[GitHub] [kafka] artemlivshits commented on a diff in pull request #12956: KAFKA-14379: consumer should refresh preferred read replica on update metadata

2022-12-09 Thread GitBox
artemlivshits commented on code in PR #12956: URL: https://github.com/apache/kafka/pull/12956#discussion_r1044843523 ## core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala: ## @@ -103,44 +105,89 @@ class FetchFromFollowerIntegrationTest extends B

[GitHub] [kafka] mumrah opened a new pull request, #12973: MINOR: Change KRaft controllership claiming algorithm

2022-12-09 Thread GitBox
mumrah opened a new pull request, #12973: URL: https://github.com/apache/kafka/pull/12973 TBD -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-u

[GitHub] [kafka] junrao commented on a diff in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2022-12-09 Thread GitBox
junrao commented on code in PR #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r1043982291 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -289,13 +296,26 @@ class UnifiedLog(@volatile var logStartOffset: Long, @volatile var partitionMetadataFile

[GitHub] [kafka] C0urante commented on a diff in pull request #12802: KAFKA-14311: Connect Worker clean shutdown does not cleanly stop connectors/tasks

2022-12-09 Thread GitBox
C0urante commented on code in PR #12802: URL: https://github.com/apache/kafka/pull/12802#discussion_r1044799940 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -1645,6 +1646,8 @@ private void startAndStop(Collection> c

[GitHub] [kafka] jolshan commented on a diff in pull request #12968: KAFKA-14417: Addressing the error server side

2022-12-09 Thread GitBox
jolshan commented on code in PR #12968: URL: https://github.com/apache/kafka/pull/12968#discussion_r1044794121 ## core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala: ## @@ -167,7 +167,7 @@ class RPCProducerIdManager(brokerId: Int, if (nextProducerId

[GitHub] [kafka] jolshan commented on a diff in pull request #12855: KAFKA-14367; Add `DescribeGroups` to the new `GroupCoordinator` interface

2022-12-09 Thread GitBox
jolshan commented on code in PR #12855: URL: https://github.com/apache/kafka/pull/12855#discussion_r1044762017 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -2061,32 +2072,58 @@ class KafkaApisTest { @Test def testHandleDescribeGroupsAuthenticationF

[GitHub] [kafka] jolshan commented on a diff in pull request #12855: KAFKA-14367; Add `DescribeGroups` to the new `GroupCoordinator` interface

2022-12-09 Thread GitBox
jolshan commented on code in PR #12855: URL: https://github.com/apache/kafka/pull/12855#discussion_r1044761059 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -2061,32 +2072,58 @@ class KafkaApisTest { @Test def testHandleDescribeGroupsAuthenticationF

[GitHub] [kafka] jolshan commented on a diff in pull request #12855: KAFKA-14367; Add `DescribeGroups` to the new `GroupCoordinator` interface

2022-12-09 Thread GitBox
jolshan commented on code in PR #12855: URL: https://github.com/apache/kafka/pull/12855#discussion_r1044755787 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -190,25 +191,29 @@ class GroupCoordinatorAdapter( override def describeGroup(

[GitHub] [kafka] jolshan commented on a diff in pull request #12855: KAFKA-14367; Add `DescribeGroups` to the new `GroupCoordinator` interface

2022-12-09 Thread GitBox
jolshan commented on code in PR #12855: URL: https://github.com/apache/kafka/pull/12855#discussion_r1044754795 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -80,8 +80,8 @@ import java.util import java.util.concurrent.{CompletableFuture, ConcurrentHashMap} import j

[GitHub] [kafka] jsancio commented on a diff in pull request #12963: MINOR: More consistent handling of snapshot IDs

2022-12-09 Thread GitBox
jsancio commented on code in PR #12963: URL: https://github.com/apache/kafka/pull/12963#discussion_r1044748464 ## core/src/test/scala/unit/kafka/server/metadata/BrokerMetadataListenerTest.scala: ## @@ -166,15 +172,15 @@ class BrokerMetadataListenerTest { image = newImage

[GitHub] [kafka] jsancio commented on a diff in pull request #12963: MINOR: More consistent handling of snapshot IDs

2022-12-09 Thread GitBox
jsancio commented on code in PR #12963: URL: https://github.com/apache/kafka/pull/12963#discussion_r1044743802 ## core/src/test/scala/unit/kafka/server/metadata/BrokerMetadataListenerTest.scala: ## @@ -166,15 +172,15 @@ class BrokerMetadataListenerTest { image = newImage

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12802: KAFKA-14311: Connect Worker clean shutdown does not cleanly stop connectors/tasks

2022-12-09 Thread GitBox
vamossagar12 commented on code in PR #12802: URL: https://github.com/apache/kafka/pull/12802#discussion_r1044742586 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -1645,6 +1646,8 @@ private void startAndStop(Collection

[GitHub] [kafka] mumrah closed pull request #12815: KIP-866 Part 1

2022-12-09 Thread GitBox
mumrah closed pull request #12815: KIP-866 Part 1 URL: https://github.com/apache/kafka/pull/12815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-u

[GitHub] [kafka] mjsax commented on pull request #12934: MINOR: add docs table entries for new metrics

2022-12-09 Thread GitBox
mjsax commented on PR #12934: URL: https://github.com/apache/kafka/pull/12934#issuecomment-1344630009 Thanks! Merged to `trunk` and cherry-picked to `3.4`, `3.3`, `3.2` and `3.1` branches. @rodesai would you have to do a follow up PR for https://github.com/apache/kafka-site ? -- T

[GitHub] [kafka] mjsax merged pull request #12934: MINOR: add docs table entries for new metrics

2022-12-09 Thread GitBox
mjsax merged PR #12934: URL: https://github.com/apache/kafka/pull/12934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] jolshan commented on a diff in pull request #12968: KAFKA-14417: Addressing the error server side

2022-12-09 Thread GitBox
jolshan commented on code in PR #12968: URL: https://github.com/apache/kafka/pull/12968#discussion_r1044712173 ## core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala: ## @@ -167,7 +167,7 @@ class RPCProducerIdManager(brokerId: Int, if (nextProducerId

[GitHub] [kafka] rondagostino commented on a diff in pull request #12856: KAFKA-14392: KRaft broker heartbeat timeout should not exceed broker.session.timeout.ms

2022-12-09 Thread GitBox
rondagostino commented on code in PR #12856: URL: https://github.com/apache/kafka/pull/12856#discussion_r1044711404 ## core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala: ## @@ -211,7 +211,7 @@ class BrokerToControllerChannelManagerImpl( 50,

[GitHub] [kafka] C0urante commented on a diff in pull request #12802: KAFKA-14311: Connect Worker clean shutdown does not cleanly stop connectors/tasks

2022-12-09 Thread GitBox
C0urante commented on code in PR #12802: URL: https://github.com/apache/kafka/pull/12802#discussion_r1044692613 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -1645,6 +1646,8 @@ private void startAndStop(Collection> c

[GitHub] [kafka] C0urante commented on a diff in pull request #12947: KAFKA-6586: Refactor ConnectDistributed and ConnectStandalone to re-use shared logic

2022-12-09 Thread GitBox
C0urante commented on code in PR #12947: URL: https://github.com/apache/kafka/pull/12947#discussion_r1044687594 ## connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectStandalone.java: ## @@ -21,41 +21,51 @@ import org.apache.kafka.common.utils.Utils; import org.

[GitHub] [kafka] C0urante commented on a diff in pull request #12947: KAFKA-6586: Refactor ConnectDistributed and ConnectStandalone to re-use shared logic

2022-12-09 Thread GitBox
C0urante commented on code in PR #12947: URL: https://github.com/apache/kafka/pull/12947#discussion_r1044687594 ## connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectStandalone.java: ## @@ -21,41 +21,51 @@ import org.apache.kafka.common.utils.Utils; import org.

[GitHub] [kafka] cmccabe commented on a diff in pull request #12856: KAFKA-14392: KRaft broker heartbeat timeout should not exceed broker.session.timeout.ms

2022-12-09 Thread GitBox
cmccabe commented on code in PR #12856: URL: https://github.com/apache/kafka/pull/12856#discussion_r1044687611 ## core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala: ## @@ -283,7 +283,7 @@ class BrokerToControllerRequestThread( time: Time, threadName:

[GitHub] [kafka] cmccabe commented on a diff in pull request #12856: KAFKA-14392: KRaft broker heartbeat timeout should not exceed broker.session.timeout.ms

2022-12-09 Thread GitBox
cmccabe commented on code in PR #12856: URL: https://github.com/apache/kafka/pull/12856#discussion_r1044686915 ## core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala: ## @@ -211,7 +211,7 @@ class BrokerToControllerChannelManagerImpl( 50, Sel

[GitHub] [kafka] cmccabe commented on a diff in pull request #12856: KAFKA-14392: KRaft broker heartbeat timeout should not exceed broker.session.timeout.ms

2022-12-09 Thread GitBox
cmccabe commented on code in PR #12856: URL: https://github.com/apache/kafka/pull/12856#discussion_r1044686357 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -221,7 +221,7 @@ class BrokerServer( config, channelName = "forwarding", thread

[GitHub] [kafka] cmccabe commented on a diff in pull request #12856: KAFKA-14392: KRaft broker heartbeat timeout should not exceed broker.session.timeout.ms

2022-12-09 Thread GitBox
cmccabe commented on code in PR #12856: URL: https://github.com/apache/kafka/pull/12856#discussion_r1044681192 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -221,7 +221,7 @@ class BrokerServer( config, channelName = "forwarding", thread

[GitHub] [kafka] cmccabe commented on a diff in pull request #12856: KAFKA-14392: KRaft broker heartbeat timeout should not exceed broker.session.timeout.ms

2022-12-09 Thread GitBox
cmccabe commented on code in PR #12856: URL: https://github.com/apache/kafka/pull/12856#discussion_r1044681192 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -221,7 +221,7 @@ class BrokerServer( config, channelName = "forwarding", thread

[GitHub] [kafka] dajac commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

2022-12-09 Thread GitBox
dajac commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1044643791 ## clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java: ## @@ -590,6 +595,14 @@ public boolean handleResponse(FetchResponse response, short version)

[GitHub] [kafka] C0urante commented on a diff in pull request #12947: KAFKA-6586: Refactor ConnectDistributed and ConnectStandalone to re-use shared logic

2022-12-09 Thread GitBox
C0urante commented on code in PR #12947: URL: https://github.com/apache/kafka/pull/12947#discussion_r1044671346 ## connect/runtime/src/main/java/org/apache/kafka/connect/cli/AbstractConnectCli.java: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [kafka] hachikuji commented on a diff in pull request #12968: KAFKA-14417: Addressing the error server side

2022-12-09 Thread GitBox
hachikuji commented on code in PR #12968: URL: https://github.com/apache/kafka/pull/12968#discussion_r1044670130 ## core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala: ## @@ -167,7 +167,7 @@ class RPCProducerIdManager(brokerId: Int, if (nextProducer

[GitHub] [kafka] hachikuji commented on a diff in pull request #12968: KAFKA-14417: Addressing the error server side

2022-12-09 Thread GitBox
hachikuji commented on code in PR #12968: URL: https://github.com/apache/kafka/pull/12968#discussion_r1044670130 ## core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala: ## @@ -167,7 +167,7 @@ class RPCProducerIdManager(brokerId: Int, if (nextProducer

[GitHub] [kafka] C0urante commented on pull request #12941: KAFKA-13709: Add docs for exactly-once support in Connect

2022-12-09 Thread GitBox
C0urante commented on PR #12941: URL: https://github.com/apache/kafka/pull/12941#issuecomment-1344572069 Thanks @tikimims! I've accepted all but one of the suggestions and asked for clarification on the other. I didn't realize how common usage of "you" and "your" in the docs were; switching

[GitHub] [kafka] C0urante commented on a diff in pull request #12941: KAFKA-13709: Add docs for exactly-once support in Connect

2022-12-09 Thread GitBox
C0urante commented on code in PR #12941: URL: https://github.com/apache/kafka/pull/12941#discussion_r1044667119 ## docs/connect.html: ## @@ -369,6 +369,114 @@ Error Reportin # Tolerate all errors. errors.tolerance=all +Exactly-once support + +Kafka Connect is capabl

[GitHub] [kafka] ijuma merged pull request #12951: MINOR: Move MetadataQuorumCommand from `core` to `tools`

2022-12-09 Thread GitBox
ijuma merged PR #12951: URL: https://github.com/apache/kafka/pull/12951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] ijuma commented on pull request #12951: MINOR: Move MetadataQuorumCommand from `core` to `tools`

2022-12-09 Thread GitBox
ijuma commented on PR #12951: URL: https://github.com/apache/kafka/pull/12951#issuecomment-1344566879 Failures are unrelated. Merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] C0urante commented on a diff in pull request #12941: KAFKA-13709: Add docs for exactly-once support in Connect

2022-12-09 Thread GitBox
C0urante commented on code in PR #12941: URL: https://github.com/apache/kafka/pull/12941#discussion_r1044663744 ## docs/connect.html: ## @@ -369,6 +369,114 @@ Error Reportin # Tolerate all errors. errors.tolerance=all +Exactly-once support + +Kafka Connect is capabl

[GitHub] [kafka] C0urante commented on a diff in pull request #12941: KAFKA-13709: Add docs for exactly-once support in Connect

2022-12-09 Thread GitBox
C0urante commented on code in PR #12941: URL: https://github.com/apache/kafka/pull/12941#discussion_r1044663744 ## docs/connect.html: ## @@ -369,6 +369,114 @@ Error Reportin # Tolerate all errors. errors.tolerance=all +Exactly-once support + +Kafka Connect is capabl

[GitHub] [kafka] mumrah commented on a diff in pull request #12965: KAFKA-14448 Let ZK brokers register with KRaft controller

2022-12-09 Thread GitBox
mumrah commented on code in PR #12965: URL: https://github.com/apache/kafka/pull/12965#discussion_r1044612119 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -690,6 +772,14 @@ class KafkaServer( _brokerState = BrokerState.PENDING_CONTROLLED_SHUTDOWN +

[GitHub] [kafka] mumrah commented on a diff in pull request #12965: KAFKA-14448 Let ZK brokers register with KRaft controller

2022-12-09 Thread GitBox
mumrah commented on code in PR #12965: URL: https://github.com/apache/kafka/pull/12965#discussion_r1044606857 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -81,6 +84,19 @@ object KafkaServer { clientConfig } + def zkClient(name: String, time: Time, conf

[GitHub] [kafka] mumrah commented on a diff in pull request #12965: KAFKA-14448 Let ZK brokers register with KRaft controller

2022-12-09 Thread GitBox
mumrah commented on code in PR #12965: URL: https://github.com/apache/kafka/pull/12965#discussion_r1044604344 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -2230,8 +2230,15 @@ class KafkaConfig private(doLog: Boolean, val props: java.util.Map[_, _], dynami

[jira] [Resolved] (KAFKA-14413) Separate MirrorMaker configurations for each connector

2022-12-09 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-14413. --- Fix Version/s: 3.4.0 Resolution: Done > Separate MirrorMaker configurations for each

[GitHub] [kafka] C0urante commented on a diff in pull request #12937: KAFKA-13881: Add Connect package infos

2022-12-09 Thread GitBox
C0urante commented on code in PR #12937: URL: https://github.com/apache/kafka/pull/12937#discussion_r1044592612 ## connect/api/src/main/java/org/apache/kafka/connect/connector/policy/package-info.java: ## @@ -0,0 +1,20 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] C0urante commented on a diff in pull request #12937: KAFKA-13881: Add Connect package infos

2022-12-09 Thread GitBox
C0urante commented on code in PR #12937: URL: https://github.com/apache/kafka/pull/12937#discussion_r1041120667 ## connect/api/src/main/java/org/apache/kafka/connect/connector/policy/package-info.java: ## @@ -0,0 +1,20 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] C0urante commented on a diff in pull request #12937: KAFKA-13881: Add Connect package infos

2022-12-09 Thread GitBox
C0urante commented on code in PR #12937: URL: https://github.com/apache/kafka/pull/12937#discussion_r1041120667 ## connect/api/src/main/java/org/apache/kafka/connect/connector/policy/package-info.java: ## @@ -0,0 +1,20 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Resolved] (KAFKA-14425) The Kafka protocol should support nullable structs

2022-12-09 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-14425. - Fix Version/s: 3.5.0 Resolution: Fixed > The Kafka protocol should support nullable struc

[jira] [Updated] (KAFKA-14391) Add ConsumerGroupHeartbeat API

2022-12-09 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-14391: Fix Version/s: (was: 3.5.0) > Add ConsumerGroupHeartbeat API > --

[jira] [Reopened] (KAFKA-14391) Add ConsumerGroupHeartbeat API

2022-12-09 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reopened KAFKA-14391: - > Add ConsumerGroupHeartbeat API > -- > > Key: KAFKA-143

[jira] [Updated] (KAFKA-14425) The Kafka protocol should support nullable structs

2022-12-09 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-14425: Description: KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-893%3A+The+Kafka+protocol+

[jira] [Comment Edited] (KAFKA-14172) bug: State stores lose state when tasks are reassigned under EOS wit…

2022-12-09 Thread John Gray (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645330#comment-17645330 ] John Gray edited comment on KAFKA-14172 at 12/9/22 2:53 PM:

[jira] [Comment Edited] (KAFKA-14172) bug: State stores lose state when tasks are reassigned under EOS wit…

2022-12-09 Thread John Gray (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645330#comment-17645330 ] John Gray edited comment on KAFKA-14172 at 12/9/22 2:53 PM:

[jira] [Resolved] (KAFKA-14391) Add ConsumerGroupHeartbeat API

2022-12-09 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-14391. - Fix Version/s: 3.5.0 Resolution: Fixed > Add ConsumerGroupHeartbeat API > ---

[jira] [Comment Edited] (KAFKA-14172) bug: State stores lose state when tasks are reassigned under EOS wit…

2022-12-09 Thread John Gray (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645330#comment-17645330 ] John Gray edited comment on KAFKA-14172 at 12/9/22 2:52 PM:

[jira] [Updated] (KAFKA-14172) bug: State stores lose state when tasks are reassigned under EOS wit…

2022-12-09 Thread John Gray (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Gray updated KAFKA-14172: -- Priority: Critical (was: Major) > bug: State stores lose state when tasks are reassigned under EOS wi

[jira] [Commented] (KAFKA-14172) bug: State stores lose state when tasks are reassigned under EOS wit…

2022-12-09 Thread John Gray (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645330#comment-17645330 ] John Gray commented on KAFKA-14172: --- I do hope this bug gets some eyes eventually, it

[GitHub] [kafka] dajac commented on pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API

2022-12-09 Thread GitBox
dajac commented on PR #12972: URL: https://github.com/apache/kafka/pull/12972#issuecomment-1344397829 This PR incudes https://github.com/apache/kafka/pull/12969 for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] dajac opened a new pull request, #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API

2022-12-09 Thread GitBox
dajac opened a new pull request, #12972: URL: https://github.com/apache/kafka/pull/12972 This patch adds the ConsumerGroupHeartbeat API alongside its new related errors. The API is gated by an internal configuration flag at the moment. Hence the API cannot be used by clients yet. The mechan

[GitHub] [kafka] dajac commented on a diff in pull request #12855: KAFKA-14367; Add `DescribeGroups` to the new `GroupCoordinator` interface

2022-12-09 Thread GitBox
dajac commented on code in PR #12855: URL: https://github.com/apache/kafka/pull/12855#discussion_r104236 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1571,53 +1571,47 @@ class KafkaApis(val requestChannel: RequestChannel, } } - def handleDescribeGro

[GitHub] [kafka] dajac merged pull request #12970: MINOR: Small refactor in DescribeGroupsResponse

2022-12-09 Thread GitBox
dajac merged PR #12970: URL: https://github.com/apache/kafka/pull/12970 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] sagarrao12 commented on pull request #12971: KAFKA-14454: Making unique StreamsConfig for tests

2022-12-09 Thread GitBox
sagarrao12 commented on PR #12971: URL: https://github.com/apache/kafka/pull/12971#issuecomment-1344187051 @ableegoldman , the failed tests seem unrelated to this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] mimaison commented on a diff in pull request #12965: KAFKA-14448 Let ZK brokers register with KRaft controller

2022-12-09 Thread GitBox
mimaison commented on code in PR #12965: URL: https://github.com/apache/kafka/pull/12965#discussion_r1044340329 ## metadata/src/main/java/org/apache/kafka/metadata/BrokerRegistration.java: ## @@ -234,6 +277,7 @@ public String toString() { bld.append(", rack=").append(ra

[GitHub] [kafka] dajac commented on a diff in pull request #12855: KAFKA-14367; Add `DescribeGroups` to the new `GroupCoordinator` interface

2022-12-09 Thread GitBox
dajac commented on code in PR #12855: URL: https://github.com/apache/kafka/pull/12855#discussion_r1044275943 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1571,53 +1571,47 @@ class KafkaApis(val requestChannel: RequestChannel, } } - def handleDescribeGro

[GitHub] [kafka] showuon commented on pull request #12729: KAFKA-14285: Delete quota node in zookeeper when configs are empty

2022-12-09 Thread GitBox
showuon commented on PR #12729: URL: https://github.com/apache/kafka/pull/12729#issuecomment-1344016944 Thanks for the update. It failed many tests in jdk17, should be infra's issue. Rerunning the tests: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-12729/7/ -- This is an au

[GitHub] [kafka] ableegoldman commented on a diff in pull request #12962: KAFKA-14318: KIP-878, Introduce partition autoscaling configs

2022-12-09 Thread GitBox
ableegoldman commented on code in PR #12962: URL: https://github.com/apache/kafka/pull/12962#discussion_r1044208412 ## streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java: ## @@ -1368,6 +1370,20 @@ public void shouldNotEnableAnyOptimizationsWithNoOptimizationC

[GitHub] [kafka] vamossagar12 commented on pull request #12971: KAFKA-14454: Making unique StreamsConfig for tests

2022-12-09 Thread GitBox
vamossagar12 commented on PR #12971: URL: https://github.com/apache/kafka/pull/12971#issuecomment-1343979588 > Looks like Commit failed after one of the suggestions. Would push a fix for that in sometime. Pushed a fix and tests seemed to have passed locally. -- This is an automated

[jira] [Commented] (KAFKA-10902) IllegalMonitorStateException in KafkaProducer.waitOnMetadata

2022-12-09 Thread Mikhail Marukhin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645142#comment-17645142 ] Mikhail Marukhin commented on KAFKA-10902: -- It looks like it's JIT issue. We ha