ableegoldman commented on code in PR #12935: URL: https://github.com/apache/kafka/pull/12935#discussion_r1044948661
########## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java: ########## @@ -526,6 +521,9 @@ public synchronized void close() { fOptions.close(); filter.close(); cache.close(); + if (statistics != null) { + statistics.close(); + } Review Comment: Sorry, I meant the "real" docs on the actual kafka site, not the javadocs. Seems like it would be useful to show how/why to use your own `Statistics` like this. Anyways I just filed a ticket for this so someone else can pick it up https://issues.apache.org/jira/browse/KAFKA-14459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org