[GitHub] [kafka] showuon commented on a diff in pull request #12753: MINOR: Document Offset and Partition 0-indexing, fix typo

2022-11-10 Thread GitBox
showuon commented on code in PR #12753: URL: https://github.com/apache/kafka/pull/12753#discussion_r1019962773 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -694,6 +694,76 @@ class PlaintextConsumerTest extends BaseConsumerTest { assertEqua

[GitHub] [kafka] showuon commented on a diff in pull request #12753: MINOR: Document Offset and Partition 0-indexing, fix typo

2022-11-10 Thread GitBox
showuon commented on code in PR #12753: URL: https://github.com/apache/kafka/pull/12753#discussion_r1019949776 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -694,6 +694,76 @@ class PlaintextConsumerTest extends BaseConsumerTest { assertEqua

[jira] [Assigned] (KAFKA-14260) InMemoryKeyValueStore iterator still throws ConcurrentModificationException

2022-11-10 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-14260: -- Assignee: A. Sophie Blee-Goldman > InMemoryKeyValueStore iterator sti

[jira] [Commented] (KAFKA-14260) InMemoryKeyValueStore iterator still throws ConcurrentModificationException

2022-11-10 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632093#comment-17632093 ] A. Sophie Blee-Goldman commented on KAFKA-14260: Seems like we should ju

[GitHub] [kafka] ableegoldman commented on a diff in pull request #12836: KAFKA-14282: stop tracking Produced sensors by processor node id

2022-11-10 Thread GitBox
ableegoldman commented on code in PR #12836: URL: https://github.com/apache/kafka/pull/12836#discussion_r1019854586 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java: ## @@ -219,26 +219,20 @@ public void send(final String topic,

[jira] [Commented] (KAFKA-14362) Same message consumed by two consumers in the same group after client restart

2022-11-10 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632082#comment-17632082 ] A. Sophie Blee-Goldman commented on KAFKA-14362: {quote}I would have tho

[jira] [Updated] (KAFKA-14382) StreamThreads can miss rebalance events when processing records during a rebalance

2022-11-10 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-14382: --- Description: One of the main improvements introduced by the cooperative prot

[jira] [Created] (KAFKA-14382) StreamThreads can miss rebalance events when processing records during a rebalance

2022-11-10 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-14382: -- Summary: StreamThreads can miss rebalance events when processing records during a rebalance Key: KAFKA-14382 URL: https://issues.apache.org/jira/browse/KAFKA-1

[GitHub] [kafka] showuon commented on a diff in pull request #12840: Updated Jackson to version 2.13.4 for fixing CVE-2022-42004

2022-11-10 Thread GitBox
showuon commented on code in PR #12840: URL: https://github.com/apache/kafka/pull/12840#discussion_r1019805336 ## LICENSE-binary: ## @@ -208,18 +208,18 @@ License Version 2.0: audience-annotations-0.5.0 commons-cli-1.4 commons-lang3-3.12.0 -jackson-annotations-2.13.3 -jackson

[jira] [Commented] (KAFKA-14379) consumer should refresh preferred read replica on update metadata

2022-11-10 Thread Deng Ziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632031#comment-17632031 ] Deng Ziming commented on KAFKA-14379: - Hello [~jeffkbkim] , you created another dupl

[jira] [Resolved] (KAFKA-14380) consumer should refresh preferred read replica on metadata update

2022-11-10 Thread Deng Ziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deng Ziming resolved KAFKA-14380. - Resolution: Duplicate duplicated with KAFKA-14379 > consumer should refresh preferred read repl

[jira] [Resolved] (KAFKA-14378) consumer should refresh preferred read replica on update metadata

2022-11-10 Thread Deng Ziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deng Ziming resolved KAFKA-14378. - Resolution: Duplicate duplicated with KAFKA-14379 > consumer should refresh preferred read repl

[jira] [Commented] (KAFKA-12935) Flaky Test RestoreIntegrationTest.shouldRecycleStateFromStandbyTaskPromotedToActiveTaskAndNotRestore

2022-11-10 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632021#comment-17632021 ] A. Sophie Blee-Goldman commented on KAFKA-12935: Reopening this since it

[jira] [Assigned] (KAFKA-12935) Flaky Test RestoreIntegrationTest.shouldRecycleStateFromStandbyTaskPromotedToActiveTaskAndNotRestore

2022-11-10 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-12935: -- Assignee: (was: Walker Carlson) > Flaky Test > RestoreIntegratio

[jira] [Updated] (KAFKA-12935) Flaky Test RestoreIntegrationTest.shouldRecycleStateFromStandbyTaskPromotedToActiveTaskAndNotRestore

2022-11-10 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12935: --- Attachment: RestoreIntegrationTest#shouldRecycleStateFromStandbyTaskPromoted

[jira] [Updated] (KAFKA-12935) Flaky Test RestoreIntegrationTest.shouldRecycleStateFromStandbyTaskPromotedToActiveTaskAndNotRestore

2022-11-10 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12935: --- Fix Version/s: (was: 3.1.0) > Flaky Test > RestoreIntegrationTest.shoul

[jira] [Commented] (KAFKA-9914) Mirror Maker 2 creates heartbeats kafka topics recursively

2022-11-10 Thread Viktor Utkin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632001#comment-17632001 ] Viktor Utkin commented on KAFKA-9914: - This is not a bug, this is misconfiguration:

[jira] [Assigned] (KAFKA-14381) Support listing all partitions being reassigned in a cluster

2022-11-10 Thread Lucas Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Wang reassigned KAFKA-14381: -- Assignee: Lucas Wang > Support listing all partitions being reassigned in a cluster > ---

[jira] [Created] (KAFKA-14381) Support listing all partitions being reassigned in a cluster

2022-11-10 Thread Lucas Wang (Jira)
Lucas Wang created KAFKA-14381: -- Summary: Support listing all partitions being reassigned in a cluster Key: KAFKA-14381 URL: https://issues.apache.org/jira/browse/KAFKA-14381 Project: Kafka Iss

[jira] [Created] (KAFKA-14380) consumer should refresh preferred read replica on metadata update

2022-11-10 Thread Jeff Kim (Jira)
Jeff Kim created KAFKA-14380: Summary: consumer should refresh preferred read replica on metadata update Key: KAFKA-14380 URL: https://issues.apache.org/jira/browse/KAFKA-14380 Project: Kafka Is

[jira] [Created] (KAFKA-14379) consumer should refresh preferred read replica on update metadata

2022-11-10 Thread Jeff Kim (Jira)
Jeff Kim created KAFKA-14379: Summary: consumer should refresh preferred read replica on update metadata Key: KAFKA-14379 URL: https://issues.apache.org/jira/browse/KAFKA-14379 Project: Kafka Is

[jira] [Created] (KAFKA-14378) consumer should refresh preferred read replica on update metadata

2022-11-10 Thread Jeff Kim (Jira)
Jeff Kim created KAFKA-14378: Summary: consumer should refresh preferred read replica on update metadata Key: KAFKA-14378 URL: https://issues.apache.org/jira/browse/KAFKA-14378 Project: Kafka Is

[jira] [Updated] (KAFKA-14373) provide builders for producer/consumer

2022-11-10 Thread Daniel Scanteianu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Scanteianu updated KAFKA-14373: -- Description: creating a producer/consumer involves looking up the consts for kafka co

[GitHub] [kafka] hachikuji commented on a diff in pull request #12837: MINOR: extract jointly owned parts of BrokerServer and ControllerServer

2022-11-10 Thread GitBox
hachikuji commented on code in PR #12837: URL: https://github.com/apache/kafka/pull/12837#discussion_r1019455482 ## core/src/main/scala/kafka/server/JointServer.scala: ## @@ -0,0 +1,237 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributo

[jira] [Created] (KAFKA-14377) Expose Broker's Name and Version to Clients

2022-11-10 Thread Travis Bischel (Jira)
Travis Bischel created KAFKA-14377: -- Summary: Expose Broker's Name and Version to Clients Key: KAFKA-14377 URL: https://issues.apache.org/jira/browse/KAFKA-14377 Project: Kafka Issue Type: I

[jira] [Updated] (KAFKA-14376) Add ConfigProvider to make use of environment variables

2022-11-10 Thread Roman Schmitz (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Schmitz updated KAFKA-14376: -- Description: So far it is not possible to inject additional configurations stored in environm

[jira] [Created] (KAFKA-14376) Add ConfigProvider to make use of environment variables

2022-11-10 Thread Roman Schmitz (Jira)
Roman Schmitz created KAFKA-14376: - Summary: Add ConfigProvider to make use of environment variables Key: KAFKA-14376 URL: https://issues.apache.org/jira/browse/KAFKA-14376 Project: Kafka Iss

[GitHub] [kafka] nicktelford commented on pull request #12842: MINOR: Fix double iteration of restoring records

2022-11-10 Thread GitBox
nicktelford commented on PR #12842: URL: https://github.com/apache/kafka/pull/12842#issuecomment-1310644429 I wasn't sure if this warranted a JIRA ticket, since it's very small. I've not included any tests because there should not be any behavioural changes here, and I expect the existing t

[GitHub] [kafka] nicktelford opened a new pull request, #12842: MINOR: Fix double iteration of restoring records

2022-11-10 Thread GitBox
nicktelford opened a new pull request, #12842: URL: https://github.com/apache/kafka/pull/12842 While restoring a batch of records, `RocksDBStore` was iterating the `ConsumerRecord`s, building a list of `KeyValue`s, and then iterating _that_ list of `KeyValue`s to add them to the RocksDB bat

[GitHub] [kafka] lucasbru commented on pull request #12795: KAFKA-14299: Initialize tasks in state updater

2022-11-10 Thread GitBox
lucasbru commented on PR #12795: URL: https://github.com/apache/kafka/pull/12795#issuecomment-1310605841 The failed tests are unrelated. ``` Build / JDK 11 and Scala 2.13 / testSecondaryRefreshAfterElapsedDelay() – org.apache.kafka.common.security.oauthbearer.internals.secured.Ref

[GitHub] [kafka] mimaison commented on pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

2022-11-10 Thread GitBox
mimaison commented on PR #12577: URL: https://github.com/apache/kafka/pull/12577#issuecomment-1310586112 Thanks! I'm off tomorrow but I'll take a look early next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [kafka] OmniaGM commented on pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

2022-11-10 Thread GitBox
OmniaGM commented on PR #12577: URL: https://github.com/apache/kafka/pull/12577#issuecomment-1310558971 @mimaison Mirror tests are now okay, the pipeline is failing because of `org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated` which isn't related

[jira] [Assigned] (KAFKA-14375) Remove use of "authorizer-properties" in EndToEndAuthorizationTest.scala

2022-11-10 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar reassigned KAFKA-14375: - Assignee: Proven Provenzano > Remove use of "authorizer-properties" in EndToEndAuthorizationTes

[jira] [Updated] (KAFKA-14375) Remove use of "authorizer-properties" in EndToEndAuthorizationTest.scala

2022-11-10 Thread Proven Provenzano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Proven Provenzano updated KAFKA-14375: -- Description: The use of {{authorizer-properties}} in AclCommand is deprecated and End

[jira] [Updated] (KAFKA-14375) Remove use of "authorizer-properties" in EndToEndAuthorizationTest.scala

2022-11-10 Thread Proven Provenzano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Proven Provenzano updated KAFKA-14375: -- Summary: Remove use of "authorizer-properties" in EndToEndAuthorizationTest.scala (wa

[jira] [Created] (KAFKA-14375) Remove use of "authorizer-properties" n EndToEndAuthorizationTest.scala

2022-11-10 Thread Proven Provenzano (Jira)
Proven Provenzano created KAFKA-14375: - Summary: Remove use of "authorizer-properties" n EndToEndAuthorizationTest.scala Key: KAFKA-14375 URL: https://issues.apache.org/jira/browse/KAFKA-14375 Pro

[GitHub] [kafka] cadonna commented on pull request #12809: [KAFKA-14324] Upgrade RocksDB to 7.1.2

2022-11-10 Thread GitBox
cadonna commented on PR #12809: URL: https://github.com/apache/kafka/pull/12809#issuecomment-1310477888 @clolov, could you please rebase to recent trunk since on trunk there is a fix for the flaky `RestoreIntegrationTest` which failed quite often in the builds? -- This is an automated me

[GitHub] [kafka] OmniaGM commented on pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

2022-11-10 Thread GitBox
OmniaGM commented on PR #12577: URL: https://github.com/apache/kafka/pull/12577#issuecomment-1310407613 > @OmniaGM I see you pushed updates a few times in the past few days. There's nothing wrong with that. Just in case you're pushing to rerun the tests, you can run the MirrorMaker test

[GitHub] [kafka] mimaison commented on pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

2022-11-10 Thread GitBox
mimaison commented on PR #12577: URL: https://github.com/apache/kafka/pull/12577#issuecomment-1310339077 @OmniaGM I see you pushed updates a few times in the past few days. There's nothing wrong with that. Just in case you're pushing to rerun the tests, you can run the MirrorMaker tests loc

[GitHub] [kafka] cadonna merged pull request #12841: MINOR: Fix flaky RestoreIntegrationTest

2022-11-10 Thread GitBox
cadonna merged PR #12841: URL: https://github.com/apache/kafka/pull/12841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] cadonna commented on pull request #12841: MINOR: Fix flaky RestoreIntegrationTest

2022-11-10 Thread GitBox
cadonna commented on PR #12841: URL: https://github.com/apache/kafka/pull/12841#issuecomment-1310259756 Build failure is unrelated: ``` Build / JDK 11 and Scala 2.13 / org.apache.kafka.clients.consumer.KafkaConsumerTest.testWakeupWithFetchDataAvailable() ``` -- This is an automat

[GitHub] [kafka] clolov commented on a diff in pull request #12809: [KAFKA-14324] Upgrade RocksDB to 7.1.2

2022-11-10 Thread GitBox
clolov commented on code in PR #12809: URL: https://github.com/apache/kafka/pull/12809#discussion_r1019053647 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java: ## @@ -610,15 +617,21 @@ public Access

[jira] [Assigned] (KAFKA-7739) Kafka Tiered Storage

2022-11-10 Thread Zhangheng Huang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhangheng Huang reassigned KAFKA-7739: -- Assignee: Satish Duggana > Kafka Tiered Storage > > >

[jira] [Assigned] (KAFKA-7739) Kafka Tiered Storage

2022-11-10 Thread Zhangheng Huang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhangheng Huang reassigned KAFKA-7739: -- Assignee: (was: Zhangheng Huang) > Kafka Tiered Storage > > >

[jira] [Assigned] (KAFKA-7739) Kafka Tiered Storage

2022-11-10 Thread Zhangheng Huang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhangheng Huang reassigned KAFKA-7739: -- Assignee: Zhangheng Huang (was: Satish Duggana) > Kafka Tiered Storage >

[GitHub] [kafka] cadonna commented on pull request #12795: KAFKA-14299: Initialize tasks in state updater

2022-11-10 Thread GitBox
cadonna commented on PR #12795: URL: https://github.com/apache/kafka/pull/12795#issuecomment-1310108263 Good catch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [kafka] lucasbru commented on pull request #12795: KAFKA-14299: Initialize tasks in state updater

2022-11-10 Thread GitBox
lucasbru commented on PR #12795: URL: https://github.com/apache/kafka/pull/12795#issuecomment-1310105681 I noticed we then also shouldn't initialize the task during recycling (to not get races between state updater and main thread). This was flagged during smoke testing -- This is an aut

[GitHub] [kafka] lucasbru commented on a diff in pull request #12795: KAFKA-14299: Initialize tasks in state updater

2022-11-10 Thread GitBox
lucasbru commented on code in PR #12795: URL: https://github.com/apache/kafka/pull/12795#discussion_r1018951885 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -250,30 +261,31 @@ private void removeUpdatingAndPausedTasks() {

[GitHub] [kafka] pratimsc commented on pull request #12840: Updated Jackson to version 2.13.4 for fixing CVE-2022-42004

2022-11-10 Thread GitBox
pratimsc commented on PR #12840: URL: https://github.com/apache/kafka/pull/12840#issuecomment-1310098026 > Should we also bump the `jackson-databind` to 2.13.4.2 for [CVE-2022-42003](https://github.com/advisories/GHSA-jjjh-jjxp-wpff)? > > ref: [spring-projects/spring-boot#32583](http

[GitHub] [kafka] cadonna commented on a diff in pull request #12795: KAFKA-14299: Initialize tasks in state updater

2022-11-10 Thread GitBox
cadonna commented on code in PR #12795: URL: https://github.com/apache/kafka/pull/12795#discussion_r1018928862 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -121,21 +121,32 @@ private void runOnce() throws InterruptedExcept

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

2022-11-10 Thread GitBox
showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1018917087 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignorTest.java: ## @@ -55,12 +60,22 @@ public abstract class AbstractStickyAssigno

[GitHub] [kafka] showuon commented on pull request #12748: KAFKA-13715: add generationId field in subscription

2022-11-10 Thread GitBox
showuon commented on PR #12748: URL: https://github.com/apache/kafka/pull/12748#issuecomment-1310065769 @dajac , PR updated. Please take a look when available. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

2022-11-10 Thread GitBox
showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1018909824 ## clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java: ## @@ -78,6 +80,26 @@ public void testDecodeGeneration() { asser

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

2022-11-10 Thread GitBox
showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1018908171 ## clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java: ## @@ -78,6 +80,26 @@ public void testDecodeGeneration() { asser

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

2022-11-10 Thread GitBox
showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1018907375 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java: ## @@ -1229,4 +1247,23 @@ private boolean in(Set pairs) {

[GitHub] [kafka] lucasbru commented on a diff in pull request #12795: KAFKA-14299: Initialize tasks in state updater

2022-11-10 Thread GitBox
lucasbru commented on code in PR #12795: URL: https://github.com/apache/kafka/pull/12795#discussion_r1018903133 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -121,21 +121,32 @@ private void runOnce() throws InterruptedExcep

[jira] [Created] (KAFKA-14374) Kafka streams losing messages in State Store during first launch of app

2022-11-10 Thread Youcef Sebiat (Jira)
Youcef Sebiat created KAFKA-14374: - Summary: Kafka streams losing messages in State Store during first launch of app Key: KAFKA-14374 URL: https://issues.apache.org/jira/browse/KAFKA-14374 Project: Ka

[GitHub] [kafka] lucasbru commented on a diff in pull request #12795: KAFKA-14299: Initialize tasks in state updater

2022-11-10 Thread GitBox
lucasbru commented on code in PR #12795: URL: https://github.com/apache/kafka/pull/12795#discussion_r1018881878 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -250,30 +261,31 @@ private void removeUpdatingAndPausedTasks() {

[GitHub] [kafka] lucasbru commented on pull request #12841: MINOR: Fix flaky RestoreIntegrationTest

2022-11-10 Thread GitBox
lucasbru commented on PR #12841: URL: https://github.com/apache/kafka/pull/12841#issuecomment-1310016220 @cadonna Could you have a look? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] lucasbru opened a new pull request, #12841: MINOR: Fix flaky RestoreIntegrationTest

2022-11-10 Thread GitBox
lucasbru opened a new pull request, #12841: URL: https://github.com/apache/kafka/pull/12841 RestoreIntegrationTest used polling to determine if a rebalance happens on one client, but if the rebalance would happen too quickly, the polling would not pick it up and the check would time out.

[GitHub] [kafka] cadonna commented on a diff in pull request #12795: KAFKA-14299: Initialize tasks in state updater

2022-11-10 Thread GitBox
cadonna commented on code in PR #12795: URL: https://github.com/apache/kafka/pull/12795#discussion_r1018848451 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -277,6 +294,9 @@ private void addTask(final Task task) {

[GitHub] [kafka] cadonna commented on a diff in pull request #12795: KAFKA-14299: Initialize tasks in state updater

2022-11-10 Thread GitBox
cadonna commented on code in PR #12795: URL: https://github.com/apache/kafka/pull/12795#discussion_r1018831974 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -121,21 +121,32 @@ private void runOnce() throws InterruptedExcept

[GitHub] [kafka] cadonna commented on a diff in pull request #12835: KAFKA-14294: check whether a transaction is in flight before skipping a commit

2022-11-10 Thread GitBox
cadonna commented on code in PR #12835: URL: https://github.com/apache/kafka/pull/12835#discussion_r1018816579 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -4450,6 +4448,10 @@ public void shouldNotFailForTimeoutExceptionOnCom

[GitHub] [kafka] cadonna commented on a diff in pull request #12835: KAFKA-14294: check whether a transaction is in flight before skipping a commit

2022-11-10 Thread GitBox
cadonna commented on code in PR #12835: URL: https://github.com/apache/kafka/pull/12835#discussion_r1018815885 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskExecutorTest.java: ## @@ -35,4 +45,47 @@ public void testPunctuateWithPause() { taskE

[GitHub] [kafka] cadonna commented on a diff in pull request #12835: KAFKA-14294: check whether a transaction is in flight before skipping a commit

2022-11-10 Thread GitBox
cadonna commented on code in PR #12835: URL: https://github.com/apache/kafka/pull/12835#discussion_r1018813558 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskExecutor.java: ## @@ -191,43 +191,49 @@ void commitOffsetsOrTransaction(final Map allOffsets =