showuon commented on code in PR #12748:
URL: https://github.com/apache/kafka/pull/12748#discussion_r1018917087
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignorTest.java:
##########
@@ -55,12 +60,22 @@ public abstract class AbstractStickyAssignorTest {
protected String topic1 = "topic1";
protected String topic2 = "topic2";
protected String topic3 = "topic3";
+ protected TopicPartition tp0 = tp(topic, 0);
+ protected TopicPartition tp1 = tp(topic, 1);
+ protected TopicPartition tp2 = tp(topic, 2);
+ protected String groupId = "group";
+ protected int generationId = 1;
protected abstract AbstractStickyAssignor createAssignor();
- protected abstract Subscription buildSubscription(List<String> topics,
List<TopicPartition> partitions);
+ // simulate ConsumerProtocolSubscription V0 protocol
+ protected abstract Subscription buildSubscriptionV0(List<String> topics,
List<TopicPartition> partitions, int generationId);
- protected abstract Subscription
buildSubscriptionWithGeneration(List<String> topics, List<TopicPartition>
partitions, int generation);
+ // simulate ConsumerProtocolSubscription V1 protocol
+ protected abstract Subscription buildSubscriptionV1(List<String> topics,
List<TopicPartition> partitions, int generationId);
+
+ // simulate ConsumerProtocolSubscription V2 or above protocol
+ protected abstract Subscription buildSubscriptionV2Above(List<String>
topics, List<TopicPartition> partitions, int generation);
Review Comment:
Created `buildSubscriptionV0`, `buildSubscriptionV1`, and
`buildSubscriptionV2Above` for all versions tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
