[GitHub] [kafka] Gerrrr commented on a diff in pull request #12393: WIP: KAFKA-12549 Prototype for transactional state stores

2022-10-18 Thread GitBox
Ge commented on code in PR #12393: URL: https://github.com/apache/kafka/pull/12393#discussion_r998932827 ## streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractTransactionalStore.java: ## @@ -0,0 +1,442 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] Gerrrr commented on a diff in pull request #12393: WIP: KAFKA-12549 Prototype for transactional state stores

2022-10-18 Thread GitBox
Ge commented on code in PR #12393: URL: https://github.com/apache/kafka/pull/12393#discussion_r998929720 ## streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractTransactionalStore.java: ## @@ -0,0 +1,442 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] Gerrrr commented on a diff in pull request #12393: WIP: KAFKA-12549 Prototype for transactional state stores

2022-10-18 Thread GitBox
Ge commented on code in PR #12393: URL: https://github.com/apache/kafka/pull/12393#discussion_r998928697 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java: ## @@ -115,7 +115,7 @@ static void closeStateManager(final Logger log,

[GitHub] [kafka] Gerrrr commented on a diff in pull request #12393: WIP: KAFKA-12549 Prototype for transactional state stores

2022-10-18 Thread GitBox
Ge commented on code in PR #12393: URL: https://github.com/apache/kafka/pull/12393#discussion_r998928697 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java: ## @@ -115,7 +115,7 @@ static void closeStateManager(final Logger log,

[GitHub] [kafka] ableegoldman commented on a diff in pull request #12758: KAFKA-13152: KIP-770, cache size config deprecation

2022-10-18 Thread GitBox
ableegoldman commented on code in PR #12758: URL: https://github.com/apache/kafka/pull/12758#discussion_r998896253 ## streams/src/main/java/org/apache/kafka/streams/internals/StreamsConfigUtils.java: ## @@ -66,4 +73,28 @@ public static boolean eosEnabled(final ProcessingMode pr

[GitHub] [kafka] showuon commented on a diff in pull request #12763: KAFKA-14273: Kafka doesn't start with KRaft on Windows

2022-10-18 Thread GitBox
showuon commented on code in PR #12763: URL: https://github.com/apache/kafka/pull/12763#discussion_r998898488 ## raft/src/main/java/org/apache/kafka/raft/FileBasedStateStore.java: ## @@ -149,6 +149,7 @@ private void writeElectionStateToFile(final File stateFile, QuorumStateData

[GitHub] [kafka] showuon commented on a diff in pull request #12753: MINOR: Document Offset and Partition 0-indexing, fix typo

2022-10-18 Thread GitBox
showuon commented on code in PR #12753: URL: https://github.com/apache/kafka/pull/12753#discussion_r998892134 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -1581,6 +1581,10 @@ public void commitAsync(final Map offsets, Of * is invoked

[GitHub] [kafka] Gerrrr commented on a diff in pull request #12393: WIP: KAFKA-12549 Prototype for transactional state stores

2022-10-18 Thread GitBox
Ge commented on code in PR #12393: URL: https://github.com/apache/kafka/pull/12393#discussion_r998842122 ## streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractTransactionalStore.java: ## @@ -0,0 +1,442 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (KAFKA-10760) In compacted topic with max.compaction.lag.ms, the segments are not rolled until new messages arrive

2022-10-18 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619908#comment-17619908 ] Jun Rao commented on KAFKA-10760: - A potential solution is to implement the time based s

[jira] [Resolved] (KAFKA-14321) max.compaction.lag.ms is not enforced accurately

2022-10-18 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-14321. - Resolution: Duplicate This actually duplicates KAFKA-10760. Closing this one. > max.compaction.lag.ms i

[GitHub] [kafka] hachikuji commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-10-18 Thread GitBox
hachikuji commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r998837515 ## raft/src/main/java/org/apache/kafka/raft/OffsetAndEpoch.java: ## @@ -25,6 +25,14 @@ public OffsetAndEpoch(long offset, int epoch) { this.epoch = epoch;

[jira] [Commented] (KAFKA-14321) max.compaction.lag.ms is not enforced accurately

2022-10-18 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619904#comment-17619904 ] Jun Rao commented on KAFKA-14321: - A potential solution is to implement the time based s

[jira] [Created] (KAFKA-14321) max.compaction.lag.ms is not enforced accurately

2022-10-18 Thread Jun Rao (Jira)
Jun Rao created KAFKA-14321: --- Summary: max.compaction.lag.ms is not enforced accurately Key: KAFKA-14321 URL: https://issues.apache.org/jira/browse/KAFKA-14321 Project: Kafka Issue Type: Bug

[jira] [Resolved] (KAFKA-4545) tombstone needs to be removed after delete.retention.ms has passed after it has been cleaned

2022-10-18 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-4545. Fix Version/s: 3.1.0 Resolution: Fixed This is fixed in KAFKA-8522. > tombstone needs to be removed

[jira] [Commented] (KAFKA-10323) NullPointerException during rebalance

2022-10-18 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619892#comment-17619892 ] Greg Harris commented on KAFKA-10323: - Also for completeness, here is the workaround

[jira] [Resolved] (KAFKA-14316) NoSuchElementException in feature control iterator

2022-10-18 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-14316. - Fix Version/s: 3.4.0 3.3.2 Resolution: Fixed > NoSuchElementEx

[jira] [Commented] (KAFKA-10323) NullPointerException during rebalance

2022-10-18 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619891#comment-17619891 ] Greg Harris commented on KAFKA-10323: - [~geliba] reported that this is still an issu

[GitHub] [kafka] hachikuji opened a new pull request, #12767: MINOR: Delete jqwik database

2022-10-18 Thread GitBox
hachikuji opened a new pull request, #12767: URL: https://github.com/apache/kafka/pull/12767 The file `metadata/.jqwik-database` was checked in by mistake in https://github.com/apache/kafka/pull/12747. In trunk, we exclude this file in `.gitignore`, so I've done so here as well. ###

[GitHub] [kafka] jlisam opened a new pull request, #12766: KAFKA-14320: Upgrade Jackson for CVE Fix

2022-10-18 Thread GitBox
jlisam opened a new pull request, #12766: URL: https://github.com/apache/kafka/pull/12766 [KAFKA-14320](https://issues.apache.org/jira/browse/KAFKA-14320) Upgrade Jackson for CVE fix. Jackson: (CVE-2020-36518)[https://nvd.nist.gov/vuln/detail/CVE-2020-36518] - Fixed by upgrading to 2

[jira] [Updated] (KAFKA-14320) Upgrade Jackson for CVE fix

2022-10-18 Thread Javier Li Sam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Javier Li Sam updated KAFKA-14320: -- Summary: Upgrade Jackson for CVE fix (was: Upgrade Jackson for CVE fixes) > Upgrade Jackson f

[jira] [Commented] (KAFKA-13486) Kafka Connect: Failed to start task due to NPE

2022-10-18 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619887#comment-17619887 ] Greg Harris commented on KAFKA-13486: - I don't believe that the REST listeners are r

[jira] [Resolved] (KAFKA-13486) Kafka Connect: Failed to start task due to NPE

2022-10-18 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris resolved KAFKA-13486. - Resolution: Duplicate > Kafka Connect: Failed to start task due to NPE > ---

[jira] [Updated] (KAFKA-14320) Upgrade Jackson for CVE fixes

2022-10-18 Thread Javier Li Sam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Javier Li Sam updated KAFKA-14320: -- Description: There is a CVE for Jackson: Jackson: [CVE-2020-36518|https://nvd.nist.gov/vuln/d

[jira] [Created] (KAFKA-14320) Upgrade Jackson for CVE fixes

2022-10-18 Thread Javier Li Sam (Jira)
Javier Li Sam created KAFKA-14320: - Summary: Upgrade Jackson for CVE fixes Key: KAFKA-14320 URL: https://issues.apache.org/jira/browse/KAFKA-14320 Project: Kafka Issue Type: Bug Com

[GitHub] [kafka] hachikuji merged pull request #12765: KAFKA-14316; Fix feature control iterator metadata version handling

2022-10-18 Thread GitBox
hachikuji merged PR #12765: URL: https://github.com/apache/kafka/pull/12765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[GitHub] [kafka] philipnee commented on a diff in pull request #12746: Consumer refactor async fetcher

2022-10-18 Thread GitBox
philipnee commented on code in PR #12746: URL: https://github.com/apache/kafka/pull/12746#discussion_r998768064 ## clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java: ## @@ -402,7 +402,7 @@ private String topicIdPartitionsToLogString(Collection partiti

[GitHub] [kafka] jsancio merged pull request #12747: KAFKA-14300; Generate snapshot after repeated controller resign

2022-10-18 Thread GitBox
jsancio merged PR #12747: URL: https://github.com/apache/kafka/pull/12747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] cmccabe commented on a diff in pull request #12747: KAFKA-14300; Generate snapshot after repeated controller resign

2022-10-18 Thread GitBox
cmccabe commented on code in PR #12747: URL: https://github.com/apache/kafka/pull/12747#discussion_r998736297 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1481,8 +1498,7 @@ private void resetToEmptyState() { snapshotGeneratorManage

[jira] [Updated] (KAFKA-14307) KRaft controller time based snapshots

2022-10-18 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-14307: --- Fix Version/s: 3.4.0 > KRaft controller time based snapshots > -

[jira] [Updated] (KAFKA-14286) Time based cluster metadata snapshots

2022-10-18 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-14286: --- Fix Version/s: 3.4.0 > Time based cluster metadata snapshots > -

[GitHub] [kafka] jsancio commented on a diff in pull request #12747: KAFKA-14300; Generate snapshot after repeated controller resign

2022-10-18 Thread GitBox
jsancio commented on code in PR #12747: URL: https://github.com/apache/kafka/pull/12747#discussion_r998729598 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1481,8 +1498,7 @@ private void resetToEmptyState() { snapshotGeneratorManage

[jira] [Updated] (KAFKA-13546) Explicitly specifying default topic creation groups should not make connector fail

2022-10-18 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-13546: -- Fix Version/s: 3.4.0 > Explicitly specifying default topic creation groups should not make con

[GitHub] [kafka] cmccabe commented on a diff in pull request #12747: KAFKA-14300; Generate snapshot after repeated controller resign

2022-10-18 Thread GitBox
cmccabe commented on code in PR #12747: URL: https://github.com/apache/kafka/pull/12747#discussion_r998722714 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1481,8 +1498,7 @@ private void resetToEmptyState() { snapshotGeneratorManage

[GitHub] [kafka] cmccabe commented on pull request #12747: KAFKA-14300; Generate snapshot after repeated controller resign

2022-10-18 Thread GitBox
cmccabe commented on PR #12747: URL: https://github.com/apache/kafka/pull/12747#issuecomment-1283019130 looks good overall, but it seems to me like resetToEmptyState should still reset this to 0. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[jira] [Assigned] (KAFKA-13989) Get connectors call fails when plugin removed

2022-10-18 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris reassigned KAFKA-13989: --- Assignee: Greg Harris > Get connectors call fails when plugin removed > ---

[jira] [Commented] (KAFKA-14206) Upgrade zookeeper to 3.7.1 to address security vulnerabilities

2022-10-18 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619788#comment-17619788 ] Igor Soarez commented on KAFKA-14206: - [~showuon] as the PR was closed and as per co

[jira] [Created] (KAFKA-14319) Storage tool format command does not work with old metadata versions

2022-10-18 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-14319: --- Summary: Storage tool format command does not work with old metadata versions Key: KAFKA-14319 URL: https://issues.apache.org/jira/browse/KAFKA-14319 Project: K

[jira] [Created] (KAFKA-14318) KIP-878: Autoscaling for Statically Partitioned Streams

2022-10-18 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-14318: -- Summary: KIP-878: Autoscaling for Statically Partitioned Streams Key: KAFKA-14318 URL: https://issues.apache.org/jira/browse/KAFKA-14318 Project: K

[jira] [Commented] (KAFKA-14000) Kafka-connect standby server shows empty tasks list

2022-10-18 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619780#comment-17619780 ] Greg Harris commented on KAFKA-14000: - This looks like similar symptoms as https://

[jira] [Updated] (KAFKA-14037) Stopping mm2 meets ExecutionException for MirrorCheckpointTask

2022-10-18 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14037: Component/s: mirrormaker > Stopping mm2 meets ExecutionException for MirrorCheckpointTask > --

[jira] [Updated] (KAFKA-14023) MirrorCheckpointTask.syncGroupOffset does not have to check if translated offset from upstream is smaller than the current consumer offset

2022-10-18 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14023: Component/s: mirrormaker > MirrorCheckpointTask.syncGroupOffset does not have to check if transla

[jira] [Resolved] (KAFKA-14137) Security Vulnerabilities reported in CVE-2021-45046 and CVE-2021-45046

2022-10-18 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris resolved KAFKA-14137. - Resolution: Fixed > Security Vulnerabilities reported in CVE-2021-45046 and CVE-2021-45046 > ---

[jira] [Commented] (KAFKA-14137) Security Vulnerabilities reported in CVE-2021-45046 and CVE-2021-45046

2022-10-18 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619773#comment-17619773 ] Greg Harris commented on KAFKA-14137: - [~createdtotrackissues] I believe this should

[GitHub] [kafka] cadonna commented on a diff in pull request #12762: KAFKA-14299: Never transition to UpdateStandby twice

2022-10-18 Thread GitBox
cadonna commented on code in PR #12762: URL: https://github.com/apache/kafka/pull/12762#discussion_r998636964 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java: ## @@ -658,6 +658,29 @@ public void shouldUpdateStandbyTaskAfterAllA

[GitHub] [kafka] cadonna merged pull request #12749: KAFKA-14299: Fix busy polling with separate state restoration

2022-10-18 Thread GitBox
cadonna merged PR #12749: URL: https://github.com/apache/kafka/pull/12749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] cadonna commented on pull request #12749: KAFKA-14299: Fix busy polling with separate state restoration

2022-10-18 Thread GitBox
cadonna commented on PR #12749: URL: https://github.com/apache/kafka/pull/12749#issuecomment-1282904554 Restarted the build and failures are unrelated: [Build / JDK 17 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.IdentityReplicationIntegrationTest.testReplicationWithEm

[jira] [Updated] (KAFKA-14317) ProduceRequest timeouts are logged as network exceptions

2022-10-18 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14317: -- Summary: ProduceRequest timeouts are logged as network exceptions (was: Producer request timeouts are

[jira] [Updated] (KAFKA-14317) Producer request timeouts are logged as network exceptions

2022-10-18 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14317: -- Description: In NetworkClient.handleTimedOutRequests, we disconnect the broker connection:   {code:jav

[jira] [Created] (KAFKA-14317) Producer request timeouts are logged as network exceptions

2022-10-18 Thread Kirk True (Jira)
Kirk True created KAFKA-14317: - Summary: Producer request timeouts are logged as network exceptions Key: KAFKA-14317 URL: https://issues.apache.org/jira/browse/KAFKA-14317 Project: Kafka Issue Ty

[jira] [Commented] (KAFKA-14315) Kraft: 1 broker setup, broker took 34 seconds to transition from PrepareCommit to CompleteCommit

2022-10-18 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619729#comment-17619729 ] Travis Bischel commented on KAFKA-14315: Note that I've also had requests repeat

[GitHub] [kafka] hachikuji opened a new pull request, #12765: KAFKA-14316; Fix feature control iterator metadata version handling

2022-10-18 Thread GitBox
hachikuji opened a new pull request, #12765: URL: https://github.com/apache/kafka/pull/12765 The iterator `FeatureControlIterator.hasNext()` checks two conditions: 1) whether we have already written the metadata version, and 2) whether the underlying iterator has additional records. However

[jira] [Created] (KAFKA-14316) NoSuchElementException in feature control iterator

2022-10-18 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-14316: --- Summary: NoSuchElementException in feature control iterator Key: KAFKA-14316 URL: https://issues.apache.org/jira/browse/KAFKA-14316 Project: Kafka Issu

[jira] [Created] (KAFKA-14315) Kraft: 1 broker setup, broker took 34 seconds to transition from PrepareCommit to CompleteCommit

2022-10-18 Thread Travis Bischel (Jira)
Travis Bischel created KAFKA-14315: -- Summary: Kraft: 1 broker setup, broker took 34 seconds to transition from PrepareCommit to CompleteCommit Key: KAFKA-14315 URL: https://issues.apache.org/jira/browse/KAFKA-143

[GitHub] [kafka] philipnee commented on a diff in pull request #12672: KAFKA-14247: Consumer background thread base implementation

2022-10-18 Thread GitBox
philipnee commented on code in PR #12672: URL: https://github.com/apache/kafka/pull/12672#discussion_r998551146 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/EventHandler.java: ## @@ -30,6 +30,14 @@ public interface EventHandler { */ Opti

[GitHub] [kafka] philipnee commented on a diff in pull request #12672: KAFKA-14247: Consumer background thread base implementation

2022-10-18 Thread GitBox
philipnee commented on code in PR #12672: URL: https://github.com/apache/kafka/pull/12672#discussion_r998548854 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultEventHandler.java: ## @@ -16,45 +16,185 @@ */ package org.apache.kafka.clients.consumer.

[GitHub] [kafka] philipnee commented on a diff in pull request #12672: KAFKA-14247: Consumer background thread base implementation

2022-10-18 Thread GitBox
philipnee commented on code in PR #12672: URL: https://github.com/apache/kafka/pull/12672#discussion_r998532115 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java: ## @@ -0,0 +1,226 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] philipnee commented on a diff in pull request #12672: KAFKA-14247: Consumer background thread base implementation

2022-10-18 Thread GitBox
philipnee commented on code in PR #12672: URL: https://github.com/apache/kafka/pull/12672#discussion_r998527530 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java: ## @@ -0,0 +1,226 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] philipnee commented on a diff in pull request #12672: KAFKA-14247: Consumer background thread base implementation

2022-10-18 Thread GitBox
philipnee commented on code in PR #12672: URL: https://github.com/apache/kafka/pull/12672#discussion_r998526630 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java: ## @@ -0,0 +1,226 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] philipnee commented on a diff in pull request #12672: KAFKA-14247: Consumer background thread base implementation

2022-10-18 Thread GitBox
philipnee commented on code in PR #12672: URL: https://github.com/apache/kafka/pull/12672#discussion_r998525478 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java: ## @@ -0,0 +1,226 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] philipnee commented on a diff in pull request #12672: KAFKA-14247: Consumer background thread base implementation

2022-10-18 Thread GitBox
philipnee commented on code in PR #12672: URL: https://github.com/apache/kafka/pull/12672#discussion_r998524805 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java: ## @@ -0,0 +1,226 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] kirktrue commented on a diff in pull request #12672: KAFKA-14247: Consumer background thread base implementation

2022-10-18 Thread GitBox
kirktrue commented on code in PR #12672: URL: https://github.com/apache/kafka/pull/12672#discussion_r998485196 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/EventHandler.java: ## @@ -30,6 +30,14 @@ public interface EventHandler { */ Optio

[GitHub] [kafka] dajac commented on pull request #12748: KAFKA-13715: add generationId field in subscription

2022-10-18 Thread GitBox
dajac commented on PR #12748: URL: https://github.com/apache/kafka/pull/12748#issuecomment-1282700266 Thanks for the PR, @showuon. Is it ready for review? I will help you to get it in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] lucasbru commented on pull request #12762: KAFKA-14299: Never transition to UpdateStandby twice

2022-10-18 Thread GitBox
lucasbru commented on PR #12762: URL: https://github.com/apache/kafka/pull/12762#issuecomment-1282691414 @cadonna @guozhangwang Could you have a look? The test failures look unrelated. ``` Build / JDK 17 and Scala 2.13 / testTransactionAfterProducerIdExpires(String).quor

[GitHub] [kafka] C0urante commented on a diff in pull request #10528: KAFKA-12497: Skip periodic offset commits for failed source tasks

2022-10-18 Thread GitBox
C0urante commented on code in PR #10528: URL: https://github.com/apache/kafka/pull/10528#discussion_r998473517 ## build.gradle: ## @@ -1205,6 +1205,7 @@ project(':clients') { testImplementation libs.bcpkix testImplementation libs.junitJupiter +testImplementation

[GitHub] [kafka] C0urante opened a new pull request, #12764: MINOR: Remove duplicate test dependency declarations for clients module

2022-10-18 Thread GitBox
C0urante opened a new pull request, #12764: URL: https://github.com/apache/kafka/pull/12764 https://github.com/apache/kafka/pull/10528 accidentally added a duplicate dependency on Log4j; this change removes it, and also groups the dependencies by scope to tidy things up a bit. ### Co

[GitHub] [kafka] lucasbru commented on pull request #12749: KAFKA-14299: Fix busy polling with separate state restoration

2022-10-18 Thread GitBox
lucasbru commented on PR #12749: URL: https://github.com/apache/kafka/pull/12749#issuecomment-1282671259 There are some errors related to missing state again. But again, it doesn't look related. Can we merge it? ``` Build / JDK 11 and Scala 2.13 / testLargeAssignmentAndGroupWithNo

[GitHub] [kafka] ijuma commented on a diff in pull request #10528: KAFKA-12497: Skip periodic offset commits for failed source tasks

2022-10-18 Thread GitBox
ijuma commented on code in PR #10528: URL: https://github.com/apache/kafka/pull/10528#discussion_r998453999 ## build.gradle: ## @@ -1205,6 +1205,7 @@ project(':clients') { testImplementation libs.bcpkix testImplementation libs.junitJupiter +testImplementation lib

[GitHub] [kafka] ijuma commented on a diff in pull request #10528: KAFKA-12497: Skip periodic offset commits for failed source tasks

2022-10-18 Thread GitBox
ijuma commented on code in PR #10528: URL: https://github.com/apache/kafka/pull/10528#discussion_r998451795 ## build.gradle: ## @@ -1205,6 +1205,7 @@ project(':clients') { testImplementation libs.bcpkix testImplementation libs.junitJupiter +testImplementation lib

[GitHub] [kafka] renaldobf opened a new pull request, #12763: KAFKA-14273: Kafka doesn't start with KRaft on Windows

2022-10-18 Thread GitBox
renaldobf opened a new pull request, #12763: URL: https://github.com/apache/kafka/pull/12763 Windows does not allow moving a file if a file descriptor is still opened. Closing the FileOutputStream prior to moving the file fix the issue. -- This is an automated message from the Apache Gi

[jira] [Assigned] (KAFKA-14314) MirrorSourceConnector throwing NPE during `isCycle` check

2022-10-18 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reassigned KAFKA-14314: -- Assignee: John Krupka > MirrorSourceConnector throwing NPE during `isCycle` check > -

[jira] [Comment Edited] (KAFKA-14314) MirrorSourceConnector throwing NPE during `isCycle` check

2022-10-18 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619564#comment-17619564 ] Mickael Maison edited comment on KAFKA-14314 at 10/18/22 1:49 PM:

[jira] [Commented] (KAFKA-14314) MirrorSourceConnector throwing NPE during `isCycle` check

2022-10-18 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619564#comment-17619564 ] Mickael Maison commented on KAFKA-14314: Great, I'll assign this ticket to you t

[jira] [Commented] (KAFKA-14314) MirrorSourceConnector throwing NPE during `isCycle` check

2022-10-18 Thread John Krupka (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619555#comment-17619555 ] John Krupka commented on KAFKA-14314: - Thanks, Mickael. Sure I can do that. I though

[jira] [Commented] (KAFKA-14314) MirrorSourceConnector throwing NPE during `isCycle` check

2022-10-18 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619540#comment-17619540 ] Mickael Maison commented on KAFKA-14314: Thanks for the details. The Replicatio

[GitHub] [kafka] OmniaGM commented on pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

2022-10-18 Thread GitBox
OmniaGM commented on PR #12577: URL: https://github.com/apache/kafka/pull/12577#issuecomment-1282380207 > The `MirrorMakerConfigTest` tests the config part, but there's nothing that proves that the configured ForwardingAdmin is actually used when creating topics, ACLs etc. That might not be

[jira] [Commented] (KAFKA-14314) MirrorSourceConnector throwing NPE during `isCycle` check

2022-10-18 Thread John Krupka (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619514#comment-17619514 ] John Krupka commented on KAFKA-14314: - We're using a custom replication policy. Here

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

2022-10-18 Thread GitBox
OmniaGM commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r998207034 ## clients/src/main/java/org/apache/kafka/clients/admin/ForwardingAdmin.java: ## @@ -0,0 +1,284 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

2022-10-18 Thread GitBox
OmniaGM commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r998206276 ## connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/MirrorClientConfig.java: ## @@ -56,7 +58,10 @@ public class MirrorClientConfig extends AbstractCon

[GitHub] [kafka] ijuma commented on pull request #12750: MINOR: Inline "Running a Kafka broker in KRaft mode" in README.md

2022-10-18 Thread GitBox
ijuma commented on PR #12750: URL: https://github.com/apache/kafka/pull/12750#issuecomment-1282365842 I went ahead and merged this since it's a clear improvement over what we have. We can do follow up PRs for further improvements. -- This is an automated message from the Apache Git Servic

[GitHub] [kafka] ijuma merged pull request #12750: MINOR: Inline "Running a Kafka broker in KRaft mode" in README.md

2022-10-18 Thread GitBox
ijuma merged PR #12750: URL: https://github.com/apache/kafka/pull/12750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Commented] (KAFKA-14314) MirrorSourceConnector throwing NPE during `isCycle` check

2022-10-18 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619486#comment-17619486 ] Mickael Maison commented on KAFKA-14314: Which replication policy are you using?

[GitHub] [kafka] soarez commented on a diff in pull request #12752: KAFKA-14303 Fix batch.size=0 in BuiltInPartitioner

2022-10-18 Thread GitBox
soarez commented on code in PR #12752: URL: https://github.com/apache/kafka/pull/12752#discussion_r998077249 ## core/src/test/scala/unit/kafka/server/ProduceRequestTest.scala: ## @@ -246,6 +248,18 @@ class ProduceRequestTest extends BaseRequestTest { assertEquals(Errors.UNS

[jira] [Created] (KAFKA-14314) MirrorSourceConnector throwing NPE during `isCycle` check

2022-10-18 Thread John Krupka (Jira)
John Krupka created KAFKA-14314: --- Summary: MirrorSourceConnector throwing NPE during `isCycle` check Key: KAFKA-14314 URL: https://issues.apache.org/jira/browse/KAFKA-14314 Project: Kafka Issue

[GitHub] [kafka] lucasbru commented on pull request #12749: KAFKA-14299: Fix busy polling with separate state restoration

2022-10-18 Thread GitBox
lucasbru commented on PR #12749: URL: https://github.com/apache/kafka/pull/12749#issuecomment-1282186142 Right, sorry, I misread your comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] cadonna commented on pull request #12749: KAFKA-14299: Fix busy polling with separate state restoration

2022-10-18 Thread GitBox
cadonna commented on PR #12749: URL: https://github.com/apache/kafka/pull/12749#issuecomment-1282160492 Didn't you want to add a unit test for case `state == State.PARTITIONS_ASSIGNED && !stateUpdaterEnabled` in this PR? See https://github.com/apache/kafka/pull/12749#discussion_r997214392.

[GitHub] [kafka] cadonna merged pull request #12743: KAFKA-14299: Fix incorrect pauses in separate state restoration

2022-10-18 Thread GitBox
cadonna merged PR #12743: URL: https://github.com/apache/kafka/pull/12743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] cadonna commented on pull request #12743: KAFKA-14299: Fix incorrect pauses in separate state restoration

2022-10-18 Thread GitBox
cadonna commented on PR #12743: URL: https://github.com/apache/kafka/pull/12743#issuecomment-1282155668 Failures are unrelated: ``` Build / JDK 17 and Scala 2.13 / org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated() ``` -- This is an au

[GitHub] [kafka] cadonna commented on pull request #12743: KAFKA-14299: Fix incorrect pauses in separate state restoration

2022-10-18 Thread GitBox
cadonna commented on PR #12743: URL: https://github.com/apache/kafka/pull/12743#issuecomment-1282155000 Yes, of course. Sorry I lost track of this one! Thank you for pinging me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] lucasbru commented on pull request #12743: KAFKA-14299: Fix incorrect pauses in separate state restoration

2022-10-18 Thread GitBox
lucasbru commented on PR #12743: URL: https://github.com/apache/kafka/pull/12743#issuecomment-1282152031 @cadonna can we please merge this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] lucasbru commented on pull request #12749: KAFKA-14299: Fix busy polling with separate state restoration

2022-10-18 Thread GitBox
lucasbru commented on PR #12749: URL: https://github.com/apache/kafka/pull/12749#issuecomment-1282151422 Makes sense. So @cadonna can we please merge this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [kafka] lucasbru opened a new pull request, #12762: KAFKA-14299: Never transition to UpdateStandby twice

2022-10-18 Thread GitBox
lucasbru opened a new pull request, #12762: URL: https://github.com/apache/kafka/pull/12762 In two situations, the current code could transition the `ChangelogReader` to `UpdateStandby` when already in that state, causing and `InvalidStateException`. Namely these two cases are:

[GitHub] [kafka] cadonna commented on pull request #12749: KAFKA-14299: Fix busy polling with separate state restoration

2022-10-18 Thread GitBox
cadonna commented on PR #12749: URL: https://github.com/apache/kafka/pull/12749#issuecomment-1281970016 `SmokeTestDriverIntegrationTest` seems to fail due to an input topic that could not be created on the broker. Might by a glitch in this specific run. Let's monitor that test in the next r

[jira] [Commented] (KAFKA-14313) Kraft: immediately producing to new topics occasionally returns NOT_LEADER_FOR_PARTITION

2022-10-18 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619308#comment-17619308 ] Luke Chen commented on KAFKA-14313: --- [~dengziming] , the issue is discussed [here|htt

[jira] [Commented] (KAFKA-14313) Kraft: immediately producing to new topics occasionally returns NOT_LEADER_FOR_PARTITION

2022-10-18 Thread Deng Ziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619281#comment-17619281 ] Deng Ziming commented on KAFKA-14313: - Hello [~twmb] , Can you also provide your cod

[GitHub] [kafka] lucasbru commented on pull request #12760: KAFKA-14309: FK join upgrades not tested with DEV_VERSION

2022-10-18 Thread GitBox
lucasbru commented on PR #12760: URL: https://github.com/apache/kafka/pull/12760#issuecomment-1281917222 Test failure is unrelated. A passing system test run for stream_upgrade_test.py is shown on https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5176/consoleText --

[GitHub] [kafka] showuon commented on a diff in pull request #12752: KAFKA-14303 Fix batch.size=0 in BuiltInPartitioner

2022-10-18 Thread GitBox
showuon commented on code in PR #12752: URL: https://github.com/apache/kafka/pull/12752#discussion_r997795605 ## core/src/test/scala/unit/kafka/server/ProduceRequestTest.scala: ## @@ -246,6 +248,18 @@ class ProduceRequestTest extends BaseRequestTest { assertEquals(Errors.UN