Gerrrr commented on code in PR #12393:
URL: https://github.com/apache/kafka/pull/12393#discussion_r998928697
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java:
##########
@@ -115,7 +115,7 @@ static void closeStateManager(final Logger log,
final StateDirectory stateDirectory,
final TaskType taskType) {
// if EOS is enabled, wipe out the whole state store for unclean close
since it is now invalid
- final boolean wipeStateStore = !closeClean && eosEnabled;
+ final boolean wipeStateStore = !closeClean && eosEnabled &&
!stateMgr.transactional();
Review Comment:
FWIW I don't think that this is a severe issue because the
`default.dsl.store` config users should be using controls transactionality of
all state stores. However, it is still possible to pass a custom state store,
so it is a good idea to check for mixed transactional configuration. Fixed in
[a5e1fe3](https://github.com/apache/kafka/pull/12393/commits/a5e1fe3122280429f2eb1c5ce119dd756620ffb3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
