[GitHub] [kafka] yashmayya commented on a diff in pull request #12355: KAFKA-14017: Implement new KIP-618 APIs in FileStreamSourceConnector

2022-10-11 Thread GitBox
yashmayya commented on code in PR #12355: URL: https://github.com/apache/kafka/pull/12355#discussion_r992989023 ## connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSourceConnector.java: ## @@ -95,4 +96,18 @@ public void stop() { public ConfigDef config() {

[GitHub] [kafka] liuzhuang2017 commented on pull request #12272: MINOR: Update the README file in examples.

2022-10-11 Thread GitBox
liuzhuang2017 commented on PR #12272: URL: https://github.com/apache/kafka/pull/12272#issuecomment-1275577470 @dengziming , Thanks your review,I have updated the pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] dengziming commented on a diff in pull request #12272: MINOR: Update the README file in examples.

2022-10-11 Thread GitBox
dengziming commented on code in PR #12272: URL: https://github.com/apache/kafka/pull/12272#discussion_r992983902 ## examples/README: ## @@ -2,11 +2,11 @@ This directory contains examples of client code that uses kafka. To run the demo: - 1. Start Zookeeper and the Kafka

[GitHub] [kafka] liuzhuang2017 commented on pull request #12272: MINOR: Update the README file in examples.

2022-10-11 Thread GitBox
liuzhuang2017 commented on PR #12272: URL: https://github.com/apache/kafka/pull/12272#issuecomment-1275512545 @dengziming ,Thanks your review, I have updated this pr according to your suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] dengziming commented on a diff in pull request #12272: MINOR: Update the README file in examples.

2022-10-11 Thread GitBox
dengziming commented on code in PR #12272: URL: https://github.com/apache/kafka/pull/12272#discussion_r992924582 ## examples/README: ## @@ -2,11 +2,11 @@ This directory contains examples of client code that uses kafka. To run the demo: - 1. Start Zookeeper and the Kafka

[jira] [Commented] (KAFKA-14291) KRaft: ApiVersionsResponse doesn't have finalizedFeatures and finalizedFeatureEpoch in KRaft mode

2022-10-11 Thread Deng Ziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616137#comment-17616137 ] Deng Ziming commented on KAFKA-14291: - Thank you [~akhileshchg] for reporting this.

[jira] [Commented] (KAFKA-14287) Multi noded with kraft combined mode will fail shutdown

2022-10-11 Thread Deng Ziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616128#comment-17616128 ] Deng Ziming commented on KAFKA-14287: - This is a problem, currently the raft dissert

[GitHub] [kafka] niket-goel opened a new pull request, #12733: KAFKA-14275; KRaft Controllers should crash after failing to apply any metadata record (#12709)

2022-10-11 Thread GitBox
niket-goel opened a new pull request, #12733: URL: https://github.com/apache/kafka/pull/12733 Make all faults in metadata processing on standby controllers be fatal. This is the same behavior-wise as the active controller. This prevents a standby controller from eventually becoming active w

[jira] [Commented] (KAFKA-14102) (SASL/OAUTHBEARER) multiple applications in one JVM process, only the first started app can consume messages

2022-10-11 Thread Shuo Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616105#comment-17616105 ] Shuo Chen commented on KAFKA-14102: --- [~gharris1727] You are right, my workaround is to

[jira] [Updated] (KAFKA-14102) (SASL/OAUTHBEARER) multiple applications in one JVM process, only the first started app can consume messages

2022-10-11 Thread Shuo Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuo Chen updated KAFKA-14102: -- Attachment: image-2022-10-12-08-43-57-597.png > (SASL/OAUTHBEARER) multiple applications in one JVM pr

[jira] [Updated] (KAFKA-14102) (SASL/OAUTHBEARER) multiple applications in one JVM process, only the first started app can consume messages

2022-10-11 Thread Shuo Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuo Chen updated KAFKA-14102: -- Attachment: image-2022-10-12-08-39-01-004.png > (SASL/OAUTHBEARER) multiple applications in one JVM pr

[jira] [Updated] (KAFKA-14291) KRaft: ApiVersionsResponse doesn't have finalizedFeatures and finalizedFeatureEpoch in KRaft mode

2022-10-11 Thread Akhilesh Chaganti (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akhilesh Chaganti updated KAFKA-14291: -- Description: https://github.com/apache/kafka/blob/d834947ae7abc8a9421d741e742200bb36f5

[jira] [Created] (KAFKA-14292) KRaft broker controlled shutdown can be delayed indefinitely

2022-10-11 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-14292: --- Summary: KRaft broker controlled shutdown can be delayed indefinitely Key: KAFKA-14292 URL: https://issues.apache.org/jira/browse/KAFKA-14292 Project: Kafka

[jira] [Created] (KAFKA-14291) KRaft: ApiVersionsResponse doesn't have finalizedFeatures and finalizedFeatureEpoch in KRaft mode

2022-10-11 Thread Akhilesh Chaganti (Jira)
Akhilesh Chaganti created KAFKA-14291: - Summary: KRaft: ApiVersionsResponse doesn't have finalizedFeatures and finalizedFeatureEpoch in KRaft mode Key: KAFKA-14291 URL: https://issues.apache.org/jira/browse/KA

[GitHub] [kafka] hachikuji opened a new pull request, #12732: MINOR: Fix incorrect example in feature command help

2022-10-11 Thread GitBox
hachikuji opened a new pull request, #12732: URL: https://github.com/apache/kafka/pull/12732 When using `kafka-features.sh` with the `--feature` parameter, we expect a numeric feature level (e.g. `metadata.version=5`). The help example suggests that we can also use a descriptive version str

[jira] [Created] (KAFKA-14290) Fix bugs that could block KRaft controlled shutdown indefinitely

2022-10-11 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-14290: Summary: Fix bugs that could block KRaft controlled shutdown indefinitely Key: KAFKA-14290 URL: https://issues.apache.org/jira/browse/KAFKA-14290 Project: Kafka

[GitHub] [kafka] nicktelford commented on pull request #12667: KAFKA-10635: Improve logging with throwing OOOSE

2022-10-11 Thread GitBox
nicktelford commented on PR #12667: URL: https://github.com/apache/kafka/pull/12667#issuecomment-1275111955 Hey @guozhangwang, we deployed this today, but we need to wait a couple of days for our app to recover before we can test a leadership election. I'm hoping I'll be able to do this tow

[jira] [Updated] (KAFKA-14102) (SASL/OAUTHBEARER) multiple applications in one JVM process, only the first started app can consume messages

2022-10-11 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14102: Component/s: (was: KafkaConnect) > (SASL/OAUTHBEARER) multiple applications in one JVM process

[jira] [Commented] (KAFKA-14102) (SASL/OAUTHBEARER) multiple applications in one JVM process, only the first started app can consume messages

2022-10-11 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616014#comment-17616014 ] Greg Harris commented on KAFKA-14102: - >From a cursory investigation, this appears t

[GitHub] [kafka] guozhangwang commented on pull request #12667: KAFKA-10635: Improve logging with throwing OOOSE

2022-10-11 Thread GitBox
guozhangwang commented on PR #12667: URL: https://github.com/apache/kafka/pull/12667#issuecomment-1275079800 ping @nicktelford , have you been able to try out this patch and collect the improved logs? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] C0urante commented on pull request #12543: KAFKA-10149: Allow auto preferred leader election when there are ongoing partition reassignments

2022-10-11 Thread GitBox
C0urante commented on PR #12543: URL: https://github.com/apache/kafka/pull/12543#issuecomment-1275066936 Thanks @jolshan. I believe it's valid to perform preferred leader election for topics even if they're currently undergoing reassignment, for reasons [discussed in an earlier PR](https:/

[GitHub] [kafka] nicktelford commented on a diff in pull request #12393: WIP: KAFKA-12549 Prototype for transactional state stores

2022-10-11 Thread GitBox
nicktelford commented on code in PR #12393: URL: https://github.com/apache/kafka/pull/12393#discussion_r991332250 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java: ## @@ -115,7 +115,7 @@ static void closeStateManager(final Logger log,

[GitHub] [kafka] hachikuji merged pull request #12634: KAFKA-14225: Fix deadlock caused by lazy val exemptSensor

2022-10-11 Thread GitBox
hachikuji merged PR #12634: URL: https://github.com/apache/kafka/pull/12634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[jira] [Resolved] (KAFKA-14275) KRaft Controllers should crash after failing to apply any metadata record

2022-10-11 Thread Niket Goel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niket Goel resolved KAFKA-14275. Fix Version/s: 3.3 Reviewer: Jason Gustafson Resolution: Fixed > KRaft Controllers

[GitHub] [kafka] C0urante commented on pull request #12366: KAFKA-14021: Implement new KIP-618 APIs in MirrorSourceConnector

2022-10-11 Thread GitBox
C0urante commented on PR #12366: URL: https://github.com/apache/kafka/pull/12366#issuecomment-1274990097 @tombentley If you have a moment, would you mind taking a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [kafka] C0urante commented on a diff in pull request #12355: KAFKA-14017: Implement new KIP-618 APIs in FileStreamSourceConnector

2022-10-11 Thread GitBox
C0urante commented on code in PR #12355: URL: https://github.com/apache/kafka/pull/12355#discussion_r992564573 ## connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSourceConnector.java: ## @@ -95,4 +96,18 @@ public void stop() { public ConfigDef config() {

[GitHub] [kafka] hachikuji merged pull request #12709: KAFKA-14275: KRaft Controllers should crash after failing to apply any metadata record

2022-10-11 Thread GitBox
hachikuji merged PR #12709: URL: https://github.com/apache/kafka/pull/12709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[GitHub] [kafka] jsancio merged pull request #12726: MINOR; Some sections are missing in the TOC

2022-10-11 Thread GitBox
jsancio merged PR #12726: URL: https://github.com/apache/kafka/pull/12726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] jsancio commented on pull request #12726: MINOR; Some sections are missing in the TOC

2022-10-11 Thread GitBox
jsancio commented on PR #12726: URL: https://github.com/apache/kafka/pull/12726#issuecomment-1274984481 Thanks for the review @showuon . Merging, cherry-picking to 3.3 and submitting PR to kafka-site. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] jsancio commented on a diff in pull request #12726: MINOR; Some sections are missing in the TOC

2022-10-11 Thread GitBox
jsancio commented on code in PR #12726: URL: https://github.com/apache/kafka/pull/12726#discussion_r992560080 ## docs/toc.html: ## @@ -111,22 +117,28 @@ Multi-Tenancy and Geo-Replication Further considerations

[GitHub] [kafka] cadonna merged pull request #12730: HOTFIX: Only update input partitions of standby tasks if they really changed

2022-10-11 Thread GitBox
cadonna merged PR #12730: URL: https://github.com/apache/kafka/pull/12730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] cadonna commented on pull request #12730: HOTFIX: Only update input partitions of standby tasks if they really changed

2022-10-11 Thread GitBox
cadonna commented on PR #12730: URL: https://github.com/apache/kafka/pull/12730#issuecomment-1274945280 Failures are unrelated: ``` Build / JDK 11 and Scala 2.13 / kafka.network.DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota() Build / JDK 11 and Scala 2.13

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12730: HOTFIX: Only update input partitions of standby tasks if they really changed

2022-10-11 Thread GitBox
guozhangwang commented on code in PR #12730: URL: https://github.com/apache/kafka/pull/12730#discussion_r992508509 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -421,6 +420,27 @@ private void handleTasksWithoutStateUpdater(final M

[GitHub] [kafka] guozhangwang commented on pull request #12730: HOTFIX: Only update input partitions of standby tasks if they really changed

2022-10-11 Thread GitBox
guozhangwang commented on PR #12730: URL: https://github.com/apache/kafka/pull/12730#issuecomment-1274908187 Thanks @cadonna , taking a look now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] niket-goel commented on pull request #12709: KAFKA-14275: KRaft Controllers should crash after failing to apply any metadata record

2022-10-11 Thread GitBox
niket-goel commented on PR #12709: URL: https://github.com/apache/kafka/pull/12709#issuecomment-1274898442 Two different tests failing this time (timeout and metric not updated) ``` org.apache.kafka.common.network.SslTransportLayerTest org.apache.kafka.streams.processor.internals.Def

[jira] [Closed] (KAFKA-14266) MirrorSourceTask will stop mirroring when get corrupt record

2022-10-11 Thread Yu Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang closed KAFKA-14266. --- > MirrorSourceTask will stop mirroring when get corrupt record > ---

[jira] [Resolved] (KAFKA-14266) MirrorSourceTask will stop mirroring when get corrupt record

2022-10-11 Thread Yu Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang resolved KAFKA-14266. - Resolution: Works for Me > MirrorSourceTask will stop mirroring when get corrupt record > --

[jira] [Comment Edited] (KAFKA-14266) MirrorSourceTask will stop mirroring when get corrupt record

2022-10-11 Thread Yu Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615898#comment-17615898 ] Yu Wang edited comment on KAFKA-14266 at 10/11/22 3:07 PM: --- [~

[jira] [Commented] (KAFKA-14266) MirrorSourceTask will stop mirroring when get corrupt record

2022-10-11 Thread Yu Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615898#comment-17615898 ] Yu Wang commented on KAFKA-14266: - [~ChrisEgerton] for this issue, as the KafkaConsumer

[jira] [Created] (KAFKA-14289) Use non zero status code in Kafka CLI when the command failed

2022-10-11 Thread Nicolas Guyomar (Jira)
Nicolas Guyomar created KAFKA-14289: --- Summary: Use non zero status code in Kafka CLI when the command failed Key: KAFKA-14289 URL: https://issues.apache.org/jira/browse/KAFKA-14289 Project: Kafka

[GitHub] [kafka] C0urante commented on pull request #12409: KAFKA-14058: Migrate ExactlyOnceWorkerSourceTaskTest from EasyMock and PowerMock to Mockito

2022-10-11 Thread GitBox
C0urante commented on PR #12409: URL: https://github.com/apache/kafka/pull/12409#issuecomment-1274751737 Rebased on latest trunk, test failures appear unrelated. @showuon @mimaison would one of you be able to take a look at this? -- This is an automated message from the Apache Git S

[jira] [Created] (KAFKA-14288) Processor topology in tasks is updated with internal intermediate topics without application ID prefix

2022-10-11 Thread Bruno Cadonna (Jira)
Bruno Cadonna created KAFKA-14288: - Summary: Processor topology in tasks is updated with internal intermediate topics without application ID prefix Key: KAFKA-14288 URL: https://issues.apache.org/jira/browse/KAFKA

[GitHub] [kafka] lucasbru opened a new pull request, #12731: MINOR: Fix usage instruction of skipSigning build parameter

2022-10-11 Thread GitBox
lucasbru opened a new pull request, #12731: URL: https://github.com/apache/kafka/pull/12731 skipSigning parameter must be set to a boolean value to work. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and

[GitHub] [kafka] cadonna commented on a diff in pull request #12730: HOTFIX: Only update input partitions of standby tasks if they really changed

2022-10-11 Thread GitBox
cadonna commented on code in PR #12730: URL: https://github.com/apache/kafka/pull/12730#discussion_r992179987 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -421,6 +420,27 @@ private void handleTasksWithoutStateUpdater(final Map in

[GitHub] [kafka] cadonna commented on pull request #12730: HOTFIX: Only update input partitions of standby tasks if they really changed

2022-10-11 Thread GitBox
cadonna commented on PR #12730: URL: https://github.com/apache/kafka/pull/12730#issuecomment-1274480546 Call for review: @vpapavas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [kafka] cadonna opened a new pull request, #12730: HOTFIX: Only update input partitions of standby tasks if they really changed

2022-10-11 Thread GitBox
cadonna opened a new pull request, #12730: URL: https://github.com/apache/kafka/pull/12730 Updating the input partitions of tasks also updates the mapping from source nodes to input topics in the processor topology within the task. The mapping is updated with the topics from the topology me

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

2022-10-11 Thread GitBox
OmniaGM commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r992140426 ## clients/src/test/java/org/apache/kafka/clients/admin/FakeForwardingAdmin.java: ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

2022-10-11 Thread GitBox
OmniaGM commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r992140426 ## clients/src/test/java/org/apache/kafka/clients/admin/FakeForwardingAdmin.java: ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Updated] (KAFKA-14287) Multi noded with kraft combined mode will fail shutdown

2022-10-11 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14287: -- Description: Multiple nodes with kraft combined mode (i.e. process.roles='broker,controller') can sta

[jira] [Updated] (KAFKA-14287) Multi noded with kraft combined mode will fail shutdown

2022-10-11 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14287: -- Description: Multiple nodes with kraft combined mode (i.e. process.roles='broker,controller') can sta

[jira] [Commented] (KAFKA-14287) Multi noded with kraft combined mode will fail shutdown

2022-10-11 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615658#comment-17615658 ] Luke Chen commented on KAFKA-14287: --- [~dengziming] [~jsancio] [~hachikuji] , any thoug

[jira] [Created] (KAFKA-14287) Multi noded with kraft combined mode will fail shutdown

2022-10-11 Thread Luke Chen (Jira)
Luke Chen created KAFKA-14287: - Summary: Multi noded with kraft combined mode will fail shutdown Key: KAFKA-14287 URL: https://issues.apache.org/jira/browse/KAFKA-14287 Project: Kafka Issue Type:

[GitHub] [kafka] tombentley commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

2022-10-11 Thread GitBox
tombentley commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r992004436 ## connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/MirrorClientConfig.java: ## @@ -56,7 +58,10 @@ public class MirrorClientConfig extends Abstract

[GitHub] [kafka] LiamClarkeNZ commented on pull request #11475: KAFKA-7077: Use default producer settings in Connect Worker

2022-10-11 Thread GitBox
LiamClarkeNZ commented on PR #11475: URL: https://github.com/apache/kafka/pull/11475#issuecomment-1274319609 Hi Konstantine, please note that reverting KAFKA-7077 won't disable producer idempotence in Kafka Connect, as it never explicitly enabled or disabled it. You'll still need to mak

[GitHub] [kafka] liuzhuang2017 commented on pull request #12272: MINOR: Update the README file in examples.

2022-10-11 Thread GitBox
liuzhuang2017 commented on PR #12272: URL: https://github.com/apache/kafka/pull/12272#issuecomment-1274219825 @dengziming OK, thanks your review, I have updated this pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use