LiamClarkeNZ commented on PR #11475: URL: https://github.com/apache/kafka/pull/11475#issuecomment-1274319609
Hi Konstantine, please note that reverting KAFKA-7077 won't disable producer idempotence in Kafka Connect, as it never explicitly enabled or disabled it. You'll still need to make changes in code to explicitly disable producer idempotence to achieve your aims, whether 7077 is reverted or not. On Wed, 23 Mar 2022 at 11:15, Konstantine Karantasis < ***@***.***> wrote: > @Ismael <https://github.com/Ismael> you're bringing up a good point, > which I missed in your latest comment before I send my recent reply. > > In light of the requirement to explicitly add the IDEMPOTENT_WRITE ACL for > Connect workers when talking to Kafka brokers older 2.8 (which I wasn't > aware of), I'd like to suggest changing course here as follows: > > - Revert KAFKA-7077 <https://issues.apache.org/jira/browse/KAFKA-7077> > from all the branches that has been merged. > - Return to KIP-318 > <https://cwiki.apache.org/confluence/display/KAFKA/KIP-318%3A+Make+Kafka+Connect+Source+idempotent>, > update it and actually vote for it. @LiamClarkeNZ > <https://github.com/LiamClarkeNZ> you referred to this KIP in the > description of this PR but I missed that this KIP hasn't been approved and > is actually currently marked as inactive. I think we should raise it again > after we update it to include all the compatibility requirements and have > it target the next major version (4.0). > - Issue a new PR that will explicitly disable idempotency by default > in Connect and will allow users to override the setting via the worker > and/or the connector configs like we allow it today. > - In the same PR, update our docs to say that despite the Kafka > producer enabling idempotency by default in 3.0, due to compatibility > requirements Connect chooses to disable idempotency for all the producers > that instantiates by default. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/kafka/pull/11475#issuecomment-1075693990>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AC2Q2JFYOJFUFYW7QRLZP23VBJA6JANCNFSM5HRTSEYA> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
