[GitHub] [kafka] showuon commented on a change in pull request #11936: MINOR: Fix an incompatible bug in GetOffsetShell

2022-03-24 Thread GitBox
showuon commented on a change in pull request #11936: URL: https://github.com/apache/kafka/pull/11936#discussion_r834992142 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -135,7 +135,11 @@ object GetOffsetShell { val partitionOffsets = partition

[GitHub] [kafka] dengziming commented on a change in pull request #11936: MINOR: Fix an incompatible bug in GetOffsetShell

2022-03-24 Thread GitBox
dengziming commented on a change in pull request #11936: URL: https://github.com/apache/kafka/pull/11936#discussion_r834991039 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -135,7 +135,11 @@ object GetOffsetShell { val partitionOffsets = partit

[GitHub] [kafka] showuon commented on a change in pull request #11936: MINOR: Fix an incompatible bug in GetOffsetShell

2022-03-24 Thread GitBox
showuon commented on a change in pull request #11936: URL: https://github.com/apache/kafka/pull/11936#discussion_r834985220 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -135,7 +135,11 @@ object GetOffsetShell { val partitionOffsets = partition

[jira] [Comment Edited] (KAFKA-13687) Limit number of batches when using kafka-dump-log.sh

2022-03-24 Thread Sergio Troiano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496312#comment-17496312 ] Sergio Troiano edited comment on KAFKA-13687 at 3/25/22, 6:24 AM:

[GitHub] [kafka] dengziming commented on a change in pull request #11936: MINOR: Fix an incompatible bug in GetOffsetShell

2022-03-24 Thread GitBox
dengziming commented on a change in pull request #11936: URL: https://github.com/apache/kafka/pull/11936#discussion_r834982567 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -135,7 +135,11 @@ object GetOffsetShell { val partitionOffsets = partit

[GitHub] [kafka] dengziming commented on a change in pull request #11936: MINOR: Fix an incompatible bug in GetOffsetShell

2022-03-24 Thread GitBox
dengziming commented on a change in pull request #11936: URL: https://github.com/apache/kafka/pull/11936#discussion_r834982567 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -135,7 +135,11 @@ object GetOffsetShell { val partitionOffsets = partit

[GitHub] [kafka] dengziming commented on a change in pull request #11936: MINOR: Fix an incompatible bug in GetOffsetShell

2022-03-24 Thread GitBox
dengziming commented on a change in pull request #11936: URL: https://github.com/apache/kafka/pull/11936#discussion_r834983243 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -70,7 +70,7 @@ object GetOffsetShell { .withRequir

[GitHub] [kafka] dengziming commented on a change in pull request #11936: MINOR: Fix an incompatible bug in GetOffsetShell

2022-03-24 Thread GitBox
dengziming commented on a change in pull request #11936: URL: https://github.com/apache/kafka/pull/11936#discussion_r834982567 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -135,7 +135,11 @@ object GetOffsetShell { val partitionOffsets = partit

[jira] [Assigned] (KAFKA-13687) Limit number of batches when using kafka-dump-log.sh

2022-03-24 Thread Sergio Troiano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergio Troiano reassigned KAFKA-13687: -- Assignee: Sergio Troiano > Limit number of batches when using kafka-dump-log.sh > ---

[GitHub] [kafka] RivenSun2 commented on pull request #11947: MINOR: Improve the description of principal under different mechanisms of sasl

2022-03-24 Thread GitBox
RivenSun2 commented on pull request #11947: URL: https://github.com/apache/kafka/pull/11947#issuecomment-1078645801 Hi @dajac @hachikuji @guozhangwang please help to review the PR . Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [kafka] RivenSun2 opened a new pull request #11947: MINOR: Improve the description of principal under different mechanisms of sasl

2022-03-24 Thread GitBox
RivenSun2 opened a new pull request #11947: URL: https://github.com/apache/kafka/pull/11947 Improve the description of principal under different mechanisms of sasl. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Resolved] (KAFKA-13770) Regression when Connect uses 0.10.x brokers due to recently added retry logic in KafkaBasedLog

2022-03-24 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-13770. --- Reviewer: Konstantine Karantasis Resolution: Fixed > Regression when Connect uses 0.10

[jira] [Updated] (KAFKA-13770) Regression when Connect uses 0.10.x brokers due to recently added retry logic in KafkaBasedLog

2022-03-24 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-13770: -- Fix Version/s: (was: 2.5.2) > Regression when Connect uses 0.10.x brokers due to recently

[jira] [Commented] (KAFKA-13770) Regression when Connect uses 0.10.x brokers due to recently added retry logic in KafkaBasedLog

2022-03-24 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17512192#comment-17512192 ] Randall Hauch commented on KAFKA-13770: --- Merged the changes to `trunk` after the P

[jira] [Updated] (KAFKA-13770) Regression when Connect uses 0.10.x brokers due to recently added retry logic in KafkaBasedLog

2022-03-24 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-13770: -- Description: KAFKA-12879 recently modified Connect's `KafkaBasedLog` class to add retry logic

[jira] [Assigned] (KAFKA-13770) Regression when Connect uses 0.10.x brokers due to recently added retry logic in KafkaBasedLog

2022-03-24 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch reassigned KAFKA-13770: - Assignee: Randall Hauch > Regression when Connect uses 0.10.x brokers due to recently a

[GitHub] [kafka] vvcephei commented on a change in pull request #11945: KAFKA-13769: Explicitly route FK join results to correct partitions

2022-03-24 Thread GitBox
vvcephei commented on a change in pull request #11945: URL: https://github.com/apache/kafka/pull/11945#discussion_r834933864 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionResponseWrapperSerde.java ## @@ -64,7 +64,7 @@

[jira] [Commented] (KAFKA-13771) Support to explicitly delete delegationTokens that have expired but have not been automatically cleaned up

2022-03-24 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17512177#comment-17512177 ] RivenSun commented on KAFKA-13771: -- Hi [~guozhang] [~dajac]   [~ijuma] Could you give s

[jira] [Created] (KAFKA-13771) Support to explicitly delete delegationTokens that have expired but have not been automatically cleaned up

2022-03-24 Thread RivenSun (Jira)
RivenSun created KAFKA-13771: Summary: Support to explicitly delete delegationTokens that have expired but have not been automatically cleaned up Key: KAFKA-13771 URL: https://issues.apache.org/jira/browse/KAFKA-13771

[GitHub] [kafka] rhauch commented on pull request #11946: KAFKA-13770: Restore compatibility with KafkaBasedLog using older Kafka brokers

2022-03-24 Thread GitBox
rhauch commented on pull request #11946: URL: https://github.com/apache/kafka/pull/11946#issuecomment-1078597932 No Connect-related failures in the builds, and a [system test run of the Connect tests](https://jenkins.confluent.io/view/All/job/system-test-kafka-branch-builder/4823/) passed

[GitHub] [kafka] rhauch merged pull request #11946: KAFKA-13770: Restore compatibility with KafkaBasedLog using older Kafka brokers

2022-03-24 Thread GitBox
rhauch merged pull request #11946: URL: https://github.com/apache/kafka/pull/11946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr..

[GitHub] [kafka] showuon commented on a change in pull request #11936: MINOR: Fix an incompatible bug in GetOffsetShell

2022-03-24 Thread GitBox
showuon commented on a change in pull request #11936: URL: https://github.com/apache/kafka/pull/11936#discussion_r834906233 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -135,7 +135,11 @@ object GetOffsetShell { val partitionOffsets = partition

[GitHub] [kafka] showuon commented on a change in pull request #11936: MINOR: Fix an incompatible bug in GetOffsetShell

2022-03-24 Thread GitBox
showuon commented on a change in pull request #11936: URL: https://github.com/apache/kafka/pull/11936#discussion_r834905197 ## File path: core/src/test/scala/kafka/tools/GetOffsetShellTest.scala ## @@ -166,6 +166,13 @@ class GetOffsetShellTest extends KafkaServerTestHarness wi

[GitHub] [kafka] showuon commented on a change in pull request #11936: MINOR: Fix an incompatible bug in GetOffsetShell

2022-03-24 Thread GitBox
showuon commented on a change in pull request #11936: URL: https://github.com/apache/kafka/pull/11936#discussion_r834904926 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -70,7 +70,7 @@ object GetOffsetShell { .withRequiredA

[GitHub] [kafka] dengziming commented on a change in pull request #11936: MINOR: Fix an incompatible bug in GetOffsetShell

2022-03-24 Thread GitBox
dengziming commented on a change in pull request #11936: URL: https://github.com/apache/kafka/pull/11936#discussion_r834896331 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -135,7 +135,11 @@ object GetOffsetShell { val partitionOffsets = partit

[GitHub] [kafka] showuon commented on pull request #10976: KAFKA-13036 Replace EasyMock and PowerMock with Mockito for RocksDBMetricsRecorderTest

2022-03-24 Thread GitBox
showuon commented on pull request #10976: URL: https://github.com/apache/kafka/pull/10976#issuecomment-1078578578 @wycc , it's been a while since your last update, could you please rebase to the latest trunk before I start the review? Thank you! -- This is an automated message from t

[GitHub] [kafka] bozhao12 commented on a change in pull request #11942: KAFKA-13767: Fetch response did not need delay return when the preferred read replica not local replica

2022-03-24 Thread GitBox
bozhao12 commented on a change in pull request #11942: URL: https://github.com/apache/kafka/pull/11942#discussion_r834860157 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1028,6 +1028,7 @@ class ReplicaManager(val config: KafkaConfig, var bytes

[GitHub] [kafka] jeff303 edited a comment on pull request #11792: Replace EasyMock/PowerMock with Mockito in DistributedHerderTest

2022-03-24 Thread GitBox
jeff303 edited a comment on pull request #11792: URL: https://github.com/apache/kafka/pull/11792#issuecomment-1078447241 Something I've learned, that I feel is not adequately covered by [this wiki](https://github.com/mockito/mockito/wiki/Mockito-vs-EasyMock): EasyMock expectations se

[GitHub] [kafka] jeff303 commented on pull request #11792: Replace EasyMock/PowerMock with Mockito in DistributedHerderTest

2022-03-24 Thread GitBox
jeff303 commented on pull request #11792: URL: https://github.com/apache/kafka/pull/11792#issuecomment-1078447241 Something I've learned, that I feel is not [adequately](https://github.com/mockito/mockito/wiki/Mockito-vs-EasyMock) covered by this wiki: EasyMock expectations seem to

[jira] [Updated] (KAFKA-13770) Regression when Connect uses 0.10.x brokers due to recently added retry logic in KafkaBasedLog

2022-03-24 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-13770: -- Description: KAFKA-12879 recently modified Connect's `KafkaBasedLog` class to add retry logic

[GitHub] [kafka] rhauch opened a new pull request #11946: KAFKA-13770: Restore compatibility with KafkaBasedLog using older Kafka brokers

2022-03-24 Thread GitBox
rhauch opened a new pull request #11946: URL: https://github.com/apache/kafka/pull/11946 The `retryEndOffsets(…)` method in `TopicAdmin` recently added (KAFKA-12879, #11797) to allow the `KafkaBasedLog.start()` method to retry any failures reading the last offsets for a topic. However, thi

[jira] [Resolved] (KAFKA-13554) Rename RangeQuery to KeyRangeQuery

2022-03-24 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-13554. -- Resolution: Won't Fix > Rename RangeQuery to KeyRangeQuery > -

[jira] [Closed] (KAFKA-13554) Rename RangeQuery to KeyRangeQuery

2022-03-24 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler closed KAFKA-13554. > Rename RangeQuery to KeyRangeQuery > -- > > Key: KAF

[jira] [Commented] (KAFKA-13554) Rename RangeQuery to KeyRangeQuery

2022-03-24 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17512096#comment-17512096 ] John Roesler commented on KAFKA-13554: -- I thought that I filed this because it had

[jira] [Updated] (KAFKA-13554) Rename RangeQuery to KeyRangeQuery

2022-03-24 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-13554: - Affects Version/s: (was: 3.2.0) > Rename RangeQuery to KeyRangeQuery > -

[jira] [Updated] (KAFKA-13554) Rename RangeQuery to KeyRangeQuery

2022-03-24 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-13554: - Priority: Minor (was: Blocker) > Rename RangeQuery to KeyRangeQuery > -

[jira] [Updated] (KAFKA-13622) Revisit the complexity of position tracking in state stores

2022-03-24 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-13622: - Priority: Minor (was: Blocker) > Revisit the complexity of position tracking in state stores >

[jira] [Updated] (KAFKA-13622) Revisit the complexity of position tracking in state stores

2022-03-24 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-13622: - Affects Version/s: (was: 3.2.0) > Revisit the complexity of position tracking in state store

[jira] [Updated] (KAFKA-13541) Make IQv2 query/store interface type safe

2022-03-24 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-13541: - Affects Version/s: (was: 3.2.0) > Make IQv2 query/store interface type safe > --

[jira] [Assigned] (KAFKA-13554) Rename RangeQuery to KeyRangeQuery

2022-03-24 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler reassigned KAFKA-13554: Assignee: John Roesler (was: Vicky Papavasileiou) > Rename RangeQuery to KeyRangeQuery >

[jira] [Updated] (KAFKA-13541) Make IQv2 query/store interface type safe

2022-03-24 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-13541: - Priority: Minor (was: Blocker) > Make IQv2 query/store interface type safe > --

[jira] [Updated] (KAFKA-13526) IQv2: Consider more generic logic for mapping between binary and typed queries

2022-03-24 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-13526: - Priority: Minor (was: Blocker) > IQv2: Consider more generic logic for mapping between binary a

[jira] [Updated] (KAFKA-13526) IQv2: Consider more generic logic for mapping between binary and typed queries

2022-03-24 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-13526: - Affects Version/s: (was: 3.2.0) > IQv2: Consider more generic logic for mapping between bina

[jira] [Updated] (KAFKA-13548) IQv2: revisit WindowKeyQuery and WindowRangeQuery

2022-03-24 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-13548: - Priority: Minor (was: Blocker) > IQv2: revisit WindowKeyQuery and WindowRangeQuery > --

[jira] [Updated] (KAFKA-13548) IQv2: revisit WindowKeyQuery and WindowRangeQuery

2022-03-24 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-13548: - Affects Version/s: (was: 3.2.0) > IQv2: revisit WindowKeyQuery and WindowRangeQuery > --

[jira] [Updated] (KAFKA-13479) Interactive Query v2

2022-03-24 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-13479: - Fix Version/s: (was: 3.2.0) > Interactive Query v2 > > >

[jira] [Created] (KAFKA-13770) Regression when Connect uses 0.10.x brokers due to recently added retry logic in KafkaBasedLog

2022-03-24 Thread Randall Hauch (Jira)
Randall Hauch created KAFKA-13770: - Summary: Regression when Connect uses 0.10.x brokers due to recently added retry logic in KafkaBasedLog Key: KAFKA-13770 URL: https://issues.apache.org/jira/browse/KAFKA-13770

[jira] [Updated] (KAFKA-13542) Utilize the new Consumer#enforceRebalance(reason) API in Streams

2022-03-24 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13542: -- Fix Version/s: 3.3.0 (was: 3.2.0) > Utilize the new Consumer#enforceReb

[jira] [Commented] (KAFKA-13542) Utilize the new Consumer#enforceRebalance(reason) API in Streams

2022-03-24 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17512046#comment-17512046 ] Bruno Cadonna commented on KAFKA-13542: --- OK, I will move this ticket to the next r

[GitHub] [kafka] vvcephei commented on pull request #11944: MINOR: Add extra notice about IQv2 compatibility

2022-03-24 Thread GitBox
vvcephei commented on pull request #11944: URL: https://github.com/apache/kafka/pull/11944#issuecomment-1077954224 Thanks, all! Merged and cherry-picked to 3.2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [kafka] vvcephei merged pull request #11944: MINOR: Add extra notice about IQv2 compatibility

2022-03-24 Thread GitBox
vvcephei merged pull request #11944: URL: https://github.com/apache/kafka/pull/11944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr

[GitHub] [kafka] mjsax commented on a change in pull request #11945: KAFKA-13769: Explicitly route FK join results to correct partitions

2022-03-24 Thread GitBox
mjsax commented on a change in pull request #11945: URL: https://github.com/apache/kafka/pull/11945#discussion_r834631843 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionResponseWrapperSerde.java ## @@ -64,7 +64,7 @@ pu

[jira] [Assigned] (KAFKA-13421) Fix ConsumerBounceTest#testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup

2022-03-24 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-13421: - Assignee: (was: Kirk True) > Fix > ConsumerBounceTest#testRollingBrokerRestartsWithSmaller

[jira] [Assigned] (KAFKA-13421) Fix ConsumerBounceTest#testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup

2022-03-24 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-13421: - Assignee: Kirk True > Fix > ConsumerBounceTest#testRollingBrokerRestartsWithSmallerMaxGroupSiz

[jira] [Commented] (KAFKA-13542) Utilize the new Consumer#enforceRebalance(reason) API in Streams

2022-03-24 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17512018#comment-17512018 ] Matthias J. Sax commented on KAFKA-13542: - SGTM. > Utilize the new Consumer#enf

[jira] [Commented] (KAFKA-13542) Utilize the new Consumer#enforceRebalance(reason) API in Streams

2022-03-24 Thread Hao Li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511960#comment-17511960 ] Hao Li commented on KAFKA-13542: Most likely I don't have bandwidth to investigate this

[jira] [Resolved] (KAFKA-13692) stream thread blocked-time-ns-total metric does not include producer metadata wait time

2022-03-24 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-13692. --- Fix Version/s: 3.3.0 (was: 3.2.0) Resolution: Fixed > stream t

[jira] [Assigned] (KAFKA-13692) stream thread blocked-time-ns-total metric does not include producer metadata wait time

2022-03-24 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang reassigned KAFKA-13692: - Assignee: Rohan Desai > stream thread blocked-time-ns-total metric does not include pro

[GitHub] [kafka] rhauch commented on a change in pull request #11908: KAFKA-13748: Do not include file stream connectors in Connect's CLASSPATH and plugin.path by default

2022-03-24 Thread GitBox
rhauch commented on a change in pull request #11908: URL: https://github.com/apache/kafka/pull/11908#discussion_r834528693 ## File path: docs/connect.html ## @@ -74,6 +74,7 @@ Running Kafka Connectconfig.storage.topic (default connect-configs) - topic to use for storing conne

[GitHub] [kafka] rhauch commented on a change in pull request #11908: KAFKA-13748: Do not include file stream connectors in Connect's CLASSPATH and plugin.path by default

2022-03-24 Thread GitBox
rhauch commented on a change in pull request #11908: URL: https://github.com/apache/kafka/pull/11908#discussion_r834528693 ## File path: docs/connect.html ## @@ -74,6 +74,7 @@ Running Kafka Connectconfig.storage.topic (default connect-configs) - topic to use for storing conne

[GitHub] [kafka] guozhangwang closed pull request #11805: KAFKA-13692: include metadata wait time in total blocked time

2022-03-24 Thread GitBox
guozhangwang closed pull request #11805: URL: https://github.com/apache/kafka/pull/11805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] rhauch commented on a change in pull request #11908: KAFKA-13748: Do not include file stream connectors in Connect's CLASSPATH and plugin.path by default

2022-03-24 Thread GitBox
rhauch commented on a change in pull request #11908: URL: https://github.com/apache/kafka/pull/11908#discussion_r834525760 ## File path: tests/kafkatest/services/connect.py ## @@ -279,12 +282,34 @@ def append_to_environment_variable(self, envvar, value): env_opts =

[GitHub] [kafka] C0urante edited a comment on pull request #11869: KAFKA-13719: fix connector restart cause duplicate tasks

2022-03-24 Thread GitBox
C0urante edited a comment on pull request #11869: URL: https://github.com/apache/kafka/pull/11869#issuecomment-1077834292 No worries @kpatelatwork, good to hear from you! @showuon no worries, thanks for taking a look. Definitely better to move cautiously than to merge something you'r

[GitHub] [kafka] C0urante commented on pull request #11869: KAFKA-13719: fix connector restart cause duplicate tasks

2022-03-24 Thread GitBox
C0urante commented on pull request #11869: URL: https://github.com/apache/kafka/pull/11869#issuecomment-1077834292 No worries @kpatelatwork, good to hear from you! @showuon no worries, thanks for taking a look. Definitely better to move cautiously than to merge something you're not c

[GitHub] [kafka] kpatelatwork commented on pull request #11869: KAFKA-13719: fix connector restart cause duplicate tasks

2022-03-24 Thread GitBox
kpatelatwork commented on pull request #11869: URL: https://github.com/apache/kafka/pull/11869#issuecomment-1077823237 @C0urante Thanks a lot this indeed seems like a bug and sorry for the late reply as I was busy. LGTM from my side -- This is an automated message from the Apache Git Ser

[jira] [Assigned] (KAFKA-13769) KTable FK join can miss records if an upstream non-key-changing operation changes key serializer

2022-03-24 Thread Aleksandr Sorokoumov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Sorokoumov reassigned KAFKA-13769: Assignee: Aleksandr Sorokoumov > KTable FK join can miss records if an up

[jira] [Updated] (KAFKA-13689) AbstractConfig log print information is incorrect

2022-03-24 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-13689: -- Fix Version/s: 3.3.0 (was: 3.2.0) > AbstractConfig log print informatio

[GitHub] [kafka] guozhangwang merged pull request #11940: KAFKA-13689: optimize the log output of logUnused method

2022-03-24 Thread GitBox
guozhangwang merged pull request #11940: URL: https://github.com/apache/kafka/pull/11940 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] guozhangwang commented on a change in pull request #11940: KAFKA-13689: optimize the log output of logUnused method

2022-03-24 Thread GitBox
guozhangwang commented on a change in pull request #11940: URL: https://github.com/apache/kafka/pull/11940#discussion_r834502144 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -530,6 +530,9 @@ private TransactionManager configur

[jira] [Assigned] (KAFKA-13766) Use `max.poll.interval.ms` as the timeout during complete-rebalance phase

2022-03-24 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-13766: --- Assignee: David Jacot > Use `max.poll.interval.ms` as the timeout during complete-rebalance

[GitHub] [kafka] dajac commented on a change in pull request #11936: MINOR: Fix an incompatible bug in GetOffsetShell

2022-03-24 Thread GitBox
dajac commented on a change in pull request #11936: URL: https://github.com/apache/kafka/pull/11936#discussion_r834419560 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -135,7 +135,11 @@ object GetOffsetShell { val partitionOffsets = partitionIn

[jira] [Created] (KAFKA-13769) KTable FK join can miss records if an upstream non-key-changing operation changes key serializer

2022-03-24 Thread Aleksandr Sorokoumov (Jira)
Aleksandr Sorokoumov created KAFKA-13769: Summary: KTable FK join can miss records if an upstream non-key-changing operation changes key serializer Key: KAFKA-13769 URL: https://issues.apache.org/jira/brow

[GitHub] [kafka] divijvaidya commented on pull request #11943: KAFKA-10095: Add stricter assertion in LogCleanerManagerTest

2022-03-24 Thread GitBox
divijvaidya commented on pull request #11943: URL: https://github.com/apache/kafka/pull/11943#issuecomment-1077705543 @abbccdda @hachikuji , this is my first code change to Apache Kafka 🎉 . Kindly review. -- This is an automated message from the Apache Git Service. To respond to the me

[jira] [Resolved] (KAFKA-13128) Flaky Test StoreQueryIntegrationTest.shouldQueryStoresAfterAddingAndRemovingStreamThread

2022-03-24 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-13128. --- Resolution: Fixed > Flaky Test > StoreQueryIntegrationTest.shouldQueryStoresAfterAddingAndR

[GitHub] [kafka] ijuma commented on a change in pull request #11743: KAFKA-13660: Switch log4j12 to reload4j

2022-03-24 Thread GitBox
ijuma commented on a change in pull request #11743: URL: https://github.com/apache/kafka/pull/11743#discussion_r834371938 ## File path: gradle/dependencies.gradle ## @@ -189,14 +188,15 @@ libs += [ powermockJunit4: "org.powermock:powermock-module-junit4:$versions.powermock",

[GitHub] [kafka] vvcephei opened a new pull request #11944: MINOR: Add extra notice about IQv2 compatibility

2022-03-24 Thread GitBox
vvcephei opened a new pull request #11944: URL: https://github.com/apache/kafka/pull/11944 Added an extra notice about IQv2's API compatibility, as discussed in the KIP-796 vote thread. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation

[GitHub] [kafka] ijuma commented on pull request #11743: KAFKA-13660: Switch log4j12 to reload4j

2022-03-24 Thread GitBox
ijuma commented on pull request #11743: URL: https://github.com/apache/kafka/pull/11743#issuecomment-1077678693 We should add something to the notable changes in `upgrade.html`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] ijuma commented on a change in pull request #11743: KAFKA-13660: Switch log4j12 to reload4j

2022-03-24 Thread GitBox
ijuma commented on a change in pull request #11743: URL: https://github.com/apache/kafka/pull/11743#discussion_r834356826 ## File path: gradle/dependencies.gradle ## @@ -189,14 +188,15 @@ libs += [ powermockJunit4: "org.powermock:powermock-module-junit4:$versions.powermock",

[GitHub] [kafka] ijuma commented on a change in pull request #11743: KAFKA-13660: Switch log4j12 to reload4j

2022-03-24 Thread GitBox
ijuma commented on a change in pull request #11743: URL: https://github.com/apache/kafka/pull/11743#discussion_r834356644 ## File path: gradle/dependencies.gradle ## @@ -177,7 +177,6 @@ libs += [ kafkaStreams_28: "org.apache.kafka:kafka-streams:$versions.kafka_28", kafkaS

[jira] [Commented] (KAFKA-10095) In LogCleanerManagerTest replace get().nonEmpty call with contains

2022-03-24 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511876#comment-17511876 ] Divij Vaidya commented on KAFKA-10095: -- Since the first pull request had no activit

[GitHub] [kafka] divijvaidya opened a new pull request #11943: KAFKA-10095: Add stricter assertion in LogCleanerManagerTest

2022-03-24 Thread GitBox
divijvaidya opened a new pull request #11943: URL: https://github.com/apache/kafka/pull/11943 Changes: 1. Add a stricter assertion in LogCleanerManagerTest 2. Minor cosmetic simplification in Scala Testing: LogCleanerManagerTest run is successful. All unit test runs are suc

[GitHub] [kafka] dengziming commented on a change in pull request #11936: MINOR: Fix an incompatible bug in GetOffsetShell

2022-03-24 Thread GitBox
dengziming commented on a change in pull request #11936: URL: https://github.com/apache/kafka/pull/11936#discussion_r834344701 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -135,7 +135,11 @@ object GetOffsetShell { val partitionOffsets = partit

[GitHub] [kafka] dengziming commented on a change in pull request #11936: MINOR: Fix an incompatible bug in GetOffsetShell

2022-03-24 Thread GitBox
dengziming commented on a change in pull request #11936: URL: https://github.com/apache/kafka/pull/11936#discussion_r834344420 ## File path: core/src/test/scala/kafka/tools/GetOffsetShellTest.scala ## @@ -166,6 +166,13 @@ class GetOffsetShellTest extends KafkaServerTestHarness

[GitHub] [kafka] ijuma merged pull request #11939: KAFKA-13761: KafkaLog4jAppender deadlocks when idempotence is enabled

2022-03-24 Thread GitBox
ijuma merged pull request #11939: URL: https://github.com/apache/kafka/pull/11939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[jira] [Commented] (KAFKA-13479) Interactive Query v2

2022-03-24 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511853#comment-17511853 ] Bruno Cadonna commented on KAFKA-13479: --- [~vvcephei] As far as I understand, the m

[jira] [Updated] (KAFKA-13479) Interactive Query v2

2022-03-24 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13479: -- Fix Version/s: 3.2.0 (was: 3.3.0) > Interactive Query v2 >

[jira] [Commented] (KAFKA-13128) Flaky Test StoreQueryIntegrationTest.shouldQueryStoresAfterAddingAndRemovingStreamThread

2022-03-24 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511841#comment-17511841 ] Bruno Cadonna commented on KAFKA-13128: --- [~wcarlson5] Do you think we can close th

[GitHub] [kafka] dajac commented on a change in pull request #11942: KAFKA-13767: Fetch response did not need delay return when the preferred read replica not local replica

2022-03-24 Thread GitBox
dajac commented on a change in pull request #11942: URL: https://github.com/apache/kafka/pull/11942#discussion_r834269788 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1028,6 +1028,7 @@ class ReplicaManager(val config: KafkaConfig, var bytesRea

[jira] [Commented] (KAFKA-9366) Upgrade log4j to log4j2

2022-03-24 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511814#comment-17511814 ] Bruno Cadonna commented on KAFKA-9366: -- [~brandonk] Actually, I removed it from the

[jira] [Updated] (KAFKA-13768) Transactional producer exits because of expiration in RecordAccumulator

2022-03-24 Thread xuexiaoyue (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuexiaoyue updated KAFKA-13768: --- Description: Hi team, I'm using a transactional producer and set request.timeout.ms to a rather sma

[jira] [Commented] (KAFKA-13542) Utilize the new Consumer#enforceRebalance(reason) API in Streams

2022-03-24 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511796#comment-17511796 ] Bruno Cadonna commented on KAFKA-13542: --- [~lihaosky] Code freeze for 3.2 is March

[GitHub] [kafka] bozhao12 commented on a change in pull request #11942: KAFKA-13767: Fetch response did not need delay return when the preferred read replica not local replica

2022-03-24 Thread GitBox
bozhao12 commented on a change in pull request #11942: URL: https://github.com/apache/kafka/pull/11942#discussion_r834172924 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1028,6 +1028,7 @@ class ReplicaManager(val config: KafkaConfig, var bytes

[GitHub] [kafka] bozhao12 commented on a change in pull request #11942: KAFKA-13767: Fetch response did not need delay return when the preferred read replica not local replica

2022-03-24 Thread GitBox
bozhao12 commented on a change in pull request #11942: URL: https://github.com/apache/kafka/pull/11942#discussion_r834172924 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1028,6 +1028,7 @@ class ReplicaManager(val config: KafkaConfig, var bytes

[GitHub] [kafka] bozhao12 commented on a change in pull request #11942: KAFKA-13767: Fetch response did not need delay return when the preferred read replica not local replica

2022-03-24 Thread GitBox
bozhao12 commented on a change in pull request #11942: URL: https://github.com/apache/kafka/pull/11942#discussion_r834168741 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1028,6 +1028,7 @@ class ReplicaManager(val config: KafkaConfig, var bytes

[GitHub] [kafka] dajac commented on a change in pull request #11942: KAFKA-13767: Fetch response did not need delay return when the preferred read replica not local replica

2022-03-24 Thread GitBox
dajac commented on a change in pull request #11942: URL: https://github.com/apache/kafka/pull/11942#discussion_r834125268 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1037,6 +1038,8 @@ class ReplicaManager(val config: KafkaConfig, errorRea

[GitHub] [kafka] mimaison commented on pull request #11929: MINOR: s390x Stage

2022-03-24 Thread GitBox
mimaison commented on pull request #11929: URL: https://github.com/apache/kafka/pull/11929#issuecomment-1077446695 Unit tests are now passing. Before pushing this further I'd like to get some agreement from the community about supporting different platforms. See https://lists.apache.org/th

[jira] [Updated] (KAFKA-13757) Improve the annotations of all related methods of DelegationToken in the Admin class

2022-03-24 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RivenSun updated KAFKA-13757: - Description: DelegationToken is a great and lightweight feature, but when users actually use it, they g

[jira] [Updated] (KAFKA-13768) Transactional producer exits because of expiration in RecordAccumulator

2022-03-24 Thread xuexiaoyue (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuexiaoyue updated KAFKA-13768: --- Description: Hi team, I'm using a transactional producer and set request.timeout.ms to a rather sma

[jira] [Updated] (KAFKA-13767) Fetch response did not need delay return when the preferred read replica not local replica

2022-03-24 Thread zhaobo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhaobo updated KAFKA-13767: --- Summary: Fetch response did not need delay return when the preferred read replica not local replica (was: F

[GitHub] [kafka] mimaison commented on a change in pull request #11908: KAFKA-13748: Do not include file stream connectors in Connect's CLASSPATH and plugin.path by default

2022-03-24 Thread GitBox
mimaison commented on a change in pull request #11908: URL: https://github.com/apache/kafka/pull/11908#discussion_r834048496 ## File path: docs/connect.html ## @@ -74,6 +74,7 @@ Running Kafka Connectconfig.storage.topic (default connect-configs) - topic to use for storing con

  1   2   >