showuon commented on a change in pull request #11705:
URL: https://github.com/apache/kafka/pull/11705#discussion_r811658823
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedCogroupedKStreamImpl.java
##
@@ -113,14 +114,23 @@
showuon commented on a change in pull request #11705:
URL: https://github.com/apache/kafka/pull/11705#discussion_r811658823
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedCogroupedKStreamImpl.java
##
@@ -113,14 +114,23 @@
lkokhreidze commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r811652014
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java
##
@@ -0,0 +1,296
showuon commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r811651144
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java
##
@@ -0,0 +1,296 @@
+
showuon commented on a change in pull request #11705:
URL: https://github.com/apache/kafka/pull/11705#discussion_r811648912
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/MaterializedInternal.java
##
@@ -56,6 +69,10 @@ public String storeName()
Indupa commented on pull request #7898:
URL: https://github.com/apache/kafka/pull/7898#issuecomment-1047501444
Currently in kafka we have not used Socketserver,SMTPAppender,JDBCAppender
and JMSSink features from log4j,unless user explicitly use it in their Custom
changes.?
lkokhreidze commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r811645496
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java
##
@@ -0,0 +1,296
Indupa commented on pull request #7898:
URL: https://github.com/apache/kafka/pull/7898#issuecomment-1047496080
Ohhh OKk, In that case none of the 4 vulnerable things ,used in kafka as of
now right.?
--
This is an automated message from the Apache Git Service.
To respo
showuon commented on a change in pull request #11788:
URL: https://github.com/apache/kafka/pull/11788#discussion_r811623527
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
##
@@ -276,8 +276,8 @@
showuon commented on pull request #11788:
URL: https://github.com/apache/kafka/pull/11788#issuecomment-1047478002
@mimaison , updated the PR in this commit:
https://github.com/apache/kafka/pull/11788/commits/29bb358a2e63046ea332981e8a5864caa9b25e78.
Thanks.
--
This is an automated messa
showuon commented on a change in pull request #11788:
URL: https://github.com/apache/kafka/pull/11788#discussion_r811623527
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
##
@@ -276,8 +276,8 @@
dongjinleekr commented on pull request #7898:
URL: https://github.com/apache/kafka/pull/7898#issuecomment-1047473190
@Indupa As long as the user explicitly configure the loggers to use them,
they are not used yet.
--
This is an automated message from the Apache Git Service.
To respond to
Indupa commented on pull request #7898:
URL: https://github.com/apache/kafka/pull/7898#issuecomment-1047472293
Hi @dongjinleekr , Can you please provide me Some information on the
Vulenerabiities regarding log4j features , Is this following vulnerable
features of log4j are using in Kafka 2
showuon edited a comment on pull request #11493:
URL: https://github.com/apache/kafka/pull/11493#issuecomment-1047469644
Failed tests are flaky tests that also failed in trunk branch:
```
[Build / JDK 17 and Scala 2.13 /
kafka.server.DynamicBrokerReconfigurationTest.testThreadPoolResi
showuon commented on pull request #11493:
URL: https://github.com/apache/kafka/pull/11493#issuecomment-1047469644
Failed tests are flaky tests:
```
[Build / JDK 17 and Scala 2.13 /
kafka.server.DynamicBrokerReconfigurationTest.testThreadPoolResize()](https://ci-builds.apache.org/job/K
showuon edited a comment on pull request #11493:
URL: https://github.com/apache/kafka/pull/11493#issuecomment-1047469153
@tim-patterson , could we rename the PR title? It seems that we don't just
assign standby tasks to `threads without active tasks`. Please help update it.
Thanks.
--
T
showuon commented on pull request #11493:
URL: https://github.com/apache/kafka/pull/11493#issuecomment-1047469153
@tim-patterson , could we rename the PR title? It seems that we not just
assign standby tasks to `threads without active tasks`. Please help update it.
Thanks.
--
This is an
showuon commented on a change in pull request #11493:
URL: https://github.com/apache/kafka/pull/11493#discussion_r811606664
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -1028,116 +1045,113 @@ private boole
showuon commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r811556641
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java
##
@@ -0,0 +1,296 @@
+
showuon commented on a change in pull request #11642:
URL: https://github.com/apache/kafka/pull/11642#discussion_r811545842
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/tools/PredicateDoc.java
##
@@ -61,7 +61,7 @@ private static void printPredicateHtml(
showuon commented on a change in pull request #11642:
URL: https://github.com/apache/kafka/pull/11642#discussion_r811545842
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/tools/PredicateDoc.java
##
@@ -61,7 +61,7 @@ private static void printPredicateHtml(
showuon merged pull request #11794:
URL: https://github.com/apache/kafka/pull/11794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr.
showuon commented on a change in pull request #11794:
URL: https://github.com/apache/kafka/pull/11794#discussion_r811537471
##
File path: docs/toc.html
##
@@ -45,6 +45,10 @@
3.3 Producer Configs
3.4 Consumer Configs
3.5 Kafka C
[
https://issues.apache.org/jira/browse/KAFKA-13679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Bourke updated KAFKA-13679:
--
Summary: Superfluous node disconnected log messages (was: Superfluous node
disconnected logs)
Philip Bourke created KAFKA-13679:
-
Summary: Superfluous node disconnected logs
Key: KAFKA-13679
URL: https://issues.apache.org/jira/browse/KAFKA-13679
Project: Kafka
Issue Type: Bug
cadonna commented on a change in pull request #11760:
URL: https://github.com/apache/kafka/pull/11760#discussion_r811402366
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java
##
@@ -56,25 +54,34 @@ private int numCaugh
cadonna commented on a change in pull request #11760:
URL: https://github.com/apache/kafka/pull/11760#discussion_r811394037
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java
##
@@ -102,17 +109,26 @@ static int assignA
tim-patterson commented on a change in pull request #11760:
URL: https://github.com/apache/kafka/pull/11760#discussion_r811393001
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java
##
@@ -102,17 +109,26 @@ static int a
mimaison commented on a change in pull request #11575:
URL: https://github.com/apache/kafka/pull/11575#discussion_r811318744
##
File path:
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/TimestampConverter.java
##
@@ -83,12 +78,36 @@
private static fi
[
https://issues.apache.org/jira/browse/KAFKA-13673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-13673:
---
Fix Version/s: 3.0.1
> disable idempotent producer when acks/retries/max.in.flight config co
mimaison commented on a change in pull request #11788:
URL: https://github.com/apache/kafka/pull/11788#discussion_r811310081
##
File path: docs/upgrade.html
##
@@ -73,7 +74,8 @@ Notable changes in 3
A bug prevented the producer idempotence default from being applied
whi
Lorenzo Cagnatel created KAFKA-13678:
Summary: 2nd punctuation using STREAM_TIME does not respect
scheduled interval
Key: KAFKA-13678
URL: https://issues.apache.org/jira/browse/KAFKA-13678
Project
cadonna commented on a change in pull request #11760:
URL: https://github.com/apache/kafka/pull/11760#discussion_r811184710
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java
##
@@ -102,17 +109,26 @@ static int assignA
rhauch merged pull request #11758:
URL: https://github.com/apache/kafka/pull/11758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr..
[
https://issues.apache.org/jira/browse/KAFKA-13675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495485#comment-17495485
]
Bruno Cadonna commented on KAFKA-13675:
---
[~pcallahan] thank you for the report,
T
mimaison commented on pull request #11642:
URL: https://github.com/apache/kafka/pull/11642#issuecomment-1046772930
@showuon @tombentley Can you take another look? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
mimaison commented on a change in pull request #11794:
URL: https://github.com/apache/kafka/pull/11794#discussion_r811030427
##
File path: docs/toc.html
##
@@ -45,6 +45,10 @@
3.3 Producer Configs
3.4 Consumer Configs
3.5 Kafka
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-1046758399
Thanks @showuon for the valuable feedback.
I've addressed your comments, please have a look when you got time.
--
This is an automated message from the Apache Git Servi
tim-patterson commented on a change in pull request #11493:
URL: https://github.com/apache/kafka/pull/11493#discussion_r810985840
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -1028,116 +1045,113 @@ private
[
https://issues.apache.org/jira/browse/KAFKA-13677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoša Vrbanac updated KAFKA-13677:
---
Affects Version/s: 2.7.0
> version 3.0.0 Processor implementation uses parameter record (res
Aljoša Vrbanac created KAFKA-13677:
--
Summary: version 3.0.0 Processor implementation uses parameter
record (restricted identifier)
Key: KAFKA-13677
URL: https://issues.apache.org/jira/browse/KAFKA-13677
alozano3 commented on pull request #10803:
URL: https://github.com/apache/kafka/pull/10803#issuecomment-1046622683
¿Shouldn't this be also applied to Connect consumer configurations ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-12874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495399#comment-17495399
]
Albert Lozano commented on KAFKA-12874:
---
¿Shouldn't this be also applied to Connec
lkokhreidze commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r810894883
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java
##
@@ -0,0 +1,295
44 matches
Mail list logo
