showuon commented on a change in pull request #11788:
URL: https://github.com/apache/kafka/pull/11788#discussion_r811623527
##########
File path:
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
##########
@@ -276,8 +276,8 @@
+ "retries due to
broker failures, etc., may write duplicates of the retried message in the
stream. "
+ "Note that enabling
idempotence requires <code>" + MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION + "</code>
to be less than or equal to " +
MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION_FOR_IDEMPOTENCE
+ " (with message
ordering preserved for any allowable value), <code>" + RETRIES_CONFIG +
"</code> to be greater than 0, and <code>"
- + ACKS_CONFIG +
"</code> must be 'all'. If these values are not explicitly set by the user,
suitable values will be chosen. If incompatible "
- + "values are set, a
<code>ConfigException</code> will be thrown.";
+ + ACKS_CONFIG +
"</code> must be 'all'. If incompatible values are set, a
<code>ConfigException</code> will be thrown. "
+ + "The default value
is `true`. But if incompatible values are set and this config is not set
explicitly, idempotent producer will be disabled automatically.";
Review comment:
`If these values are not explicitly set by the user, suitable values
will be chosen.`
-> remove this line because we already default all the values to **suitable
values**.
Added:
`The default value is 'true'. But if incompatible values are set and this
config is not set explicitly, idempotent producer will be disabled
automatically.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
