[jira] [Commented] (KAFKA-7870) Error sending fetch request (sessionId=1578860481, epoch=INITIAL) to node 2: java.io.IOException: Connection to 2 was disconnected before the response was read.

2021-09-21 Thread priya Vijay (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17418435#comment-17418435 ] priya Vijay commented on KAFKA-7870: We are running kafka 2.8 and see similar issues.

[GitHub] [kafka] jlprat commented on pull request #11350: Scala3 migration

2021-09-21 Thread GitBox
jlprat commented on pull request #11350: URL: https://github.com/apache/kafka/pull/11350#issuecomment-924613583 One of tus failures was https://issues.apache.org/jira/browse/KAFKA-8785 I need to check the other one -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] ccding commented on pull request #11351: KAFKA-13315: log layer exception during shutdown that caused an unclean shutdown

2021-09-21 Thread GitBox
ccding commented on pull request #11351: URL: https://github.com/apache/kafka/pull/11351#issuecomment-924557403 FYI: there is a side effect of not throwing `IllegalStateException`. The `deleteSegment` function will not throw and we will be able to rename the `.swap` files to regular files

[GitHub] [kafka] mjsax commented on a change in pull request #11336: DRAFT: Add currentPosition and times to ProcessorContext

2021-09-21 Thread GitBox
mjsax commented on a change in pull request #11336: URL: https://github.com/apache/kafka/pull/11336#discussion_r713538585 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/api/ProcessorContext.java ## @@ -247,4 +251,45 @@ Cancellable schedule(final Duratio

[GitHub] [kafka] mjsax commented on a change in pull request #11347: KAFKA-13296: warn if previous assignment has duplicate partitions

2021-09-21 Thread GitBox
mjsax commented on a change in pull request #11347: URL: https://github.com/apache/kafka/pull/11347#discussion_r713232644 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -351,6 +351,17 @@ public GroupAssignme

[GitHub] [kafka] RivenSun2 commented on a change in pull request #11340: fix issue : KafkaConsumer cannot jump out of the poll method, and the…

2021-09-21 Thread GitBox
RivenSun2 commented on a change in pull request #11340: URL: https://github.com/apache/kafka/pull/11340#discussion_r713524099 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1069,6 +1065,37 @@ private void maybeAu

[GitHub] [kafka] ccding commented on a change in pull request #11351: KAFKA-13315: log layer exception during shutdown that caused an unclean shutdown

2021-09-21 Thread GitBox
ccding commented on a change in pull request #11351: URL: https://github.com/apache/kafka/pull/11351#discussion_r713531154 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -499,12 +499,13 @@ class BrokerServer( if (clientToControllerChannelManager

[GitHub] [kafka] RivenSun2 commented on a change in pull request #11340: fix issue : KafkaConsumer cannot jump out of the poll method, and the…

2021-09-21 Thread GitBox
RivenSun2 commented on a change in pull request #11340: URL: https://github.com/apache/kafka/pull/11340#discussion_r713524099 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1069,6 +1065,37 @@ private void maybeAu

[GitHub] [kafka] RivenSun2 commented on a change in pull request #11340: fix issue : KafkaConsumer cannot jump out of the poll method, and the…

2021-09-21 Thread GitBox
RivenSun2 commented on a change in pull request #11340: URL: https://github.com/apache/kafka/pull/11340#discussion_r713524099 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1069,6 +1065,37 @@ private void maybeAu

[GitHub] [kafka] RivenSun2 commented on a change in pull request #11340: fix issue : KafkaConsumer cannot jump out of the poll method, and the…

2021-09-21 Thread GitBox
RivenSun2 commented on a change in pull request #11340: URL: https://github.com/apache/kafka/pull/11340#discussion_r713524099 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1069,6 +1065,37 @@ private void maybeAu

[GitHub] [kafka] junrao commented on a change in pull request #11351: KAFKA-13315: log layer exception during shutdown that caused an unclean shutdown

2021-09-21 Thread GitBox
junrao commented on a change in pull request #11351: URL: https://github.com/apache/kafka/pull/11351#discussion_r713494615 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -499,12 +499,13 @@ class BrokerServer( if (clientToControllerChannelManager

[GitHub] [kafka] ijuma commented on a change in pull request #11351: KAFKA-13315: log layer exception during shutdown that caused an unclean shutdown

2021-09-21 Thread GitBox
ijuma commented on a change in pull request #11351: URL: https://github.com/apache/kafka/pull/11351#discussion_r713489901 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -499,12 +499,13 @@ class BrokerServer( if (clientToControllerChannelManager !

[GitHub] [kafka] junrao commented on pull request #11348: MINOR: fix CreateTopic to return the same as DescribeTopic

2021-09-21 Thread GitBox
junrao commented on pull request #11348: URL: https://github.com/apache/kafka/pull/11348#issuecomment-924462411 cherry-picked the PR to 3.0 branch too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] junrao merged pull request #11348: MINOR: fix CreateTopic to return the same as DescribeTopic

2021-09-21 Thread GitBox
junrao merged pull request #11348: URL: https://github.com/apache/kafka/pull/11348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr..

[GitHub] [kafka] junrao commented on a change in pull request #11351: KAFKA-13315: log layer exception during shutdown that caused an unclean shutdown

2021-09-21 Thread GitBox
junrao commented on a change in pull request #11351: URL: https://github.com/apache/kafka/pull/11351#discussion_r713478871 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -499,12 +499,13 @@ class BrokerServer( if (clientToControllerChannelManager

[GitHub] [kafka] showuon commented on a change in pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

2021-09-21 Thread GitBox
showuon commented on a change in pull request #11211: URL: https://github.com/apache/kafka/pull/11211#discussion_r713474671 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredWindowStore.java ## @@ -292,13 +408,46 @@ public V fetch(final K key,

[GitHub] [kafka] ccding commented on a change in pull request #11348: MINOR: fix CreateTopic to return the same as DescribeTopic

2021-09-21 Thread GitBox
ccding commented on a change in pull request #11348: URL: https://github.com/apache/kafka/pull/11348#discussion_r713470616 ## File path: core/src/main/scala/kafka/server/ZkAdminManager.scala ## @@ -118,7 +118,7 @@ class ZkAdminManager(val config: KafkaConfig, metadataAndCo

[GitHub] [kafka] vincent81jiang commented on a change in pull request #11327: KAFKA-13305: fix NullPointerException in LogCleanerManager "uncleanable-bytes" gauge

2021-09-21 Thread GitBox
vincent81jiang commented on a change in pull request #11327: URL: https://github.com/apache/kafka/pull/11327#discussion_r713458476 ## File path: core/src/main/scala/kafka/log/LogCleanerManager.scala ## @@ -511,6 +513,27 @@ private[log] class LogCleanerManager(val logDirs: Seq[

[GitHub] [kafka] vincent81jiang commented on a change in pull request #11327: KAFKA-13305: fix NullPointerException in LogCleanerManager "uncleanable-bytes" gauge

2021-09-21 Thread GitBox
vincent81jiang commented on a change in pull request #11327: URL: https://github.com/apache/kafka/pull/11327#discussion_r713458476 ## File path: core/src/main/scala/kafka/log/LogCleanerManager.scala ## @@ -511,6 +513,27 @@ private[log] class LogCleanerManager(val logDirs: Seq[

[GitHub] [kafka] vincent81jiang commented on a change in pull request #11327: KAFKA-13305: fix NullPointerException in LogCleanerManager "uncleanable-bytes" gauge

2021-09-21 Thread GitBox
vincent81jiang commented on a change in pull request #11327: URL: https://github.com/apache/kafka/pull/11327#discussion_r713458476 ## File path: core/src/main/scala/kafka/log/LogCleanerManager.scala ## @@ -511,6 +513,27 @@ private[log] class LogCleanerManager(val logDirs: Seq[

[GitHub] [kafka] vincent81jiang commented on a change in pull request #11327: KAFKA-13305: fix NullPointerException in LogCleanerManager "uncleanable-bytes" gauge

2021-09-21 Thread GitBox
vincent81jiang commented on a change in pull request #11327: URL: https://github.com/apache/kafka/pull/11327#discussion_r713458476 ## File path: core/src/main/scala/kafka/log/LogCleanerManager.scala ## @@ -511,6 +513,27 @@ private[log] class LogCleanerManager(val logDirs: Seq[

[GitHub] [kafka] vincent81jiang commented on a change in pull request #11327: KAFKA-13305: fix NullPointerException in LogCleanerManager "uncleanable-bytes" gauge

2021-09-21 Thread GitBox
vincent81jiang commented on a change in pull request #11327: URL: https://github.com/apache/kafka/pull/11327#discussion_r713451787 ## File path: core/src/main/scala/kafka/log/LogCleanerManager.scala ## @@ -511,6 +513,27 @@ private[log] class LogCleanerManager(val logDirs: Seq[

[GitHub] [kafka] ccding opened a new pull request #11351: KAFKA-13315: log layer exception during shutdown that caused an unclean shutdown

2021-09-21 Thread GitBox
ccding opened a new pull request #11351: URL: https://github.com/apache/kafka/pull/11351 We have seen an exception caused by shutting down the scheduler before shutting down LogManager. When LogManager was closing partitions one by one, the scheduler called to delete old segments du

[GitHub] [kafka] jlprat commented on a change in pull request #11350: Scala3 migration

2021-09-21 Thread GitBox
jlprat commented on a change in pull request #11350: URL: https://github.com/apache/kafka/pull/11350#discussion_r713423728 ## File path: core/src/main/scala/kafka/controller/PartitionStateMachine.scala ## @@ -477,7 +477,7 @@ class ZkPartitionStateMachine(config: KafkaConfig,

[jira] [Created] (KAFKA-13315) log layer exception during shutdown that caused an unclean shutdown

2021-09-21 Thread Cong Ding (Jira)
Cong Ding created KAFKA-13315: - Summary: log layer exception during shutdown that caused an unclean shutdown Key: KAFKA-13315 URL: https://issues.apache.org/jira/browse/KAFKA-13315 Project: Kafka

[jira] [Assigned] (KAFKA-13315) log layer exception during shutdown that caused an unclean shutdown

2021-09-21 Thread Cong Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cong Ding reassigned KAFKA-13315: - Assignee: Cong Ding > log layer exception during shutdown that caused an unclean shutdown > ---

[GitHub] [kafka] jlprat commented on pull request #11350: Scala3 migration

2021-09-21 Thread GitBox
jlprat commented on pull request #11350: URL: https://github.com/apache/kafka/pull/11350#issuecomment-924387703 Ping @ijuma I was able to have some progress with migrating to Scala3. I still need to check why some test failures occur only on Scala3. Let me know what you think about the cha

[jira] [Commented] (KAFKA-12954) Add Support for Scala 3 in 4.0.0

2021-09-21 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17418321#comment-17418321 ] Josep Prat commented on KAFKA-12954: Work in progress PR is available here: [https:

[GitHub] [kafka] jlprat opened a new pull request #11350: Scala3 migration

2021-09-21 Thread GitBox
jlprat opened a new pull request #11350: URL: https://github.com/apache/kafka/pull/11350 This PR lays the groundwork for the Scala3 migration of the code base. Gradle's Scala3 plugin is merged but not released yet (see [PR](https://github.com/gradle/gradle/pull/18001)). During the migra

[GitHub] [kafka] glasser commented on pull request #10873: KAFKA-7360 Fixed code snippet

2021-09-21 Thread GitBox
glasser commented on pull request #10873: URL: https://github.com/apache/kafka/pull/10873#issuecomment-924378381 I'm not sure why you chose that list of reviewers but I am not a Kafka reviewer. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] junrao commented on a change in pull request #11348: MINOR: fix CreateTopic to return the same as DescribeTopic

2021-09-21 Thread GitBox
junrao commented on a change in pull request #11348: URL: https://github.com/apache/kafka/pull/11348#discussion_r713413729 ## File path: core/src/main/scala/kafka/server/ZkAdminManager.scala ## @@ -118,7 +118,7 @@ class ZkAdminManager(val config: KafkaConfig, metadataAndCo

[GitHub] [kafka] 3schwartz commented on a change in pull request #11340: fix issue : KafkaConsumer cannot jump out of the poll method, and the…

2021-09-21 Thread GitBox
3schwartz commented on a change in pull request #11340: URL: https://github.com/apache/kafka/pull/11340#discussion_r713359407 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1069,6 +1065,37 @@ private void maybeAu

[jira] [Commented] (KAFKA-12225) Unexpected broker bottleneck when scaling producers

2021-09-21 Thread Sam Cantero (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17418292#comment-17418292 ] Sam Cantero commented on KAFKA-12225: - is this similar to https://issues.apache.org/

[GitHub] [kafka] guozhangwang commented on a change in pull request #11227: KAFKA-13211: add support for infinite range query for WindowStore

2021-09-21 Thread GitBox
guozhangwang commented on a change in pull request #11227: URL: https://github.com/apache/kafka/pull/11227#discussion_r713277824 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryWindowStore.java ## @@ -462,14 +460,34 @@ public boolean hasNex

[GitHub] [kafka] vamossagar12 commented on a change in pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

2021-09-21 Thread GitBox
vamossagar12 commented on a change in pull request #11211: URL: https://github.com/apache/kafka/pull/11211#discussion_r713255569 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredWindowStore.java ## @@ -292,13 +408,46 @@ public V fetch(final K

[GitHub] [kafka] vamossagar12 commented on pull request #11076: KAFKA-12486: Enforce Rebalance when a TaskCorruptedException is throw…

2021-09-21 Thread GitBox
vamossagar12 commented on pull request #11076: URL: https://github.com/apache/kafka/pull/11076#issuecomment-924190789 I guess this test case got fixed recently in a new commit => `shouldQueryStoresAfterAddingAndRemovingStreamThread` => https://github.com/apache/kafka/commit/5a6f19b2

[GitHub] [kafka] cmccabe commented on a change in pull request #11311: KAFKA-13280: Avoid O(N) behavior in KRaftMetadataCache#topicNamesToIds

2021-09-21 Thread GitBox
cmccabe commented on a change in pull request #11311: URL: https://github.com/apache/kafka/pull/11311#discussion_r713235847 ## File path: metadata/src/main/java/org/apache/kafka/image/TopicsImage.java ## @@ -92,6 +98,148 @@ public int hashCode() { return Objects.hash(t

[jira] [Created] (KAFKA-13314) Pluggable components initialized with getConfiguredInstance do not respect dynamic config updates

2021-09-21 Thread David Mao (Jira)
David Mao created KAFKA-13314: - Summary: Pluggable components initialized with getConfiguredInstance do not respect dynamic config updates Key: KAFKA-13314 URL: https://issues.apache.org/jira/browse/KAFKA-13314

[GitHub] [kafka] vvcephei merged pull request #11334: KAFKA-13246: StoreQueryIntegrationTest#shouldQueryStoresAfterAddingAn…

2021-09-21 Thread GitBox
vvcephei merged pull request #11334: URL: https://github.com/apache/kafka/pull/11334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr

[GitHub] [kafka] C0urante edited a comment on pull request #11333: KAFKA-13306: Null connector config value passes validation, but fails creation

2021-09-21 Thread GitBox
C0urante edited a comment on pull request #11333: URL: https://github.com/apache/kafka/pull/11333#issuecomment-924133203 Thanks @lhunyady. I wonder if instead of throwing an exception we can add an error message to the offending config properties? This would allow other configuration error

[GitHub] [kafka] C0urante commented on pull request #11333: KAFKA-13306: Null connector config value passes validation, but fails creation

2021-09-21 Thread GitBox
C0urante commented on pull request #11333: URL: https://github.com/apache/kafka/pull/11333#issuecomment-924133203 Thanks @lhunyady. I wonder if instead of throwing an exception we can add an error message to the offending config properties? This would allow other configuration errors to be

[GitHub] [kafka] C0urante opened a new pull request #11349: MINOR: Fix use of ConfigException in AbstractConfig class

2021-09-21 Thread GitBox
C0urante opened a new pull request #11349: URL: https://github.com/apache/kafka/pull/11349 The two-arg variant is intended to take a property name and value, not an exception message and a cause. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implem

[GitHub] [kafka] wcarlson5 commented on a change in pull request #11334: KAFKA-13246: StoreQueryIntegrationTest#shouldQueryStoresAfterAddingAn…

2021-09-21 Thread GitBox
wcarlson5 commented on a change in pull request #11334: URL: https://github.com/apache/kafka/pull/11334#discussion_r713141647 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StoreQueryIntegrationTest.java ## @@ -477,6 +477,7 @@ public void shouldQuery

[GitHub] [kafka] ccding commented on pull request #11348: MINOR: fix CreateTopic to return the same as DescribeTopic

2021-09-21 Thread GitBox
ccding commented on pull request #11348: URL: https://github.com/apache/kafka/pull/11348#issuecomment-924028973 failed tests are passing on my local run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] andy0x01 commented on a change in pull request #11334: KAFKA-13246: StoreQueryIntegrationTest#shouldQueryStoresAfterAddingAn…

2021-09-21 Thread GitBox
andy0x01 commented on a change in pull request #11334: URL: https://github.com/apache/kafka/pull/11334#discussion_r713063360 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StoreQueryIntegrationTest.java ## @@ -477,6 +477,7 @@ public void shouldQueryS

[GitHub] [kafka] viktorsomogyi commented on pull request #11276: KAFKA-13240: Disable HTTP TRACE Method in Connect

2021-09-21 Thread GitBox
viktorsomogyi commented on pull request #11276: URL: https://github.com/apache/kafka/pull/11276#issuecomment-923908827 @mimaison would you please check this again if you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] ahamedmulaffer commented on pull request #8575: KAFKA-8713 KIP-581 Add accept.optional.null to solve optional null

2021-09-21 Thread GitBox
ahamedmulaffer commented on pull request #8575: URL: https://github.com/apache/kafka/pull/8575#issuecomment-923888236 Any update or possible workaround ? @rhauch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] lhunyady commented on pull request #11333: KAFKA-13306: Null connector config value passes validation, but fails creation

2021-09-21 Thread GitBox
lhunyady commented on pull request #11333: URL: https://github.com/apache/kafka/pull/11333#issuecomment-923881582 @C0urante @kkonstantine Can you please review this change for me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] showuon commented on a change in pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

2021-09-21 Thread GitBox
showuon commented on a change in pull request #11211: URL: https://github.com/apache/kafka/pull/11211#discussion_r712843244 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredWindowStore.java ## @@ -292,13 +408,46 @@ public V fetch(final K key,

[GitHub] [kafka] showuon commented on a change in pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

2021-09-21 Thread GitBox
showuon commented on a change in pull request #11211: URL: https://github.com/apache/kafka/pull/11211#discussion_r712843244 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredWindowStore.java ## @@ -292,13 +408,46 @@ public V fetch(final K key,

[GitHub] [kafka] showuon commented on a change in pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

2021-09-21 Thread GitBox
showuon commented on a change in pull request #11211: URL: https://github.com/apache/kafka/pull/11211#discussion_r712843244 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredWindowStore.java ## @@ -292,13 +408,46 @@ public V fetch(final K key,

[GitHub] [kafka] showuon commented on a change in pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

2021-09-21 Thread GitBox
showuon commented on a change in pull request #11211: URL: https://github.com/apache/kafka/pull/11211#discussion_r712843244 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredWindowStore.java ## @@ -292,13 +408,46 @@ public V fetch(final K key,

[GitHub] [kafka] dajac merged pull request #11344: KAFKA-13312; 'NetworkDegradeTest#test_rate' should wait until iperf server is listening

2021-09-21 Thread GitBox
dajac merged pull request #11344: URL: https://github.com/apache/kafka/pull/11344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...