ccding commented on pull request #11351: URL: https://github.com/apache/kafka/pull/11351#issuecomment-924557403
FYI: there is a side effect of not throwing `IllegalStateException`. The `deleteSegment` function will not throw and we will be able to rename the `.swap` files to regular files during shutdown. This is a good thing. https://github.com/apache/kafka/blob/5a6f19b2a1ff72c52ad627230ffdf464456104ee/core/src/main/scala/kafka/log/LocalLog.scala#L895-L909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
