lkokhreidze commented on pull request #10802:
URL: https://github.com/apache/kafka/pull/10802#issuecomment-856507161
Hi @cadonna @vvcephei @ableegoldman, I know it's busy times with 3.0 release
on the radar, but would appreciate review on this PR when you got time. Thanks!
--
This is
mushfiqur rahoman created KAFKA-12912:
-
Summary: fdgfdgfg
Key: KAFKA-12912
URL: https://issues.apache.org/jira/browse/KAFKA-12912
Project: Kafka
Issue Type: Bug
Reporter: mush
mjsax commented on a change in pull request #10810:
URL: https://github.com/apache/kafka/pull/10810#discussion_r647115686
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java
##
@@ -158,32 +165,52 @@ Cancellable schedule(final Duration i
mjsax commented on a change in pull request #10810:
URL: https://github.com/apache/kafka/pull/10810#discussion_r647126680
##
File path:
streams/test-utils/src/main/java/org/apache/kafka/streams/processor/MockProcessorContext.java
##
@@ -319,7 +321,7 @@ public void setRecordMet
mjsax commented on a change in pull request #10810:
URL: https://github.com/apache/kafka/pull/10810#discussion_r647126680
##
File path:
streams/test-utils/src/main/java/org/apache/kafka/streams/processor/MockProcessorContext.java
##
@@ -319,7 +321,7 @@ public void setRecordMet
jlprat commented on pull request #10693:
URL: https://github.com/apache/kafka/pull/10693#issuecomment-856457128
Thanks @ableegoldman for your comments.
As far as I can tell after reading
https://issues.apache.org/jira/browse/KAFKA-12625, mostly the copyright files
were worked on, bu
mjsax commented on a change in pull request #10810:
URL: https://github.com/apache/kafka/pull/10810#discussion_r647122650
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/api/RecordMetadata.java
##
@@ -16,19 +16,51 @@
*/
package org.apache.kafka.stream
jlprat commented on a change in pull request #10810:
URL: https://github.com/apache/kafka/pull/10810#discussion_r647120250
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java
##
@@ -158,32 +165,52 @@ Cancellable schedule(final Duration
mjsax commented on a change in pull request #10810:
URL: https://github.com/apache/kafka/pull/10810#discussion_r647115686
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java
##
@@ -158,32 +165,52 @@ Cancellable schedule(final Duration i
mjsax merged pull request #10731:
URL: https://github.com/apache/kafka/pull/10731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
dongjinleekr commented on a change in pull request #10827:
URL: https://github.com/apache/kafka/pull/10827#discussion_r647107617
##
File path: core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala
##
@@ -116,7 +121,13 @@ object ReplicaVerificationTool extends Logging {
dongjinleekr commented on a change in pull request #10827:
URL: https://github.com/apache/kafka/pull/10827#discussion_r647107617
##
File path: core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala
##
@@ -116,7 +121,13 @@ object ReplicaVerificationTool extends Logging {
showuon commented on a change in pull request #10838:
URL: https://github.com/apache/kafka/pull/10838#discussion_r647088680
##
File path: core/src/main/scala/kafka/server/DynamicConfigManager.scala
##
@@ -154,7 +156,7 @@ class DynamicConfigManager(private val zkClient:
KafkaZk
showuon commented on a change in pull request #10838:
URL: https://github.com/apache/kafka/pull/10838#discussion_r647088430
##
File path: core/src/main/scala/kafka/server/DynamicConfigManager.scala
##
@@ -71,9 +71,11 @@ object ConfigEntityName {
*
* This will fire a watcher
showuon opened a new pull request #10838:
URL: https://github.com/apache/kafka/pull/10838
Some refactor to DynamicConfigManager class
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
Dongjin Lee created KAFKA-12911:
---
Summary: Configure automatic formatter for
org.apache.kafka.streams.processor
Key: KAFKA-12911
URL: https://issues.apache.org/jira/browse/KAFKA-12911
Project: Kafka
dongjinleekr commented on pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#issuecomment-856406538
@cadonna Here is the update. I excluded the `core` module from this PR
(i.e., it contains formatting configurations only, not actual formatting now)
and opened separate iss
Dongjin Lee created KAFKA-12910:
---
Summary: Configure automatic formatter for
org.apache.kafka.streams.state
Key: KAFKA-12910
URL: https://issues.apache.org/jira/browse/KAFKA-12910
Project: Kafka
ableegoldman commented on pull request #10683:
URL: https://github.com/apache/kafka/pull/10683#issuecomment-856403807
Pt. 2 is fully ready for review @guozhangwang @wcarlson5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
showuon commented on pull request #10665:
URL: https://github.com/apache/kafka/pull/10665#issuecomment-856392681
@mimaison , please help have a 2nd review. Thank you.
The failed tests are unrelated and flaky.
```
Build / JDK 15 and Scala 2.13 /
kafka.server.RaftClusterTest.
showuon commented on pull request #10338:
URL: https://github.com/apache/kafka/pull/10338#issuecomment-856390836
@mumrah , could you help have a 2nd review? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
mumrah commented on a change in pull request #10749:
URL: https://github.com/apache/kafka/pull/10749#discussion_r647047054
##
File path: raft/src/main/java/org/apache/kafka/raft/FileBasedStateStore.java
##
@@ -91,14 +92,17 @@ private QuorumStateData readStateFromFile(File file)
dengziming commented on pull request #10159:
URL: https://github.com/apache/kafka/pull/10159#issuecomment-856376303
Resolved by #10793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
dengziming closed pull request #10159:
URL: https://github.com/apache/kafka/pull/10159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, ple
jsancio commented on pull request #10749:
URL: https://github.com/apache/kafka/pull/10749#issuecomment-856347044
@mumrah or @hachikuji Can you take a look at this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
mjsax commented on pull request #10736:
URL: https://github.com/apache/kafka/pull/10736#issuecomment-856345646
Hard to say. Also the logs are truncated. However, it seems there is some
issue in the beginning that maybe some topic where not created?
```
[2021-05-27 08:36:11,424] WARN [
ableegoldman commented on pull request #10693:
URL: https://github.com/apache/kafka/pull/10693#issuecomment-856336135
Thanks. We just went through a large cleanup of the licensing and notices
for the 2.8.0 release, which is how we ended up in the current state of things.
It was my understa
ableegoldman commented on pull request #10736:
URL: https://github.com/apache/kafka/pull/10736#issuecomment-856331849
Hey @vvcephei @bellemare , any thoughts on Luke's analysis above? I'm not
super familiar with the FKJ so it's difficult for me to say whether this sounds
like a possible da
junrao commented on pull request #10829:
URL: https://github.com/apache/kafka/pull/10829#issuecomment-856314359
@hachikuji : Could you take a look at this minor PR? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
lct45 commented on a change in pull request #10813:
URL: https://github.com/apache/kafka/pull/10813#discussion_r646992164
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorNodeTest.java
##
@@ -160,8 +160,8 @@ private void testMetrics(fin
ableegoldman commented on a change in pull request #10609:
URL: https://github.com/apache/kafka/pull/10609#discussion_r646986783
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StateDirectoryTest.java
##
@@ -593,6 +575,111 @@ public void should
ableegoldman merged pull request #10609:
URL: https://github.com/apache/kafka/pull/10609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
ableegoldman commented on pull request #10609:
URL: https://github.com/apache/kafka/pull/10609#issuecomment-856307579
Thanks @guozhangwang ! I'm going to go ahead and merge this one now since
it's been out there for so long, I will follow up on that test case in the Pt.
2 PR
--
This is
[
https://issues.apache.org/jira/browse/KAFKA-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-12909:
---
Assignee: Matthias J. Sax
> Allow users to opt-into spurious left/outer stream-stre
Matthias J. Sax created KAFKA-12909:
---
Summary: Allow users to opt-into spurious left/outer stream-stream
join improvement
Key: KAFKA-12909
URL: https://issues.apache.org/jira/browse/KAFKA-12909
Proj
lct45 commented on a change in pull request #10813:
URL: https://github.com/apache/kafka/pull/10813#discussion_r646979245
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/SinkNode.java
##
@@ -60,8 +60,8 @@ public void init(final InternalProcesso
[
https://issues.apache.org/jira/browse/KAFKA-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-8613:
---
Description:
Currently, the grace period is set to retention time if the grace period is not
[
https://issues.apache.org/jira/browse/KAFKA-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-8613:
---
Summary: Make grace period mandatory (was: Set default grace period to 0)
> Make grace perio
lct45 commented on a change in pull request #10813:
URL: https://github.com/apache/kafka/pull/10813#discussion_r646974657
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorNodeTest.java
##
@@ -160,8 +160,8 @@ private void testMetrics(fin
ccding commented on a change in pull request #10763:
URL: https://github.com/apache/kafka/pull/10763#discussion_r646971381
##
File path: core/src/main/scala/kafka/log/LogLoader.scala
##
@@ -368,12 +368,50 @@ object LogLoader extends Logging {
for (swapFile <- swapFiles) {
[
https://issues.apache.org/jira/browse/KAFKA-12898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12898:
---
Fix Version/s: 3.0.0
> Owned partitions in the subscription must be sorted
>
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r646958227
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -1812,37 +1577,36 @@ class Log(@volatile private var _dir: File,
endOffset: Long
): Un
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r646955278
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -1788,14 +1559,8 @@ class Log(@volatile private var _dir: File,
maybeHandleIOException(s"
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r646945793
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -1578,144 +1409,85 @@ class Log(@volatile private var _dir: File,
.map(_.messageOffse
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r646945592
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -1578,144 +1409,85 @@ class Log(@volatile private var _dir: File,
.map(_.messageOffse
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r646945351
##
File path: core/src/main/scala/kafka/log/LocalLog.scala
##
@@ -0,0 +1,1010 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
junrao merged pull request #10823:
URL: https://github.com/apache/kafka/pull/10823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
Jose Armando Garcia Sancio created KAFKA-12908:
--
Summary: Load snapshot heuristic
Key: KAFKA-12908
URL: https://issues.apache.org/jira/browse/KAFKA-12908
Project: Kafka
Issue Typ
dejan2609 commented on a change in pull request #10606:
URL: https://github.com/apache/kafka/pull/10606#discussion_r646942636
##
File path: gradle/wrapper/gradle-wrapper.properties
##
@@ -1,5 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
-distributi
rondagostino commented on pull request #10823:
URL: https://github.com/apache/kafka/pull/10823#issuecomment-856248774
For example, here's one of the 20 failures:
```
[2021-06-05T02:12:18.820Z] AuthorizerIntegrationTest >
testDeleteGroupApiWithDeleteGroupAcl() STARTED
[2021-06-0
rondagostino edited a comment on pull request #10823:
URL: https://github.com/apache/kafka/pull/10823#issuecomment-856248033
> JDK 11 test seems to have failed with 20 failures. Are they related to
this PR?
Thanks for the review, @junrao. Those failures are unrelated -- they are
du
rondagostino commented on pull request #10823:
URL: https://github.com/apache/kafka/pull/10823#issuecomment-856248033
< JDK 11 test seems to have failed with 20 failures. Are they related to
this PR?
Thanks for the review, @junrao. Those failures are unrelated -- they are
due to ht
[
https://issues.apache.org/jira/browse/KAFKA-12483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358864#comment-17358864
]
Randall Hauch commented on KAFKA-12483:
---
KIP-722 was approved today.
> Enable cli
[
https://issues.apache.org/jira/browse/KAFKA-12484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358860#comment-17358860
]
Randall Hauch commented on KAFKA-12484:
---
KIP-721 was approved today.
> Enable Con
[
https://issues.apache.org/jira/browse/KAFKA-12904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch updated KAFKA-12904:
--
Description:
The fix for KAFKA-9374 changed how the `ConnectorPluginsResource` and its
method
[
https://issues.apache.org/jira/browse/KAFKA-12904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch updated KAFKA-12904:
--
Description:
The fix for KAFKA-9374 changed how the `ConnectorPluginsResource` and its
method
ableegoldman commented on pull request #10740:
URL: https://github.com/apache/kafka/pull/10740#issuecomment-856221486
Hey @izzyacademy , any update on this? Btw, I would recommend just
continuing to work on this PR rather than opening a new one
--
This is an automated message from the Ap
Krishna Kinnal created KAFKA-12907:
--
Summary: Cannot lockdown access to topic creation using Kafka ACLs
Key: KAFKA-12907
URL: https://issues.apache.org/jira/browse/KAFKA-12907
Project: Kafka
wycc commented on a change in pull request #10835:
URL: https://github.com/apache/kafka/pull/10835#discussion_r646848688
##
File path: build.gradle
##
@@ -1710,6 +1711,8 @@ project(':streams') {
testImplementation libs.powermockEasymock
testImplementation libs.bcp
wycc commented on a change in pull request #10835:
URL: https://github.com/apache/kafka/pull/10835#discussion_r646847971
##
File path: build.gradle
##
@@ -1484,6 +1484,7 @@ project(':storage') {
testImplementation project(':clients').sourceSets.test.output
testImp
ijuma commented on a change in pull request #10835:
URL: https://github.com/apache/kafka/pull/10835#discussion_r646825247
##
File path: build.gradle
##
@@ -1484,6 +1484,7 @@ project(':storage') {
testImplementation project(':clients').sourceSets.test.output
testImplem
[
https://issues.apache.org/jira/browse/KAFKA-12646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-12646:
---
Summary: Implement snapshot generation on brokers (was: Implement lo
[
https://issues.apache.org/jira/browse/KAFKA-12646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio reassigned KAFKA-12646:
--
Assignee: Jose Armando Garcia Sancio
> Implement snapshot gen
[
https://issues.apache.org/jira/browse/KAFKA-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-12338.
-
Resolution: Fixed
> The code of MetadataRecordSerde duplicate with MetadataParser
>
hachikuji merged pull request #10793:
URL: https://github.com/apache/kafka/pull/10793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, plea
junrao commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r646791532
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -1578,144 +1409,85 @@ class Log(@volatile private var _dir: File,
.map(_.messageOffset
wycc commented on a change in pull request #10835:
URL: https://github.com/apache/kafka/pull/10835#discussion_r646802528
##
File path:
streams/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker
##
@@ -0,0 +1,2 @@
+mock-maker-inline
Review comment:
mjsax closed pull request #10837:
URL: https://github.com/apache/kafka/pull/10837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
mjsax opened a new pull request #10837:
URL: https://github.com/apache/kafka/pull/10837
Need to resolve a merge-conflict in `gradle/dependencies.gradle` due to
version bump of `scalaLogging` (cf
https://github.com/apache/kafka/commit/274eccf922bd05f0979a649f1b466a569f197009#diff-02b139e755
wycc commented on a change in pull request #10835:
URL: https://github.com/apache/kafka/pull/10835#discussion_r646780507
##
File path: build.gradle
##
@@ -1710,6 +1710,7 @@ project(':streams') {
testImplementation libs.powermockEasymock
Review comment:
There ar
ijuma commented on a change in pull request #10835:
URL: https://github.com/apache/kafka/pull/10835#discussion_r646771843
##
File path:
streams/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker
##
@@ -0,0 +1,2 @@
+mock-maker-inline
Review comment:
I d
ijuma commented on a change in pull request #10835:
URL: https://github.com/apache/kafka/pull/10835#discussion_r646771214
##
File path: build.gradle
##
@@ -1710,6 +1710,7 @@ project(':streams') {
testImplementation libs.powermockEasymock
Review comment:
Can we remo
sarwarbhuiyan commented on pull request #10836:
URL: https://github.com/apache/kafka/pull/10836#issuecomment-856090401
Updated with new JIRA
JIRA: 12906
KIP: KIP-334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
[
https://issues.apache.org/jira/browse/KAFKA-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sarwar Bhuiyan updated KAFKA-12906:
---
Description: As documented in KIP-334 (provide link), we should add a new
RecordDeserializat
sarwarbhuiyan edited a comment on pull request #10836:
URL: https://github.com/apache/kafka/pull/10836#issuecomment-856090401
Updated with new JIRA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
sarwarbhuiyan edited a comment on pull request #10836:
URL: https://github.com/apache/kafka/pull/10836#issuecomment-856090401
Updated with new JIRA
JIRA: [12906](https://issues.apache.org/jira/browse/KAFKA-12906)
KIP:
[KIP-334](https://cwiki.apache.org/confluence/pages/viewpage.ac
[
https://issues.apache.org/jira/browse/KAFKA-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sarwar Bhuiyan updated KAFKA-12906:
---
Issue Type: Improvement (was: Bug)
Priority: Minor (was: Major)
> Consumer should in
[
https://issues.apache.org/jira/browse/KAFKA-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sarwar Bhuiyan updated KAFKA-12906:
---
Labels: kip-334 (was: )
> Consumer should include partition and offset number in deserializ
[
https://issues.apache.org/jira/browse/KAFKA-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sarwar Bhuiyan updated KAFKA-12906:
---
Component/s: consumer
> Consumer should include partition and offset number in deserializati
Sarwar Bhuiyan created KAFKA-12906:
--
Summary: Consumer should include partition and offset number in
deserialization exception
Key: KAFKA-12906
URL: https://issues.apache.org/jira/browse/KAFKA-12906
ijuma commented on pull request #10828:
URL: https://github.com/apache/kafka/pull/10828#issuecomment-856088259
Thanks @rondagostino
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/KAFKA-9374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358713#comment-17358713
]
Randall Hauch commented on KAFKA-9374:
--
Please ignore link to [GitHub Pull Request
[
https://issues.apache.org/jira/browse/KAFKA-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sarwar Bhuiyan updated KAFKA-5682:
--
Description:
When we encounter an exception when validating a fetched record or when
deseriali
[
https://issues.apache.org/jira/browse/KAFKA-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sarwar Bhuiyan updated KAFKA-5682:
--
Description:
When we encounter an exception when validating a fetched record or when
deseriali
[
https://issues.apache.org/jira/browse/KAFKA-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sarwar Bhuiyan updated KAFKA-5682:
--
Description:
When we encounter an exception when deserializing it, we raise it to the user
and
[
https://issues.apache.org/jira/browse/KAFKA-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sarwar Bhuiyan reassigned KAFKA-5682:
-
Assignee: Sarwar Bhuiyan (was: Stanislav Kozlovski)
> Consumer should include partition
[
https://issues.apache.org/jira/browse/KAFKA-10614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang resolved KAFKA-10614.
---
Fix Version/s: 3.0.0
Resolution: Fixed
> Group coordinator onElection/onResignation s
sarwarbhuiyan opened a new pull request #10836:
URL: https://github.com/apache/kafka/pull/10836
* Dedicated RecordDerserializationException according to KIP-334 proposal.
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests
chia7712 commented on a change in pull request #10835:
URL: https://github.com/apache/kafka/pull/10835#discussion_r646742679
##
File path:
streams/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker
##
@@ -0,0 +1,2 @@
+mock-maker-inline
Review comment:
guozhangwang commented on pull request #9441:
URL: https://github.com/apache/kafka/pull/9441#issuecomment-856074980
Thank YOU for the great patience @tombentley (it lasts for more than 6
months..) !
--
This is an automated message from the Apache Git Service.
To respond to the message, p
wycc opened a new pull request #10835:
URL: https://github.com/apache/kafka/pull/10835
Development of EasyMock and PowerMock has stagnated while Mockito continues
to be actively developed. With the new Java cadence, it's a problem to depend
on libraries that do bytecode generation and
rondagostino edited a comment on pull request #10828:
URL: https://github.com/apache/kafka/pull/10828#issuecomment-856062129
@ijuma I checked out 772f2cfc828d9da56559968a8eed06f2c8c43062 from before
those PRs I mentioned above (Wed Feb 3) and I see the same log line in a system
test. I th
rondagostino commented on pull request #10828:
URL: https://github.com/apache/kafka/pull/10828#issuecomment-856062129
@ijuma I checked out 772f2cfc828d9da56559968a8eed06f2c8c43062 from before
those PRs I mentioned above (Wed Feb 3) and I see the same log line in a system
test. I thin chec
rhauch opened a new pull request #10834:
URL: https://github.com/apache/kafka/pull/10834
The constant is specified in milliseconds, and so the MILLISECOND time unit
should be used instead of SECONDS. See
#8069/[KAFKA-9374](https://issues.apache.org/jira/browse/KAFKA-9374).
Inspected
rhauch commented on pull request #10833:
URL: https://github.com/apache/kafka/pull/10833#issuecomment-856054711
Specified the wrong KAFKA issue in my PR branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
rhauch closed pull request #10833:
URL: https://github.com/apache/kafka/pull/10833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
[
https://issues.apache.org/jira/browse/KAFKA-12904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch reassigned KAFKA-12904:
-
Assignee: Randall Hauch
> Connect's validate REST endpoint uses incorrect timeout
> ---
rhauch opened a new pull request #10833:
URL: https://github.com/apache/kafka/pull/10833
The constant is specified in milliseconds, and so the MILLISECOND time unit
should be used instead of SECONDS.
Inspected other uses of the same constant and other changes in the original
PR, and
lct45 commented on a change in pull request #10813:
URL: https://github.com/apache/kafka/pull/10813#discussion_r646714882
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/SourceNode.java
##
@@ -51,10 +52,16 @@ public SourceNode(final String name
YI-CHEN WANG created KAFKA-12905:
Summary: Replace EasyMock and PowerMock with Mockito for
NamedCacheMetricsTest
Key: KAFKA-12905
URL: https://issues.apache.org/jira/browse/KAFKA-12905
Project: Kafka
1 - 100 of 126 matches
Mail list logo
