[GitHub] [kafka] ijuma commented on a change in pull request #10835: KAFKA-12905: Replace EasyMock and PowerMock with Mockito for NamedCacheMetricsTest

[GitBox]

ijuma commented on a change in pull request #10835:
URL: https://github.com/apache/kafka/pull/10835#discussion_r646825247



##########
File path: build.gradle
##########
@@ -1484,6 +1484,7 @@ project(':storage') {
     testImplementation project(':clients').sourceSets.test.output
     testImplementation libs.junitJupiter
     testImplementation libs.mockitoCore
+    testImplementation libs.mockitoInline // supports mocking static methods, 
final classes, etc.

Review comment:
       Why have we made this change?

##########
File path: build.gradle
##########
@@ -1710,6 +1711,8 @@ project(':streams') {
     testImplementation libs.powermockEasymock
     testImplementation libs.bcpkix
     testImplementation libs.hamcrest
+    testImplementation libs.mockitoCore

Review comment:
       We probably don't need this, right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org