jlprat commented on a change in pull request #10766:
URL: https://github.com/apache/kafka/pull/10766#discussion_r640338703
##
File path: docs/toc.html
##
@@ -86,26 +86,26 @@
Increasing replication factor
6.2 Datace
jlprat commented on pull request #10767:
URL: https://github.com/apache/kafka/pull/10767#issuecomment-849379890
@showuon thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
jlprat commented on pull request #10767:
URL: https://github.com/apache/kafka/pull/10767#issuecomment-849363018
Hi @showuon it is not the right character _per se_, it is only for a
consistency reason with the rest of the examples on the documentation. The vast
majority of the bash examples
[
https://issues.apache.org/jira/browse/KAFKA-12819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantine Karantasis resolved KAFKA-12819.
Resolution: Fixed
> Quality of life improvements for tests
> -
[
https://issues.apache.org/jira/browse/KAFKA-12819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantine Karantasis updated KAFKA-12819:
---
Fix Version/s: 3.0.0
> Quality of life improvements for tests
>
kkonstantine merged pull request #10762:
URL: https://github.com/apache/kafka/pull/10762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
[
https://issues.apache.org/jira/browse/KAFKA-10886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352300#comment-17352300
]
Mehajabeen commented on KAFKA-10886:
Hi Wenbing,
Thanks for respondin
dongjinleekr commented on pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#issuecomment-849306073
@cadonna I greatly appreciate your detailed review. Here is the update!
:smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, p
dongjinleekr commented on a change in pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#discussion_r640273965
##
File path: eclipse-formatter.xml
##
@@ -0,0 +1,60 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
dongjinleekr commented on a change in pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#discussion_r640273794
##
File path: core/src/test/java/kafka/test/junit/ClusterTestExtensions.java
##
@@ -175,7 +175,7 @@ private void processClusterTest(ExtensionContext
dongjinleekr commented on a change in pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#discussion_r640273422
##
File path: eclipse-formatter.xml
##
@@ -0,0 +1,60 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
showuon commented on a change in pull request #10768:
URL: https://github.com/apache/kafka/pull/10768#discussion_r640268231
##
File path: docs/ops.html
##
@@ -248,98 +248,98 @@ only exist on brokers 5,6.
Since the tool accepts the input list of topics as a json file, you
showuon commented on a change in pull request #10767:
URL: https://github.com/apache/kafka/pull/10767#discussion_r640262291
##
File path: docs/quickstart.html
##
@@ -244,7 +244,7 @@
Congratulations!
-You have successfully finished the Apache Ka
showuon commented on a change in pull request #10766:
URL: https://github.com/apache/kafka/pull/10766#discussion_r640261542
##
File path: docs/toc.html
##
@@ -86,26 +86,26 @@
Increasing replication factor
6.2 Datac
showuon opened a new pull request #10773:
URL: https://github.com/apache/kafka/pull/10773
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
[
https://issues.apache.org/jira/browse/KAFKA-10886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352242#comment-17352242
]
Wenbing Shen commented on KAFKA-10886:
--
I already know why you can’t use this patch
kowshik commented on pull request #10684:
URL: https://github.com/apache/kafka/pull/10684#issuecomment-849263208
@junrao Thanks for the review and for catching this issue! I've fixed the
build now. The issue was that the code in `Log.scala` used the
`Iterator.nextOption()`[API](https://www
[
https://issues.apache.org/jira/browse/KAFKA-9977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352230#comment-17352230
]
dc-heros commented on KAFKA-9977:
-
hi [~ChrisEgerton], do you assign this issue to me ?
[
https://issues.apache.org/jira/browse/KAFKA-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352219#comment-17352219
]
dc-heros commented on KAFKA-5892:
-
hi [~rhauch], can you assign me to this issue? Many th
vitojeng commented on a change in pull request #10668:
URL: https://github.com/apache/kafka/pull/10668#discussion_r640217904
##
File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java
##
@@ -491,25 +493,23 @@ public void testStateThreadClose() throws Exc
guozhangwang merged pull request #10771:
URL: https://github.com/apache/kafka/pull/10771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
guozhangwang commented on a change in pull request #10765:
URL: https://github.com/apache/kafka/pull/10765#discussion_r640180457
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/TaskMetricsTest.java
##
@@ -56,20 +49,9 @@
private fin
ableegoldman commented on pull request #10657:
URL: https://github.com/apache/kafka/pull/10657#issuecomment-849182031
No worries! Take care of yourself first, KIP-216 can wait for you 🙂 I just
wanted to check in and mostly, make sure you don't need anything from my end.
I'll keep an eye o
ijuma commented on a change in pull request #10704:
URL: https://github.com/apache/kafka/pull/10704#discussion_r640186978
##
File path:
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
##
@@ -106,7 +107,7 @@ public AbstractConfig(ConfigDef definition, M
vitojeng commented on pull request #10657:
URL: https://github.com/apache/kafka/pull/10657#issuecomment-849170302
@ableegoldman Thanks for your concern, KIP-216 still in progress. 🙂
It's really busy in the last two weeks, some bad things continue to happen
in Taiwan.
I will stick to
prince-mahajan opened a new pull request #10771:
URL: https://github.com/apache/kafka/pull/10771
Fixing the link to a cited blog. The existing link now points to a steroid
website so need to pull the blog from internet archives.
*More detailed description of your change,
if necess
[
https://issues.apache.org/jira/browse/KAFKA-12845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352111#comment-17352111
]
Pedro Gontijo edited comment on KAFKA-12845 at 5/26/21, 10:43 PM:
[
https://issues.apache.org/jira/browse/KAFKA-12845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352111#comment-17352111
]
Pedro Gontijo commented on KAFKA-12845:
---
Thanks for the reply [~mjsax]
I see what
ableegoldman edited a comment on pull request #10657:
URL: https://github.com/apache/kafka/pull/10657#issuecomment-849145231
Hey @vitojeng , was this the final PR for KIP-216? If not is the next one
available yet? No rush, just want to make sure you haven't been waiting on
reviews this who
[
https://issues.apache.org/jira/browse/KAFKA-5876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-5876:
--
Description:
Currently, IQ does only throws {{InvalidStateStoreException}} for
lbradstreet edited a comment on pull request #10704:
URL: https://github.com/apache/kafka/pull/10704#issuecomment-849144204
@ijuma I figured out the cause with some state change checks. The problem is
that we're passing a recording map through to the channel/principal builders,
and the rec
ableegoldman commented on pull request #10657:
URL: https://github.com/apache/kafka/pull/10657#issuecomment-849145231
Hey @vitojeng , was this the final PR for KIP-216? If not is the next one
available yet? No rush, just want to make sure you haven't been waiting on
reviews this whole time
lbradstreet commented on pull request #10704:
URL: https://github.com/apache/kafka/pull/10704#issuecomment-849144204
@ijuma I figured out the cause with some state change checks. The problem is
that we're passing a recording map through to the channel/principal builders,
and the recording
[
https://issues.apache.org/jira/browse/KAFKA-12550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12550:
---
Fix Version/s: (was: 3.0.0)
4.0.0
> Introduce RESTORI
[
https://issues.apache.org/jira/browse/KAFKA-12550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12550:
---
Priority: Major (was: Blocker)
> Introduce RESTORING state to the KafkaStre
[
https://issues.apache.org/jira/browse/KAFKA-12550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman reassigned KAFKA-12550:
--
Assignee: (was: A. Sophie Blee-Goldman)
> Introduce RESTORING sta
Lincong Li created KAFKA-12854:
--
Summary: Add a config to allow skipping metadata cache update when
topic partition is unassigned
Key: KAFKA-12854
URL: https://issues.apache.org/jira/browse/KAFKA-12854
P
Colin McCabe created KAFKA-12853:
Summary: Implement broker-side KRaft snapshots
Key: KAFKA-12853
URL: https://issues.apache.org/jira/browse/KAFKA-12853
Project: Kafka
Issue Type: Improvement
mjsax commented on a change in pull request #10668:
URL: https://github.com/apache/kafka/pull/10668#discussion_r640127195
##
File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java
##
@@ -525,14 +525,13 @@ public void testStateGlobalThreadClose() throws
mjsax commented on a change in pull request #10668:
URL: https://github.com/apache/kafka/pull/10668#discussion_r640126531
##
File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java
##
@@ -491,25 +493,23 @@ public void testStateThreadClose() throws Except
Jun Rao created KAFKA-12852:
---
Summary: Log.splitOverflowedSegment() doesn't generate producer
snapshot for new segment
Key: KAFKA-12852
URL: https://issues.apache.org/jira/browse/KAFKA-12852
Project: Kafka
junrao merged pull request #10756:
URL: https://github.com/apache/kafka/pull/10756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
kowshik commented on pull request #10684:
URL: https://github.com/apache/kafka/pull/10684#issuecomment-849086875
Thanks for the review @junrao! I have addressed your comments in
4b836034415c3d5f6b84384ef9be1e75b66edc4b.
--
This is an automated message from the Apache Git Service.
To resp
mumrah commented on a change in pull request #10752:
URL: https://github.com/apache/kafka/pull/10752#discussion_r640070688
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -1199,6 +1213,22 @@ public void processBatchEndOffset(long of
tang7526 commented on a change in pull request #10534:
URL: https://github.com/apache/kafka/pull/10534#discussion_r640027627
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -162,15 +162,43 @@ class LogSegment private[log] (val log: FileRecords,
// appe
tang7526 commented on a change in pull request #10534:
URL: https://github.com/apache/kafka/pull/10534#discussion_r640027627
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -162,15 +162,43 @@ class LogSegment private[log] (val log: FileRecords,
// appe
tang7526 commented on a change in pull request #10534:
URL: https://github.com/apache/kafka/pull/10534#discussion_r640024597
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -162,15 +162,43 @@ class LogSegment private[log] (val log: FileRecords,
// appe
[
https://issues.apache.org/jira/browse/KAFKA-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352010#comment-17352010
]
Britt Bolen edited comment on KAFKA-9531 at 5/26/21, 6:28 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352010#comment-17352010
]
Britt Bolen edited comment on KAFKA-9531 at 5/26/21, 6:27 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352010#comment-17352010
]
Britt Bolen commented on KAFKA-9531:
I see a similar issue using both the cli produce
tang7526 removed a comment on pull request #10534:
URL: https://github.com/apache/kafka/pull/10534#issuecomment-825051965
@chia7712 Could you help to review this PR? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
tang7526 commented on pull request #10534:
URL: https://github.com/apache/kafka/pull/10534#issuecomment-849014645
> @tang7526: Thanks for the PR. A few comments below. Also, could we add a
unit test for this?
Done.
--
This is an automated message from the Apache Git Service.
To re
tang7526 commented on a change in pull request #10534:
URL: https://github.com/apache/kafka/pull/10534#discussion_r640016337
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -162,15 +162,43 @@ class LogSegment private[log] (val log: FileRecords,
// appe
tang7526 commented on a change in pull request #10534:
URL: https://github.com/apache/kafka/pull/10534#discussion_r640016337
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -162,15 +162,43 @@ class LogSegment private[log] (val log: FileRecords,
// appe
mjsax commented on a change in pull request #10731:
URL: https://github.com/apache/kafka/pull/10731#discussion_r640004045
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/ValueTransformerWithKey.java
##
@@ -75,14 +75,20 @@
void init(final ProcessorCont
[
https://issues.apache.org/jira/browse/KAFKA-12848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351978#comment-17351978
]
Sagar Rao commented on KAFKA-12848:
---
[~ableegoldman], I think I have seen it in the AK
[
https://issues.apache.org/jira/browse/KAFKA-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351974#comment-17351974
]
Josep Prat commented on KAFKA-12849:
Thanks a lot for the explanation! It's all clea
[
https://issues.apache.org/jira/browse/KAFKA-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351970#comment-17351970
]
A. Sophie Blee-Goldman commented on KAFKA-12849:
That's something we'll
ableegoldman merged pull request #10755:
URL: https://github.com/apache/kafka/pull/10755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
A. Sophie Blee-Goldman created KAFKA-12851:
--
Summary: Flaky Test
RaftEventSimulationTest.canMakeProgressIfMajorityIsReachable
Key: KAFKA-12851
URL: https://issues.apache.org/jira/browse/KAFKA-12851
ableegoldman commented on pull request #10755:
URL: https://github.com/apache/kafka/pull/10755#issuecomment-848974085
Unrelated test failures:
`DynamicBrokerConfigTest.testPasswordConfigEncoderSecretChange()`
`RaftClusterTest`
`RaftEventSimulationTest.canMakeProgressIfMajorityIsReac
[
https://issues.apache.org/jira/browse/KAFKA-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351965#comment-17351965
]
Josep Prat commented on KAFKA-12849:
Just to be sure, the intention is to convert Ta
[
https://issues.apache.org/jira/browse/KAFKA-12848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351948#comment-17351948
]
A. Sophie Blee-Goldman commented on KAFKA-12848:
[~sagarrao] John actual
[
https://issues.apache.org/jira/browse/KAFKA-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351947#comment-17351947
]
Josep Prat commented on KAFKA-12849:
I'll prepare the KIP tomorrow
> Consider migra
[
https://issues.apache.org/jira/browse/KAFKA-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351946#comment-17351946
]
A. Sophie Blee-Goldman commented on KAFKA-9168:
---
Sounds good! This shouldn'
mjsax commented on a change in pull request #10755:
URL: https://github.com/apache/kafka/pull/10755#discussion_r639948650
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/TaskMetadata.java
##
@@ -40,6 +40,18 @@
private final Optional timeCurrentIdl
mumrah commented on a change in pull request #10752:
URL: https://github.com/apache/kafka/pull/10752#discussion_r639938409
##
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##
@@ -22,7 +22,6 @@ import java.util.concurrent.atomic.AtomicBoolean
import java.util.c
ableegoldman commented on a change in pull request #10755:
URL: https://github.com/apache/kafka/pull/10755#discussion_r639936420
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/TaskMetadata.java
##
@@ -40,6 +40,18 @@
private final Optional timeCur
[
https://issues.apache.org/jira/browse/KAFKA-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351940#comment-17351940
]
A. Sophie Blee-Goldman commented on KAFKA-12849:
Yep – it _should_ be re
[
https://issues.apache.org/jira/browse/KAFKA-12824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351939#comment-17351939
]
Matthias J. Sax commented on KAFKA-12824:
-
It's not totally clear, but 4.0 shoul
[
https://issues.apache.org/jira/browse/KAFKA-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josep Prat reassigned KAFKA-12849:
--
Assignee: Josep Prat
> Consider migrating TaskMetadata to interface with internal implementat
[
https://issues.apache.org/jira/browse/KAFKA-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351936#comment-17351936
]
Josep Prat commented on KAFKA-12849:
I would like to work on this one. Shall I creat
[
https://issues.apache.org/jira/browse/KAFKA-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josep Prat updated KAFKA-12849:
---
Comment: was deleted
(was: I would like to work on this one. Shall I first create the KIP?)
> Consi
[
https://issues.apache.org/jira/browse/KAFKA-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351935#comment-17351935
]
Josep Prat commented on KAFKA-12849:
I would like to work on this one. Shall I first
cmccabe commented on a change in pull request #10752:
URL: https://github.com/apache/kafka/pull/10752#discussion_r639928477
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -1199,6 +1213,22 @@ public void processBatchEndOffset(long o
cmccabe commented on pull request #10752:
URL: https://github.com/apache/kafka/pull/10752#issuecomment-848944712
Thanks for this, @mumrah . Very clean PR overall.
Can you add a test that the RPC fails if we don't have cluster
authorization, in `ControllerApisTest.scala`? Should be ve
cmccabe commented on a change in pull request #10752:
URL: https://github.com/apache/kafka/pull/10752#discussion_r639922279
##
File path:
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala
##
@@ -259,6 +260,10 @@ class BrokerMetadataListener(
clientQuo
cmccabe commented on a change in pull request #10752:
URL: https://github.com/apache/kafka/pull/10752#discussion_r639919977
##
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##
@@ -22,7 +22,6 @@ import java.util.concurrent.atomic.AtomicBoolean
import java.util.
cmccabe commented on a change in pull request #10752:
URL: https://github.com/apache/kafka/pull/10752#discussion_r639919437
##
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##
@@ -246,9 +245,16 @@ class BrokerServer(
// Create transaction coordinator,
ableegoldman commented on a change in pull request #10755:
URL: https://github.com/apache/kafka/pull/10755#discussion_r639896963
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/TaskMetadata.java
##
@@ -40,6 +40,18 @@
private final Optional timeCur
[
https://issues.apache.org/jira/browse/KAFKA-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351916#comment-17351916
]
Jitendra Sahu commented on KAFKA-5892:
--
Sure,go ahead.
> Connector property overrid
[
https://issues.apache.org/jira/browse/KAFKA-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12849:
---
Labels: needs-kip newbie newbie++ (was: )
> Consider migrating TaskMetadata
[
https://issues.apache.org/jira/browse/KAFKA-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351898#comment-17351898
]
Justine Olshan edited comment on KAFKA-12257 at 5/26/21, 4:05 PM:
[
https://issues.apache.org/jira/browse/KAFKA-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351898#comment-17351898
]
Justine Olshan edited comment on KAFKA-12257 at 5/26/21, 4:05 PM:
[
https://issues.apache.org/jira/browse/KAFKA-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351898#comment-17351898
]
Justine Olshan edited comment on KAFKA-12257 at 5/26/21, 4:05 PM:
socutes commented on pull request #10596:
URL: https://github.com/apache/kafka/pull/10596#issuecomment-848901314
PR is a little hasty, I submit each KIP to initiate the operation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
socutes closed pull request #10596:
URL: https://github.com/apache/kafka/pull/10596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
[
https://issues.apache.org/jira/browse/KAFKA-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351898#comment-17351898
]
Justine Olshan commented on KAFKA-12257:
With the changes from
[KIP-516|https:/
jolshan commented on a change in pull request #10761:
URL: https://github.com/apache/kafka/pull/10761#discussion_r639833755
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -325,19 +325,25 @@ class Log(@volatile private var _dir: File,
// Ensure we do not try to
vvcephei commented on a change in pull request #10731:
URL: https://github.com/apache/kafka/pull/10731#discussion_r639778036
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/ValueTransformerWithKey.java
##
@@ -75,14 +75,20 @@
void init(final ProcessorC
[
https://issues.apache.org/jira/browse/KAFKA-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351807#comment-17351807
]
jorge arada commented on KAFKA-7500:
Any ideia when the SinkConnector will be release
KahnCheny commented on pull request #10746:
URL: https://github.com/apache/kafka/pull/10746#issuecomment-848777456
jenkins pr-merge passes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
showuon commented on pull request #10338:
URL: https://github.com/apache/kafka/pull/10338#issuecomment-848770650
@mumrah , could you please take a look again? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
jlprat commented on pull request #10769:
URL: https://github.com/apache/kafka/pull/10769#issuecomment-848762697
CC. @cadonna as you reviewed the last doc changes on formatting and styling,
you might want to review these as well. I split the changes in several PRs so
it's more bearable to r
jlprat commented on pull request #10770:
URL: https://github.com/apache/kafka/pull/10770#issuecomment-848762769
CC. @cadonna as you reviewed the last doc changes on formatting and styling,
you might want to review these as well. I split the changes in several PRs so
it's more bearable to r
jlprat commented on pull request #10767:
URL: https://github.com/apache/kafka/pull/10767#issuecomment-848762425
CC. @cadonna as you reviewed the last doc changes on formatting and styling,
you might want to review these as well. I split the changes in several PRs so
it's more bearable to r
jlprat commented on pull request #10768:
URL: https://github.com/apache/kafka/pull/10768#issuecomment-848762557
CC. @cadonna as you reviewed the last doc changes on formatting and styling,
you might want to review these as well. I split the changes in several PRs so
it's more bearable to r
jlprat commented on pull request #10766:
URL: https://github.com/apache/kafka/pull/10766#issuecomment-848762136
CC. @cadonna as you reviewed the last doc changes on formatting and styling,
you might want to review these as well. I split the changes in several PRs so
it's more bearable to r
jlprat opened a new pull request #10770:
URL: https://github.com/apache/kafka/pull/10770
Fix examples under security.html so they use the right bash icon (`>`
instead of `$`) and also uses the right tool for showing code listings
Some of the diffs are caused also by the IDE alignin
jlprat opened a new pull request #10769:
URL: https://github.com/apache/kafka/pull/10769
Uses the right tool to show code listings, so it is consistent with the
rest of the examples
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
1 - 100 of 123 matches
Mail list logo
