[GitHub] [kafka] showuon commented on pull request #10457: KAFKA-12596: remove --zookeeper option from topic command

showuon commented on pull request #10457: URL: https://github.com/apache/kafka/pull/10457#issuecomment-842887662 @ijuma , please help review this PR again. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [kafka] showuon commented on pull request #10715: KAFKA-9295: increase heartbeat and session timeout

showuon commented on pull request #10715: URL: https://github.com/apache/kafka/pull/10715#issuecomment-842883396 failed test is flaky RaftClusterTest: ``` Build / JDK 15 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic() ``` -- This is an a

[GitHub] [kafka] satishd commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

satishd commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r634023546 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerConfig.java ## @@ -0,0 +1,197 @

[GitHub] [kafka] vamossagar12 commented on pull request #10542: KAFKA-12313: Streamling windowed Deserialiser configs.

vamossagar12 commented on pull request #10542: URL: https://github.com/apache/kafka/pull/10542#issuecomment-842807268 thanks @ableegoldman , have updated the main KIP page, the streams kiP sub page and the actual kiP. Thanks for your support! -- This is an automated message from the Apac

[jira] [Commented] (KAFKA-12804) In-Memory state store backed by InMemoryKeyValueStore is slow due to synchronizing reads/writes using a single lock.

[ https://issues.apache.org/jira/browse/KAFKA-12804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346566#comment-17346566 ] Ki Lok Wong commented on KAFKA-12804: - Yep, I will do it later this arvo.  Cheers.

[GitHub] [kafka] showuon commented on pull request #10715: KAFKA-9295: increase heartbeat and session timeout

showuon commented on pull request #10715: URL: https://github.com/apache/kafka/pull/10715#issuecomment-842799201 @ableegoldman , as discussed, could you help review this PR to increase session timeout? Thanks. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Assigned] (KAFKA-12804) In-Memory state store backed by InMemoryKeyValueStore is slow due to synchronizing reads/writes using a single lock.

[ https://issues.apache.org/jira/browse/KAFKA-12804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ki Lok Wong reassigned KAFKA-12804: --- Assignee: Ki Lok Wong > In-Memory state store backed by InMemoryKeyValueStore is slow due t

[jira] [Commented] (KAFKA-12804) In-Memory state store backed by InMemoryKeyValueStore is slow due to synchronizing reads/writes using a single lock.

[ https://issues.apache.org/jira/browse/KAFKA-12804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346554#comment-17346554 ] A. Sophie Blee-Goldman commented on KAFKA-12804: Hey [~gorsonw] thanks f

[GitHub] [kafka] showuon opened a new pull request #10715: KAFKA-9295: increase heartbeat and session timeout

showuon opened a new pull request #10715: URL: https://github.com/apache/kafka/pull/10715 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgra

[jira] [Updated] (KAFKA-12804) In-Memory state store backed by InMemoryKeyValueStore is slow due to synchronizing reads/writes using a single lock.

[ https://issues.apache.org/jira/browse/KAFKA-12804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ki Lok Wong updated KAFKA-12804: Remaining Estimate: 2h (was: 2m) Original Estimate: 2h (was: 2m) > In-Memory state store ba

[jira] [Created] (KAFKA-12804) In-Memory state store backed by InMemoryKeyValueStore is slow due to synchronizing reads/writes using a single lock.

Ki Lok Wong created KAFKA-12804: --- Summary: In-Memory state store backed by InMemoryKeyValueStore is slow due to synchronizing reads/writes using a single lock. Key: KAFKA-12804 URL: https://issues.apache.org/jira/br

[GitHub] [kafka] showuon commented on pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

showuon commented on pull request #10471: URL: https://github.com/apache/kafka/pull/10471#issuecomment-842772724 @ijuma , could you take a look again for this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [kafka] showuon commented on pull request #10665: KAFKA-9009: increase replica.lag.time.max.ms to make the test reliable

showuon commented on pull request #10665: URL: https://github.com/apache/kafka/pull/10665#issuecomment-842772461 @edoardocomar @mimaison , could you help review this PR to make the test reliable. Thank you. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [kafka] abbccdda commented on pull request #9311: KAFKA-9910: Implement new transaction timed out error

abbccdda commented on pull request #9311: URL: https://github.com/apache/kafka/pull/9311#issuecomment-842758541 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [kafka] jsancio commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

jsancio commented on a change in pull request #10705: URL: https://github.com/apache/kafka/pull/10705#discussion_r633958458 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -936,21 +944,13 @@ private QuorumController(LogContext logCo

[GitHub] [kafka] jsancio commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

jsancio commented on a change in pull request #10705: URL: https://github.com/apache/kafka/pull/10705#discussion_r633957907 ## File path: core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala ## @@ -234,22 +259,20 @@ class BrokerMetadataListener(brokerId: Int,

[GitHub] [kafka] jsancio commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

jsancio commented on a change in pull request #10705: URL: https://github.com/apache/kafka/pull/10705#discussion_r633956946 ## File path: raft/src/main/java/org/apache/kafka/raft/LeaderAndEpoch.java ## @@ -28,6 +28,10 @@ public LeaderAndEpoch(OptionalInt leaderId, int epoch) {

[GitHub] [kafka] jsancio commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

jsancio commented on a change in pull request #10705: URL: https://github.com/apache/kafka/pull/10705#discussion_r633956837 ## File path: raft/src/main/java/org/apache/kafka/raft/BatchReader.java ## @@ -57,4 +60,9 @@ */ @Override void close(); + +static Bat

[GitHub] [kafka] jsancio commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

jsancio commented on a change in pull request #10705: URL: https://github.com/apache/kafka/pull/10705#discussion_r633956073 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -202,7 +200,7 @@ public Builder setMetrics(ControllerMetrics

[GitHub] [kafka] jsancio commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

jsancio commented on a change in pull request #10705: URL: https://github.com/apache/kafka/pull/10705#discussion_r633956010 ## File path: metadata/src/test/java/org/apache/kafka/metalog/LocalLogManager.java ## @@ -218,7 +226,7 @@ synchronized void electLeaderIfNeeded() { /

[GitHub] [kafka] jsancio commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

jsancio commented on a change in pull request #10705: URL: https://github.com/apache/kafka/pull/10705#discussion_r633940297 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2261,6 +2260,11 @@ private Long append(int epoch, List records, boolean

[jira] [Created] (KAFKA-12803) Support reassigning partitions when in KRaft mode

Colin McCabe created KAFKA-12803: Summary: Support reassigning partitions when in KRaft mode Key: KAFKA-12803 URL: https://issues.apache.org/jira/browse/KAFKA-12803 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-12788) Improve KRaft replica placement

[ https://issues.apache.org/jira/browse/KAFKA-12788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-12788: - Affects Version/s: 2.8.0 > Improve KRaft replica placement > --- > >

[jira] [Resolved] (KAFKA-12788) Improve KRaft replica placement

[ https://issues.apache.org/jira/browse/KAFKA-12788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-12788. -- Fix Version/s: 3.0.0 Reviewer: Jun Rao Resolution: Fixed > Improve KRaft repli

[GitHub] [kafka] cmccabe merged pull request #10494: KAFKA-12788: improve KRaft replica placement

cmccabe merged pull request #10494: URL: https://github.com/apache/kafka/pull/10494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] jsancio commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

jsancio commented on a change in pull request #10705: URL: https://github.com/apache/kafka/pull/10705#discussion_r633935466 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftClient.java ## @@ -56,24 +57,17 @@ void handleSnapshot(SnapshotReader reader);

[GitHub] [kafka] jsancio commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

jsancio commented on a change in pull request #10705: URL: https://github.com/apache/kafka/pull/10705#discussion_r633935466 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftClient.java ## @@ -56,24 +57,17 @@ void handleSnapshot(SnapshotReader reader);

[GitHub] [kafka] jsancio commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

jsancio commented on a change in pull request #10705: URL: https://github.com/apache/kafka/pull/10705#discussion_r633930529 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftClient.java ## @@ -56,24 +57,17 @@ void handleSnapshot(SnapshotReader reader);

[GitHub] [kafka] cmccabe commented on a change in pull request #10494: KAFKA-12788: improve KRaft replica placement

cmccabe commented on a change in pull request #10494: URL: https://github.com/apache/kafka/pull/10494#discussion_r633929510 ## File path: metadata/src/test/java/org/apache/kafka/controller/StripedReplicaPlacerTest.java ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [kafka] cmccabe commented on a change in pull request #10494: KAFKA-12788: improve KRaft replica placement

cmccabe commented on a change in pull request #10494: URL: https://github.com/apache/kafka/pull/10494#discussion_r633926611 ## File path: metadata/src/main/java/org/apache/kafka/controller/StripedReplicaPlacer.java ## @@ -0,0 +1,411 @@ +/* + * Licensed to the Apache Software F

[GitHub] [kafka] cmccabe commented on a change in pull request #10494: KAFKA-12788: improve KRaft replica placement

cmccabe commented on a change in pull request #10494: URL: https://github.com/apache/kafka/pull/10494#discussion_r633926611 ## File path: metadata/src/main/java/org/apache/kafka/controller/StripedReplicaPlacer.java ## @@ -0,0 +1,411 @@ +/* + * Licensed to the Apache Software F

[GitHub] [kafka] cmccabe commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

cmccabe commented on a change in pull request #10705: URL: https://github.com/apache/kafka/pull/10705#discussion_r633909171 ## File path: metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java ## @@ -209,136 +196,6 @@ public void testUnregisterBroker() th

[GitHub] [kafka] cmccabe commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

cmccabe commented on a change in pull request #10705: URL: https://github.com/apache/kafka/pull/10705#discussion_r633900447 ## File path: core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala ## @@ -234,22 +259,20 @@ class BrokerMetadataListener(brokerId: Int,

[GitHub] [kafka] cmccabe commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

cmccabe commented on a change in pull request #10705: URL: https://github.com/apache/kafka/pull/10705#discussion_r633918245 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -936,21 +944,13 @@ private QuorumController(LogContext logCo

[jira] [Created] (KAFKA-12802) Add a file based cache for consumed remote log metadata for each partition to avoid consuming again incase of broker restarts.

Satish Duggana created KAFKA-12802: -- Summary: Add a file based cache for consumed remote log metadata for each partition to avoid consuming again incase of broker restarts. Key: KAFKA-12802 URL: https://issues.ap

[jira] [Updated] (KAFKA-9555) Topic-based implementation for the RemoteLogMetadataManager

[ https://issues.apache.org/jira/browse/KAFKA-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-9555: -- Description: The purpose of this task is to implement a {{RemoteLogMetadataManager}} based on

[GitHub] [kafka] cmccabe commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

cmccabe commented on a change in pull request #10705: URL: https://github.com/apache/kafka/pull/10705#discussion_r633917057 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftClient.java ## @@ -56,24 +57,17 @@ void handleSnapshot(SnapshotReader reader);

[GitHub] [kafka] cmccabe commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

cmccabe commented on a change in pull request #10705: URL: https://github.com/apache/kafka/pull/10705#discussion_r633915001 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2261,6 +2260,11 @@ private Long append(int epoch, List records, boolean

[GitHub] [kafka] cmccabe commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

cmccabe commented on a change in pull request #10705: URL: https://github.com/apache/kafka/pull/10705#discussion_r633914096 ## File path: metadata/src/test/java/org/apache/kafka/metalog/LocalLogManager.java ## @@ -331,22 +343,40 @@ public void beginShutdown() { } @O

[GitHub] [kafka] cmccabe commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

cmccabe commented on a change in pull request #10705: URL: https://github.com/apache/kafka/pull/10705#discussion_r633912779 ## File path: metadata/src/test/java/org/apache/kafka/metalog/LocalLogManager.java ## @@ -218,7 +226,7 @@ synchronized void electLeaderIfNeeded() { /

[GitHub] [kafka] cmccabe commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

cmccabe commented on a change in pull request #10705: URL: https://github.com/apache/kafka/pull/10705#discussion_r633910968 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -624,50 +617,71 @@ public String toString() { retur

[GitHub] [kafka] cmccabe commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

cmccabe commented on a change in pull request #10705: URL: https://github.com/apache/kafka/pull/10705#discussion_r633910968 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -624,50 +617,71 @@ public String toString() { retur

[jira] [Assigned] (KAFKA-9578) Kafka Tiered Storage - System Tests

[ https://issues.apache.org/jira/browse/KAFKA-9578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana reassigned KAFKA-9578: - Assignee: Kamal Chandraprakash (was: Alexandre Dupriez) > Kafka Tiered Storage - System

[jira] [Updated] (KAFKA-9579) RLM fetch implementation by adding respective purgatory

[ https://issues.apache.org/jira/browse/KAFKA-9579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-9579: -- Fix Version/s: 3.0.0 > RLM fetch implementation by adding respective purgatory > --

[jira] [Updated] (KAFKA-9578) Kafka Tiered Storage - System Tests

[ https://issues.apache.org/jira/browse/KAFKA-9578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-9578: -- Fix Version/s: 3.0.0 > Kafka Tiered Storage - System Tests > -

[jira] [Updated] (KAFKA-9990) Supporting transactions in tiered storage

[ https://issues.apache.org/jira/browse/KAFKA-9990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-9990: -- Fix Version/s: 3.0.0 > Supporting transactions in tiered storage >

[jira] [Assigned] (KAFKA-7739) Kafka Tiered Storage

[ https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana reassigned KAFKA-7739: - Assignee: Satish Duggana (was: Harsha) > Kafka Tiered Storage > >

[jira] [Updated] (KAFKA-12641) Clear RemoteLogLeaderEpochState entry when it become empty.

[ https://issues.apache.org/jira/browse/KAFKA-12641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-12641: --- Fix Version/s: 3.0.0 > Clear RemoteLogLeaderEpochState entry when it become empty. > --

[jira] [Updated] (KAFKA-9555) Topic-based implementation for the RemoteLogMetadataManager

[ https://issues.apache.org/jira/browse/KAFKA-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-9555: -- Fix Version/s: 3.0.0 > Topic-based implementation for the RemoteLogMetadataManager > --

[jira] [Updated] (KAFKA-9550) RemoteLogManager implementation

[ https://issues.apache.org/jira/browse/KAFKA-9550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-9550: -- Fix Version/s: 3.0.0 > RemoteLogManager implementation > > >

[jira] [Updated] (KAFKA-7739) Kafka Tiered Storage

[ https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-7739: -- Component/s: core > Kafka Tiered Storage > > > Key: KAFKA-

[jira] [Updated] (KAFKA-7739) Kafka Tiered Storage

[ https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-7739: -- Fix Version/s: 3.0.0 > Kafka Tiered Storage > > > Key: KAF

[GitHub] [kafka] cmccabe commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

cmccabe commented on a change in pull request #10705: URL: https://github.com/apache/kafka/pull/10705#discussion_r633909171 ## File path: metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java ## @@ -209,136 +196,6 @@ public void testUnregisterBroker() th

[GitHub] [kafka] cmccabe commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

cmccabe commented on a change in pull request #10705: URL: https://github.com/apache/kafka/pull/10705#discussion_r633906477 ## File path: raft/src/main/java/org/apache/kafka/raft/LeaderAndEpoch.java ## @@ -28,6 +28,10 @@ public LeaderAndEpoch(OptionalInt leaderId, int epoch) {

[GitHub] [kafka] cmccabe commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

cmccabe commented on a change in pull request #10705: URL: https://github.com/apache/kafka/pull/10705#discussion_r633905804 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -202,7 +200,7 @@ public Builder setMetrics(ControllerMetrics

[GitHub] [kafka] cmccabe commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

cmccabe commented on a change in pull request #10705: URL: https://github.com/apache/kafka/pull/10705#discussion_r633904989 ## File path: raft/src/main/java/org/apache/kafka/raft/BatchReader.java ## @@ -57,4 +60,9 @@ */ @Override void close(); + +static Bat

[GitHub] [kafka] cmccabe commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

cmccabe commented on a change in pull request #10705: URL: https://github.com/apache/kafka/pull/10705#discussion_r633903456 ## File path: raft/src/main/java/org/apache/kafka/raft/LeaderAndEpoch.java ## @@ -28,6 +28,10 @@ public LeaderAndEpoch(OptionalInt leaderId, int epoch) {

[GitHub] [kafka] cmccabe commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

cmccabe commented on a change in pull request #10705: URL: https://github.com/apache/kafka/pull/10705#discussion_r633903456 ## File path: raft/src/main/java/org/apache/kafka/raft/LeaderAndEpoch.java ## @@ -28,6 +28,10 @@ public LeaderAndEpoch(OptionalInt leaderId, int epoch) {

[GitHub] [kafka] cmccabe commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

cmccabe commented on a change in pull request #10705: URL: https://github.com/apache/kafka/pull/10705#discussion_r633903456 ## File path: raft/src/main/java/org/apache/kafka/raft/LeaderAndEpoch.java ## @@ -28,6 +28,10 @@ public LeaderAndEpoch(OptionalInt leaderId, int epoch) {

[GitHub] [kafka] cmccabe commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

cmccabe commented on a change in pull request #10705: URL: https://github.com/apache/kafka/pull/10705#discussion_r633900447 ## File path: core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala ## @@ -234,22 +259,20 @@ class BrokerMetadataListener(brokerId: Int,

[GitHub] [kafka] bbejeck commented on pull request #10697: MINOR: Add @cluster annotation to StreamsNamedRepartitionTopicTest

bbejeck commented on pull request #10697: URL: https://github.com/apache/kafka/pull/10697#issuecomment-842656430 merged #10697 into trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [kafka] bbejeck merged pull request #10697: MINOR: Add @cluster annotation to StreamsNamedRepartitionTopicTest

bbejeck merged pull request #10697: URL: https://github.com/apache/kafka/pull/10697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] ableegoldman commented on a change in pull request #10646: KAFKA-8897 Follow-up: Consolidate the global state stores

ableegoldman commented on a change in pull request #10646: URL: https://github.com/apache/kafka/pull/10646#discussion_r633866937 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -174,13 +176,15 @@ public void re

[GitHub] [kafka] ryannedolan commented on a change in pull request #10712: KAFKA-12798: Fixing MM2 rebalance timeout issue when source cluster is not available

ryannedolan commented on a change in pull request #10712: URL: https://github.com/apache/kafka/pull/10712#discussion_r63387 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java ## @@ -198,6 +198,10 @@ + " proper

[GitHub] [kafka] guozhangwang commented on a change in pull request #10646: KAFKA-8897 Follow-up: Consolidate the global state stores

guozhangwang commented on a change in pull request #10646: URL: https://github.com/apache/kafka/pull/10646#discussion_r633858383 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -174,13 +176,15 @@ public void re

[GitHub] [kafka] guozhangwang commented on a change in pull request #10646: KAFKA-8897 Follow-up: Consolidate the global state stores

guozhangwang commented on a change in pull request #10646: URL: https://github.com/apache/kafka/pull/10646#discussion_r633858091 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -174,13 +176,15 @@ public void re

[GitHub] [kafka] ableegoldman commented on a change in pull request #10646: KAFKA-8897 Follow-up: Consolidate the global state stores

ableegoldman commented on a change in pull request #10646: URL: https://github.com/apache/kafka/pull/10646#discussion_r633854799 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -128,8 +129,7 @@ public void setG

[GitHub] [kafka] guozhangwang commented on a change in pull request #10646: KAFKA-8897 Follow-up: Consolidate the global state stores

guozhangwang commented on a change in pull request #10646: URL: https://github.com/apache/kafka/pull/10646#discussion_r633852084 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -128,8 +129,7 @@ public void setG

[jira] [Updated] (KAFKA-12781) Improve the endOffsets accuracy in TaskMetadata

[ https://issues.apache.org/jira/browse/KAFKA-12781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12781: --- Affects Version/s: (was: 2.8.0) > Improve the endOffsets accuracy in Tas

[jira] [Commented] (KAFKA-12781) Improve the endOffsets accuracy in TaskMetadata

[ https://issues.apache.org/jira/browse/KAFKA-12781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346423#comment-17346423 ] A. Sophie Blee-Goldman commented on KAFKA-12781: Ah, that's my bad – I w

[jira] [Updated] (KAFKA-12781) Improve the endOffsets accuracy in TaskMetadata

[ https://issues.apache.org/jira/browse/KAFKA-12781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12781: --- Fix Version/s: 3.0.0 > Improve the endOffsets accuracy in TaskMetadata > --

[GitHub] [kafka] bbejeck commented on pull request #10697: MINOR: Add @cluster annotation to StreamsNamedRepartitionTopicTest

bbejeck commented on pull request #10697: URL: https://github.com/apache/kafka/pull/10697#issuecomment-842616336 This PR only touched a python system test file, failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] rondagostino commented on pull request #10697: MINOR: Add @cluster annotation to StreamsNamedRepartitionTopicTest

rondagostino commented on pull request #10697: URL: https://github.com/apache/kafka/pull/10697#issuecomment-842602694 Thanks, @bbejeck . Test passed: https://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2021-05-17--001.1621281781--rondagostino--systest_add_

[GitHub] [kafka] bbejeck commented on pull request #10697: MINOR: Add @cluster annotation to StreamsNamedRepartitionTopicTest

bbejeck commented on pull request #10697: URL: https://github.com/apache/kafka/pull/10697#issuecomment-842583178 @rondagostino can we run a branch builder for this PR as a sanity check? -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [kafka] gharris1727 commented on a change in pull request #8259: KAFKA-7421: Ensure Connect's PluginClassLoader is truly parallel capable and resolve deadlock occurrences

gharris1727 commented on a change in pull request #8259: URL: https://github.com/apache/kafka/pull/8259#discussion_r633794872 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/SynchronizationTest.java ## @@ -0,0 +1,469 @@ +/* + * Licensed t

[GitHub] [kafka] gharris1727 commented on a change in pull request #8259: KAFKA-7421: Ensure Connect's PluginClassLoader is truly parallel capable and resolve deadlock occurrences

gharris1727 commented on a change in pull request #8259: URL: https://github.com/apache/kafka/pull/8259#discussion_r633780467 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java ## @@ -48,25 +48,25 @@ import java.u

[GitHub] [kafka] rhauch commented on a change in pull request #8259: KAFKA-7421: Ensure Connect's PluginClassLoader is truly parallel capable and resolve deadlock occurrences

rhauch commented on a change in pull request #8259: URL: https://github.com/apache/kafka/pull/8259#discussion_r633778524 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/SynchronizationTest.java ## @@ -0,0 +1,469 @@ +/* + * Licensed to the

[GitHub] [kafka] cmccabe commented on pull request #10696: KAFKA-12777 Refactor and cleanup AutoTopicCreationManager

cmccabe commented on pull request #10696: URL: https://github.com/apache/kafka/pull/10696#issuecomment-842547338 (Copying offline discussion to github) I think creating a base class and using implementation inheritance is worse than the current code. Looking at the code, I see very l

[GitHub] [kafka] cmccabe commented on a change in pull request #10572: KAFKA-12697: Add OfflinePartitionCount and PreferredReplicaImbalanceCount metrics to Quorum Controller

cmccabe commented on a change in pull request #10572: URL: https://github.com/apache/kafka/pull/10572#discussion_r633769533 ## File path: metadata/src/main/java/org/apache/kafka/controller/BrokersToIsrs.java ## @@ -139,10 +140,16 @@ public TopicIdPartition next() { * Part

[jira] [Commented] (KAFKA-12419) Remove Deprecated APIs of Kafka Streams in 3.0

[ https://issues.apache.org/jira/browse/KAFKA-12419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346378#comment-17346378 ] Josep Prat commented on KAFKA-12419: Tomorrow I'll create the tickets for the Kafka

[GitHub] [kafka] rajinisivaram merged pull request #10633: KAFKA-12751: Reset AlterIsr in-flight state for duplicate update requests

rajinisivaram merged pull request #10633: URL: https://github.com/apache/kafka/pull/10633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] mumrah commented on pull request #10561: KAFKA-12686 AlterIsr and LeaderAndIsr race condition

mumrah commented on pull request #10561: URL: https://github.com/apache/kafka/pull/10561#issuecomment-842540233 @chia7712 or @cmccabe let me know if you have anymore feedback or questions. I'd like to get this one merged -- This is an automated message from the Apache Git Service. To re

[GitHub] [kafka] rajinisivaram commented on pull request #10633: KAFKA-12751: Reset AlterIsr in-flight state for duplicate update requests

rajinisivaram commented on pull request #10633: URL: https://github.com/apache/kafka/pull/10633#issuecomment-842540743 @mumrah Thanks for the review. Test failures not related, merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] cmccabe commented on a change in pull request #10550: MINOR: Add support for ZK Authorizer with KRaft

cmccabe commented on a change in pull request #10550: URL: https://github.com/apache/kafka/pull/10550#discussion_r633749112 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -99,6 +100,9 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] cmccabe opened a new pull request #10714: MINOR: add ConfigUtils method for printing configurations

cmccabe opened a new pull request #10714: URL: https://github.com/apache/kafka/pull/10714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] ableegoldman commented on pull request #10675: KAFKA-12574: remove internal Producer config and auto downgrade logic

ableegoldman commented on pull request #10675: URL: https://github.com/apache/kafka/pull/10675#issuecomment-842500319 One unrelated failure in RaftClusterTest, otherwise tests passed. Merging to trunk -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] guozhangwang commented on a change in pull request #10675: KAFKA-12574: remove internal Producer config and auto downgrade logic

guozhangwang commented on a change in pull request #10675: URL: https://github.com/apache/kafka/pull/10675#discussion_r633174817 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java ## @@ -237,13 +237,15 @@ private static boolea

[GitHub] [kafka] mumrah commented on pull request #10694: MINOR: fix system test TestSecurityRollingUpgrade

mumrah commented on pull request #10694: URL: https://github.com/apache/kafka/pull/10694#issuecomment-842509752 Did a `--repeat 4` run of `security_rolling_upgrade_test.py` and everything passed https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4514/ -- This is an automat

[GitHub] [kafka] cmccabe commented on pull request #10707: KAFKA-12792: Fix metrics bug and introduce TimelineInteger

cmccabe commented on pull request #10707: URL: https://github.com/apache/kafka/pull/10707#issuecomment-842490006 Thanks, @mumrah . > Should we include a comment about the thread safety of these timeline classes? Yeah. I added a comment about the classes requiring external syn

[GitHub] [kafka] dongjinleekr commented on pull request #10709: KAFKA-12794: Fix trailing json tokens in DescribeProducersRequest.json

dongjinleekr commented on pull request #10709: URL: https://github.com/apache/kafka/pull/10709#issuecomment-842297201 Nice Catch. 👍👍👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] NLincoln commented on pull request #10709: KAFKA-12794: Fix trailing json tokens in DescribeProducersRequest.json

NLincoln commented on pull request #10709: URL: https://github.com/apache/kafka/pull/10709#issuecomment-842404631 @dajac done! https://issues.apache.org/jira/browse/KAFKA-12800 I can't edit the assignee field of that ticket, but I can submit a patch for it tonight :) -- This is an

[GitHub] [kafka] ableegoldman merged pull request #10542: KAFKA-12313: Streamling windowed Deserialiser configs.

ableegoldman merged pull request #10542: URL: https://github.com/apache/kafka/pull/10542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [kafka] jlprat commented on pull request #10710: KAFKA-12796: Removal of deprecated classes under `streams-scala`

jlprat commented on pull request #10710: URL: https://github.com/apache/kafka/pull/10710#issuecomment-842288466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [kafka] jlprat commented on pull request #10711: MINOR: Update Scala to 2.13.6

jlprat commented on pull request #10711: URL: https://github.com/apache/kafka/pull/10711#issuecomment-842513321 PR was created 5 hours ago and some jenkins jobs are still running, maybe there has been a problem with those jobs. Anyway, the failure reported is one of the known flaky tests

[GitHub] [kafka] dajac merged pull request #10709: KAFKA-12794: Fix trailing json tokens in DescribeProducersRequest.json

dajac merged pull request #10709: URL: https://github.com/apache/kafka/pull/10709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] mumrah merged pull request #10694: MINOR: fix system test TestSecurityRollingUpgrade

mumrah merged pull request #10694: URL: https://github.com/apache/kafka/pull/10694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] rondagostino commented on a change in pull request #10550: MINOR: Add support for ZK Authorizer with KRaft

rondagostino commented on a change in pull request #10550: URL: https://github.com/apache/kafka/pull/10550#discussion_r633107724 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -99,6 +100,9 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] ableegoldman commented on pull request #10690: MINOR: clarify message ordering with max in-flight requests and idempotent producer

ableegoldman commented on pull request #10690: URL: https://github.com/apache/kafka/pull/10690#issuecomment-842508231 Just the one flaky test `org.apache.kafka.streams.integration.KTableKTableForeignKeyInnerJoinMultiIntegrationTest.shouldInnerJoinMultiPartitionQueryable()` which Luke is go

[GitHub] [kafka] rondagostino commented on pull request #10694: MINOR: fix system test TestSecurityRollingUpgrade

rondagostino commented on pull request #10694: URL: https://github.com/apache/kafka/pull/10694#issuecomment-842403412 Thanks, for the review @mumrah! Regarding your question: > Looks like we're checking client security protocol + sasl mechanism as well as the inter broker protocol +

[GitHub] [kafka] NLincoln commented on a change in pull request #10709: KAFKA-12794: Fix trailing json tokens in DescribeProducersRequest.json

NLincoln commented on a change in pull request #10709: URL: https://github.com/apache/kafka/pull/10709#discussion_r633535873 ## File path: clients/src/main/resources/common/message/DescribeProducersRequest.json ## @@ -27,6 +27,5 @@ { "name": "PartitionIndexes", "type"

  1   2   3   >