ableegoldman commented on a change in pull request #10646:
URL: https://github.com/apache/kafka/pull/10646#discussion_r633866937
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##########
@@ -174,13 +176,15 @@ public void registerStore(final StateStore store, final
StateRestoreCallback sta
throw new IllegalArgumentException(String.format("Trying to
register store %s that is not a known global store", store.name()));
}
+ // register the store first, so that if later an exception is thrown
then eventually while we call `close`
Review comment:
+1 on disallowing the app to continue after an illegal exception. We
need to reserve _some_ kind of exception for actual critical, fatal system
errors that a user can't just ignore to spin up a new thread. And that has
essentially been the meaning of these illegal exceptions in Streams thus far.
As I mentioned in another thread, I've been very concerned about this in the
new handler since we haven't been strict in properly cleaning up after an
illegal exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
