ijuma commented on a change in pull request #9202:
URL: https://github.com/apache/kafka/pull/9202#discussion_r475046516
##
File path:
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##
@@ -1401,16 +1401,17 @@ object GroupMetadataManager {
val vers
ijuma commented on pull request #9202:
URL: https://github.com/apache/kafka/pull/9202#issuecomment-678594470
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
chia7712 edited a comment on pull request #9162:
URL: https://github.com/apache/kafka/pull/9162#issuecomment-678590561
```testMetadataRetries``` is traced by #9091
```DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota```
pass on my local
chia7712 commented on pull request #9162:
URL: https://github.com/apache/kafka/pull/9162#issuecomment-678590561
```testMetadataRetries``` is traced by #9091
This is an automated message from the Apache Git Service.
To respond
chia7712 commented on pull request #9182:
URL: https://github.com/apache/kafka/pull/9182#issuecomment-678589736
failed tests pass on my local
This is an automated message from the Apache Git Service.
To respond to the message
chia7712 commented on a change in pull request #9102:
URL: https://github.com/apache/kafka/pull/9102#discussion_r475041700
##
File path:
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java
##
@@ -2511,4 +2511,39 @@ public void
testEnforceRebalanceTr
vvcephei merged pull request #9137:
URL: https://github.com/apache/kafka/pull/9137
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
vvcephei commented on pull request #9137:
URL: https://github.com/apache/kafka/pull/9137#issuecomment-678575081
It looks like java 14 only failed while attempting to download some docs
from Oracle, and java 8 failed on this unrelated test:
`org.apache.kafka.clients.admin.KafkaAdminClientTe
ableegoldman commented on a change in pull request #9138:
URL: https://github.com/apache/kafka/pull/9138#discussion_r475014135
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractRocksDBSegmentedBytesStore.java
##
@@ -72,22 +86,40 @@
abbccdda commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r474843042
##
File path:
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java
##
@@ -84,6 +84,14 @@
public static final String RETRY_BACKOF
[
https://issues.apache.org/jira/browse/KAFKA-10410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182163#comment-17182163
]
Mark Shelton commented on KAFKA-10410:
--
The problem is that since 2.6 the StateRest
ableegoldman commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r474977836
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java
##
@@ -0,0 +1,579 @@
+/*
+ * Lic
ableegoldman commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r474966465
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java
##
@@ -0,0 +1,579 @@
+/*
+ * Lic
[
https://issues.apache.org/jira/browse/KAFKA-10357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182142#comment-17182142
]
Sophie Blee-Goldman commented on KAFKA-10357:
-
I'm a little less concerned a
mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r474959176
##
File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala
##
@@ -0,0 +1,132 @@
+package kafka.server
+
+import java.util
+import java.util.
mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r474934833
##
File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala
##
@@ -0,0 +1,132 @@
+package kafka.server
+
+import java.util
+import java.util.
soarez commented on a change in pull request #9000:
URL: https://github.com/apache/kafka/pull/9000#discussion_r474950526
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamImplTest.java
##
@@ -1865,6 +1865,17 @@ public void
shouldNotAllowNul
rondagostino commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r474950597
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/KAFKA-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182133#comment-17182133
]
Gokul Srinivas commented on KAFKA-10186:
[~mjsax] Understood. thank you. I'll cl
ableegoldman commented on a change in pull request #9186:
URL: https://github.com/apache/kafka/pull/9186#discussion_r474931289
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java
##
@@ -58,29 +60,46 @@ public void init
mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r474934833
##
File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala
##
@@ -0,0 +1,132 @@
+package kafka.server
+
+import java.util
+import java.util.
mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r474930329
##
File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala
##
@@ -0,0 +1,132 @@
+package kafka.server
+
+import java.util
+import java.util.
mjsax commented on pull request #9146:
URL: https://github.com/apache/kafka/pull/9146#issuecomment-678459181
Thanks for the PR @johnthotekat! -- Merged to `trunk`.
Congrats to completing KIP-648.
This is an automated m
mjsax merged pull request #9146:
URL: https://github.com/apache/kafka/pull/9146
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
vvcephei commented on a change in pull request #8955:
URL: https://github.com/apache/kafka/pull/8955#discussion_r474898311
##
File path:
streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/Serdes.scala
##
@@ -24,6 +24,7 @@ import java.util
import org.apache.ka
mjsax commented on pull request #9028:
URL: https://github.com/apache/kafka/pull/9028#issuecomment-678457711
Thanks for the patch @serjchebotarev! Merged to `trunk`.
This is an automated message from the Apache Git Service.
T
mjsax merged pull request #9028:
URL: https://github.com/apache/kafka/pull/9028
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mjsax commented on pull request #9186:
URL: https://github.com/apache/kafka/pull/9186#issuecomment-678455951
@ableegoldman Can you help to review?
This is an automated message from the Apache Git Service.
To respond to the me
mjsax commented on pull request #9186:
URL: https://github.com/apache/kafka/pull/9186#issuecomment-678455265
Thanks for the PR @JoelWee -- Not exactly sure what NPE test you have in
mind, but feel free to add a new test class
`src/test/java/org/apache/kafka/streams/kstream/internals/KStrea
abbccdda commented on a change in pull request #9102:
URL: https://github.com/apache/kafka/pull/9102#discussion_r474892245
##
File path:
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java
##
@@ -2511,4 +2511,39 @@ public void
testEnforceRebalanceTr
abbccdda commented on pull request #9161:
URL: https://github.com/apache/kafka/pull/9161#issuecomment-678454054
@ijuma Do we have any possible dependency on the consumer performance stats?
I personally think the change is safe, just want to double check.
--
mjsax commented on pull request #9000:
URL: https://github.com/apache/kafka/pull/9000#issuecomment-678452210
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please log
mjsax commented on a change in pull request #9000:
URL: https://github.com/apache/kafka/pull/9000#discussion_r474887535
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamImplTest.java
##
@@ -1865,6 +1865,17 @@ public void
shouldNotAllowNull
mjsax commented on a change in pull request #9000:
URL: https://github.com/apache/kafka/pull/9000#discussion_r474886689
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilderTest.java
##
@@ -175,6 +177,12 @@ public void testAdd
mjsax commented on pull request #9064:
URL: https://github.com/apache/kafka/pull/9064#issuecomment-678450380
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please log
mjsax commented on a change in pull request #9121:
URL: https://github.com/apache/kafka/pull/9121#discussion_r474877105
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImplTest.java
##
@@ -180,6 +183,27 @@ public void shouldRe
[
https://issues.apache.org/jira/browse/KAFKA-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182086#comment-17182086
]
Matthias J. Sax commented on KAFKA-10186:
-
Thanks [~nym3r0s] – working on the co
mjsax commented on pull request #9204:
URL: https://github.com/apache/kafka/pull/9204#issuecomment-678445541
Call for review @hachikuji @cmccabe (seem to be an easy one)
This is an automated message from the Apache Git Servic
omkreddy merged pull request #9205:
URL: https://github.com/apache/kafka/pull/9205
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
ableegoldman commented on pull request #8834:
URL: https://github.com/apache/kafka/pull/8834#issuecomment-678432871
Hey @guozhangwang , any progress on this?
This is an automated message from the Apache Git Service.
To respon
jolshan opened a new pull request #9205:
URL: https://github.com/apache/kafka/pull/9205
The ducker-ak test example includes a file path that does not exist. I fixed
to be the correct path.
This is an automated message from t
[
https://issues.apache.org/jira/browse/KAFKA-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181973#comment-17181973
]
Ranadeep Deb commented on KAFKA-10421:
--
I can definitely test a newer version. But
[
https://issues.apache.org/jira/browse/KAFKA-10020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bill Bejeck updated KAFKA-10020:
Fix Version/s: 2.7.0
> KIP-616: Rename implicit Serdes instances in kafka-streams-scala
>
[
https://issues.apache.org/jira/browse/KAFKA-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181928#comment-17181928
]
Ning Zhang commented on KAFKA-10370:
After looking at HDFS Sink connector
https://g
mumrah merged pull request #7222:
URL: https://github.com/apache/kafka/pull/7222
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181869#comment-17181869
]
Yaroslav Derman edited comment on KAFKA-9747 at 8/21/20, 2:02 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181869#comment-17181869
]
Yaroslav Derman commented on KAFKA-9747:
Have the same problem for Debezium (Mysq
cadonna commented on pull request #9177:
URL: https://github.com/apache/kafka/pull/9177#issuecomment-678269275
test this please
This is an automated message from the Apache Git Service.
To respond to the message, please log o
[
https://issues.apache.org/jira/browse/KAFKA-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181814#comment-17181814
]
Ismael Juma commented on KAFKA-10378:
-
[~cmccabe] can you please post links to your
mimaison commented on pull request #9136:
URL: https://github.com/apache/kafka/pull/9136#issuecomment-678140872
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
mimaison commented on pull request #9136:
URL: https://github.com/apache/kafka/pull/9136#issuecomment-678132390
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mimaison commented on pull request #9136:
URL: https://github.com/apache/kafka/pull/9136#issuecomment-678131966
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-10422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181726#comment-17181726
]
Mickael Maison commented on KAFKA-10422:
You can request the permission to creat
[
https://issues.apache.org/jira/browse/KAFKA-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181723#comment-17181723
]
Ismael Juma commented on KAFKA-10421:
-
Would you be able to test a newer version, 2.
tombentley commented on pull request #9136:
URL: https://github.com/apache/kafka/pull/9136#issuecomment-678105023
@mimaison fixed.
This is an automated message from the Apache Git Service.
To respond to the message, please lo
[
https://issues.apache.org/jira/browse/KAFKA-10422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181691#comment-17181691
]
Guillaume Bort commented on KAFKA-10422:
Thanks for you answer. What is the righ
Mikhail Grinfeld created KAFKA-10424:
Summary: MirrorMaker 2.0 does not replicates topic's "clean.policy"
Key: KAFKA-10424
URL: https://issues.apache.org/jira/browse/KAFKA-10424
Project: Kafka
57 matches
Mail list logo
