abbccdda commented on a change in pull request #9084:
URL: https://github.com/apache/kafka/pull/9084#discussion_r460671888
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -728,7 +728,11 @@ protected void onJoinPrep
showuon edited a comment on pull request #9029:
URL: https://github.com/apache/kafka/pull/9029#issuecomment-664133647
hi @ning2008wisc , thanks for your suggestion. but I don't think it's good
to merge all the 4 commits into 1. I think the commit history is a kind of
records to keep why th
showuon edited a comment on pull request #9029:
URL: https://github.com/apache/kafka/pull/9029#issuecomment-664133647
hi @ning2008wisc , thanks for your suggestion. but I don't think it's good
to merge all the 4 commits into 1. I think the commit history is a kind of
records to keep why th
guozhangwang opened a new pull request #9084:
URL: https://github.com/apache/kafka/pull/9084
Some of the rebalance listener may be implemented by Kafka as well, e.g.
Connect and Streams, and if the exception thrown is actually a KafkaException,
then we should not wrap it but directly throw
showuon commented on pull request #9029:
URL: https://github.com/apache/kafka/pull/9029#issuecomment-664133647
hi @ning2008wisc , thanks for your suggestion. but I don't think it's good
to merge all the 4 commits into 1. I think the commit history is a kind of
records to keep why the autho
guozhangwang opened a new pull request #9083:
URL: https://github.com/apache/kafka/pull/9083
Should be reviewed after https://github.com/apache/kafka/pull/8964 is
merged, in which we first commit (flush) then suspend.
### Committer Checklist (excluded from commit message)
- [ ] Ve
[
https://issues.apache.org/jira/browse/KAFKA-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165435#comment-17165435
]
Raman Verma commented on KAFKA-10312:
-
I have a patch available. Need permission to
Raman Verma created KAFKA-10312:
---
Summary: MetadataCache.getPartitionMetadata may return incorrect
error code when partition's leader is not present at the MetadataCache
Key: KAFKA-10312
URL: https://issues.apache.o
chia7712 commented on pull request #9077:
URL: https://github.com/apache/kafka/pull/9077#issuecomment-664103549
@abbccdda thanks for reviews!
This is an automated message from the Apache Git Service.
To respond to the message
abbccdda commented on pull request #9049:
URL: https://github.com/apache/kafka/pull/9049#issuecomment-664102269
Sg, will close the PR @ijuma
This is an automated message from the Apache Git Service.
To respond to the message
abbccdda closed pull request #9049:
URL: https://github.com/apache/kafka/pull/9049
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
Boyang Chen created KAFKA-10311:
---
Summary: Flaky test KafkaAdminClientTest#testMetadataRetries
Key: KAFKA-10311
URL: https://issues.apache.org/jira/browse/KAFKA-10311
Project: Kafka
Issue Type:
abbccdda commented on pull request #9077:
URL: https://github.com/apache/kafka/pull/9077#issuecomment-664098712
got 2/3 in previous run
This is an automated message from the Apache Git Service.
To respond to the message, plea
abbccdda commented on pull request #9077:
URL: https://github.com/apache/kafka/pull/9077#issuecomment-664098665
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r460621030
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -243,18 +242,24 @@ public void handleAssignmen
Mathieu1124 closed pull request #9076:
URL: https://github.com/apache/kafka/pull/9076
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
Mathieu1124 commented on pull request #9076:
URL: https://github.com/apache/kafka/pull/9076#issuecomment-664081255
> I think it was grammatically correct as it stood before this change. This
change, if it were to occur, would have to state `if the leader fails` (the
current change says `if
huxihx commented on a change in pull request #9081:
URL: https://github.com/apache/kafka/pull/9081#discussion_r460609876
##
File path: core/src/test/scala/integration/kafka/api/TransactionsTest.scala
##
@@ -406,6 +406,26 @@ class TransactionsTest extends KafkaServerTestHarness
huxihx commented on a change in pull request #9081:
URL: https://github.com/apache/kafka/pull/9081#discussion_r460608228
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
##
@@ -687,7 +687,7 @@ public void sendOffsetsToTransaction(Map off
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r460599173
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java
##
@@ -49,6 +61,31 @@
this.stateDirectory
[
https://issues.apache.org/jira/browse/KAFKA-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boyang Chen updated KAFKA-10309:
Fix Version/s: 2.6.1
2.5.2
> KafkaProducer's sendOffsetsToTransaction should no
[
https://issues.apache.org/jira/browse/KAFKA-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165375#comment-17165375
]
Boyang Chen commented on KAFKA-10309:
-
Thanks for the proposal, I think this general
[
https://issues.apache.org/jira/browse/KAFKA-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boyang Chen updated KAFKA-10309:
Component/s: streams
> KafkaProducer's sendOffsetsToTransaction should not block infinitively
> --
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r460592249
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java
##
@@ -454,6 +456,41 @@ public void flush(
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r460590891
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java
##
@@ -38,13 +41,39 @@
*/
final class StateM
Jose Armando Garcia Sancio created KAFKA-10310:
--
Summary: Kafka Raft Snapshot
Key: KAFKA-10310
URL: https://issues.apache.org/jira/browse/KAFKA-10310
Project: Kafka
Issue Type: N
guozhangwang merged pull request #9068:
URL: https://github.com/apache/kafka/pull/9068
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r460588651
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java
##
@@ -93,8 +93,8 @@ public boolean isActive() {
[
https://issues.apache.org/jira/browse/KAFKA-10159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165362#comment-17165362
]
Rens Groothuijsen commented on KAFKA-10159:
---
[~ryannedolan] From what I can se
ning2008wisc commented on pull request #9029:
URL: https://github.com/apache/kafka/pull/9029#issuecomment-664045085
Hi @showuon thanks for your work, a minor thing - do you mind to consolidate
/ merge the current 4 commits into 1 commit?
--
[
https://issues.apache.org/jira/browse/KAFKA-6477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165329#comment-17165329
]
Litao Deng commented on KAFKA-6477:
---
I posted my [PR|[https://github.com/mangobatao/kaf
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r460449901
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -275,31 +259,70 @@ private void restoreSta
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r460449901
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -275,31 +259,70 @@ private void restoreSta
mjsax commented on pull request #9075:
URL: https://github.com/apache/kafka/pull/9075#issuecomment-664031539
Merged to `trunk` and cherry-picked to `2.6` branch.
This is an automated message from the Apache Git Service.
To re
ijuma merged pull request #9080:
URL: https://github.com/apache/kafka/pull/9080
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
vvcephei commented on a change in pull request #9031:
URL: https://github.com/apache/kafka/pull/9031#discussion_r460562257
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/EnumerableWindowDefinition.java
##
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache So
mjsax merged pull request #9075:
URL: https://github.com/apache/kafka/pull/9075
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
rgroothuijsen removed a comment on pull request #9078:
URL: https://github.com/apache/kafka/pull/9078#issuecomment-663854901
I'm not entirely sure about returning raw nulls as a fallback, however, or
how permissive it should be about null values in general. Thoughts?
-
ijuma opened a new pull request #9082:
URL: https://github.com/apache/kafka/pull/9082
I left out updates that could be risky. Preliminary testing indicates
we can build (including spotBugs) and run tests with Java 15 with
these changes. I will do more thorough testing once Java 15 reac
sasakitoa opened a new pull request #9081:
URL: https://github.com/apache/kafka/pull/9081
This PR will change KafkaProducer#sendOffsetsToTransaction to be affected by
max.block.ms to avoid blocking infinitively.
This is
Sasaki Toru created KAFKA-10309:
---
Summary: KafkaProducer's sendOffsetsToTransaction should not block
infinitively
Key: KAFKA-10309
URL: https://issues.apache.org/jira/browse/KAFKA-10309
Project: Kafka
ijuma edited a comment on pull request #9022:
URL: https://github.com/apache/kafka/pull/9022#issuecomment-664002055
Green build, merging to trunk, 2.6 and 2.5.
This is an automated message from the Apache Git Service.
To resp
ijuma merged pull request #9022:
URL: https://github.com/apache/kafka/pull/9022
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ijuma commented on pull request #9022:
URL: https://github.com/apache/kafka/pull/9022#issuecomment-664002055
Green build, merging to trunk and 2.6.
This is an automated message from the Apache Git Service.
To respond to the m
[
https://issues.apache.org/jira/browse/KAFKA-10307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165240#comment-17165240
]
John Roesler commented on KAFKA-10307:
--
Ah, I’d overlooked the link to the github c
[
https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165187#comment-17165187
]
Jerry Wei commented on KAFKA-10134:
---
[~ijuma] correct, just while restarting consumer,
[
https://issues.apache.org/jira/browse/KAFKA-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165185#comment-17165185
]
John Thomas commented on KAFKA-10302:
-
[~enether] You've already started working on
showuon edited a comment on pull request #9029:
URL: https://github.com/apache/kafka/pull/9029#issuecomment-663329158
@mimaison , thanks for your comments. I've updated in this commit:
https://github.com/apache/kafka/pull/9029/commits/5345c6835ef42da973b794634d9b8d65f27ee80a.
What I did ar
48 matches
Mail list logo
