Re: GitHub and Bitbucket branch source UI refactoring

2017-08-04 Thread Michael Kobit
We haven't upgraded to the latest plugin yet (partially because of this) so no workaround yet. We are going to do a test cycle in the next few weeks. I opened https://issues.jenkins-ci.org/browse/JENKINS-45860 a few days ago to hopefully understand how to implement it since I originally implemen

Re: GitHub and Bitbucket branch source UI refactoring

2017-08-03 Thread Tim Downey
Hi Michael -- I finally go around to upgrading as well and am facing the same problem. Have you worked around this? Are you just supplying the XML directly? On Tuesday, July 11, 2017 at 8:39:29 PM UTC-4, Michael Kobit wrote: > > Finally got some time to try it out (sorry!) and I know the PR ha

Re: GitHub and Bitbucket branch source UI refactoring

2017-07-11 Thread Michael Kobit
Finally got some time to try it out (sorry!) and I know the PR has already been merged, but UI looks great, and the contextual help menus make it easy to pick up. Awesome job! Only thing I noticed is no built-in Job DSL support - we use the Job DSL entirely to create and setup all of our Organizat

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-29 Thread Mark Waite
I think I have detected the difference between by multi-branch pipelines with GitHub branch sources. The problem job is a GitHub private repository ( https://github.com/MarkEWaite/jenkins-bugs-private), while the working job is a GitHub public repository (https://github.com/MarkEWaite/jenkins-bugs

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-29 Thread Mark Waite
I'm using latest betas (as far as I can tell). The GitHub source is now working in the cases that were failing previously. Thanks very much for that! Unfortunately, when I open the "Configure" page for one of my multi-branch pipeline job that is using GitHub as a branch source, it reverts the

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-26 Thread Michael Neale
I retested with latest betas and looking good (binary compat, migration etc). On Monday, June 26, 2017 at 11:46:49 PM UTC+10, Stephen Connolly wrote: > > > > On 26 June 2017 at 06:13, Kevin Burnett > wrote: > >> This is so good. :) >> > > Great to hear it. I love feedback (+ve or -ve beats none

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-26 Thread Stephen Connolly
On 26 June 2017 at 06:13, Kevin Burnett wrote: > This is so good. :) > Great to hear it. I love feedback (+ve or -ve beats none) > > The pre and post diffs looked right, and the new UI and functionality > gives me everything that I was hoping for. > w00t > > I'm going to remove the "discove

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-26 Thread Stephen Connolly
Check the drop-box link... https://www.dropbox.com/sh/47weboatdzus22w/AADNF_aBniOyEeQi9MvM82sMa?dl=0 git, mercurial, github and bitbucket are all up as far as -alpha-4 -alpha-4 is looking very near a beta release candidate (just need to confirm I have all the code reviewers happy) I will not be r

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-26 Thread Mark Waite
The experimental update center includes a new version of the git plugin and the mercurial plugin. Per Kevin Burnett's comment, please don't release it this week. I need more testing time. Mark Waite On Mon, Jun 26, 2017 at 7:29 AM Michael Kobit wrote: > I'm going to have time to do this today

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-26 Thread Michael Kobit
I'm going to have time to do this today. Are there newer alphas available? On Mon, Jun 26, 2017, 08:13 Kevin Burnett wrote: > This is so good. :) > > The pre and post diffs looked right, and the new UI and functionality > gives me everything that I was hoping for. > > I'm going to remove the "di

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-26 Thread Kevin Burnett
This is so good. :) The pre and post diffs looked right, and the new UI and functionality gives me everything that I was hoping for. I'm going to remove the "discover pull requests from [everywhere]" behaviors and select "Only branches that are also filed as PRs" on production as soon as possi

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-23 Thread Stephen Connolly
On 23 June 2017 at 17:24, Mark Waite wrote: > I see duplicate entries in the "Add' configuration of the Bitbucket source > for "Checkout over ssh". Let me know if you need steps to see that. > Shouldn't... may just be a bug in the drop down populator when you have GitHub and Bitbucket > > I a

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-23 Thread Mark Waite
I see duplicate entries in the "Add' configuration of the Bitbucket source for "Checkout over ssh". Let me know if you need steps to see that. I also wonder if the text "General", "Git" and "Bitbucket" should be italicized, or bold, or separated with dashes, or something, so that the user has

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-23 Thread Mark Waite
The UI experience has been great for me in the two or three places where I've used it. I was a little surprised (and pleased) with the adaptation that the local branch setting is now a toggle. I think that's the right approach, since (as far as I can tell) that is the 99% use case. Earlier I

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-23 Thread Stephen Connolly
How do you find the new UI compared with the previous one? On 23 June 2017 at 14:18, Joseph P wrote: > Upgrade on "prod like" went smooth :) > Could we move the question for behaviours closer to the behaviours text? > > >

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-23 Thread Stephen Connolly
On 23 June 2017 at 14:18, Joseph P wrote: > Upgrade on "prod like" went smooth :) > w00t! > Could we move the question for behaviours closer to the behaviours text? > > >

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-22 Thread Mark Waite
Question inline for a specific plugin, but the question may be general enough to merit discussion. On Tuesday, June 20, 2017 at 7:29:33 AM UTC-6, Stephen Connolly wrote: > > OK! Here we are... testing time! > > These are the plugins that are being covered: (download links should be > live in an

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-22 Thread Mark Waite
JENKINS-45085 captures the problem I was seeing. The multiple-scms plugin causes a null pointer exception in my multi-branch pipeline job when opening the configure URL of the job. That problem is visible with Jenkins 2.46.3 and 2.60.1. Since my environment does not need or use the multiple-s

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-22 Thread Mark Waite
False alarm, or rather, accurate alarm that has nothing to do with the alpha releases of the plugins. I see an NPE in the console log with the released versions of all plugins, using Jenkins 2.46.3. It is an issue, but not an issue with the alpha releases of the plugins. Mark Waite On Thursd

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-22 Thread Mark Waite
Sorry, fat fingers. I have a multi-branch pipeline job defined to read from https://github.com/MarkEWaite/git-client-plugin using Git with username / password credentials. It works as expected with the alpha versions of the plugins. When I "configure" that job, it shows the project repository

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-22 Thread Stephen Connolly
Mark, can you share details win me via hipchat? On 22 June 2017 at 08:04, Mark Waite wrote: > My docker image that I've upgraded is showing an unexpected behavior in a > GitHub (not git) > > > On Friday, June 16, 2017 at 12:19:24 PM UTC-6, Stephen Connolly wrote: >> >> Just a quick status updat

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-22 Thread Mark Waite
My docker image that I've upgraded is showing an unexpected behavior in a GitHub (not git) On Friday, June 16, 2017 at 12:19:24 PM UTC-6, Stephen Connolly wrote: > > Just a quick status update. > > In final stages of this work now. Bobby is being a superstar and reviewing > my 13k LoC change on

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-22 Thread Mark Waite
On Thu, Jun 22, 2017 at 7:19 AM Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > In any case we are probably more interested in other Bitbucket users as at > most you (Mark) would end up using the CloudBees testing Bitbucket Server > instance which is the same one I used and we are mor

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-22 Thread Stephen Connolly
In any case we are probably more interested in other Bitbucket users as at most you (Mark) would end up using the CloudBees testing Bitbucket Server instance which is the same one I used and we are more interested in testing a variety of configurations not multiple people testing the same configura

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-22 Thread Stephen Connolly
It's now known as the BitBucket Branch Source plugin... but the plugin short-name is cloudbees-bitbucket-branch-source On 22 June 2017 at 13:41, Mark Waite wrote: > I used the experimental update center to update to the latest beta plugin > versions. I didn't have access from my Jenkins to the

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-22 Thread Mark Waite
I used the experimental update center to update to the latest beta plugin versions. I didn't have access from my Jenkins to the CloudBees BitBucket Source Branch plugin, so I'm ignoring it. Mark Waite On Thu, Jun 22, 2017 at 4:56 AM Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > S

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-22 Thread Stephen Connolly
So yes, it's github-branch-source 2.2.0-alpha-3 that is required for as good as possible inter-op with BlueOcean. Note that when using BlueOcean with GitHub Org Folders you will fall victim to JENKINS-45058 irrespective of the version of GitHub Branch Source that you are using... the migration to

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-22 Thread Michael Neale
It does look better now with the new version. I confirmed running a scan didn't make anything go away. On Thursday, June 22, 2017 at 3:20:37 PM UTC+10, Stephen Connolly wrote: > > > On Thu 22 Jun 2017 at 04:29, Michael Neale > wrote: > >> I saw all jobs disappear in a github org folder that bl

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-21 Thread Stephen Connolly
I believe the issue is due to BlueOcean continually replacing the GitHubSCMNavigator and the legacy constructor not populating the discovery traits using the legacy defaults. Great that we caught this now. This does point to an issue for anyone using BlueOcean and configuring traits on a BlueOcean

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-21 Thread Stephen Connolly
On Thu 22 Jun 2017 at 04:29, Michael Neale wrote: > I saw all jobs disappear in a github org folder that blue ocean created > previously, when I triggered a scan. > > (it also doesn't seem to trigger scans if I add change the pattern, or run > the wizard again). > I need to investigate some of t

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-21 Thread Michael Neale
I saw all jobs disappear in a github org folder that blue ocean created previously, when I triggered a scan. (it also doesn't seem to trigger scans if I add change the pattern, or run the wizard again). On Thursday, June 22, 2017 at 4:39:30 AM UTC+10, Mark Waite wrote: > > I haven't tried it

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-21 Thread Stephen Connolly
If you cannot get an ideal "before" that's ok... I'm just trying to make it easier to know if you have and problematic rebuilds... if you can't get it clean, best is better than none at all On Wed 21 Jun 2017 at 20:34, Michael Kobit wrote: > Will be able to run this through tomorrow or Friday. T

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-21 Thread Michael Kobit
Will be able to run this through tomorrow or Friday. The before state is harder to get because of how we manage onboarding consumers. On Wed, Jun 21, 2017, 13:39 Mark Waite wrote: > I haven't tried it yet. I'm configuring the "before" state today and will > capture its state, then will deploy t

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-21 Thread Mark Waite
I haven't tried it yet. I'm configuring the "before" state today and will capture its state, then will deploy the new code tomorrow morning and capture the after state. I won't do anything to compare those until tomorrow evening or this weekend. Mark Waite On Wed, Jun 21, 2017 at 12:30 PM Steph

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-21 Thread Stephen Connolly
How many people have been able to try this so far? On Tue 20 Jun 2017 at 14:52, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > If you are chomping at the bit, here are all the binaries: > > https://www.dropbox.com/sh/47weboatdzus22w/AADNF_aBniOyEeQi9MvM82sMa?dl=0 > > SHA1 checksums:

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-20 Thread Stephen Connolly
If you are chomping at the bit, here are all the binaries: https://www.dropbox.com/sh/47weboatdzus22w/AADNF_aBniOyEeQi9MvM82sMa?dl=0 SHA1 checksums: d9c346ac8db497a35825c7dbbb934842a2bc429a branch-api.hpi 16da429f09fb585fd1d744809ee22c8d612fb62c cloudbees-bitbucket-branch-source.hpi 234fa8eb88da

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-20 Thread Stephen Connolly
OK! Here we are... testing time! These are the plugins that are being covered: (download links should be live in an hour or two) scm-api 2.2.0-alpha-1 https://updates.jenkins.io/download/plugins/scm-api/2.2.0-alpha-1/scm-api.hpi branch-api 2.0.11-alpha-1 https://updates.jenkins.io/download/plugin

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-18 Thread Michael Kobit
I may be able to help with this as well. On Fri, Jun 16, 2017, 17:28 Dan Tran wrote: > I will give it a spin too. > > Thanks > > -Dan > > On Friday, June 16, 2017 at 11:57:26 AM UTC-7, Kevin Burnett wrote: >> >> we'd be down to try that, yes. thanks for making these changes in a way >> that will

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-16 Thread Dan Tran
I will give it a spin too. Thanks -Dan On Friday, June 16, 2017 at 11:57:26 AM UTC-7, Kevin Burnett wrote: > > we'd be down to try that, yes. thanks for making these changes in a way > that will benefit the product long-term! > > fingers are crossed that there's already a built-in way to preten

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-16 Thread Kevin Burnett
we'd be down to try that, yes. thanks for making these changes in a way that will benefit the product long-term! fingers are crossed that there's already a built-in way to pretend like pull requests don't exist! you're already building the branches; why also build the pull requests, eh? :) tha

Re: GitHub and Bitbucket branch source UI refactoring

2017-06-16 Thread Mark Waite
I'd like to be part of the beta test. Mark Waite On Fri, Jun 16, 2017 at 12:19 PM Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > Just a quick status update. > > In final stages of this work now. Bobby is being a superstar and reviewing > my 13k LoC change on the Bitbucket branch so

GitHub and Bitbucket branch source UI refactoring

2017-06-16 Thread Stephen Connolly
Just a quick status update. In final stages of this work now. Bobby is being a superstar and reviewing my 13k LoC change on the Bitbucket branch source - brings lots of feature parity with GitHub and adds the configuration ability of the pure Git branch source I am finalising the GitHub Branch So