Re: Email-ext plugin Groovy Grab

2013-03-20 Thread Slide
I'll take a look and give some comments as soon as I can. On Tue, Mar 19, 2013 at 10:37 PM, Rahul Somasunderam wrote: > I've created a PR with some unit tests, however I'm unable to get this to > work on Jenkins. It looks like my code is just not being called. Obviously > I'm missing something,

Re: Email-ext plugin Groovy Grab

2013-03-19 Thread Slide
Pull requests are definitely the best way to get something in. Please provide tests with your pull requests. On Tue, Mar 19, 2013 at 10:02 AM, Rahul Somasunderam wrote: > Would it make sense if I forked and submitted a PR which turns this on? > I'm assuming anyone using html emails would benefit

Re: Email-ext plugin Groovy Grab

2013-03-19 Thread Rahul Somasunderam
Would it make sense if I forked and submitted a PR which turns this on? I'm assuming anyone using html emails would benefit from this. R, rahul Rahul Somasunderam +1 510 270 2883 On Mon, Mar 18, 2013 at 9:51 PM, Rahul Somasunderam wrote: > https://gist.github.com/rahulsom/5125421 > > These are

Re: Email-ext plugin Groovy Grab

2013-03-18 Thread Rahul Somasunderam
https://gist.github.com/rahulsom/5125421 These are my script and my template. If I get this going, my plan is to turn images into attachments so we don't have to deal with the nag message about external images. Rahul Somasunderam +1 510 270 2883 On Mon, Mar 18, 2013 at 9:45 PM, Rahul Somasunder

Re: Email-ext plugin Groovy Grab

2013-03-18 Thread Slide
This is not tested at all, but you could try the method call variant instead: groovy.grape.Grape.grab([group:'org.springframework', module:'spring', version:'2.5.6']) slide On Mon, Mar 18, 2013 at 9:24 PM, Rahul Somasunderam wrote: > I've used some responsive email templates and created a pret

Re: Email-ext plugin Groovy Grab

2013-03-18 Thread Rahul Somasunderam
I've used some responsive email templates and created a pretty looking email for build reports. Some people unfortunately use gmail, and they still see terrible emails because gmail completely wipes out the style tags in my email. I'm using jsoup to inline the styles in my emails so gmail will ren

Re: Email-ext plugin Groovy Grab

2013-03-18 Thread Slide
External libraries are not currently supported, I don't think it necessarily will be either, what exact functionality do you need from an external library? On Mon, Mar 18, 2013 at 9:19 PM, Rahul Somasunderam wrote: > Hi, > > I'm trying to write a groovy script to modify the message being sent ou

Email-ext plugin Groovy Grab

2013-03-18 Thread Rahul Somasunderam
Hi, I'm trying to write a groovy script to modify the message being sent out by the email-ext plugin. I tried using Grab but that gave me this: Executing pre-send script java.lang.NoClassDefFoundError: org/apache/ivy/core/report/ResolveReport at java.lang.Class.getDeclaredMethods0(Nativ