I'll take a look and give some comments as soon as I can.
On Tue, Mar 19, 2013 at 10:37 PM, Rahul Somasunderam <rahul....@gmail.com>wrote: > I've created a PR with some unit tests, however I'm unable to get this to > work on Jenkins. It looks like my code is just not being called. Obviously > I'm missing something, but I'm not sure. Would you have some time to take a > look at https://github.com/jenkinsci/email-ext-plugin/pull/60 and tell me > what I'm doing wrong? > > TIA. > > rahul > > Rahul Somasunderam > +1 510 270 2883 > > > On Tue, Mar 19, 2013 at 10:14 AM, Slide <slide.o....@gmail.com> wrote: > >> Pull requests are definitely the best way to get something in. Please >> provide tests with your pull requests. >> >> >> On Tue, Mar 19, 2013 at 10:02 AM, Rahul Somasunderam <rahul....@gmail.com >> > wrote: >> >>> Would it make sense if I forked and submitted a PR which turns this on? >>> I'm assuming anyone using html emails would benefit from this. >>> >>> R, >>> rahul >>> >>> Rahul Somasunderam >>> +1 510 270 2883 >>> >>> >>> On Mon, Mar 18, 2013 at 9:51 PM, Rahul Somasunderam <rahul....@gmail.com >>> > wrote: >>> >>>> https://gist.github.com/rahulsom/5125421 >>>> >>>> These are my script and my template. If I get this going, my plan is to >>>> turn images into attachments so we don't have to deal with the nag message >>>> about external images. >>>> >>>> Rahul Somasunderam >>>> +1 510 270 2883 >>>> >>>> >>>> On Mon, Mar 18, 2013 at 9:45 PM, Rahul Somasunderam < >>>> rahul....@gmail.com> wrote: >>>> >>>>> This actually gives a compilation error. Can I put a jar somewhere in >>>>> the classpath and restart jenkins to let this work? >>>>> >>>>> org.codehaus.groovy.control.MultipleCompilationErrorsException: startup >>>>> failed: >>>>> Script1.groovy: 4: unable to resolve class org.jsoup.nodes.Document >>>>> @ line 4, column 1. >>>>> import org.jsoup.nodes.Document; >>>>> ^ >>>>> >>>>> Script1.groovy: 6: unable to resolve class org.jsoup.select.Elements >>>>> @ line 6, column 1. >>>>> import org.jsoup.select.Elements; >>>>> ^ >>>>> >>>>> Script1.groovy: 3: unable to resolve class org.jsoup.Jsoup >>>>> @ line 3, column 1. >>>>> import org.jsoup.Jsoup; >>>>> ^ >>>>> >>>>> Script1.groovy: 5: unable to resolve class org.jsoup.nodes.Element >>>>> @ line 5, column 1. >>>>> import org.jsoup.nodes.Element; >>>>> ^ >>>>> >>>>> 4 errors >>>>> >>>>> at >>>>> org.codehaus.groovy.control.ErrorCollector.failIfErrors(ErrorCollector.java:302) >>>>> at >>>>> org.codehaus.groovy.control.CompilationUnit.applyToSourceUnits(CompilationUnit.java:858) >>>>> at >>>>> org.codehaus.groovy.control.CompilationUnit.doPhaseOperation(CompilationUnit.java:548) >>>>> at >>>>> org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:497) >>>>> at >>>>> groovy.lang.GroovyClassLoader.doParseClass(GroovyClassLoader.java:306) >>>>> at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:287) >>>>> at groovy.lang.GroovyShell.parseClass(GroovyShell.java:731) >>>>> at groovy.lang.GroovyShell.parse(GroovyShell.java:743) >>>>> at groovy.lang.GroovyShell.evaluate(GroovyShell.java:578) >>>>> at groovy.lang.GroovyShell.evaluate(GroovyShell.java:618) >>>>> at groovy.lang.GroovyShell.evaluate(GroovyShell.java:589) >>>>> at >>>>> hudson.plugins.emailext.ExtendedEmailPublisher.executePresendScript(ExtendedEmailPublisher.java:415) >>>>> at >>>>> hudson.plugins.emailext.ExtendedEmailPublisher.sendMail(ExtendedEmailPublisher.java:314) >>>>> at >>>>> hudson.plugins.emailext.ExtendedEmailPublisher._perform(ExtendedEmailPublisher.java:296) >>>>> at >>>>> hudson.plugins.emailext.ExtendedEmailPublisher.perform(ExtendedEmailPublisher.java:256) >>>>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >>>>> at >>>>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) >>>>> at >>>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >>>>> at java.lang.reflect.Method.invoke(Method.java:601) >>>>> at >>>>> org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite$PojoCachedMethodSite.invoke(PojoMetaMethodSite.java:189) >>>>> at >>>>> org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite.call(PojoMetaMethodSite.java:53) >>>>> at >>>>> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:42) >>>>> at >>>>> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:108) >>>>> at >>>>> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:124) >>>>> at Script1$_run_closure1.doCall(Script1.groovy:26) >>>>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >>>>> at >>>>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) >>>>> at >>>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >>>>> at java.lang.reflect.Method.invoke(Method.java:601) >>>>> at >>>>> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:90) >>>>> at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:233) >>>>> at >>>>> org.codehaus.groovy.runtime.metaclass.ClosureMetaClass.invokeMethod(ClosureMetaClass.java:272) >>>>> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:884) >>>>> at groovy.lang.Closure.call(Closure.java:412) >>>>> at groovy.lang.Closure.call(Closure.java:425) >>>>> at >>>>> org.codehaus.groovy.runtime.DefaultGroovyMethods.each(DefaultGroovyMethods.java:1377) >>>>> at >>>>> org.codehaus.groovy.runtime.DefaultGroovyMethods.each(DefaultGroovyMethods.java:1349) >>>>> at org.codehaus.groovy.runtime.dgm$149.invoke(Unknown Source) >>>>> at >>>>> org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite$PojoMetaMethodSiteNoUnwrapNoCoerce.invoke(PojoMetaMethodSite.java:271) >>>>> at >>>>> org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite.call(PojoMetaMethodSite.java:53) >>>>> at >>>>> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:42) >>>>> at >>>>> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:108) >>>>> at >>>>> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:116) >>>>> at Script1.run(Script1.groovy:19) >>>>> at groovy.lang.GroovyShell.evaluate(GroovyShell.java:580) >>>>> at groovy.lang.GroovyShell.evaluate(GroovyShell.java:618) >>>>> at groovy.lang.GroovyShell.evaluate(GroovyShell.java:589) >>>>> at >>>>> hudson.util.RemotingDiagnostics$Script.call(RemotingDiagnostics.java:150) >>>>> at >>>>> hudson.util.RemotingDiagnostics$Script.call(RemotingDiagnostics.java:122) >>>>> at hudson.remoting.LocalChannel.call(LocalChannel.java:45) >>>>> at >>>>> hudson.util.RemotingDiagnostics.executeGroovy(RemotingDiagnostics.java:119) >>>>> at jenkins.model.Jenkins.doScript(Jenkins.java:3349) >>>>> at jenkins.model.Jenkins.doScript(Jenkins.java:3332) >>>>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >>>>> at >>>>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) >>>>> at >>>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >>>>> at java.lang.reflect.Method.invoke(Method.java:601) >>>>> at >>>>> org.kohsuke.stapler.Function$InstanceFunction.invoke(Function.java:288) >>>>> at org.kohsuke.stapler.Function.bindAndInvoke(Function.java:151) >>>>> at >>>>> org.kohsuke.stapler.Function.bindAndInvokeAndServeResponse(Function.java:90) >>>>> at org.kohsuke.stapler.MetaClass$1.doDispatch(MetaClass.java:111) >>>>> at >>>>> org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:53) >>>>> at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:573) >>>>> at org.kohsuke.stapler.Stapler.invoke(Stapler.java:658) >>>>> at org.kohsuke.stapler.Stapler.invoke(Stapler.java:487) >>>>> at org.kohsuke.stapler.Stapler.service(Stapler.java:164) >>>>> at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) >>>>> at >>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290) >>>>> at >>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) >>>>> at >>>>> hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:95) >>>>> at hudson.util.PluginServletFilter.doFilter(PluginServletFilter.java:87) >>>>> at >>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) >>>>> at >>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) >>>>> at hudson.security.csrf.CrumbFilter.doFilter(CrumbFilter.java:47) >>>>> at >>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) >>>>> at >>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) >>>>> at >>>>> hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:84) >>>>> at >>>>> hudson.security.ChainedServletFilter.doFilter(ChainedServletFilter.java:76) >>>>> at hudson.security.HudsonFilter.doFilter(HudsonFilter.java:164) >>>>> at >>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) >>>>> at >>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) >>>>> at >>>>> org.kohsuke.stapler.compression.CompressionFilter.doFilter(CompressionFilter.java:50) >>>>> at >>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) >>>>> at >>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) >>>>> at >>>>> hudson.util.CharacterEncodingFilter.doFilter(CharacterEncodingFilter.java:81) >>>>> at >>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) >>>>> at >>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) >>>>> at >>>>> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233) >>>>> at >>>>> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191) >>>>> at >>>>> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:470) >>>>> at >>>>> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127) >>>>> at >>>>> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) >>>>> at >>>>> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) >>>>> at >>>>> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298) >>>>> at org.apache.jk.server.JkCoyoteHandler.invoke(JkCoyoteHandler.java:190) >>>>> at org.apache.jk.common.HandlerRequest.invoke(HandlerRequest.java:291) >>>>> at org.apache.jk.common.ChannelSocket.invoke(ChannelSocket.java:776) >>>>> at >>>>> org.apache.jk.common.ChannelSocket.processConnection(ChannelSocket.java:705) >>>>> at >>>>> org.apache.jk.common.ChannelSocket$SocketConnection.runIt(ChannelSocket.java:898) >>>>> at >>>>> org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:690) >>>>> at java.lang.Thread.run(Thread.java:722) >>>>> >>>>> >>>>> >>>>> On Mon, Mar 18, 2013 at 9:28 PM, Slide <slide.o....@gmail.com> wrote: >>>>> >>>>>> groovy.grape.Grape.grab([group:'org.springframework', >>>>>> module:'spring', version:'2.5.6']) >>>>>> >>>>> >>>>> >>>>> >>>>> Rahul Somasunderam >>>>> +1 510 270 2883 >>>>> >>>> >>>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Jenkins Users" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to jenkinsci-users+unsubscr...@googlegroups.com. >>> For more options, visit https://groups.google.com/groups/opt_out. >>> >>> >>> >> >> >> >> -- >> Website: http://earl-of-code.com >> >> -- >> You received this message because you are subscribed to a topic in the >> Google Groups "Jenkins Users" group. >> To unsubscribe from this topic, visit >> https://groups.google.com/d/topic/jenkinsci-users/Avme-hTCeDs/unsubscribe?hl=en >> . >> To unsubscribe from this group and all its topics, send an email to >> jenkinsci-users+unsubscr...@googlegroups.com. >> >> For more options, visit https://groups.google.com/groups/opt_out. >> >> >> > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to jenkinsci-users+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out. > > > -- Website: http://earl-of-code.com -- You received this message because you are subscribed to the Google Groups "Jenkins Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-users+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
