Re: TestGrouping.Java seems to combine multiple tests into one huge test

2013-06-21 Thread Michael McCandless
On Thu, Jun 20, 2013 at 7:09 PM, Tom Burton-West wrote: > Sine my objective is to undersdand BlockGroupingCollector, I thought I > would extract a test for BlockGroupingCollector, maybe in another file as > Robert suggested. I think that makes sense! > I was looking at testRandom because that is

Re: TestGrouping.Java seems to combine multiple tests into one huge test

2013-06-20 Thread Tom Burton-West
Sine my objective is to undersdand BlockGroupingCollector, I thought I would extract a test for BlockGroupingCollector, maybe in another file as Robert suggested. I was looking at testRandom because that is where BlockGroupingCollector is tested, but it looks to me like some trickery is involved c

Re: TestGrouping.Java seems to combine multiple tests into one huge test

2013-06-18 Thread Tom Burton-West
Thanks Mike and Robert, >>Refactoring this test would be fantastic, but I wouldn't want to take it on :) >>Maybe an easier step would be to rename this test something like TestRandomGrouping, and add some brand new very simple-easy-to-understand tests to a new file(s). I opened LUCENE-5065. I'l

Re: TestGrouping.Java seems to combine multiple tests into one huge test

2013-06-18 Thread Michael McCandless
+1 to somehow refactor this scary test to make it more understandable! Mike McCandless http://blog.mikemccandless.com On Tue, Jun 18, 2013 at 12:48 PM, Tom Burton-West wrote: > Hello, > > I'm trying to understand BlockGroupingCollector. I thought I would start > by running the tests in the d

Re: TestGrouping.Java seems to combine multiple tests into one huge test

2013-06-18 Thread Robert Muir
On Tue, Jun 18, 2013 at 9:48 AM, Tom Burton-West wrote: > Hello, > > I'm trying to understand BlockGroupingCollector. I thought I would start > by running the tests in the debugger. However the only test I can find is > > lucene/grouping/src/test/org/apache/lucene/search/grouping/TestGrouping.

TestGrouping.Java seems to combine multiple tests into one huge test

2013-06-18 Thread Tom Burton-West
Hello, I'm trying to understand BlockGroupingCollector. I thought I would start by running the tests in the debugger. However the only test I can find is lucene/grouping/src/test/org/apache/lucene/search/grouping/TestGrouping.java In TestGrouping.java, in the second test, "testRandom" it see