Thanks Mike and Robert, >>Refactoring this test would be fantastic, but I wouldn't want to take it on :)
>>Maybe an easier step would be to rename this test something like TestRandomGrouping, and add some brand new very simple-easy-to-understand tests to a new file(s). I opened LUCENE-5065. I'll try your "easier step. Since the reason I'm looking at the test is that I'm trying to understand BlockGroupingCollector, I'll start by trying to just pull out as simple a test as I can figure out for BlockGroupingCollector and add that. It may take me a while, since I need to walk through the code a lot more before I understand it enough to feel confident that I can pull out an appropriate test. Tom On Tue, Jun 18, 2013 at 1:14 PM, Michael McCandless < luc...@mikemccandless.com> wrote: > +1 to somehow refactor this scary test to make it more understandable! > > Mike McCandless > > http://blog.mikemccandless.com > > > On Tue, Jun 18, 2013 at 12:48 PM, Tom Burton-West <tburt...@umich.edu> > wrote: > > Hello, > > > > I'm trying to understand BlockGroupingCollector. I thought I would > start > > by running the tests in the debugger. However the only test I can find > is > > > lucene/grouping/src/test/org/apache/lucene/search/grouping/TestGrouping.java > > > > > > In TestGrouping.java, in the second test, "testRandom" it seems like a > > fairly large number of things are tested, including a test of > > BlockGroupingCollector. > > > > I'm having a hard time understanding the tests and wonder if perhaps > > TestGrouping.java might be refactored to make it easier to understand. > > > > Is there some reason that separate tests are not broken out? > > I also could not find setup and teardown methods. Is there some reason > > they are not being used? > > Would it make sense to open a JIRA issue to refactor TestGrouping.java > to > > make a clearer separation between different things being tested? > > In particular, perhaps BlockGroupingCollector could have a separate test? > > > > Tom > > --------------------------------------------------------------------- > To unsubscribe, e-mail: java-user-unsubscr...@lucene.apache.org > For additional commands, e-mail: java-user-h...@lucene.apache.org > >
