Re: [PR] SOLR-17678 Add support to return original score ( the query score ) in case of r… [solr]

2025-03-06 Thread via GitHub
sijuv commented on code in PR #3222: URL: https://github.com/apache/solr/pull/3222#discussion_r1984121100 ## solr/core/src/test/org/apache/solr/search/TestReRankQParserPlugin.java: ## @@ -64,6 +64,80 @@ public void testReRankQParserPluginConstants() { assertEquals(ReRankQPa

[jira] [Updated] (SOLR-17691) Request for Patch for Solr 8.4 - Zookeeper Status Error ("For input string: 'null'")

2025-03-06 Thread Aviral Sinha (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aviral Sinha updated SOLR-17691: Attachment: Solr8.4SourceCompilationError.txt > Request for Patch for Solr 8.4 - Zookeeper Status

[jira] [Commented] (SOLR-17691) Request for Patch for Solr 8.4 - Zookeeper Status Error ("For input string: 'null'")

2025-03-06 Thread Aviral Sinha (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933186#comment-17933186 ] Aviral Sinha commented on SOLR-17691: - Hi Jan, Thanks for your response. I checked

[jira] [Comment Edited] (SOLR-17691) Request for Patch for Solr 8.4 - Zookeeper Status Error ("For input string: 'null'")

2025-03-06 Thread Aviral Sinha (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933186#comment-17933186 ] Aviral Sinha edited comment on SOLR-17691 at 3/7/25 3:16 AM: -

[jira] [Commented] (SOLR-17632) Text to Vector Update Request Processor

2025-03-06 Thread Renato Haeberli (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932909#comment-17932909 ] Renato Haeberli commented on SOLR-17632: [~abenedetti]  I think it would make sen

Re: [PR] SOLR-17690 Make solr zk tools read ZK_HOST environment [solr]

2025-03-06 Thread via GitHub
janhoy commented on code in PR #3240: URL: https://github.com/apache/solr/pull/3240#discussion_r1982990193 ## solr/core/src/java/org/apache/solr/cli/CLIUtils.java: ## @@ -216,12 +216,29 @@ public static String normalizeSolrUrl(CommandLine cli) throws Exception { } /** -

Re: [PR] SOLR-17690 Make solr zk tools read ZK_HOST environment [solr]

2025-03-06 Thread via GitHub
janhoy commented on code in PR #3240: URL: https://github.com/apache/solr/pull/3240#discussion_r1982990193 ## solr/core/src/java/org/apache/solr/cli/CLIUtils.java: ## @@ -216,12 +216,29 @@ public static String normalizeSolrUrl(CommandLine cli) throws Exception { } /** -

[PR] SOLR-17655: Remove ExternalFileField [solr]

2025-03-06 Thread via GitHub
epugh opened a new pull request, #3244: URL: https://github.com/apache/solr/pull/3244 https://issues.apache.org/jira/browse/SOLR-17655 # Description ExternalFileField is deprecated, remove it. # Solution Remove deprecated Field Type. # Tests E

Re: [PR] SOLR-17438 Resolve committer GPG key from other source [solr]

2025-03-06 Thread via GitHub
madrob commented on PR #3145: URL: https://github.com/apache/solr/pull/3145#issuecomment-2703782935 I linked to a an infra issue on JIRA, it looks like there hasn't been any work yet. I may have been too optimistic about software development timelines, we may as well finish this now and the

Re: [PR] SOLR-17678 Add support to return original score ( the query score ) in case of r… [solr]

2025-03-06 Thread via GitHub
HoustonPutman commented on code in PR #3222: URL: https://github.com/apache/solr/pull/3222#discussion_r1983473324 ## solr/core/src/java/org/apache/solr/search/DocIterator.java: ## @@ -43,4 +43,13 @@ public interface DocIterator extends Iterator { * instance was retrieved.

Re: [PR] SOLR-17690 Make solr zk tools read ZK_HOST environment [solr]

2025-03-06 Thread via GitHub
epugh commented on code in PR #3240: URL: https://github.com/apache/solr/pull/3240#discussion_r1983432038 ## solr/core/src/java/org/apache/solr/cli/CLIUtils.java: ## @@ -216,12 +217,32 @@ public static String normalizeSolrUrl(CommandLine cli) throws Exception { } /** -

[jira] [Updated] (SOLR-17655) Deprecate ExternalFileField in lieu of in-place docValue updates

2025-03-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17655: -- Labels: pull-request-available (was: ) > Deprecate ExternalFileField in lieu of in-place docVa

Re: [PR] SOLR-17684: SolrJ Reference Guide (Ping) - Incorrect Status Retrieval [solr]

2025-03-06 Thread via GitHub
umut-sar commented on PR #3237: URL: https://github.com/apache/solr/pull/3237#issuecomment-2703195348 @epugh Thanks! I appreciate the guidance and the opportunity to improve the solution. Always happy to contribute! -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] SOLR-17690 Make solr zk tools read ZK_HOST environment [solr]

2025-03-06 Thread via GitHub
janhoy commented on code in PR #3240: URL: https://github.com/apache/solr/pull/3240#discussion_r1982953396 ## solr/core/src/java/org/apache/solr/cli/CLIUtils.java: ## @@ -216,12 +217,32 @@ public static String normalizeSolrUrl(CommandLine cli) throws Exception { } /** -

Re: [PR] SOLR-17690 Make solr zk tools read ZK_HOST environment [solr]

2025-03-06 Thread via GitHub
janhoy commented on code in PR #3240: URL: https://github.com/apache/solr/pull/3240#discussion_r1982951185 ## solr/core/src/java/org/apache/solr/cli/CLIUtils.java: ## @@ -216,12 +217,32 @@ public static String normalizeSolrUrl(CommandLine cli) throws Exception { } /** -

Re: [PR] SOLR-17690 Make solr zk tools read ZK_HOST environment [solr]

2025-03-06 Thread via GitHub
janhoy commented on code in PR #3240: URL: https://github.com/apache/solr/pull/3240#discussion_r1982951185 ## solr/core/src/java/org/apache/solr/cli/CLIUtils.java: ## @@ -216,12 +217,32 @@ public static String normalizeSolrUrl(CommandLine cli) throws Exception { } /** -

[jira] [Updated] (SOLR-17690) Solr CLI tools like zk cp does not read ZK_HOST

2025-03-06 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-17690: --- Fix Version/s: (was: 9.8.1) > Solr CLI tools like zk cp does not read ZK_HOST > -

[jira] [Created] (SOLR-17691) Request for Patch for Solr 8.4 - Zookeeper Status Error ("For input string: 'null'")

2025-03-06 Thread Aviral Sinha (Jira)
Aviral Sinha created SOLR-17691: --- Summary: Request for Patch for Solr 8.4 - Zookeeper Status Error ("For input string: 'null'") Key: SOLR-17691 URL: https://issues.apache.org/jira/browse/SOLR-17691 Pro

Re: [PR] SOLR-17678 Add support to return original score ( the query score ) in case of r… [solr]

2025-03-06 Thread via GitHub
sijuv commented on code in PR #3222: URL: https://github.com/apache/solr/pull/3222#discussion_r1984120901 ## solr/core/src/java/org/apache/solr/search/DocSlice.java: ## Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] SOLR-17678 Add support to return original score ( the query score ) in case of r… [solr]

2025-03-06 Thread via GitHub
sijuv commented on code in PR #3222: URL: https://github.com/apache/solr/pull/3222#discussion_r1984122502 ## solr/solr-ref-guide/modules/query-guide/pages/query-re-ranking.adoc: ## @@ -107,6 +107,9 @@ q=greetings&rq={!rerank reRankQuery=$rqq reRankDocs=1000 reRankWeight=3}&rqq=

[jira] [Resolved] (SOLR-17691) Request for Patch for Solr 8.4 - Zookeeper Status Error ("For input string: 'null'")

2025-03-06 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-17691. Resolution: Information Provided Hi, As Solr 8.4 is end of life and not recommended there will not

Re: [PR] SOLR-17678 Add support to return original score ( the query score ) in case of r… [solr]

2025-03-06 Thread via GitHub
sijuv commented on code in PR #3222: URL: https://github.com/apache/solr/pull/3222#discussion_r1984125791 ## solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java: ## @@ -183,7 +182,7 @@ public class SolrIndexSearcher extends IndexSearcher implements Closeable, SolrI

[jira] [Assigned] (SOLR-17655) Deprecate ExternalFileField in lieu of in-place docValue updates

2025-03-06 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh reassigned SOLR-17655: Assignee: Eric Pugh > Deprecate ExternalFileField in lieu of in-place docValue updates > -

[jira] [Updated] (SOLR-17658) Implement Admin UI Start Screen

2025-03-06 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christos Malliaridis updated SOLR-17658: Status: Patch Available (was: Open) > Implement Admin UI Start Screen > --

Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHits per collector. [solr]

2025-03-06 Thread via GitHub
HoustonPutman commented on code in PR #2960: URL: https://github.com/apache/solr/pull/2960#discussion_r1983655608 ## solr/core/src/java/org/apache/solr/search/QueryResult.java: ## @@ -22,6 +22,7 @@ public class QueryResult { // Object for back compatibility so that we render

Re: [PR] SOLR-17309: Enhance certificate based authentication plugin with flexible cert principal resolution [solr]

2025-03-06 Thread via GitHub
laminelam commented on PR #3029: URL: https://github.com/apache/solr/pull/3029#issuecomment-2704941460 Hi @epugh Could you merge this when you get a chance? I have another PR built on top of this one that I'd like to push upstream -- This is an automated message from the Apache Git

Re: [PR] SOLR-17678 Add support to return original score ( the query score ) in case of r… [solr]

2025-03-06 Thread via GitHub
sijuv commented on code in PR #3222: URL: https://github.com/apache/solr/pull/3222#discussion_r1983830223 ## solr/core/src/java/org/apache/solr/search/DocIterator.java: ## @@ -43,4 +43,13 @@ public interface DocIterator extends Iterator { * instance was retrieved. */

Re: [PR] SOLR-17438 Resolve committer GPG key from other source [solr]

2025-03-06 Thread via GitHub
janhoy commented on PR #3145: URL: https://github.com/apache/solr/pull/3145#issuecomment-2704318289 Ok, will commit this then. It is fairly simple to modify should the file move -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] fix the solr zk invocation [solr-operator]

2025-03-06 Thread via GitHub
elangelo commented on PR #756: URL: https://github.com/apache/solr-operator/pull/756#issuecomment-2704474666 > Has anyone tested this with Solr 8.11 (This is still supported for the 0.9 line) ![image](https://github.com/user-attachments/assets/94741c96-0d73-4241-9661-ff9380f72fc9)