sijuv commented on code in PR #3222:
URL: https://github.com/apache/solr/pull/3222#discussion_r1983830223
##########
solr/core/src/java/org/apache/solr/search/DocIterator.java:
##########
@@ -43,4 +43,13 @@ public interface DocIterator extends Iterator<Integer> {
* instance was retrieved.
*/
public float score();
+
+ /**
+ * Returns the query match score in case of rerank queries
+ *
+ * @return the query match score in case of a rerank query, null otherwise.
+ */
+ public default Float matchScore() {
+ return null;
+ }
Review Comment:
the issue is that the matchScore is only relevant if there is a rerank in
question. We cannot return 0 and rely on this being 0 to not populate the field
because 0 could be a valid score. The scores would depend on how the user
formed the scoring query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
