kotman12 commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1982512886
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -185,8 +188,31 @@ public void setQueryParams(Set queryParams) {
this.queryParams = queryP
janhoy commented on code in PR #3240:
URL: https://github.com/apache/solr/pull/3240#discussion_r1981064826
##
solr/core/src/java/org/apache/solr/cli/RunExampleTool.java:
##
@@ -305,7 +305,7 @@ protected void runExample(CommandLine cli, String
exampleName) throws Exception
[
https://issues.apache.org/jira/browse/SOLR-17690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-17690:
---
Fix Version/s: 9.9
> Solr CLI tools like zk cp does not read ZK_HOST
> --
janhoy commented on PR #3240:
URL: https://github.com/apache/solr/pull/3240#issuecomment-2700380093
I ran crave locally since it does not work in gh-actions:
```
../crave run
Downloading update
https://github.com/accupara/crave/releases/download/0.2-7064/crave-0.2-7064-darwin-am
janhoy commented on PR #3240:
URL: https://github.com/apache/solr/pull/3240#issuecomment-2700391514
Hmm, there's no `9.8.1` section in CHANGES.txt on `main`, and not on
`branch_9x`, only on `branch_9_8`.
Is the correct way for this bugfix to skip CHANGES here and on 9x, and then
add one
janhoy commented on PR #2685:
URL: https://github.com/apache/solr/pull/2685#issuecomment-2700615649
@iamsanjay I merged in main branch and resolved conflicts the best I could.
I also updated README.md with the latest usage text for the tool, and took it
for a spin and fixed a bug with an un
ps-muspelkat opened a new pull request, #763:
URL: https://github.com/apache/solr-operator/pull/763
This PR addresses the possibility to add an `hostName` to the ingress
configuration of a given solrcloud instance as described in #667.
The change is quit simple. Unfortunately, the `ma
[
https://issues.apache.org/jira/browse/SOLR-17256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932577#comment-17932577
]
Sanjay Dutt commented on SOLR-17256:
Is there any easier way to get preferred nodes t
[
https://issues.apache.org/jira/browse/SOLR-17256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932577#comment-17932577
]
Sanjay Dutt edited comment on SOLR-17256 at 3/5/25 10:18 AM:
-
[
https://issues.apache.org/jira/browse/SOLR-17679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Khaled Alkhouli updated SOLR-17679:
---
Status: Patch Available (was: Open)
> Request for Documentation/Feature Improvement on Hybri
malliaridis commented on code in PR #3223:
URL: https://github.com/apache/solr/pull/3223#discussion_r1981850710
##
solr/core/src/java/org/apache/solr/cli/AuthTool.java:
##
@@ -75,8 +75,10 @@ public class AuthTool extends ToolBase {
.longOpt("solr-include-file")
janhoy commented on PR #3240:
URL: https://github.com/apache/solr/pull/3240#issuecomment-2700193133
Refactored a bit, to be able to use the `--zk-host foo --> ZK_HOST=foo`
fallback other places that attempt to read only the option.
Activated the fix since the Crave tests don't run a
dsmiley commented on PR #3163:
URL: https://github.com/apache/solr/pull/3163#issuecomment-2701019493
Map.get, Map.remove, Map.put -- basic operations are O(1) in a hash based
Map, but not in a dense array List that SOM is today.
--
This is an automated message from the Apache Git Service.
gerlowskija commented on code in PR #756:
URL: https://github.com/apache/solr-operator/pull/756#discussion_r1981474383
##
controllers/solrcloud_controller_basic_auth_test.go:
##
@@ -351,12 +351,12 @@ func expectBasicAuthConfigOnPodTemplateWithGomega(g
Gomega, solrCloud *solrv1b
jkmuriithi opened a new pull request, #3238:
URL: https://github.com/apache/solr/pull/3238
https://issues.apache.org/jira/browse/SOLR-17043
# Description
Currently, some SolrClient implementations (especially our "load-balancing"
and "cloud" clients) do pattern-matching
HoustonPutman commented on code in PR #3240:
URL: https://github.com/apache/solr/pull/3240#discussion_r1981736330
##
solr/core/src/java/org/apache/solr/cli/RunExampleTool.java:
##
@@ -305,7 +305,7 @@ protected void runExample(CommandLine cli, String
exampleName) throws Exceptio
babesflorin opened a new pull request, #3242:
URL: https://github.com/apache/solr/pull/3242
This pull request includes several updates and improvements to the Solr
project, focusing on version updates, bug fixes, and enhancements to the backup
functionality. The most important changes inclu
babesflorin closed pull request #3242: Save model compacted solr 17050
URL: https://github.com/apache/solr/pull/3242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
babesflorin opened a new pull request, #3241:
URL: https://github.com/apache/solr/pull/3241
This pull request includes several changes to configuration files, GitHub
workflows, and documentation. The most important changes include updates to the
`.git-blame-ignore-revs` file, the addition o
epugh commented on code in PR #3240:
URL: https://github.com/apache/solr/pull/3240#discussion_r1981755145
##
solr/core/src/java/org/apache/solr/cli/CLIUtils.java:
##
@@ -216,12 +216,29 @@ public static String normalizeSolrUrl(CommandLine cli)
throws Exception {
}
/**
-
epugh commented on code in PR #3240:
URL: https://github.com/apache/solr/pull/3240#discussion_r1981763825
##
solr/core/src/java/org/apache/solr/cli/RunExampleTool.java:
##
@@ -305,7 +305,7 @@ protected void runExample(CommandLine cli, String
exampleName) throws Exception
epugh commented on code in PR #3240:
URL: https://github.com/apache/solr/pull/3240#discussion_r1981764531
##
solr/core/src/test/org/apache/solr/cli/ZkSubcommandsTest.java:
##
@@ -507,10 +507,8 @@ public void testGetFile() throws Exception {
Path file =
tmpDir.resol
mikeywuu commented on PR #763:
URL: https://github.com/apache/solr-operator/pull/763#issuecomment-2701590303
Sorry, had to re-create the PR. #764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mikeywuu opened a new pull request, #764:
URL: https://github.com/apache/solr-operator/pull/764
This PR addresses the possibility to add an `hostName` to the ingress
configuration of a given solrcloud instance as described in #667.
The change is quit simple. Unfortunately, the `make p
malliaridis commented on code in PR #3223:
URL: https://github.com/apache/solr/pull/3223#discussion_r1981863388
##
solr/bin/solr:
##
@@ -612,22 +612,11 @@ if [[ "$SCRIPT_CMD" == "auth" ]]; then
fi
fi
- if [ -z "${AUTH_PORT:-}" ]; then
-for ID in $(ps auxww | grep
dsmiley commented on PR #3163:
URL: https://github.com/apache/solr/pull/3163#issuecomment-2701775120
> So what is the point of changing from a LinkedHashMap to LinkedHashMap in
a SMO?
A LinkedHashMap doesn't implement NamedList. An SMO does. Thus a Solr 10
server could start passin
malliaridis commented on code in PR #3223:
URL: https://github.com/apache/solr/pull/3223#discussion_r1981863388
##
solr/bin/solr:
##
@@ -612,22 +612,11 @@ if [[ "$SCRIPT_CMD" == "auth" ]]; then
fi
fi
- if [ -z "${AUTH_PORT:-}" ]; then
-for ID in $(ps auxww | grep
[
https://issues.apache.org/jira/browse/SOLR-16305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932623#comment-17932623
]
Jason Gerlowski commented on SOLR-16305:
+1 to what others have already mentioned
HoustonPutman commented on PR #3240:
URL: https://github.com/apache/solr/pull/3240#issuecomment-2701378283
> Hmm, there's no `9.8.1` section in CHANGES.txt on `main`, and not on
`branch_9x`, only on `branch_9_8`. Is the correct way for this bugfix to skip
CHANGES here and on 9x, and then ad
samuelverstraete commented on code in PR #756:
URL: https://github.com/apache/solr-operator/pull/756#discussion_r1981717896
##
controllers/solrcloud_controller_basic_auth_test.go:
##
@@ -351,12 +351,12 @@ func expectBasicAuthConfigOnPodTemplateWithGomega(g
Gomega, solrCloud *so
janhoy commented on issue #762:
URL: https://github.com/apache/solr-operator/issues/762#issuecomment-2701079910
> There's a PR [here](https://github.com/apache/solr-operator/pull/756) to
update the `bin/solr zk` invocation that's seemingly already most of the way
there...
Fixing it i
[
https://issues.apache.org/jira/browse/SOLR-17679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Khaled Alkhouli updated SOLR-17679:
---
Status: Open (was: Patch Available)
> Request for Documentation/Feature Improvement on Hybri
renatoh commented on PR #3163:
URL: https://github.com/apache/solr/pull/3163#issuecomment-2700819405
> Only an SMO is also a NamedList. A LinkedHashMap itself is not.
Just for my understand: What exactly would improve by unmarshalling to a SMO
backed by LinkedHashMap compared to just
renatoh commented on PR #3163:
URL: https://github.com/apache/solr/pull/3163#issuecomment-2701327325
> Map.get, Map.remove, Map.put -- basic operations are O(1) in a hash based
Map, but not in a dense array List that SOM is today.
I do understand that part, but today, we are umarshall
ps-muspelkat closed pull request #763: Make ingress hostname configurable
URL: https://github.com/apache/solr-operator/pull/763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dsmiley merged PR #3239:
URL: https://github.com/apache/solr/pull/3239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
HoustonPutman commented on PR #3239:
URL: https://github.com/apache/solr/pull/3239#issuecomment-2701967655
Good change, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
epugh merged PR #3237:
URL: https://github.com/apache/solr/pull/3237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
[
https://issues.apache.org/jira/browse/SOLR-17684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932760#comment-17932760
]
ASF subversion and git services commented on SOLR-17684:
Commit d
epugh commented on PR #3237:
URL: https://github.com/apache/solr/pull/3237#issuecomment-2702160424
Thank you for your contribution @umut-sar... I appreciate you open a PR,
and then took the feedback and came back with an even better solution!
--
This is an automated message from the Apa
janhoy commented on PR #3240:
URL: https://github.com/apache/solr/pull/3240#issuecomment-2702257270
> I feel that the users may be overwhelmed with the amount of options we
give them for defining a property (CLI option, env vars and file), which makes
our code more complex as well
Ad
dsmiley opened a new pull request, #3243:
URL: https://github.com/apache/solr/pull/3243
This method should lean on two other classes to handle the details. Tests
pass, and there are a couple testing this method including the particulars of
"omit".
--
This is an automated message from th
janhoy commented on code in PR #3240:
URL: https://github.com/apache/solr/pull/3240#discussion_r1982302027
##
solr/core/src/test/org/apache/solr/cli/ZkSubcommandsTest.java:
##
@@ -507,10 +507,8 @@ public void testGetFile() throws Exception {
Path file =
tmpDir.reso
janhoy commented on code in PR #3240:
URL: https://github.com/apache/solr/pull/3240#discussion_r1982317593
##
solr/core/src/java/org/apache/solr/cli/RunExampleTool.java:
##
@@ -305,7 +305,7 @@ protected void runExample(CommandLine cli, String
exampleName) throws Exception
HoustonPutman commented on PR #3223:
URL: https://github.com/apache/solr/pull/3223#issuecomment-2702105858
So instead of using SOLR_TOOL_HOST, and instead using SOLR_HOST in the java
code, I think we can remove the SOLR_TOOL_HOST all together, since we set it in
`bin/solr`:
```bash
HoustonPutman commented on PR #756:
URL: https://github.com/apache/solr-operator/pull/756#issuecomment-2702120082
Has anyone tested this with Solr 8.11 (This is still supported for the 0.9
line)
--
This is an automated message from the Apache Git Service.
To respond to the message, please
epugh commented on code in PR #756:
URL: https://github.com/apache/solr-operator/pull/756#discussion_r1982211735
##
controllers/solrcloud_controller_basic_auth_test.go:
##
@@ -351,12 +351,12 @@ func expectBasicAuthConfigOnPodTemplateWithGomega(g
Gomega, solrCloud *solrv1bet
HoustonPutman commented on PR #3240:
URL: https://github.com/apache/solr/pull/3240#issuecomment-2702130634
So I think there is good discussion to be had here about the use of EnvVars
in the SolrCLI logic (which currently we do use for default Solr URLs). But in
the meantime, I do believe th
[
https://issues.apache.org/jira/browse/SOLR-16305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932750#comment-17932750
]
David Smiley commented on SOLR-16305:
-
I definitely also strongly prefer the 2nd appr
[
https://issues.apache.org/jira/browse/SOLR-17684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932759#comment-17932759
]
ASF subversion and git services commented on SOLR-17684:
Commit a
50 matches
Mail list logo
