janhoy commented on code in PR #3240:
URL: https://github.com/apache/solr/pull/3240#discussion_r1982317593
##########
solr/core/src/java/org/apache/solr/cli/RunExampleTool.java:
##########
@@ -305,7 +305,7 @@ protected void runExample(CommandLine cli, String
exampleName) throws Exception
"techproducts".equals(exampleName) ? "sample_techproducts_configs" :
"_default";
boolean isCloudMode = !cli.hasOption(USER_MANAGED_OPTION);
- String zkHost = cli.getOptionValue(CommonCLIOptions.ZK_HOST_OPTION);
+ String zkHost = CLIUtils.getZkHostFromCliOrEnv(cli);
Review Comment:
Let's improve the examples in a followup issue. Perhaps we should not take
away capabilities in 9.x, bu make this a 10.0 improvement. For now, this change
here brings parity with how `--zk-host` option is documented and supported in
the rest of the CLI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
