dsmiley commented on code in PR #3209:
URL: https://github.com/apache/solr/pull/3209#discussion_r1968827196
##
solr/core/src/java/org/apache/solr/response/RawResponseWriter.java:
##
@@ -88,41 +85,27 @@ protected QueryResponseWriter
getBaseWriter(SolrQueryRequest request) {
@
dsmiley opened a new pull request, #3210:
URL: https://github.com/apache/solr/pull/3210
We'd like to see all errors found when the "precommit" GitHub Action runs,
not just the first error.
note: I'll revert the intentionally bad commit that's there to validate it
works
--
This is
dsmiley commented on code in PR #3209:
URL: https://github.com/apache/solr/pull/3209#discussion_r1969009364
##
solr/core/src/java/org/apache/solr/response/PrometheusResponseWriter.java:
##
@@ -47,12 +47,15 @@
* org.apache.solr.handler.admin.MetricsHandler}
*/
@SuppressWarni
dsmiley opened a new pull request, #3209:
URL: https://github.com/apache/solr/pull/3209
QRW now does write(OutputStream) and NOT write(Writer).
BinaryQueryResponseWriter is removed
QRW.writeToString for tests
TextQueryResponseWriter added as base for all text QRWs
QueryResponseWriterU
[
https://issues.apache.org/jira/browse/SOLR-17682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17682:
--
Labels: pull-request-available (was: )
> Refactor QueryResponseWriter hierarchy to put binary
dsmiley commented on PR #3179:
URL: https://github.com/apache/solr/pull/3179#issuecomment-2680779168
I tried to move the CHANGES.txt entry below to Optimizations but I don't
have permissions to push to your fork of Solr -- [see
this](https://docs.github.com/en/pull-requests/collaborating-wi
dsmiley merged PR #3204:
URL: https://github.com/apache/solr/pull/3204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
[
https://issues.apache.org/jira/browse/SOLR-16903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930070#comment-17930070
]
ASF subversion and git services commented on SOLR-16903:
Commit 5
gerlowskija commented on PR #2930:
URL: https://github.com/apache/solr/pull/2930#issuecomment-2679415513
> It has zero consequences for any caller.
It's not really about consequences, it's about being consistent/intuitive.
Even users who know about the `PATCH` verb and its semantics
HoustonPutman commented on PR #3054:
URL: https://github.com/apache/solr/pull/3054#issuecomment-2679306623
Hey @gerlowskija this is causing a few errors.
First I've found is that the `getCoreStatus()` api takes a `Boolean`, but
then de-refrences it to a `boolean`. So requests that don
[
https://issues.apache.org/jira/browse/SOLR-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-3954.
-
Resolution: Won't Fix
DIH has moved to https://github.com/SearchScale/dataimporthandler
> Option to have
psalagnac commented on code in PR #3200:
URL: https://github.com/apache/solr/pull/3200#discussion_r1968195273
##
solr/solrj/src/java/org/apache/solr/client/solrj/request/UpdateRequest.java:
##
@@ -368,147 +368,39 @@ public void setDeleteQuery(List deleteQuery) {
// --
HoustonPutman commented on PR #3054:
URL: https://github.com/apache/solr/pull/3054#issuecomment-2679559395
Also `TestReplicationHandler.doTestIndexAndConfigAliasReplication`:
```
TestReplicationHandler > doTestIndexAndConfigAliasReplication FAILED
java.lang.ClassCastException
[
https://issues.apache.org/jira/browse/SOLR-13271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929897#comment-17929897
]
Jason Gerlowski commented on SOLR-13271:
I noticed recently that MODIFYCOLLECTION
HoustonPutman commented on code in PR #3197:
URL: https://github.com/apache/solr/pull/3197#discussion_r1968316944
##
solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java:
##
@@ -1027,6 +1028,64 @@ public static String assertJQ(SolrQueryRequest req,
double delta, Str
psalagnac commented on code in PR #3200:
URL: https://github.com/apache/solr/pull/3200#discussion_r1968216711
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/XMLRequestWriter.java:
##
@@ -0,0 +1,216 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
epugh commented on code in PR #3200:
URL: https://github.com/apache/solr/pull/3200#discussion_r1968218397
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/XMLRequestWriter.java:
##
@@ -0,0 +1,216 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
psalagnac commented on code in PR #3200:
URL: https://github.com/apache/solr/pull/3200#discussion_r1968216711
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/XMLRequestWriter.java:
##
@@ -0,0 +1,216 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
psalagnac commented on code in PR #3200:
URL: https://github.com/apache/solr/pull/3200#discussion_r1968216711
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/XMLRequestWriter.java:
##
@@ -0,0 +1,216 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
psalagnac commented on PR #3200:
URL: https://github.com/apache/solr/pull/3200#issuecomment-2679343190
> I assume you moved some things around but didn't really write code here
(i.e. all code, variable names was the choice of original authors)?
Yes, just moved things around.
--
epugh commented on PR #1999:
URL: https://github.com/apache/solr/pull/1999#issuecomment-2679572157
Yep, need to wait for Lucene 10, otherwise we get some unit test failures:
```
gradlew test --tests
TestOpenNLPExtractNamedEntitiesUpdateProcessorFactory.testExtractFieldRegexReplaceA
HoustonPutman merged PR #3205:
URL: https://github.com/apache/solr/pull/3205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apa
[
https://issues.apache.org/jira/browse/SOLR-14202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-14202.
--
Resolution: Won't Fix
DIH has moved to https://github.com/SearchScale/dataimporthandler
> UpdateProces
[
https://issues.apache.org/jira/browse/SOLR-4241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-4241.
-
Resolution: Won't Fix
DIH has moved to https://github.com/SearchScale/dataimporthandler
> Add object to S
David Smiley created SOLR-17682:
---
Summary: Refactor QueryResponseWriter hierarchy to put binary at
the base and add TextQueryResponseWriter sub
Key: SOLR-17682
URL: https://issues.apache.org/jira/browse/SOLR-17682
[
https://issues.apache.org/jira/browse/SOLR-13731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929615#comment-17929615
]
Noble Paul commented on SOLR-13731:
---
Constructing a SolrInputDocument etc is much more
gerlowskija commented on code in PR #3206:
URL: https://github.com/apache/solr/pull/3206#discussion_r1967557670
##
solr/core/src/java/org/apache/solr/search/join/HashRangeQuery.java:
##
@@ -91,6 +96,9 @@ private int[] getCache(LeafReaderContext context) throws
IOException {
Yugank created SOLR-17681:
-
Summary: Text to Vector Filter for Indexing
Key: SOLR-17681
URL: https://issues.apache.org/jira/browse/SOLR-17681
Project: Solr
Issue Type: New Feature
Reporte
AndreyBozhko commented on code in PR #3204:
URL: https://github.com/apache/solr/pull/3204#discussion_r1967834442
##
solr/core/src/java/org/apache/solr/handler/admin/SystemInfoHandler.java:
##
@@ -145,7 +145,7 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryRespo
dsmiley merged PR #3206:
URL: https://github.com/apache/solr/pull/3206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
dsmiley commented on code in PR #3206:
URL: https://github.com/apache/solr/pull/3206#discussion_r1967881072
##
solr/core/src/java/org/apache/solr/search/join/HashRangeQuery.java:
##
@@ -91,6 +96,9 @@ private int[] getCache(LeafReaderContext context) throws
IOException {
[
https://issues.apache.org/jira/browse/SOLR-17677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929815#comment-17929815
]
ASF subversion and git services commented on SOLR-17677:
Commit 3
dsmiley commented on PR #3204:
URL: https://github.com/apache/solr/pull/3204#issuecomment-2678884231
I plan to merge this tonight; it's very straightforward
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dsmiley commented on PR #3179:
URL: https://github.com/apache/solr/pull/3179#issuecomment-2678890820
I'll merge this tonight. If you don't get to CHANGES.txt; I'll do it. I
edited the JIRA issue description to better identify what this is about; it was
confusing to speak of "dynamic field
ds-manzinger commented on PR #3179:
URL: https://github.com/apache/solr/pull/3179#issuecomment-2678911271
Hi, i commited changes.txt about 1 hour ago
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
epugh commented on code in PR #1999:
URL: https://github.com/apache/solr/pull/1999#discussion_r1967948785
##
solr/modules/analysis-extras/src/java/org/apache/solr/update/processor/DocumentCategorizerUpdateProcessorFactory.java:
##
@@ -0,0 +1,569 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/SOLR-13731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929833#comment-17929833
]
David Smiley commented on SOLR-13731:
-
There are many classes in SolrJ and it's not a
gerlowskija opened a new pull request, #143:
URL: https://github.com/apache/solr-site/pull/143
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
38 matches
Mail list logo
